Friday, September 9, 2022
20 changes · master
Resolved issues and error corrections
This fix prevents an editor error when users add images in terms and conditions content on product pages. It ensures the carousel image removal option only appears for actual carousel images, while other images can still be removed using the standard block removal action.
Original PR description
This commits fixes the following things: - The fact that we were having a trace-back when putting an image inside a div that was in the div with the id `#product_detail` and clicking on the `remove` button in the editor. In reality this button should not have been available because the image is not in the carousel. We now check that the image is in the `o_wsale_product_images` div (which is the carousel) to display the `remove` button. To remove an image outside of this carousel, simply click on the `remove` block button. - Also fixes a bug where removing the image wasn't working on the carousel task_id=[2973363](https://www.odoo.com/web#id=2973363&cids=1&menu_id=4720&action=333&active_id=5157&model=project.task&view_type=form)
This update makes Odoo show a proper, understandable error when an already closed database cursor is used, avoiding confusing internal failures. It also removes outdated database cursor code and simplifies related internals, improving maintainability without changing normal user workflows.
Original PR description
[FIX] sql_db.py: fix error type raised by closed cursor Since https://github.com/odoo/odoo/commit/e014cc88394fb9c8f6cff556ca73d5efafea030f, our proxy `Cursor` object doesn't return an understandable…
[FIX] sql_db.py: fix error type raised by closed cursor Since https://github.com/odoo/odoo/commit/e014cc88394fb9c8f6cff556ca73d5efafea030f, our proxy `Cursor` object doesn't return an understandable error when we try to use it when it is already closed (`NoneType` or `Recursion` error). Instead of reverting https://github.com/odoo/odoo/commit/e014cc88394fb9c8f6cff556ca73d5efafea030f, add a check in `__getitem__` raising a IterfaceError (like psycopg) if we try to use psycopg cursor (`self._obj`) [REM] sql_db.py: remove/depreciated methods - Remove depreciated `after` method of `Cursor` - Remove `unbuffer`/`flush_env`/`clear_env` methods - Remove specific code for python version 2.7 - Depreciated autocommit [REM] sql_db.py: clean file and our Cursor class Remove unused feature of our `Cursor` class (proxy object of psycopg cursor): - Remove `_default_log_exceptions` (unused except in test) - Remove `serialized` args of `__init__`, our cursor is always serialized Also: - Remove unused `serialized` args of `cursor` method (`Connection` class) - Simplify some code - Update some docstring - Clean import task-2766494
Employees without recruitment permissions can now open the HR departments view when the recruitment app is installed. This prevents an unnecessary access error and keeps basic HR navigation available to users who do not work with recruitment.
Original PR description
When hr_recruitment is installed and a user doesn't have any recruitment access, an access error is raised. This commit fixes the access error, allowing the user to access the hr departments view when hr_recruitment is installed and the user has no hr_recruitment access. task-2971553 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website editor now reliably refreshes the “Edit in Backend” button label when users move between different website records, such as forum pages and posts. This prevents confusing or outdated button text and helps users open the correct backend screen.
Original PR description
Since the button must be rendered when its text changes, the variable that holds its text must be stored in the component state. The button already had the right text before a bit by chance because the new name was computed before the component was rendered. Now we make sure that the component will be rendered when the name is recomputed. The problem is visible if we slow down the getUserModelName function and go to a forum.post from a forum.forum. task-2889929 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website payments component now correctly declares its reliance on the payment accounting component. This helps ensure payment-related functions are available when needed, reducing setup or runtime issues for businesses using online payments.
Original PR description
Fine tuning of 61b8c0c1a2be6e7966413bf3c60b4475ae0e9a94. All accounts and payments related methods were moved to the `account_payment` module, so we are compelled to add the dependency. See also: - https://github.com/odoo/upgrade/pull/3879
The mail emoji picker has been corrected to include emojis up to Unicode 12.0. This improves the user experience by making more modern emoji options available when composing messages.
Original PR description
Task-2977886
This fixes an issue where placeholder sample-data messaging could appear inside related list or kanban sections when creating a new record from a sample-data view. Users now see a cleaner, more accurate form experience without misleading empty-state content.
Original PR description
Let's assume the following scenario: - be on a list or kanban view with sample data - click on "Create" (-> opens the form view) - in the form view, there's a kanban x2many field Before this commit, the no content helper was displayed in the form view, whereas it obviously should not. The issue occurred since [1], as this commit has the unwanted since effect to set the property `useSampleModel` to true on the form view model, which is used in the x2many kanban renderer to determine whether or not to display the no content helper. This commit forces that property to `false` on views that explicitely ask to ignore sample data. [1] 2600d1f2ae0ad5e478bd01ca7fdc69933576bff5
This fixes a small editor issue where table editing buttons could remain visible after switching views while the cursor was still over a table. The controls now hide when the cursor leaves the table, keeping the editing interface clean and avoiding confusing leftover buttons.
Original PR description
When hovering the first row and/or first column of a table, the buttons appear to edit it. These are removed in the callback of a mousemove event on the editable. If we click for instance on the code view button while still over the table, the mouse didn't move so the buttons are not removed. Then after that moving the mouse doesn't trigger the callback since the editable is not visible anymore. So the buttons stay. This fixes that case by adding a listener to the table on mouseleave, that will remove the buttons, then self-destroy. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change prevents an error that could occur when users clicked empty areas around tables in form views, such as work center settings. It keeps editor selection handling limited to the editable area, improving stability during routine form editing.
Original PR description
Steps to reproduce: odoo community > manufacturing > configuration > settings > enable work orders and save Then configuration > work centers > open a record > edit > click multiple times in the white space between the tab "general information" and the group "product information"
This update makes an event registration test easier to diagnose when it fails intermittently, helping maintain software quality. It also corrects pronoun usage in demo contact data for better wording consistency.
Original PR description
Fix occasionally failing test. Changing step labels allows to indentify which is failing. We also fix pronouns usage in demo data. Task-2976841
This change disables two automated checks that were failing unpredictably, even when the product itself was not necessarily broken. This helps keep validation pipelines reliable while the underlying test instability is investigated separately.
Original PR description
First known failure: https://runbot.odoo.com/runbot/build/16066782 First Nightly https://runbot.odoo.com/runbot/build/18976006 Failed in staging: https://runbot.odoo.com/runbot/build/19121210
Phone fields with no number now stay hidden instead of showing the word "false". This prevents confusing or unprofessional-looking contact details from appearing to users.
Original PR description
This commit hides the <a> representing the phone number if it is unset. Before this commit, it could display "false" instead of being invisible. Now, the <a> element is no longer added to the DOM. A test has been adapted to assert that behavior.
This update fixes unstable automated tests around the web interface’s autocomplete behavior. It helps prevent random test failures, making development and release validation more dependable without changing what users see.
Original PR description
This commit fixes several tests involving an Autocomplete component that would sometimes fail because it delays it's next rendering on input (by a setTimeout 0 in the tests). This is sometimes not enough as it may imply that the next rendering occurs after the next animation frame, which isn't what we wait for in the tests (we expect the next rendering to be applied in the next animation frame). This commit fixes remaining tests that we forgot in [1] [1] de6cd189a40a7145b6750bc582ca3cf0644c9bab
This fixes an issue in the web interface where a date provided as text was not correctly passed to a record. Business users benefit from more reliable date handling and fewer data entry issues in forms or automated flows.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes small payment configuration issues caused by recent provider renames and form layout changes. Business users should see cleaner payment provider setup screens, with Stripe express checkout options shown only where they actually apply.
Original PR description
Fine-tuning of https://github.com/odoo/odoo/commit/0501bbd62e517f6c215d9e7e36d61747c7f5816b. Now that `company_id` is present in the header, the XPath of the provider form view defined in the `website_payment` module puts the field `website_id` in the wrong place. This commit moves the field where it belongs. **** Fine-tuning of https://github.com/odoo/odoo/commit/61b8c0c1a2be6e7966413bf3c60b4475ae0e9a94. Missing rename of `transfer` to `custom` following commit https://github.com/odoo/odoo/commit/5f41f15e6b1d59bb99e3d304e6728a72547d2235. **** Before this commit, when Stripe was installed, all providers would display the option `Allow Express Checkout`. Now, the `Allow Express Checkout` field is only shown on providers that support this feature, even if Stripe is installed. **** [FIX] payment_demo: test provider code doesn't exists anymore Missing rename of `test` to `demo` following commit e64848940116684a22eaec538b58e79c21b7e9c3.
Creating a new payslip no longer triggers an error when no employee has been selected yet. Time off deferment warnings are now shown whenever relevant time off exists, helping payroll users continue their work without interruption.
Original PR description
After https://github.com/odoo/enterprise/pull/30468, it was decided to show the time off to defer warning in the form view only if the related employee of the payslip had some time off to defer. However, when creating a payslip, we don't have an employee yet and a traceback is shown. This commit reverts this behavior. So if there is a time-off to defer, the warning will be shown everytime. task-2976064
Users can now send signature requests even when no fields have been added to the document. This prevents an error message and keeps the signing workflow moving smoothly.
Original PR description
Sending without any added fields now works.
This fix polishes the user experience and visual layout of subscription-related sales screens. It helps sales and subscription users work with clearer, more consistent forms, reducing friction in day-to-day subscription management.
Original PR description
Follow up of https://github.com/odoo/enterprise/commit/878e1b0d7ca0dfd74c446b335c4ea92a22adfa47
The subscription app now includes a direct menu link to recurrence settings. This makes it easier for users to find and manage recurring subscription options without navigating through less obvious screens.
Original PR description
Add link to recurrence in menu
Administrators now receive the expected app management rights when installing an app, so they can access it immediately without manually updating their own user permissions. This keeps app permission behavior consistent across enterprise apps and reduces setup friction.
Original PR description
When the admin installs an app, he should see it directly, without having to give himself the app rights on his user form. This enterprise commit doesn't really change anything, but harmonizes the definition of app manager groups between the different apps. Finetuning of #27595 Task ID - 2936569