Monday, September 26, 2022
22 changes · master
Enhancements to existing features
Belgian employee salary setup now includes a private license plate field where relevant. This helps payroll and HR teams capture vehicle-related employee information directly during salary configuration, reducing follow-up data collection.
Original PR description
Add private_license_plate to the salary configurator. task-2936873
The salary configurator now captures an employee's private vehicle license plate as part of personal information. This improves Belgian payroll and salary contract setup by ensuring vehicle-related details are available where needed.
Original PR description
…ry configurator Add private_license_plate to the salary configurator. task-2936873
This update makes it cleaner for developers to adjust the context used by the timesheet grid. It does not change day-to-day user behavior, but it improves maintainability and makes future customizations safer and faster.
Original PR description
Before this commit modifying the context is not very clean. By making it a subfunction we can do a short & clean `super()` call to modify the context :)
Resolved issues and error corrections
A visual issue in enterprise list views was corrected so invalid cells show the intended border color. This helps users more clearly identify fields that need attention when reviewing or editing list data.
Original PR description
community: - https://github.com/odoo/odoo/pull/100183 task-2984169
Miscellaneous changes
Before this commit: When marking task as done, we overwrite so_line even for timesheets with so_line already set After this commit: When marking task as done, so_line is automatically set only for timesheets with no value for so_line. Task-2849270 Forward-Port-Of: odoo/enterprise#31490 Forward-Port-Of: odoo/enterprise#31165
Original PR description
Before this commit: When marking task as done, we overwrite so_line even for timesheets with so_line already set After this commit: When marking task as done, so_line is automatically set only for timesheets with no value for so_line. Task-2849270 Forward-Port-Of: odoo/enterprise#31490 Forward-Port-Of: odoo/enterprise#31165
lang is used in `select` query in all cases. whatever if name is translatable. So we need to set the var lang in all cases. task-nightly-click-all Forward-Port-Of: odoo/enterprise#31699
Original PR description
lang is used in `select` query in all cases. whatever if name is translatable. So we need to set the var lang in all cases. task-nightly-click-all Forward-Port-Of: odoo/enterprise#31699
task-2936932 Forward-Port-Of: odoo/enterprise#31596
Original PR description
task-2936932 Forward-Port-Of: odoo/enterprise#31596
Clicking button_update_avatax() creates taxes returned by Avatax that don't already exist. Various sales groups can click the button but don't have create access on account.tax. Solve it by sudoing the account.tax create call, similar to what is done in account_taxcloud. ~~This changes the account_avatax_sale tests to use a new sales user. This user is unlinked during class teardown to avoid having to change the query_count in TestLeadConvertMass.test_assignment_salesmen from 709 to 712 qu
Original PR description
Clicking button_update_avatax() creates taxes returned by Avatax that don't already exist. Various sales groups can click the button but don't have create access on account.tax. Solve it by sudoing the account.tax create call, similar to what is done in account_taxcloud. ~~This changes the account_avatax_sale tests to use a new sales user. This user is unlinked during class teardown to avoid having to change the query_count in TestLeadConvertMass.test_assignment_salesmen from 709 to 712 queries in the crm module.~~ opw-2988747 ~~PR note: instead of unlinking the user in the test I can add a community PR to update the query count, don't know if that's preferable. Both approaches are pretty awkward imo 🤷♂️.~~ Forward-Port-Of: odoo/enterprise#31636 Forward-Port-Of: odoo/enterprise#31540
Community: odoo/odoo#99408 Forward-Port-Of: odoo/enterprise#31291
Original PR description
Community: odoo/odoo#99408 Forward-Port-Of: odoo/enterprise#31291
With the change to 'always edit' on form views by default, several 'oe_read_only' fields had to be modified to play nice with the fact that in most cases, there is no read_only mode Forward-Port-Of: odoo/enterprise#31793
Original PR description
With the change to 'always edit' on form views by default, several 'oe_read_only' fields had to be modified to play nice with the fact that in most cases, there is no read_only mode Forward-Port-Of: odoo/enterprise#31793
This will add a button to launch the bank sync process directly on the tree view of the online synchronizations, replacing the create button that is not there. Forward-Port-Of: odoo/enterprise#31755
Original PR description
This will add a button to launch the bank sync process directly on the tree view of the online synchronizations, replacing the create button that is not there. Forward-Port-Of: odoo/enterprise#31755
# Current behaviour In Studio, when editing one of the text values of a newly added priority widget, we get a stacktrace. Visible only in debug=0 mode. # Expected behaviour You should be able to edit text values of priority widget without error. # Steps to reproduce - Install Project and Studio - Go to Project, choose whatever project - Select an item and activate Studio - Add a Priority Field to the form view - Select the Priority widget and select "Edit values" in the property tab
Original PR description
# Current behaviour In Studio, when editing one of the text values of a newly added priority widget, we get a stacktrace. Visible only in debug=0 mode. # Expected behaviour You should be able to edit…
# Current behaviour In Studio, when editing one of the text values of a newly added priority widget, we get a stacktrace. Visible only in debug=0 mode. # Expected behaviour You should be able to edit text values of priority widget without error. # Steps to reproduce - Install Project and Studio - Go to Project, choose whatever project - Select an item and activate Studio - Add a Priority Field to the form view - Select the Priority widget and select "Edit values" in the property tab - Edit one of the text values and try to confirm - Stacktrace should show up about a TypeError in js # Reason for the problem In debug=0 mode, we are retrieving the value of the `<li>` item with jQuery's `data()` method. The problem is that data() will coerce strings that have a number in them to a js number. So if value inside the HTML is '2', val in js is 2, not '2'. This breaks the conditional search of the index due to the strict equality (===) which doesn't coerce types implicitly. index is therefor -1 (non of the element satisfy the search), so on the next line when we try to access `this.selection[index]`, it is `undefined`, triggering the TypeError when accessing an attribute on the object. # Fix Replace jQuery's `data()` with `dataset.value`, which always returns a string (the raw value of value). `dataset.value` is already used for the same code when debug mode is activated for either simple debug or asset debug (same file, line 196). # Affected versions - 14.0 - 15.0 - saas-15.2 - saas-15.3 - 16.0 - master --- opw-2966783 Forward-Port-Of: odoo/enterprise#31587
This PR makes spreadsheet dashboards translatable. In a nutshell: - source terms are extracted from the spreadsheet data file - terms are then dynamically translated by the spreadsheet component in the web client Community PR https://github.com/odoo/odoo/pull/100809 Forward-Port-Of: odoo/enterprise#31629
Original PR description
This PR makes spreadsheet dashboards translatable. In a nutshell: - source terms are extracted from the spreadsheet data file - terms are then dynamically translated by the spreadsheet component in the web client Community PR https://github.com/odoo/odoo/pull/100809 Forward-Port-Of: odoo/enterprise#31629
Purpose ======= By default the user template has the Administrator access rights for all the applications, except the global admin rights. Add the missing security groups to the default user template. Forward-Port-Of: odoo/enterprise#31656
Original PR description
Purpose ======= By default the user template has the Administrator access rights for all the applications, except the global admin rights. Add the missing security groups to the default user template. Forward-Port-Of: odoo/enterprise#31656
Some fields are overridden to have 0,00 amount in financial reports. In l10n_lu reports: - Create journal items for the previous year that would appear on either BS or PnL - Export PnL through "Export ECDF Declaration" - Some report fields related to the previous year's data have their amount set to 0,00 even though there should be a non-zero value That is because `_report_useful_fields` checks if report values contain the `parent_code`. If the parent_*code* is not in the report, it ad
Original PR description
Some fields are overridden to have 0,00 amount in financial reports. In l10n_lu reports: - Create journal items for the previous year that would appear on either BS or PnL - Export PnL through "Export ECDF Declaration" - Some report fields related to the previous year's data have their amount set to 0,00 even though there should be a non-zero value That is because `_report_useful_fields` checks if report values contain the `parent_code`. If the parent_*code* is not in the report, it adds the parent_*field* in report values with 0 amount. But for the previous year `parent_code` != `parent_field`, as `parent_field` is `parent_code + 1`. Thus, report values would never contain the `parent_code` and the amount of the `parent_field` is overridden to 0. opw-2989056 Forward-Port-Of: odoo/enterprise#31713 Forward-Port-Of: odoo/enterprise#31582
button type was missing task: 2985735 Forward-Port-Of: odoo/enterprise#31548
Original PR description
button type was missing task: 2985735 Forward-Port-Of: odoo/enterprise#31548
Forward-Port-Of: odoo/enterprise#31452 Forward-Port-Of: odoo/enterprise#31392
Original PR description
Forward-Port-Of: odoo/enterprise#31452 Forward-Port-Of: odoo/enterprise#31392
Description of the issue/feature this PR addresses: A feature allowing to reboot the IoT Box and to restart Odoo on the IoT Box allows the user to do both these things remotely. Current behavior before PR: Before, the user had to manually unplug and replug the IoT Box to reboot it. Restarting Odoo on the IoT Box also implied connecting to the IoT Box. Desired behavior after PR is merged: Now the user can restart Odoo on the IoT Box and reboot the IoT Box through the IoT app in debug mod
Original PR description
Description of the issue/feature this PR addresses: A feature allowing to reboot the IoT Box and to restart Odoo on the IoT Box allows the user to do both these things remotely. Current behavior before PR: Before, the user had to manually unplug and replug the IoT Box to reboot it. Restarting Odoo on the IoT Box also implied connecting to the IoT Box. Desired behavior after PR is merged: Now the user can restart Odoo on the IoT Box and reboot the IoT Box through the IoT app in debug mode, on the IoT Box view page. [Another PR](https://github.com/odoo/odoo/pull/100999) in odoo allows the user to do it from the IoT Box homepage as well. [Task 2476576](https://www.odoo.com/web#id=2476576&cids=1&menu_id=4720&action=333&active_id=1428&model=project.task&view_type=form) -- I confirm I have signed the CLA and read the PR guidelines at [www.odoo.com/submit-pr](http://www.odoo.com/submit-pr) Forward-Port-Of: odoo/enterprise#31723
Currently unable to see if someone is working on a picking thus when qty is changed from barcode app, current user is assigned on picking and is shown on the kanban view, if not set user of batch is shown, added unassigned or assigned to self picking filter TaskId: 2871679 COM PR: https://github.com/odoo/odoo/pull/94633 Forward-Port-Of: odoo/enterprise#28886
Original PR description
Currently unable to see if someone is working on a picking thus when qty is changed from barcode app, current user is assigned on picking and is shown on the kanban view, if not set user of batch is shown, added unassigned or assigned to self picking filter TaskId: 2871679 COM PR: https://github.com/odoo/odoo/pull/94633 Forward-Port-Of: odoo/enterprise#28886
The line "Resultados de ejercicios anteriores" was not well calculated. We add a hidden line to calculate the amount from previous year Profit and Loss and add it to the sum of accounts 120 and 121. We do the same for th three balance sheet reports. opw-2920843 Forward-Port-Of: odoo/enterprise#30756
Original PR description
The line "Resultados de ejercicios anteriores" was not well calculated. We add a hidden line to calculate the amount from previous year Profit and Loss and add it to the sum of accounts 120 and 121. We do the same for th three balance sheet reports. opw-2920843 Forward-Port-Of: odoo/enterprise#30756
This commit fixes two layout issues in views, where a field should be displayed next to an icon, with a whitespace in between. Forward-Port-Of: odoo/enterprise#31610
Original PR description
This commit fixes two layout issues in views, where a field should be displayed next to an icon, with a whitespace in between. Forward-Port-Of: odoo/enterprise#31610
Steps to reproduce: 1) Create Shipping Methods: - Put test and production keys - Carrier Type: UPS (you have to load them beforehand with the BUTTON) - Default package: "Pak" 2) Create new product: - Weight = 1 - Storable Product - On hand product : 25 units 3) Create new product: - Weight = 2 - Storable Product - On hand product : 25 units 4) Create a sale order: - Add the two created products - Add a shipping Easypost - click on get rate before adding it - confirm 5) C
Original PR description
Steps to reproduce: 1) Create Shipping Methods: - Put test and production keys - Carrier Type: UPS (you have to load them beforehand with the BUTTON) - Default package: "Pak" 2) Create new product: -…
Steps to reproduce: 1) Create Shipping Methods: - Put test and production keys - Carrier Type: UPS (you have to load them beforehand with the BUTTON) - Default package: "Pak" 2) Create new product: - Weight = 1 - Storable Product - On hand product : 25 units 3) Create new product: - Weight = 2 - Storable Product - On hand product : 25 units 4) Create a sale order: - Add the two created products - Add a shipping Easypost - click on get rate before adding it - confirm 5) Click on the smart button delivery 6) Set the quantity done for one of the product and click on "PUT IN PACK" - select "Pak" 7) Set the quantity done for the other product and click on "PUT IN PACK" - select "Pak" 8) Validate Issue: - Traceback: 'NoneType' object is not subscriptable Cause: In a test environment, with easypost-ups, whenever you have only one `tracking_id` for multiple shipments (by default in test env), easypost-ups will respond with only one `tracker` for the first shipment (package) and set the `tracker` for the other shipments (packages) to Null. Transcript with easypost tech support: ``` I did some testing on my end and found that there will be only one tracker object returned when in the Test environment with UPS. I also found that in production, I received a tracker object as well as tracking URLs for both shipments in the order. You are correct with your original outreach, that in test, you would only receive one tracker object since the tracking codes are the same. ``` Solution: Though not beautiful, when in test mode and with UPS, select only the `tracker` for the first shipment. opw-2963499 Forward-Port-Of: odoo/enterprise#31241