Friday, September 30, 2022
52 changes · master
Enhancements to existing features
List views now avoid showing confusing placeholder text when certain file-related fields contain non-file data. This keeps existing file size information for real attachments while making tooltips cleaner and easier to understand.
Original PR description
When using a binary field in a list renderer the tooltip displays either: 1. `[Object object]` - for non stored json data 2. File size - for attachment data to resolve case 1, the formatter checks the type of the data and returns an empty string, while maintaining the behaviour for case 2. This can be seen when using the `analytic_distribution` widget (see invoices odoo/odoo#98914)
The accounting app now has a dedicated form view for tax groups, making the setup screen cleaner and easier to read. Unnecessary country code information is hidden because the country is already shown, reducing clutter for users managing tax settings.
Original PR description
The tax group model doesn't have a form view leading to a left side bigger than the right side and some fields showing that we don't want to see. Thus, we add a form view and hide the field country_code, which is not needed here since we already see the country_id. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
A visual spacing issue in form views has been corrected so section titles and grouped content no longer appear too close together. This makes forms easier to read and provides a cleaner layout for users.
Original PR description
Since commit https://github.com/odoo-dev/odoo/commit/8fa6e923d0fc8695d92e0b114e230d3abab7d9bc, the `o_horizontal_separator` no longer has a right margin and did not have enough space between each `o_inner_group`. This commit fixes this issue. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Purpose: ======== Knowledge allows to search images from unsplash when selecting a cover for an article. One would like to show only images with a landscape orientation when selecting a cover, since images with other orientations do not fit properly. Also made "UnsplashError" component exportable so that it can be used in Knowledge's Cover Selector. Specs: ====== Modified unsplash_service and image_selector so that one can specify the orientation of the images to fetch from unsplash. A
Original PR description
Purpose: ======== Knowledge allows to search images from unsplash when selecting a cover for an article. One would like to show only images with a landscape orientation when selecting a cover, since images with other orientations do not fit properly. Also made "UnsplashError" component exportable so that it can be used in Knowledge's Cover Selector. Specs: ====== Modified unsplash_service and image_selector so that one can specify the orientation of the images to fetch from unsplash. Added the orientation as cache key so that images in cache are not shown when using the same query word but with another orientation (eg. in knowledge, search an image for the body of the article then searching a cover using the same query term). Task-2852916 Forward-Port-Of: odoo/odoo#101032
The fix ensures that when users open the "Holes in sequence" shortcut from a journal dashboard, the create form defaults to the same journal they were working on instead of Miscellaneous Entries. This reduces confusion and helps accounting users correct sequence gaps more accurately.
Original PR description
When using the "Holes in sequence" shortcut on a journal in the Dashboard, the "Create" form shows the Miscellanous Entries journal as a default instead of the same Journal that the user trying to fix. Video: https://watch.screencastify.com/v/kUorLSIHwoy97UKuDJBC
This update applies minor fixes to manufacturing work order screens. It should improve day-to-day usability for teams managing production operations without changing core business processes.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Prior, by default Skill history report goes to stacked view. Which is not informative for the kind of information that is displayed. task - 2993831 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100997
Original PR description
Prior, by default Skill history report goes to stacked view. Which is not informative for the kind of information that is displayed. task - 2993831 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100997
Forward-Port-Of: odoo/odoo#101288
Original PR description
Forward-Port-Of: odoo/odoo#101288
Odoo charts have a specific need of dataSources for their runtime data (in oppostion to standard graphs). In order to link the chart with its datasource, we injected the chart id inside its definition in order to be able to fetch the corresponding datasource. Unfortunately, this approach require that we can access the chartId from anywhere which is unfortunately not the case when we copy/cut/paste a chart. The current implementation would c the chart Note that a chart should not be aware of it
Original PR description
Odoo charts have a specific need of dataSources for their runtime data (in oppostion to standard graphs). In order to link the chart with its datasource, we injected the chart id inside its definition in order to be able to fetch the corresponding datasource. Unfortunately, this approach require that we can access the chartId from anywhere which is unfortunately not the case when we copy/cut/paste a chart. The current implementation would c the chart Note that a chart should not be aware of its own id, that is its place in the mapping of a plugin. This commit changes the approach to set the dataSource inside the chart directly through a method only available on OdooChart instances. task 2998207 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101308
Since that commit dd7f4d501a4d23b04a1899be8fd51cc583673c9d A picking type cannot make the scan of the source location mandatory if the scan of the destination source is optional. An error is raised in case the user tries to edit and save a picking types with this erronous config but there is also an issue if the user tries to set the outgoing shipments in 2 or 3 steps. The method `_create_or_update_sequences_and_picking_types` was the cause of this issue because of an `update` on the `stock.pic
Original PR description
Since that commit dd7f4d501a4d23b04a1899be8fd51cc583673c9d A picking type cannot make the scan of the source location mandatory if the scan of the destination source is optional. An error is raised in case the user tries to edit and save a picking types with this erronous config but there is also an issue if the user tries to set the outgoing shipments in 2 or 3 steps. The method `_create_or_update_sequences_and_picking_types` was the cause of this issue because of an `update` on the `stock.picking.type`. We try to update `restrict_scan_source_location` to "mandatory" and `restrict_scan_dest_location` to "no" for the pick operation, the issue is with `update`, each field is write one by one, and so, it will write on `restrict_scan_source_location` first while `restrict_scan_dest_location` is still set on "optional". To fix that, we replace the `update` by a `write`. Forward-Port-Of: odoo/odoo#101443
Imported unsplash in web_editor when it was not a dependency. This caused the test to fail when web_unsplash was not installed. As it is necessary to import it when the module is installed, this test is moved to test_website as both modules are installed there. (Also updated to ES6 import syntax + odoo-module style test) task #3000801 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101544
Original PR description
Imported unsplash in web_editor when it was not a dependency. This caused the test to fail when web_unsplash was not installed. As it is necessary to import it when the module is installed, this test is moved to test_website as both modules are installed there. (Also updated to ES6 import syntax + odoo-module style test) task #3000801 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101544
part of task-3000274 Forward-Port-Of: odoo/odoo#101561
Original PR description
part of task-3000274 Forward-Port-Of: odoo/odoo#101561
This helps tracking views that still need to be converted, like we already do for fields. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101581
Original PR description
This helps tracking views that still need to be converted, like we already do for fields. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101581
If website is installed, the login page of Odoo has opengraph meta that will be used to create link preview on mention and channel link. This PR add a xpath condition to always ignore mention and channel link in the message body. Part of task-3000274 Forward-Port-Of: odoo/odoo#101594
Original PR description
If website is installed, the login page of Odoo has opengraph meta that will be used to create link preview on mention and channel link. This PR add a xpath condition to always ignore mention and channel link in the message body. Part of task-3000274 Forward-Port-Of: odoo/odoo#101594
Before this commit Can display the color list picker event if no color_field has been set. This could lead to a traceback if a color is selected. After this commit The field does not allow to show the color list without a color_field. Forward-Port-Of: odoo/odoo#101602
Original PR description
Before this commit Can display the color list picker event if no color_field has been set. This could lead to a traceback if a color is selected. After this commit The field does not allow to show the color list without a color_field. Forward-Port-Of: odoo/odoo#101602
Preview of accrued entries should occupy full width. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101608
Original PR description
Preview of accrued entries should occupy full width. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101608
Forward-Port-Of: odoo/odoo#101622
Original PR description
Forward-Port-Of: odoo/odoo#101622
If a user imports a FacturX where an item has a name but no description, the invoice is not created. We now use the item name as a fallback in case there is no description. opw-2951705 Forward-Port-Of: odoo/odoo#101624 Forward-Port-Of: odoo/odoo#101545
Original PR description
If a user imports a FacturX where an item has a name but no description, the invoice is not created. We now use the item name as a fallback in case there is no description. opw-2951705 Forward-Port-Of: odoo/odoo#101624 Forward-Port-Of: odoo/odoo#101545
Steps to reproduce: 1. change system and admin's time zone to one with a different date than UTC 2. enable multi-currency in the accounting module 3. add rates for the current date in local time zone and UTC 4. go to settings > currencies 5. the rate for the UTC date is displayed To fix this, we should use a time zone aware field in `res_currency`. opw-2945108 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#1001
Original PR description
Steps to reproduce: 1. change system and admin's time zone to one with a different date than UTC 2. enable multi-currency in the accounting module 3. add rates for the current date in local time zone and UTC 4. go to settings > currencies 5. the rate for the UTC date is displayed To fix this, we should use a time zone aware field in `res_currency`. opw-2945108 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100123
When we introduced the `useSortable` hook [1] and [2], the kanban column fit the size of the kanban record when the DnD record hovers the column. This behavior is not desired when the record is hovering over a folded column, so we apply now a `display:none` value on the record to avoid the resize of the column. Steps to reproduce: 1. Go to project 2. Open Office design 3. Try to drag and drop a record to a folded column The width of the folded column is incremented to the width of the re
Original PR description
When we introduced the `useSortable` hook [1] and [2], the kanban column fit the size of the kanban record when the DnD record hovers the column. This behavior is not desired when the record is hovering over a folded column, so we apply now a `display:none` value on the record to avoid the resize of the column. Steps to reproduce: 1. Go to project 2. Open Office design 3. Try to drag and drop a record to a folded column The width of the folded column is incremented to the width of the record => bug Links: 1. https://github.com/odoo/odoo/commit/ebb410accbe3aac051e73031384f640a40544efc 2. https://github.com/odoo/odoo/commit/cf4a8f198fd2daa2b4d9f9f69c5c769c21ff13c5 Forward-Port-Of: odoo/odoo#101424
Prepare support of embed views and complete owlification of commands by adding preparatory commits. See sub commits for more details. Prepares Task-2796156 Prepares https://github.com/odoo/enterprise/pull/29423 Forward-Port-Of: odoo/odoo#101566
Original PR description
Prepare support of embed views and complete owlification of commands by adding preparatory commits. See sub commits for more details. Prepares Task-2796156 Prepares https://github.com/odoo/enterprise/pull/29423 Forward-Port-Of: odoo/odoo#101566
Odoo CLA for Vanneri Happy to Contribute Forward-Port-Of: odoo/odoo#101525
Original PR description
Odoo CLA for Vanneri Happy to Contribute Forward-Port-Of: odoo/odoo#101525
task-3000399 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101642
Original PR description
task-3000399 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101642
This commit fixes the issue where the undo of the resizing of an element is not done in one step. Steps to reproduce: - drop a snippet (like text-image) - resize the image - undo => you have to click multiple times before going back to the initial size. task-2968749 Forward-Port-Of: odoo/odoo#99354
Original PR description
This commit fixes the issue where the undo of the resizing of an element is not done in one step. Steps to reproduce: - drop a snippet (like text-image) - resize the image - undo => you have to click multiple times before going back to the initial size. task-2968749 Forward-Port-Of: odoo/odoo#99354
Description of the issue/feature this PR addresses: If auth_msg is set, it can be used of template.xml Current behavior before PR: pending_msg,done_msg and cancel_msg was used when set them in template.xml of website_sale. But auth_msg was not used. Desired behavior after PR is merged: If auth_msg is set,it can be used of template.xml similarly pending_msg,done_msg and cancel_msg -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-
Original PR description
Description of the issue/feature this PR addresses: If auth_msg is set, it can be used of template.xml Current behavior before PR: pending_msg,done_msg and cancel_msg was used when set them in template.xml of website_sale. But auth_msg was not used. Desired behavior after PR is merged: If auth_msg is set,it can be used of template.xml similarly pending_msg,done_msg and cancel_msg -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#99367
Forward-Port-Of: odoo/odoo#101638
Original PR description
Forward-Port-Of: odoo/odoo#101638
When updating bootstrap to bootstrap 5 with [1], the h-0 and w-0 extended utility classes were lost. This commit adds them back, using the Utility API of Bootstrap described here [2], and the $utilities-sizes from [3]. Therefore, the code introduced in [4] is not needed anymore (those classes are now available in all Odoo instead of just the frontend). This commit fixes the footer "scroll to top" option of the website builder. [1]: https://github.com/odoo/odoo/commit/971e5a91aab9
Original PR description
When updating bootstrap to bootstrap 5 with [1], the h-0 and w-0 extended utility classes were lost. This commit adds them back, using the Utility API of Bootstrap described here [2], and the $utilities-sizes from [3]. Therefore, the code introduced in [4] is not needed anymore (those classes are now available in all Odoo instead of just the frontend). This commit fixes the footer "scroll to top" option of the website builder. [1]: https://github.com/odoo/odoo/commit/971e5a91aab9 [2]: https://getbootstrap.com/docs/5.0/utilities/api/ [3]: https://github.com/odoo/odoo/commit/e377a084174d [4]: https://github.com/odoo/odoo/commit/da55072a6935 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101541
Always edit mode comes with several layout and behavioral changes that may necessitate changes in tours (both in terms of selectors for the tips and in terms of content, e.g. since "Save" steps are now kind of redundant). Forward-Port-Of: odoo/odoo#101328
Original PR description
Always edit mode comes with several layout and behavioral changes that may necessitate changes in tours (both in terms of selectors for the tips and in terms of content, e.g. since "Save" steps are now kind of redundant). Forward-Port-Of: odoo/odoo#101328
This reverts commit 3a7349d02b6b667c890af2f197a3640d875b804e. This toolbar being more accessible in mobile (scrolling to access all the buttons), sadly it broke the toolbar's dropdown... Forward-Port-Of: odoo/odoo#101711
Original PR description
This reverts commit 3a7349d02b6b667c890af2f197a3640d875b804e. This toolbar being more accessible in mobile (scrolling to access all the buttons), sadly it broke the toolbar's dropdown... Forward-Port-Of: odoo/odoo#101711
This PR https://github.com/odoo/odoo/pull/97805 wrongly assumed that self contained a single workorder. This would raise an error if there were multiple records in self. Solution: Modify calls on `self` to `workorder` (as we already iterate through them) Forward-Port-Of: odoo/odoo#101706 Forward-Port-Of: odoo/odoo#101580
Original PR description
This PR https://github.com/odoo/odoo/pull/97805 wrongly assumed that self contained a single workorder. This would raise an error if there were multiple records in self. Solution: Modify calls on `self` to `workorder` (as we already iterate through them) Forward-Port-Of: odoo/odoo#101706 Forward-Port-Of: odoo/odoo#101580
This PR brings some fixes to fields since the form view is shown in edition mode by default. `phone, url and email` fields were missing a way to interact with the link, since an input is displayed instead Tests have been added/adapted to make sure the link is available again, and shown as expected. The SmsButton has also been adapted, since it was no longer visible in form views and should now be visible Forward-Port-Of: odoo/odoo#101433
Original PR description
This PR brings some fixes to fields since the form view is shown in edition mode by default. `phone, url and email` fields were missing a way to interact with the link, since an input is displayed instead Tests have been added/adapted to make sure the link is available again, and shown as expected. The SmsButton has also been adapted, since it was no longer visible in form views and should now be visible Forward-Port-Of: odoo/odoo#101433
This field widget is no longer used in form, list or kanban views, so it hasn't been converted to owl. This commit removes its legacy implementation from the registry, s.t. we ensure nobody use it again. Moreover, we adapted a new view test using it to use another field widget instead, to remove the dependency and ease the removal that should happen soon. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I
Original PR description
This field widget is no longer used in form, list or kanban views, so it hasn't been converted to owl. This commit removes its legacy implementation from the registry, s.t. we ensure nobody use it again. Moreover, we adapted a new view test using it to use another field widget instead, to remove the dependency and ease the removal that should happen soon. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101563
Fixup for d823033ad67702b1b92d27a3f66c7a4ec304c644 Portal user should not modify partner's name if an invoice for this partner is already issued. However, delivery address contact may have empty name, while eCommerce UI requires filling out the name. This blocks checkout process. Fix it by allowing name changes, when it's not set. opw-2981455 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm
Original PR description
Fixup for d823033ad67702b1b92d27a3f66c7a4ec304c644 Portal user should not modify partner's name if an invoice for this partner is already issued. However, delivery address contact may have empty name, while eCommerce UI requires filling out the name. This blocks checkout process. Fix it by allowing name changes, when it's not set. opw-2981455 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100797
This PR improves the fiduciary mode by: - removing message error about the change of sequence format - suggesting the Customer Invoice / Vendor Bill date according to the following heuristic: - Last day of the month of the most recent Customer Invoice / Vendor Bill (ignoring drafts) OR today (whichever is the smallest) - If this date falls before a Lock Date, pick the last day of the first month that is not locked Example 1 : We are June 17th 2022. No Lock date. Bill Date of the mos
Original PR description
This PR improves the fiduciary mode by: - removing message error about the change of sequence format - suggesting the Customer Invoice / Vendor Bill date according to the following heuristic: - Last…
This PR improves the fiduciary mode by: - removing message error about the change of sequence format - suggesting the Customer Invoice / Vendor Bill date according to the following heuristic: - Last day of the month of the most recent Customer Invoice / Vendor Bill (ignoring drafts) OR today (whichever is the smallest) - If this date falls before a Lock Date, pick the last day of the first month that is not locked Example 1 : We are June 17th 2022. No Lock date. Bill Date of the most recent Vendor Bill : March 15th 2022 ==> Default New Vendor Bill date = March 31st 2022 (last day of March 2022) Example 2 : We are June 17th 2022. No Lock date. Bill Date of the most recent Vendor Bill : March 31st 2022 ==> Default New Vendor Bill date = March 31st 2022 (last day of March 2022) Example 3 : We are June 17th 2022. No Lock date. Bill Date of the most recent Vendor Bill : June 2nd 2022 ==> Default New Vendor Bill date = June 17th 2022 (today is the smallest) Example 4 : We are June 17th 2022. Lock date : April 30th 2022. Bill Date of the most recent Vendor Bill : April 30th 2022 ==> Default New Vendor Bill date = May 31st 2022 (last day of the first month not locked) - renaming the invoice according to suggested date Task id: 2887007 Forward-Port-Of: odoo/odoo#95918
Various corrections: - In validation screen: make the bar above buttons as wide as the screen. Make outlook and google calendar buttons closer. - In demo data: The centered text for "Technical Demo" is not looking good at all. Make it align left. - In various screens, have the same spacing between the arrow and the All appointment text in the navbar. - In the appointment card view, make the horizontal bar as wide as the rest of the elements. - Make the titles appear in the same place of t
Original PR description
Various corrections: - In validation screen: make the bar above buttons as wide as the screen. Make outlook and google calendar buttons closer. - In demo data: The centered text for "Technical Demo"…
Various corrections: - In validation screen: make the bar above buttons as wide as the screen. Make outlook and google calendar buttons closer. - In demo data: The centered text for "Technical Demo" is not looking good at all. Make it align left. - In various screens, have the same spacing between the arrow and the All appointment text in the navbar. - In the appointment card view, make the horizontal bar as wide as the rest of the elements. - Make the titles appear in the same place of the screen to make transitions smoother. (No "flicker" because of moving element) - Make navbar the same height in all screens. - Make user picture appear at the same place in registration and validation views. (Most elements will now be set at the same place, with the same style, if possible. This prevents flickering) User card Cards are now displayed even when no avatars is set to the appointment type (except for random assignment, since no user is set at the start of the appointment process): it now contains the phone and email of the selected user as well. The texts "Meeting details" and "You will meet with" are deleted. The templates are simplified accordingly. Icons of the user card and of appointment details are aligned in the "Details" screen. Task-2991577 Forward-Port-Of: odoo/enterprise#31655
Purpose: - Instead of opening other users' private articles that are not shown in the sidebar (but that you can access because you are admin user) when there are no articles in the sidebar, show the No Content Helper. When the No Content Helper is shown, the "virtual article in creation" is now not editable at all (previously, even with the helper displayed, one could write in the body, change the name, add an icon/cover or add to favorites). We force the user to use one of our "create" b
Original PR description
Purpose: - Instead of opening other users' private articles that are not shown in the sidebar (but that you can access because you are admin user) when there are no articles in the sidebar, show the No Content Helper. When the No Content Helper is shown, the "virtual article in creation" is now not editable at all (previously, even with the helper displayed, one could write in the body, change the name, add an icon/cover or add to favorites). We force the user to use one of our "create" buttons to create an article. Task-2985591 Forward-Port-Of: odoo/enterprise#31947
Some empty groupby were in the ES, LU and AT balance sheet because of the script for reportalypse. Also corrected a traceback where we couldn't access the abridged version of the LU BS task-id: 3001269 Forward-Port-Of: odoo/enterprise#32016
Original PR description
Some empty groupby were in the ES, LU and AT balance sheet because of the script for reportalypse. Also corrected a traceback where we couldn't access the abridged version of the LU BS task-id: 3001269 Forward-Port-Of: odoo/enterprise#32016
Right now, when moving an article above a read-only article, we cannot do so because it changes the sequence of the read-only article. With this PR, the article can be moved above the read-only article. taskID-2925856 Forward-Port-Of: odoo/enterprise#32008
Original PR description
Right now, when moving an article above a read-only article, we cannot do so because it changes the sequence of the read-only article. With this PR, the article can be moved above the read-only article. taskID-2925856 Forward-Port-Of: odoo/enterprise#32008
This commit is the counterpart of https://github.com/odoo/odoo/pull/101433, and adapts the code of voip to patch the right elements in the PhoneField template. As the field now always displays a Call button, the call must be enabled even in edition mode. Forward-Port-Of: odoo/enterprise#31954
Original PR description
This commit is the counterpart of https://github.com/odoo/odoo/pull/101433, and adapts the code of voip to patch the right elements in the PhoneField template. As the field now always displays a Call button, the call must be enabled even in edition mode. Forward-Port-Of: odoo/enterprise#31954
test_action_perform_auto_transfer is calling action_perform_auto_transfer twice at the last day of the month. This is not an issue as the transfer from the next month will just be there empty until the next day. The test was failing on the last day of the month as it expects a single call to action_perform_auto_transfer. Forward-Port-Of: odoo/enterprise#32066
Original PR description
test_action_perform_auto_transfer is calling action_perform_auto_transfer twice at the last day of the month. This is not an issue as the transfer from the next month will just be there empty until the next day. The test was failing on the last day of the month as it expects a single call to action_perform_auto_transfer. Forward-Port-Of: odoo/enterprise#32066
Purpose: - - Change the indentation of the articles names in the sidebar, so that articles of the same level (parent/1st child/2nd child, ...) are aligned - Make the size of the input match exactly the length of the article name: previously, the input size was set using the size attribute, which approximates the length using the number of characters of the name and a mean character width value. This resulted in cropped names if there was a majority of large characters, or in a too lar
Original PR description
Purpose: - - Change the indentation of the articles names in the sidebar, so that articles of the same level (parent/1st child/2nd child, ...) are aligned - Make the size of the input match exactly…
Purpose: - - Change the indentation of the articles names in the sidebar, so that articles of the same level (parent/1st child/2nd child, ...) are aligned - Make the size of the input match exactly the length of the article name: previously, the input size was set using the size attribute, which approximates the length using the number of characters of the name and a mean character width value. This resulted in cropped names if there was a majority of large characters, or in a too large input if it was the opposite. The name was also cropped when entering the edition mode. The input size now matches exactly the article name, at any time - Change the range of the allowed width for the resizable sidebar: allows users to make it smaller than before, but not as wide (users could resize it to take the half of the screen width, which was too much considered it is a sidebar) - Change wording of messages shown when trying to move an article: adds the article name in the message, and the destination in the title to make it easier for the user - Make icons bigger in the options panel - Avoid changing the look of the sidebar when installing website: fixes the font-size in the sidebar so that the search bar, section headers and article names are not too large when installing website. - Fix hidden article names in the sidebar: shows the article names in the sidebar even when the window size is small. - Add resizable sidebar in frontend: allows visitors to resize the sidebar, the same way users can do it in backend, as visitors can also have small screens - Keep selected sidebar size: when an user changes the size of the sidebar, the selected width is stored in localStorage so that it can be set automatically when the user selects another article or reloads the page Task-2858661 Forward-Port-Of: odoo/enterprise#31852
This PR brings some fixes regarding previous owl conversion. Forward-Port-Of: odoo/enterprise#31993
Original PR description
This PR brings some fixes regarding previous owl conversion. Forward-Port-Of: odoo/enterprise#31993
Forward-Port-Of: odoo/enterprise#31769
Original PR description
Forward-Port-Of: odoo/enterprise#31769
Forward-Port-Of: odoo/enterprise#31756
Original PR description
Forward-Port-Of: odoo/enterprise#31756
Forward-Port-Of: odoo/enterprise#31991
Original PR description
Forward-Port-Of: odoo/enterprise#31991
Forward-Port-Of: odoo/enterprise#32013
Original PR description
Forward-Port-Of: odoo/enterprise#32013
Overriding `_get_view` should be avoided when possible, when there is an easier alternative. In this case, the method override can be avoided by simply using the key `form_view_ref` to correctly choose the form to use in that action. In this case, since the result of `_get_view` is cached, since odoo/odoo#99417, it even leaded to a bug when calling `get_view` twice, once with `{'force_email': False}` and once with `{force_email: True}`, as the context key `force_email` is not taken
Original PR description
Overriding `_get_view` should be avoided when possible,
when there is an easier alternative.
In this case, the method override can be avoided by
simply using the key `form_view_ref` to correctly
choose the form to use in that action.
In this case, since the result of `_get_view` is cached,
since odoo/odoo#99417,
it even leaded to a bug when calling `get_view` twice,
once with `{'force_email': False}`
and once with `{force_email: True}`,
as the context key `force_email` is not taken into account,
and `_get_view` would therefore return the same view for
the two possible values.
Forward-Port-Of: odoo/enterprise#31937Before: when we selected credit note boleta in the wizard, it would not put it as such in the case of a full refund. Replaces https://github.com/odoo/odoo/pull/97933/files Forward-Port-Of: odoo/enterprise#30874
Original PR description
Before: when we selected credit note boleta in the wizard, it would not put it as such in the case of a full refund. Replaces https://github.com/odoo/odoo/pull/97933/files Forward-Port-Of: odoo/enterprise#30874
Before this PR it is not possible to override the read_grid() and insert multiple custom keys for the titles in the Grid view. Since Odoo was not re-checking/updating the groupBy part it was always loading the old values. This caused it to be impossible to define custom row_fields (with a super()) in the read_group. By always updating/computing/comparing against what is controller in the XML-RPC layer we always have all the row_fields used and shown. Sample to test: In timesheet_grid/mode
Original PR description
Before this PR it is not possible to override the read_grid() and insert multiple custom keys for the titles in the Grid view. Since Odoo was not re-checking/updating the groupBy part it was always loading the old values. This caused it to be impossible to define custom row_fields (with a super()) in the read_group.
By always updating/computing/comparing against what is controller in the XML-RPC layer we always have all the row_fields used and shown.
Sample to test:
In timesheet_grid/models/analytic.py in the 'read_grid' set a custom row_fields right above the if not self.env.context.get() like this: row_fields = ['partner_id', 'project_id', 'task_id', 'so_line'] This should show the customer name, projct name, task name and sale order name (if set) in the Grid view. Before our JS changes it doesn't though as it keeps working with the defaults ('project_id', 'task_id') and doesn't use our custom set ones.
Forward-Port-Of: odoo/enterprise#31988In l10n_be_hr_payroll and opting for a part time contract (1/5) for an employee who is already working 4/5, the work time rate is 25%. The work time rate should be based on the default resource calendar of the contract's structure type. If an employee works part time 1/5, the work time rate should be 20% task-2841583 Forward-Port-Of: odoo/enterprise#31956 Forward-Port-Of: odoo/enterprise#27169
Original PR description
In l10n_be_hr_payroll and opting for a part time contract (1/5) for an employee who is already working 4/5, the work time rate is 25%. The work time rate should be based on the default resource calendar of the contract's structure type. If an employee works part time 1/5, the work time rate should be 20% task-2841583 Forward-Port-Of: odoo/enterprise#31956 Forward-Port-Of: odoo/enterprise#27169
Enterprise part of odoo/odoo#101288 Forward-Port-Of: odoo/enterprise#31850
Original PR description
Enterprise part of odoo/odoo#101288 Forward-Port-Of: odoo/enterprise#31850
Purpose: ======== Instead of using the standard "avatar" image picker for the covers, create a CoverSelector, based on ImageSelector used in the MediaDialog from web_editor which is prettier, allows to reuse covers, and allows to select images from unsplash. When the user clicks on "add cover" in knowledge, picks a random image from unsplash using the name of the article as search query. If unsplash credentials are not set or if service is down, falls back to the "change cover" beha
Original PR description
Purpose: ======== Instead of using the standard "avatar" image picker for the covers, create a CoverSelector, based on ImageSelector used in the MediaDialog from web_editor which is prettier, allows…
Purpose: ======== Instead of using the standard "avatar" image picker for the covers, create a CoverSelector, based on ImageSelector used in the MediaDialog from web_editor which is prettier, allows to reuse covers, and allows to select images from unsplash. When the user clicks on "add cover" in knowledge, picks a random image from unsplash using the name of the article as search query. If unsplash credentials are not set or if service is down, falls back to the "change cover" behaviour, showing the CoverSelector allowing the user to pick an existing cover, to upload a new one, or to enter its unsplash credentials. Specs: ====== Create a "knowledge.cover" model which references an image in ir.attachment (the actual cover image). This allows to create a "bank of images" for knowledge articles, so that images uploaded as covers can be reused in different articles without duplicating the attachment, but cannot be seen in the mediaDialog when used in other apps, or when used in the body of articles. The model also stores the url of the images, so that the images can be displayed in frontend (these urls contains access tokens when they are required for external access, which is the case for images uploaded using the "upload image" button). Create the components "CoverDialog" and "CoverSelector", based on "MediaDialog" and "ImageSelector" but adapted for knowledge's use-cases and the new "knowledge.cover" model. This CoverSelector only shows covers used in articles the user can access, so that covers of private articles remain private. The binary field "cover" is replaced by a many2one field "cover_image_id" referencing a record of the new "knowledge.cover" model. A new field "cover_image_id" has also been added, referencing the covers' attachment, which is used to display the cover. When a cover is not used anymore, it is deleted. - Extend "web_unsplash" controller and add a route that fetches a random image from unsplash using a query word, then uses "web_unsplash"'s route to save the image in ir_attachments. - Add a method calling this route using the article name as query when clicking on the "Add cover" button. During the request, the button is hidden so that one can not click multiple times on it and send several rpc's. If the request returns an error (unsplash credentials not set, service unavailable, ...), opens the CoverSelectorDialog instead. Task-2852916 Forward-Port-Of: odoo/enterprise#31744