Saturday, October 1, 2022
21 changes · master
Resolved issues and error corrections
This update fixes an issue where changes made in the Planning form might not finish saving properly. It ensures the save process completes in the right order, reducing the risk of lost or inconsistent planning updates.
Original PR description
Commit 6ff687bf08ee7d9d2f80673df5d848f835eeea8f missed an await on super call.
Miscellaneous changes
Consider this case: Template A has 2 variants: KIT and NOKIT KIT has a total cost of 100, NOKIT costs 50 When selling NOKIT, the current code will select the bom of KIT to calculate the price_unit of NOKIT, which means that when reconciling the aml of the invoice (amount = 100) with the aml of the cogs move (amount = 50), it will be partial due to the difference in amount. This also messes with the balance sheet report. This fix ensures that only boms directly related to the product
Original PR description
Consider this case: Template A has 2 variants: KIT and NOKIT KIT has a total cost of 100, NOKIT costs 50 When selling NOKIT, the current code will select the bom of KIT to calculate the price_unit of NOKIT, which means that when reconciling the aml of the invoice (amount = 100) with the aml of the cogs move (amount = 50), it will be partial due to the difference in amount. This also messes with the balance sheet report. This fix ensures that only boms directly related to the product are selected. opw-2918080 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#98424 Forward-Port-Of: odoo/odoo#97453
Use case to reproduce: - Create a product with manufacture and MTO route - Set the warehouse in 3 steps manufacturing - Confirm a SO for 5 units - Update the quantity to 4 units Current behavior Each picking has a quantity to 4 units. Except for the post production to stock that still for 5 units but a return is created. Expected behavior Each picking has 4 units It happens due to `_run_pull` that will create a new procurement group in post production location (the purpose is to a
Original PR description
Use case to reproduce: - Create a product with manufacture and MTO route - Set the warehouse in 3 steps manufacturing - Confirm a SO for 5 units - Update the quantity to 4 units Current behavior Each…
Use case to reproduce: - Create a product with manufacture and MTO route - Set the warehouse in 3 steps manufacturing - Confirm a SO for 5 units - Update the quantity to 4 units Current behavior Each picking has a quantity to 4 units. Except for the post production to stock that still for 5 units but a return is created. Expected behavior Each picking has 4 units It happens due to `_run_pull` that will create a new procurement group in post production location (the purpose is to avoid a merge between semi-finished product and finished product). But in the case of a negative procurement, we want to decrease a picking and not create a production order. So create a new procurement group with the next MO sequence will aslo create another issue because `_run_manufacture` will skip the MO creation since the quantity is negative and it will be a gap in the sequence number. Instead of creating a new procurement group, search for an existing in sibbling moves, so `_search_picking_for_assignation` could find a picking to merge the negative procurement and decrease an existing move. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100407
Before this commit, the "Oh snap!" dialog could be displayed anytime a server validation error was returned by an RPC. Also, clicking on the "discard" button in this dialog always triggered an `historyBack` even when we open a new action. Now, this dialog is only opened on error while saving and does not `historyBack` anymore. Forward-Port-Of: odoo/odoo#101363
Original PR description
Before this commit, the "Oh snap!" dialog could be displayed anytime a server validation error was returned by an RPC. Also, clicking on the "discard" button in this dialog always triggered an `historyBack` even when we open a new action. Now, this dialog is only opened on error while saving and does not `historyBack` anymore. Forward-Port-Of: odoo/odoo#101363
There are 2 issues solved in this commit 1. Fetch plans is called too many times (Journal items List view). This is not necessary as plans are only required if editing 2. Plans are not fetched again if the product/account changes. This is because the record referenced by props and nextProps is the same, hence a change is not detected. Forward-Port-Of: odoo/odoo#101400
Original PR description
There are 2 issues solved in this commit 1. Fetch plans is called too many times (Journal items List view). This is not necessary as plans are only required if editing 2. Plans are not fetched again if the product/account changes. This is because the record referenced by props and nextProps is the same, hence a change is not detected. Forward-Port-Of: odoo/odoo#101400
**Description of the issue/feature this PR addresses:** Unclear lockdate message **Current behavior before PR:** The current message may make you believe the date on the invoice will be changed when it's the accounting date **Desired behavior after PR is merged:** This aims to clarify that the move.invoice_date will stay the same when it's the move.date that will be changed --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of:
Original PR description
**Description of the issue/feature this PR addresses:** Unclear lockdate message **Current behavior before PR:** The current message may make you believe the date on the invoice will be changed when it's the accounting date **Desired behavior after PR is merged:** This aims to clarify that the move.invoice_date will stay the same when it's the move.date that will be changed --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101705
The calendar view and all its extensions have been converted to owl, so it's time to get rid of the legacy implementation. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101688
Original PR description
The calendar view and all its extensions have been converted to owl, so it's time to get rid of the legacy implementation. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101688
Before this commit, in a grouped kanban view, when the "delete" button of a card is clicked, the card is deleted but a "Load more..." is displayed in the column. Why is this? The group counter is not correctly decremented when the record is deleted How to reproduce : - Go to a grouped kanban view with a delete button on its cards - Click on the delete button Before this commit: The record is deleted and "Load more..." is displayed in the record column. After this commit: The rec
Original PR description
Before this commit, in a grouped kanban view, when the "delete" button of a card is clicked, the card is deleted but a "Load more..." is displayed in the column. Why is this? The group counter is not correctly decremented when the record is deleted How to reproduce : - Go to a grouped kanban view with a delete button on its cards - Click on the delete button Before this commit: The record is deleted and "Load more..." is displayed in the record column. After this commit: The record is deleted. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101697
Before this commit, in a form view, the state selection button was placed on the left. It should be on the right. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101698
Original PR description
Before this commit, in a form view, the state selection button was placed on the left. It should be on the right. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101698
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101704
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101704
Owlification of the mailing filter widget task-2984157 Forward-Port-Of: odoo/odoo#100181
Original PR description
Owlification of the mailing filter widget task-2984157 Forward-Port-Of: odoo/odoo#100181
Before this commit, open an act window action asking for a tree view would cause a crash. We fix that. Forward-Port-Of: odoo/odoo#101717
Original PR description
Before this commit, open an act window action asking for a tree view would cause a crash. We fix that. Forward-Port-Of: odoo/odoo#101717
Forward-Port-Of: odoo/odoo#101724
Original PR description
Forward-Port-Of: odoo/odoo#101724
Forward-Port-Of: odoo/odoo#101753
Original PR description
Forward-Port-Of: odoo/odoo#101753
This is an oversight in odoo/odoo#100130 A modifier set with `context.get('...')`, for instance `invisible="context.get('sign_directly_without_mail',False)"` takes priority on attrs only if the result of `context.get('...')` isn't falsy e.g. https://github.com/odoo/enterprise/blob/1a4e4fafe4fc78dab0aad7ab6241a6f4a7be317a/sign/wizard/sign_send_request_views.xml#L64 should return - `modifiers="{'invisible': [['is_user_signer', '=', false]]}"` with `context.get('sign_directly_without_
Original PR description
This is an oversight in odoo/odoo#100130
A modifier set with `context.get('...')`,
for instance
`invisible="context.get('sign_directly_without_mail',False)"` takes priority on attrs
only if the result of `context.get('...')` isn't falsy
e.g.
https://github.com/odoo/enterprise/blob/1a4e4fafe4fc78dab0aad7ab6241a6f4a7be317a/sign/wizard/sign_send_request_views.xml#L64
should return
- `modifiers="{'invisible': [['is_user_signer', '=', false]]}"` with `context.get('sign_directly_without_mail') == False`
- `modifiers="{'invisible': true}"` with `context.get('sign_directly_without_mail') == True`
Forward-Port-Of: odoo/odoo#101615…ialog The current implementation of the selector is biased to only work properly if you have installed `documents_spreadsheet`. This commit fixes the issue by relying on component `Notebook` which is meant to handle these configurations and allows to remove some custom code. task 3002232 Forward-Port-Of: odoo/enterprise#32073
Original PR description
…ialog The current implementation of the selector is biased to only work properly if you have installed `documents_spreadsheet`. This commit fixes the issue by relying on component `Notebook` which is meant to handle these configurations and allows to remove some custom code. task 3002232 Forward-Port-Of: odoo/enterprise#32073
This commit replaces a usecase of the legacy FormViewDialog by the wowl FormViewDialog, as we are about to remove the legacy one. Forward-Port-Of: odoo/enterprise#32080
Original PR description
This commit replaces a usecase of the legacy FormViewDialog by the wowl FormViewDialog, as we are about to remove the legacy one. Forward-Port-Of: odoo/enterprise#32080
The refresh icon in the setting near the next execution date field is placed at the next row while it should be placed just next to the field. This is caused by it taking 100% of the width, so setting the width to auto will fix the issue. Forward-Port-Of: odoo/enterprise#32063
Original PR description
The refresh icon in the setting near the next execution date field is placed at the next row while it should be placed just next to the field. This is caused by it taking 100% of the width, so setting the width to auto will fix the issue. Forward-Port-Of: odoo/enterprise#32063
The calendar view and all its extensions have been converted to owl, so it's time to get rid of the legacy implementation. Forward-Port-Of: odoo/enterprise#32061
Original PR description
The calendar view and all its extensions have been converted to owl, so it's time to get rid of the legacy implementation. Forward-Port-Of: odoo/enterprise#32061
- When a subscription's payment fails during the automatic renewal process, the subscription might be closed if the limit date is exceeded. The code was trying to do so by writing the value `'close'` on the `state` field, which is invalid. Instead we should call the `set_close` function to properly close it. Forward-Port-Of: odoo/enterprise#31572 Forward-Port-Of: odoo/enterprise#31523
Original PR description
- When a subscription's payment fails during the automatic renewal process, the subscription might be closed if the limit date is exceeded.
The code was trying to do so by writing the value `'close'` on the `state` field, which is invalid. Instead we should call the `set_close` function to properly close it.
Forward-Port-Of: odoo/enterprise#31572
Forward-Port-Of: odoo/enterprise#31523## Knowledge Behaviors (OWL) & Embedded Views This PR introduces a new system to integrate owl components inside the Knowledge editor. This system replaces the old html_injector widget and reimplements all previously introduced commands (`/template`, `/file`, `/toc`, `/article`, `/outline`, `/index`). This PR also introduces a new feature allowing the user to integrate embedded views inside a Knowledge article. With that feature, the user can easily integrate reports, graphs, pipeline
Original PR description
## Knowledge Behaviors (OWL) & Embedded Views This PR introduces a new system to integrate owl components inside the Knowledge editor. This system replaces the old html_injector widget and reimplements all previously introduced commands (`/template`, `/file`, `/toc`, `/article`, `/outline`, `/index`). This PR also introduces a new feature allowing the user to integrate embedded views inside a Knowledge article. With that feature, the user can easily integrate reports, graphs, pipelines, maps, etc in their articles. Finally, this PR introduces two new commands: - `/kanban`: inserts a kanban view listing the hidden articles of the current article. - `/list` inserts a list view listing the hidden articles of the current article. task-2796156 Co-authored-by: Julien Banken <jbn@odoo.com> Co-authored-by: Damien Abeloos <abd@odoo.com> Forward-Port-Of: odoo/enterprise#29423