Sunday, October 2, 2022
11 changes · master
Miscellaneous changes
Tests adaptations will come in a following PR, but the current focus is set on owl conversion. task-2936932 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101370
Original PR description
Tests adaptations will come in a following PR, but the current focus is set on owl conversion. task-2936932 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101370
PURPOSE With this commit you can now see how the mailing you're creating will look like on a mobile. LINKS Task-2818037 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#90580
Original PR description
PURPOSE With this commit you can now see how the mailing you're creating will look like on a mobile. LINKS Task-2818037 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#90580
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101605
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101605
Some overrides of search might allow to sort on non sortable fields like my_activity_date_deadline on crm_lead. An option allow_order was used to indicate that to the legacy list view. The new list view introduced with https://github.com/odoo/odoo/commit/bc0a0cead62edd1e0b299fb9a90cd21792814618 no longer consider that option and consequently the Pipeline list view of crm can now longer be sorted by my_activity_date_deadline. The same happens in some other views. In this commit, we reintroduce
Original PR description
Some overrides of search might allow to sort on non sortable fields like my_activity_date_deadline on crm_lead. An option allow_order was used to indicate that to the legacy list view. The new list view introduced with https://github.com/odoo/odoo/commit/bc0a0cead62edd1e0b299fb9a90cd21792814618 no longer consider that option and consequently the Pipeline list view of crm can now longer be sorted by my_activity_date_deadline. The same happens in some other views. In this commit, we reintroduce the use of that option in the list view and fix that problem. Forward-Port-Of: odoo/odoo#101770
:warning: This PR was done in 16.0 but once merged, it will be backported to 14.0 (with the needed adaptations for the stable policy if something is not stable friendly) :warning: ----------------------------- Before this commit, the only possibility when adding a google font was to use google servers to serve the font. This was not ideal as some people really want to serve it themselves without the need of their visitors to reach google servers. That's especially true since recentl
Original PR description
:warning: This PR was done in 16.0 but once merged, it will be backported to 14.0 (with the needed adaptations for the stable policy if something is not stable friendly) :warning:…
:warning: This PR was done in 16.0 but once merged, it will be backported to 14.0 (with the needed adaptations for the stable policy if something is not stable friendly) :warning: ----------------------------- Before this commit, the only possibility when adding a google font was to use google servers to serve the font. This was not ideal as some people really want to serve it themselves without the need of their visitors to reach google servers. That's especially true since recently where it seems like German clients are receiving letter about that to tell them it's illegal and this should be changed, as it would't respect the GDPR. Somehow, it seems related to the fact that google know you visited a website by just downloading the font, because they very well know with just your IP who you are exactly. It's yet unsure if that issue is founded or not, but since German courts seems to be sanctioning people about this, there is no reason to not at least provide a workaround. What is sure is that it makes a lot of noise and more and more people seems to be impacted by this as many opw are getting opened, as well as github messages. Whether it is founded or not is thus not really our problem anymore, we should just provide a way for our people to protect themselves against this "German law problem" (or at least think they are protecting, if Odoo thinks that's a non issue or the German court is wrong or ambiguous). Note that a cookies banner to inform user would not be enough for that "problem", as the user would already have accessed your website and thus the related problematic fonts. Another solution which is not something we want (at all) would be to serve local system fonts while the user did not consent about google fonts, or having a blocking screen page telling people visiting the website will fetch google fonts. Obviously those 2 possibilities are a no go as it leads to terrible UX. Finally, note that: - in Odoo 16, the default fonts will be the system fonts, meaning there won't be any call to google by default, regardless of this pr - there is a work in progress to improve the current cookies bar to differentiate essential and non essential cookies and to allow user to accept only one or both (task-2800976). Useful links: - https://github.com/odoo/odoo/issues/83638#issuecomment-1054470699 ODO detailed point of view about this - https://rewis.io/urteile/urteil/lhm-20-01-2022-3-o-1749320/ The German law about this Closes #83638 task-2756486 opw-2970167 opw-2960466 opw-2960555 opw-2952427 opw-2800976 opw-2748647 (possibly many more) Forward-Port-Of: odoo/odoo#101129
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101738
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101738
The changes introduced by [commit 1] broke the `getSelectedVariantValues` method when using the optional products modal with a preconfigured variant. When the variant is preconfigured, the variant selection form is not rendered. As a consequence the `VariantMixin` fails to retrieve the combination used when calling `getSelectedVariantValues`. In v14 this problem was solved by including an element in the DOM containing the attribute value ids in one of its data attributes. Restoring this eleme
Original PR description
The changes introduced by [commit 1] broke the `getSelectedVariantValues` method when using the optional products modal with a preconfigured variant. When the variant is preconfigured, the variant selection form is not rendered. As a consequence the `VariantMixin` fails to retrieve the combination used when calling `getSelectedVariantValues`. In v14 this problem was solved by including an element in the DOM containing the attribute value ids in one of its data attributes. Restoring this element and the associated logic for retrieving it solves the problem. [commit 1]: https://github.com/odoo/odoo/commit/2b832269f474d9b08c7c6cd827e5f78ebcfafeca opw-2722176 Forward-Port-Of: odoo/odoo#101360 Forward-Port-Of: odoo/odoo#90160
The quantities on l10n_it_edi can be positive or negative. Since the government disallows negative quanities, the xml template specifies the quantity as absolute. The unit price is calculated, and will be calculated correctly regardless of whether the quantity is positive or negative. This this constraint can be removed as it is no longer required. Forward-Port-Of: odoo/odoo#101303
Original PR description
The quantities on l10n_it_edi can be positive or negative. Since the government disallows negative quanities, the xml template specifies the quantity as absolute. The unit price is calculated, and will be calculated correctly regardless of whether the quantity is positive or negative. This this constraint can be removed as it is no longer required. Forward-Port-Of: odoo/odoo#101303
Invoices were being paid via a payment token before the taxes were computed. The already existing `_create_recurring_invoice` override won't cover subscriptions that are auto-charged via a token. For those `_create_recurring_invoice` will call `_handle_automatic_invoices` which calls `_do_payment`. opw-2990784 Forward-Port-Of: odoo/enterprise#31835 Forward-Port-Of: odoo/enterprise#31607
Original PR description
Invoices were being paid via a payment token before the taxes were computed. The already existing `_create_recurring_invoice` override won't cover subscriptions that are auto-charged via a token. For those `_create_recurring_invoice` will call `_handle_automatic_invoices` which calls `_do_payment`. opw-2990784 Forward-Port-Of: odoo/enterprise#31835 Forward-Port-Of: odoo/enterprise#31607
Currently, the form view for automatic transfers is bugged, and the accounts/transfers tree views overlap each other. This commit is a small fix to better render this view. Part of the big task fixing bugs in accounting Task id=2996493 Forward-Port-Of: odoo/enterprise#32071
Original PR description
Currently, the form view for automatic transfers is bugged, and the accounts/transfers tree views overlap each other. This commit is a small fix to better render this view. Part of the big task fixing bugs in accounting Task id=2996493 Forward-Port-Of: odoo/enterprise#32071
task-2936932 Forward-Port-Of: odoo/enterprise#31903
Original PR description
task-2936932 Forward-Port-Of: odoo/enterprise#31903