Odoo Changelog — 2022-10-04

Tuesday, October 4, 2022

77 changes · master

Improvements(2)

Enhancements to existing features

[IMP] mail: move code from components to models (ComposerTextInput)

Coremastermail

The mail message composer was reorganized to move some behind-the-scenes logic into shared models. This should make the composer easier to maintain and evolve without changing how users write messages today.

Original PR description

+ Create ComposerTextInputView model
+ Replace uses of useRef with useRefToModel
+ Replace use of useUpdate with useUpdateToModel
+ Remove dead code (ComposerTextInput._isEmpty)

Task-3001200.

#mail#composer#maintainability

[IMP] l10n_be_hr_payroll: migrate binary_commission field to owl

PR #30970

Enterprisemasterl10n_be_hr_payroll

The Belgian payroll commission import field has been updated to use Odoo’s newer interface technology. This keeps the feature aligned with the current platform and helps maintain a smoother, more reliable user experience without changing the business workflow.

Original PR description

This commit migrates the `binary_commission` field to owl.

#payroll#belgium#commission#user interface

Bug Fixes(5)

Resolved issues and error corrections

[FIX] website_sale_renting: Traceback on product catalog click

PR #101719

Coremasterwebsite_sale

Fixed an issue that could cause an error when shoppers clicked a product in the website sales catalog with renting enabled. This helps keep the online shopping experience smooth and prevents interruptions during product browsing.

Original PR description

task_id: 3000852

#website#sales#renting#catalog

[FIX] website_sale{_renting,}: datepicker option position

PR #101900

Other(70)

Miscellaneous changes

[FW][I18N] *: translate fr_BE based on fr

PR #102002

Coremasteraccountaccount_debit_noteaccount_edi_ubl_ciigamification_sale_crmbase

Automatically translate "avoir" into "note de crédit" Forward-Port-Of: odoo/odoo#101968 Forward-Port-Of: odoo/odoo#101856

Original PR description

Automatically translate "avoir" into "note de crédit"

Forward-Port-Of: odoo/odoo#101968
Forward-Port-Of: odoo/odoo#101856

[FW][FIX] hr_holidays: remove default working hours on stress days

**Bug**: Users are able to modify their eCommerce cart after it has been paid when they fail to return to Odoo through the payment provider's return route. This prevents the cart from being confirmed. **Steps to reproduce**: 1. Install the payment provider Mollie and set it to test mode. 2. Go to the /shop page, add a product to the cart, and select Mollie for the payment. 3. On Mollie's hosted payment page, use the card number 4111111111111111 with the expiry date 03/30 and the secret code 123. Select 'paid' as the payment outcome. 4. Confirm the payment but take care not to be redirected to the /payment/status route. For examples, close the tab before or comment out https://github.com/odoo/odoo/blob/15.0/addons/payment_mollie/controllers/main.py#L38. 5. Go back to /shop/cart and modify the cart. 6. Wait up to 20 minutes for the "payment: post-process transactions" cron to try to confirm the cart. 7. Check the cart's chatter: the confirmation failed because the cart's and transaction's amounts mismatch. **Explanation**: The post-processing of the transaction is responsible for confirming the cart, but it failed to be triggered because the user did not visit the /payment/status page. The post-processing cron takes care of pending post-processings after 10 to 20 minutes, which is long enough for the user to modify their cart. **Fix**: Force creating a new cart as soon as the current one is paid and is being requested by the website. task-2995504 Forward-Port-Of: odoo/odoo#101956 Forward-Port-Of: odoo/odoo#101169

It seems that there is a rather frequent warning that can be added to mail received by outlook 365 and that has the form: ``` <table border="0" cellspacing="0" cellpadding="0" align="left" width="100%" style="width:100.0%"> ...Caution: This is an external email and has a suspicious subject or content... </table> ``` The combination of `align="left" width="100%"` means that a div after this alert will probably have a width of 0 (because the previous content is floating to the left, and taking 100% of width so there is 0 pixel of width remaining). This is not an issue in general, but in Odoo this conflicts with a code that adds scrollbar if a message content overflows (but here since width is 0 pixel the content is just hidden). With this commit, if we detect the code that is used in all our received report (width=100% and float=left), we ignore the float to prevent this issue from happening. An alternative is to avoid Outlook 365 adding this structure in a message (see [1]), but this is only possible if we can change the configuration where this structure is added (eg. we can't if it is a customer that is forwarding a mail already broken). [1]: https://learn.microsoft.com/en-us/microsoft-365/security/office-365-security/set-up-anti-phishing-policies?view=o365-worldwide#first-contact-safety-tip opw-2887342 opw-2946587 Forward-Port-Of: odoo/odoo#101295

[FIX] base: no back-end view caching in --dev xml mode In `--dev xml` mode, you would like the views to be loaded from their definition in the XML file directly. The view caching introduced in https://github.com/odoo/odoo/pull/99417 prevents that feature, as once the view has been loaded a first time, the views are returned directly from the cache, therefore not taking into account changes directly done in the XML file views. Setting a conditional decorator, disabling the caching when in `--dev xml` mode, solves this issue. Solves https://github.com/odoo/odoo/pull/99417#issuecomment-1241977197 [IMP] base: move view related methods out of odoo/models.py By definition, views are useless without the web client. The web client is in the module `web`. Therefore, in a perfect world, the `get_views` model method and any related method should be within the `web` module, as without it they are useless. Let's imagine you would like to use fully in command-line, without web client, all those view related methods are useless. Maybe excepted for reports, as you might still like to be able to print reports while using odoo fully in command line. Views related method therefore shouldn't be in `odoo/models.py`. Also, when you think about it, `get_views` related methods do not make sense without the model `ir.ui.view`, which is loaded after the `get_views` related methods, which also doesn't make sense. However, moving these methods fully in the `web` module is an harder work. For instance, there are base models, such as res.partner, already overriding `get_view` in the `base` module, and therefore relying on these view related methods. As a first step, we move view related methods direcly in the `odoo/addons/base/models/ir_ui_view.py` file, where the `ir.ui.view` model is loaded. This is not only a design / cleaning change, but a required change to be able to use content of `odoo.tools.config`, which is loaded after `odoo/models.py`. For instance, if you want to configure a conditional decorator based on the config `odoo.tools.config['dev_mode']`, it is not possible to do so in `odoo/models.py` because the config is parsed/loaded after `odoo/models.py`. The config is loaded here: https://github.com/odoo/odoo/blob/31de2b0a7a0921cab3c6c54045d15da46c8e6d8a/odoo/cli/server.py#L127 While, within the same file, `odoo/models.py` gets loaded through the `import odoo` https://github.com/odoo/odoo/blob/31de2b0a7a0921cab3c6c54045d15da46c8e6d8a/odoo/cli/server.py#L26 And we would like to put such a decorator based on `odoo.tools.config['dev_mode']` on `_get_view_cache`, to not cache the back-end views when `--dev xml` is passed in the server arguments. Forward-Port-Of: odoo/odoo#101200

The new formView is now editable with studio. How it basically works: - each node of interest in the arch is assigned an xpath relative to the arch at compile time. - most of the studio logic relies on that studioXpath (clicking, drag/drop) - each component uses that xpath to identify itself, be draggable if applicable, and be modified if applicable. - every node of the arch is present in the compiled template, though they won't necessarily end up in the DOM (they have a t-if that reflect their invisible modifier state). - the config in the env of the formEditor holds methods and variables that allow for interacting with the viewEditorManager and for editing the view. What has changed: - hopefully minimal functional changes, except the persistence of the current active node in edition specifically, if the current node is not findable anymore (e.g. because it has become invisible), the sidebar is reset to the initial state, and so is the editor itself: they won't try to guess which element should be in edition next. - technically a lot of things: the editor must satisfy the view.js interface drag and drop is handled natively via a in-house feature, though support for JQueryUI is still present for legacy compatibility reasons. - The compiler passes metadata and it is the responsibility of each form component to handle those. - The new form grid layout is supported, though draggable field (the ones with automatic labels) are handled differently the label is now the one unit that handles click, display of the style and the drag/drop. The two elements (label and field) are now outlined separately, though at the same time, letting two outlines appear. This may be resolve when the "subgrid" feature of CSS is supported across browsers. Co-authored-by: Bruno Boi <boi@odoo.com> Co-authored-by: Samuel Degueldre <sad@odoo.com> Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com> Co-authored-by: Julien Mougenot <jum@odoo.com> Co-authored-by: Jorge Pinna Puissant <jpp@odoo.com> Forward-Port-Of: odoo/enterprise#32186

Improvements(2)

[IMP] mail: move code from components to models (ComposerTextInput)

[IMP] l10n_be_hr_payroll: migrate binary_commission field to owl

Bug Fixes(5)

[FIX] website_sale_renting: Traceback on product catalog click

[FIX] website_sale{_renting,}: datepicker option position

Other(70)

[FW][I18N] *: translate fr_BE based on fr

[FW][FIX] hr_holidays: remove default working hours on stress days

Improvements(2)

[IMP] mail: move code from components to models (ComposerTextInput)

[IMP] l10n_be_hr_payroll: migrate binary_commission field to owl

Bug Fixes(5)

[FIX] website_sale_renting: Traceback on product catalog click

[FIX] website_sale{_renting,}: datepicker option position

Other(70)

[FW][I18N] *: translate fr_BE based on fr

[FW][FIX] hr_holidays: remove default working hours on stress days

[FIX] test_sale_product_configurator: remove edit

[FIX] website_sale_renting: traceback on product catalog click

[FIX] website_sale{_renting,}: datepicker option position

[FW][FIX] spreadsheet_dashboard: update dashboards

[FW][FIX] hr_holidays: Fixed to remove supporting documents after uploaded.

[FW][IMP] mail: improve mail template usability

[FW][FIX] l10n_it_edi: fix it vat change

[FW][IMP] account_edi, l10n_*: Make the EDI engine more flexible

[FW][FIX] sale: fix test_pricelist_dates

[FW][FIX] website_sale: fix traceback on login page

[FW][FIX] sale: use str2bool to make sure the boolean sale.automatic_invo…

[FW][FIX] web: Dialog Form buttons' spacing

[FW][FIX] l10n_in_edi: correct reference of tag_ids

[FW][IMP] mail: reintroduce mail_template_ids in activity (new)

[FW][FIX] stock: immediate transfer message alignment

[FW][FIX] sale_stock: prevent displaying vendor's info in DO

[FW][FIX] mass_mailing: fix kanban card joined contents

[FW][IMP] account : cash discount: set up default accounts and configs

[FW][FIX] (website_)hr_recruitment: unpublished job on archive

[FW][FIX] sale: multicompany fpos access

[FW][FIX] account: account move report date label

[FW][FIX] tools: fix underline and italic in logged notes

[FW][FIX] website_sale: prevent users from modifying paid carts

[FW][FIX] loyalty: make it possible to import coupons etc

[FW][FIX] resource: show planning resource in its timezone

[FW][REF] stock: counted qty, forecast, json stock widgets to owl

[FW][FIX] web: fix file upload service event listeners

[FW][FIX] website_sale: reorder quantity width

[FW][FIX] payment_alipay: format Alipay API parameter total_fee correctly

[FW][FIX] hr_contract: allow archiving employee

[FW][FIX] mail: outlook 365 warning not hiding mail

[FW][FIX] base: no back-end view caching in --dev xml mode

[FW][IMP] spreadsheet: Lazy load xml templates

[FW][REV] web: kanban: bottom quickCreate button

[FW] Revert "[FIX] web: restore open notebook page"

[FW][IMP] web: toggling an optional field in list view do not unselect row

[FW][FIX] web: quick create inputs don't take all space

[FW][FIX] web: click on m2o in editable/multiEdit list

[FW][REF] barcodes: barcode_handler and field_float_scannable to wowl

[FW] 16.0 studio lpe

[FW] Various fixes for DomainSelector

[FW][FIX] web: create a record with the widget "many2many"

[FW][FIX] spreadsheet_dashboard: set the first sheet as active sheet

[FW][FIX] web: FormViewDialog: handle `close` attr on buttons

[FW][FIX] web: list: allow accurate text selection

[FW][FIX] im_livechat: move checkbox "only if no operator"

[FW][FIX] mail: fix and clean display of chatter in new form views

[FW][FIX] mail_enterprise, account_invoice_extract: adapt code to change

[FW] 16.0 remove last view dialogs aab

[FW][MERGE] web_studio: editor for the new WOWL FormView

[FW][FIX] sale_ebay: default ebay quantity value for product:

[FW][FIX] account_sepa_direct_debit: mandat form buttons

[FW][IMP] documents: code cleanup

[FW][FIX] project_forecast: adapt test for timezone

[FW][IMP] loyalty: allow import/export

[FW][IMP] sign_itsme: use correct iap api endpoint

[FW][FIX] web_studio: fix undeterministic crash caused by BS5 transitions

[FW][FIX] data_merge_model: see notification message from find_duplicates

[FW][FIX] account_accounting: lock date labels are misplaced

[FW][IMP] sign: modify button layout

[FW][FIX] l10n_cl_edi: fix check for boletas exentas

[FW] Saas 15.3 subscription discount arj