Sunday, October 9, 2022
21 changes · master
Miscellaneous changes
task-2804999 See also: - https://github.com/odoo/documentation/pull/2782 Forward-Port-Of: odoo/odoo#101756
Original PR description
task-2804999 See also: - https://github.com/odoo/documentation/pull/2782 Forward-Port-Of: odoo/odoo#101756
**Before**  **After**  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102629
Original PR description
**Before**  **After**  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102629
The quotation template got a button to design it, which lands on their website/frontend preview. The goal is to then be able to enter edit mode and customize it. But since we merged frontend > backend with [1], it was not possible anymore (unless you manually know and tweak the URL to add `/@/`. [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b Forward-Port-Of: odoo/odoo#99926
Original PR description
The quotation template got a button to design it, which lands on their website/frontend preview. The goal is to then be able to enter edit mode and customize it. But since we merged frontend > backend with [1], it was not possible anymore (unless you manually know and tweak the URL to add `/@/`. [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b Forward-Port-Of: odoo/odoo#99926
The fiscal country field could be used to create a new res country or open the form view and allow to change things such as the country code. This is obviously an issue and shouldn't be allowed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102113
Original PR description
The fiscal country field could be used to create a new res country or open the form view and allow to change things such as the country code. This is obviously an issue and shouldn't be allowed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102113
Replace some layout magic with some layout determinism; in particular, the view attempted to have a 4 column layout which is not well supported in grid form views. This commit instead create a "normal" structure (outer group > inner group) for "boolean" group access (e.g. 'Extra Rights' or 'Technical' sections of the user form access groups, whilst in debug mode). Forward-Port-Of: odoo/odoo#102649
Original PR description
Replace some layout magic with some layout determinism; in particular, the view attempted to have a 4 column layout which is not well supported in grid form views. This commit instead create a "normal" structure (outer group > inner group) for "boolean" group access (e.g. 'Extra Rights' or 'Technical' sections of the user form access groups, whilst in debug mode). Forward-Port-Of: odoo/odoo#102649
Preparation for https://github.com/odoo/odoo/pull/98429 for 16.1 Forward-Port-Of: odoo/odoo#102779
Original PR description
Preparation for https://github.com/odoo/odoo/pull/98429 for 16.1 Forward-Port-Of: odoo/odoo#102779
This commit includes several changes in the Plausible dashboard: - Remove the "Analytics" title. - Add margins (container-fluid => container). This also fixes the country map overflow and the flickering. - Remove the duplicated scrollbars. - Use the background colors from within the iframe. - Hide the date range buttons by default, but show them if `website_sale` is installed. It also reorders the Reporting menu as follows: - Analytics - eCommerce - Online Sales - Visitors - Page
Original PR description
This commit includes several changes in the Plausible dashboard: - Remove the "Analytics" title. - Add margins (container-fluid => container). This also fixes the country map overflow and the flickering. - Remove the duplicated scrollbars. - Use the background colors from within the iframe. - Hide the date range buttons by default, but show them if `website_sale` is installed. It also reorders the Reporting menu as follows: - Analytics - eCommerce - Online Sales - Visitors - Page Views task-2993773 Forward-Port-Of: odoo/odoo#102286
Two fixes: - The resequence form view design as it was broken by recent CSS changes - Add constrains on account.account to disallow setting a receivable or payable account on a bank journal bank account. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102014
Original PR description
Two fixes: - The resequence form view design as it was broken by recent CSS changes - Add constrains on account.account to disallow setting a receivable or payable account on a bank journal bank account. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102014
Only kanban, tree and form implements onchanges. Therefore, on calendar, graph, pivot, ..., putting `on_change="1"` is useless and is a waste of resources and KB. e.g. CRM lead pivot view Before: ```xml <pivot string="Pipeline Analysis" sample="1"> <field name="create_date" interval="month" type="row"/> <field name="stage_id" type="col" on_change="1"/> <field name="expected_revenue" type="measure"/> <field name="color" modifiers="{"invisible": true}"/>
Original PR description
Only kanban, tree and form implements onchanges. Therefore, on calendar, graph, pivot, ..., putting `on_change="1"` is useless and is a waste of resources and KB. e.g. CRM lead pivot view Before:…
Only kanban, tree and form implements onchanges.
Therefore, on calendar, graph, pivot, ..., putting `on_change="1"` is useless and is a waste of resources and KB.
e.g. CRM lead pivot view
Before:
```xml
<pivot string="Pipeline Analysis" sample="1">
<field name="create_date" interval="month" type="row"/>
<field name="stage_id" type="col" on_change="1"/>
<field name="expected_revenue" type="measure"/>
<field name="color" modifiers="{"invisible": true}"/>
<field name="automated_probability" modifiers="{"invisible": true}"/>
<field name="message_bounce" modifiers="{"invisible": true}"/>
<field name="probability" on_change="1" modifiers="{"invisible": true}"/>
</pivot>
```
After:
```xml
<pivot string="Pipeline Analysis" sample="1">
<field name="create_date" interval="month" type="row"/>
<field name="stage_id" type="col"/>
<field name="expected_revenue" type="measure"/>
<field name="color" modifiers="{"invisible": true}"/>
<field name="automated_probability" modifiers="{"invisible": true}"/>
<field name="message_bounce" modifiers="{"invisible": true}"/>
<field name="probability" modifiers="{"invisible": true}"/>
</pivot>
```
I would have like something smarter, like using the `editable` concept for instance, but it's not that easy.
e.g. kanban is not considered as editable, while it does support onchanges when grouping record by a field and drag and dropping record from one column to another.
However, if we change the kanban view to make it editable, the view validation will start validating the fields domain: https://github.com/odoo/odoo/blob/45d4ac14f65c53dcde56592715d50169bde116ad/odoo/addons/base/models/ir_ui_view.py#L1439-L1442 causing issues:
- If a field used in the domain is not in the view, it will need to be added in the view,
- while it will not be used, as you cannot do a search in related fields in kanban views anyway. e.g.
```
odoo.tools.convert.ParseError: while parsing /data/build/odoo/addons/analytic/views/analytic_line_views.xml:120
Error while validating view near:
<kanban class="o_kanban_mobile" __validate__="1">
<field name="date"/>
<field name="name"/>
Field 'company_id' used in domain of field 'account_id' ([('company_id', 'in', [company_id, False])]) must be present in view but is missing.
```
In addition, the kanban doesn't need the readonly and required attributes on the field nodes, as other editable views (tree and forms) do.
In addition, the tree list is currently considered as "editable" only when it has `editable="bottom" or `editable="top"`, while a tree without this editable attribute can still trigger onchange, for instance when using `widget="handle"` or `widget="boolean_toggle"`. We should therefore making the tree list editable whatever the case, leading to the same issues than listed for the kanban above, or make an exception for field in non-editable tree views using a widget..
So, as the smarter way seems difficult and risky, for a limited gain I choose the easy way by separating the concept "editable" and "onchange-able" and to not set `on_change="1"` on views not considered as "onchange-able".
Forward-Port-Of: odoo/odoo#102572--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102379
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102379
For the "+New" button, a `get_modules_info` route was added because the information cannot be built-in the page by a server-side QWeb template anymore. This commit removes this route and replaces it by a call to the default `search_read`. task-2687506 Forward-Port-Of: odoo/odoo#101465
Original PR description
For the "+New" button, a `get_modules_info` route was added because the information cannot be built-in the page by a server-side QWeb template anymore. This commit removes this route and replaces it by a call to the default `search_read`. task-2687506 Forward-Port-Of: odoo/odoo#101465
This commit allows to regenerate the connectors of the step block when one of the columns of the block is duplicated or deleted. Steps to reproduce: - Drop a steps block - Duplicate one of the columns => The last column of the first row has a connector to the right of the page. task-2687506 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102366
Original PR description
This commit allows to regenerate the connectors of the step block when one of the columns of the block is duplicated or deleted. Steps to reproduce: - Drop a steps block - Duplicate one of the columns => The last column of the first row has a connector to the right of the page. task-2687506 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102366
Before this commit the neutralize system introduced in v16 was using ORM methods in order to change appropriate records. Although flexible, this approach could lead to call some methods with side effects while neutralizing (eg: overloads of write). This patch converts the neutralize system to a safer "inert" SQL based approach by migrating the generic method _neutralize to SQL files exposed in the modules manifests as the neutralize key. Task id: 2961687 Community PR: https://github.com
Original PR description
Before this commit the neutralize system introduced in v16 was using ORM methods in order to change appropriate records. Although flexible, this approach could lead to call some methods with side effects while neutralizing (eg: overloads of write). This patch converts the neutralize system to a safer "inert" SQL based approach by migrating the generic method _neutralize to SQL files exposed in the modules manifests as the neutralize key. Task id: 2961687 Community PR: https://github.com/odoo/odoo/pull/101529 Forward-Port-Of: odoo/enterprise#31984
Badges for rental status were different from wizard to report. This commit standardizes all badge renderings for rental. Some layout designs are also improved. task-3007659 Forward-Port-Of: odoo/enterprise#32395
Original PR description
Badges for rental status were different from wizard to report. This commit standardizes all badge renderings for rental. Some layout designs are also improved. task-3007659 Forward-Port-Of: odoo/enterprise#32395
Fix the reconciliation report in two ways: - Fix the export buttons so that they export other things than tracebacks. The xlsx export isn't completely working, as it involves changes in the report headers that are being done in a separate PR. - Remove the link from the Consolidated Accounting column when printing the pdf Also fix the consolidation chart form view by putting the invert sign field on the right of the currency_id, and fix the company_ids and
Original PR description
Fix the reconciliation report in two ways:
- Fix the export buttons so that they export other things than
tracebacks. The xlsx export isn't completely working, as it
involves changes in the report headers that are being done in a
separate PR.
- Remove the link from the Consolidated Accounting column when
printing the pdf
Also fix the consolidation chart form view by putting the invert sign field on the right of the currency_id, and fix the company_ids and children_ids tables to take the whole width
Forward-Port-Of: odoo/enterprise#32225This commit hides the date range buttons on the odoo-side. See https://github.com/odoo/odoo/pull/102286. task-2993773 Forward-Port-Of: odoo/enterprise#32464
Original PR description
This commit hides the date range buttons on the odoo-side. See https://github.com/odoo/odoo/pull/102286. task-2993773 Forward-Port-Of: odoo/enterprise#32464
In the subscription plan form view the recurring_rule_count field and the recurring_rule_type field should be in the same line, however they are taking one line each. This commit fixes this. task-3010032 Forward-Port-Of: odoo/enterprise#32514
Original PR description
In the subscription plan form view the recurring_rule_count field and the recurring_rule_type field should be in the same line, however they are taking one line each. This commit fixes this. task-3010032 Forward-Port-Of: odoo/enterprise#32514
Fix a few issues with analytics in accounting reports. - The report would not open when analytic items without move_line_id were used into it - The audit of an analytic column value would just open the move line list view of the balance column. It will now open the list of analytics lines impacting the amount Also add a filter allowing to filter in or out the analytic items without any accounting correspondence. Forward-Port-Of: odoo/enterprise#32351
Original PR description
Fix a few issues with analytics in accounting reports. - The report would not open when analytic items without move_line_id were used into it - The audit of an analytic column value would just open the move line list view of the balance column. It will now open the list of analytics lines impacting the amount Also add a filter allowing to filter in or out the analytic items without any accounting correspondence. Forward-Port-Of: odoo/enterprise#32351
A condition wasn't properly migrated to the next account types, making it so that every first move lines with a partner was blue instead of just being blue if the account isn't receivable/payable. Forward-Port-Of: odoo/enterprise#32426
Original PR description
A condition wasn't properly migrated to the next account types, making it so that every first move lines with a partner was blue instead of just being blue if the account isn't receivable/payable. Forward-Port-Of: odoo/enterprise#32426
A few reports with redirections to the journal items list are broken since reportalypse. The issue is that some override disappeared in the process, so we put it back in a different way as we can't just override the method anymore. Forward-Port-Of: odoo/enterprise#31894
Original PR description
A few reports with redirections to the journal items list are broken since reportalypse. The issue is that some override disappeared in the process, so we put it back in a different way as we can't just override the method anymore. Forward-Port-Of: odoo/enterprise#31894
Before this commit the neutralize system introduced in v16 was using ORM methods in order to change appropriate records. Although flexible, this approach could lead to call some methods with side effects while neutralizing (eg: overloads of write). This patch converts the neutralize system to a safer "inert" SQL based approach by migrating the generic method _neutralize to SQL files exposed in the modules manifests as the neutralize key. Task id: 2961687 Enterprise PR: https://github.co
Original PR description
Before this commit the neutralize system introduced in v16 was using ORM methods in order to change appropriate records. Although flexible, this approach could lead to call some methods with side effects while neutralizing (eg: overloads of write). This patch converts the neutralize system to a safer "inert" SQL based approach by migrating the generic method _neutralize to SQL files exposed in the modules manifests as the neutralize key. Task id: 2961687 Enterprise PR: https://github.com/odoo/enterprise/pull/31984 Forward-Port-Of: odoo/odoo#101529