Odoo Changelog — 2022-11-04

Friday, November 4, 2022

48 changes · master

Improvements(2)

Enhancements to existing features

[IMP] crm: hide phone and company in lead tree view.

Coremastercrm

The CRM leads and opportunities list is now less cluttered by hiding phone and company columns by default. Users can still show these fields when needed, but the everyday view is easier to scan and work with.

Original PR description

At the moment, the tree view is quite dense. In order to ease its use, make company and phone fields optional and hidden by default. This is done for crm.leads as both leads and opportunities.

Task-3053159

#crm#leads#opportunities#list view#usability

[IMP] product, sale: define product exclusions with their products

PR #104020

Coremasterproductsale

Product option restrictions are now defined alongside the products they affect, instead of being split across the sales module. This reduces the risk of installation failures or data inconsistencies when modules are installed in different orders.

Original PR description

Following recent changes in stable deleting/archiving product variants forbidden by
attributes exclusions, installing some modules after the sale app failed because
the product `product_product_4d` specified in `product` was deleted by the attributes
exclusions of the `sale` module.

This has been fixed in stable by removing all references to this xml_id.

Nevertheless, this bug showed us that the definition of attributes exclusion
for a product in another module than the one creating it is a bad idea, as it
modifies what's allowed or not with that product, leading to potential database inconsistencies.

This commit moves the exclusions targeting products from the `product`
module to the `product` module, to reduce the risks of other modules using/referencing
the deleted/modified products in a way conflicting with the exclusions.

#product options#demo data#module installation

Bug Fixes(1)

Resolved issues and error corrections

[IMP] web: show clipboard field even if it's empty

PR #104248

Coremasterweb

Clipboard fields now stay visible even when they have no content, so users can edit them instead of seeing a missing field. This improves form usability and prevents issues when empty text values are handled by the copy button.

Original PR description

**Issue:** When a copy clipboard field is empty, there is no way to edit it because the Field component is not shown. This issue can be reproduced using any type of copy clipboard field: -…

**Issue:**

When a copy clipboard field is empty, there is no way to edit it
because the Field component is not shown.

This issue can be reproduced using any type of copy clipboard field:
- CopyClipboardChar
- CopyClipboardText
- CopyClipboardURL

Check the following video for illustration:
https://youtu.be/CTzqJRtwqv0

**Solution:**

This PR proposes a fix of *always* showing the copy clipboard field
(together with the copy button) even if the content is empty.

For illustration, check: https://youtu.be/jMM7zn_mFCU

**Notable changes:**

- The modified tests were using a wrong class name. But since they were
asserting the "non-existence" of the copy button, they were working.
- We are casting null text field to empty string (just like char field)
so that we avoid crash (in dev mode) when passing a "boolean" as 'content'
props to the 'CopyButton' component. This is asserted in the augmented
test case where we also try to render an empty text field.

TASK-ID: 2861388

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Other(45)

Miscellaneous changes

[FW][FIX] sale_timesheet: adapt JS tour of sale_timesheet for always edit

PR #104305

Coremastersale_timesheet

Before this commit, the sale_timesheet tour sometimes fails because it cannot click on the save button. Since the always edit feature, the form view is automatically saved when the user leaves the view, so it is now not necessary to click on the save button and then leave the form view. This commit removes the steps in which they simulate the user clicks on the save button to avoid any indeterminate errors when that tour is launched. Forward-Port-Of: odoo/odoo#104159

Original PR description

Before this commit, the sale_timesheet tour sometimes fails because it cannot click on the save button. Since the always edit feature, the form view is automatically saved when the user leaves the view, so it is now not necessary to click on the save button and then leave the form view.

This commit removes the steps in which they simulate the user clicks on the save button to avoid any indeterminate errors when that tour is launched.

Forward-Port-Of: odoo/odoo#104159

At the moment, the tree view is quite dense. In order to ease its use, make company and phone fields optional and hidden by default. This is done for crm.leads as both leads and opportunities. Task-3053159

Following recent changes in stable deleting/archiving product variants forbidden by attributes exclusions, installing some modules after the sale app failed because the product `product_product_4d` specified in `product` was deleted by the attributes exclusions of the `sale` module. This has been fixed in stable by removing all references to this xml_id. Nevertheless, this bug showed us that the definition of attributes exclusion for a product in another module than the one creating it is a bad idea, as it modifies what's allowed or not with that product, leading to potential database inconsistencies. This commit moves the exclusions targeting products from the `product` module to the `product` module, to reduce the risks of other modules using/referencing the deleted/modified products in a way conflicting with the exclusions.

**Issue:** When a copy clipboard field is empty, there is no way to edit it because the Field component is not shown. This issue can be reproduced using any type of copy clipboard field: - CopyClipboardChar - CopyClipboardText - CopyClipboardURL Check the following video for illustration: https://youtu.be/CTzqJRtwqv0 **Solution:** This PR proposes a fix of *always* showing the copy clipboard field (together with the copy button) even if the content is empty. For illustration, check: https://youtu.be/jMM7zn_mFCU **Notable changes:** - The modified tests were using a wrong class name. But since they were asserting the "non-existence" of the copy button, they were working. - We are casting null text field to empty string (just like char field) so that we avoid crash (in dev mode) when passing a "boolean" as 'content' props to the 'CopyButton' component. This is asserted in the augmented test case where we also try to render an empty text field. TASK-ID: 2861388 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The main motivation for this change is to improve performance of BoM `explode`, which heavily rely on checking the lines to skip. `explode` is also called from product `compute_quantities_dict` which is called multiple times during upgrades. With this fix we improved the running time of an upgrade _test_ from 3h:30m to 2h:55m which gives a 16% performance improvement. The goal of `_skip_bom_line` is to check that for each attribute present on the line, at least one value associated to that attribute must be in the attribute values of the product(*). If none is found then we consider that we can skip the line. The previous implementation was inefficient. It grouped all values by attribute, then checked one by one if at least one value is on the product. In case one attribute does not have any value on the product it skipped the line. The implementation we propose here is to take the intersection of the product and line values, then check that their attributes are the same. The later can be done with a simple length check. In case they are different the line must be skipped. Note that this works because only one value is possible per attribute in a product. Both implementations are equivalent. The second is more efficient because does not branch and relies on (record)set operations. For example, let's consider a product with two attribute values `a` and `b`, and a line with multiple values `a`,`y` for attribute 1, and `z` for attribute 2. ``` Product Line +---+ +-----+ | a | <- same attribute -> | a,y | +---+ +-----+ | b | <- same attribute -> | z | +---+ + ----+ ``` This line must be skipped. The reason is that the value `b` is not among the list `[z]` of values for attribute 2 on the line. The new implementation would get the intersection of attribute values as `[a]` from there the comparison of the attributes will fail because `[a]` has only one attribute while the line has two. Let's consider a second case, where there is no value on the line for attribute 2. ``` Product Line +---+ +-----+ | a | <- same attribute -> | a,y | +---+ +-----+ | b | <- same attribute -> | | +---+ + ----+ ``` This line is not skipped because there is no value for attribute 2 on the line. Therefore the condition(*) per attribute is not violated for this product. The new implementation gets `[a]` as intersection of values, but now the attributes coincide: they are both attribute 1 for the intersection and the line. Finally, ``` Product Line +---+ +-----+ | a | <- same attribute -> | a,y | +---+ +-----+ | | <- same attribute -> | z,w | +---+ + ----+ ``` This line is skipped because none of `[z,w]` are in the product. The new implementation would get again `[a]` as intersection which does not match the attributes on the line. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104976 Forward-Port-Of: odoo/odoo#99047

Improvements(2)

[IMP] crm: hide phone and company in lead tree view.

[IMP] product, sale: define product exclusions with their products

Bug Fixes(1)

[IMP] web: show clipboard field even if it's empty

Other(45)

[FW][FIX] sale_timesheet: adapt JS tour of sale_timesheet for always edit

Improvements(2)

[IMP] crm: hide phone and company in lead tree view.

[IMP] product, sale: define product exclusions with their products

Bug Fixes(1)

[IMP] web: show clipboard field even if it's empty

Other(45)

[FW][FIX] sale_timesheet: adapt JS tour of sale_timesheet for always edit

[FW][FIX] project: ensure cost are subtracted when calculating margin

[FW][FIX] project: add default project when user wants to add subtask

[FW][FIX] {hr,sale}_timesheet: prevent default project_id on non timesheets

[FW][FIX] web: Allow user to download binary file in always edit mode

[FW][ADD] l10n_my

[FW][FIX] account: invoice report duplicated values

[FW][FIX] Base send correct report paperformat to wkhtmltopdf

[FW][13.0][FIX] mrp: ensure only active BoMs are considered on product2bom

[FW][FIX] account: wrong computation smart button on analytic account

[FW][IMP] stock: Add a void button box on Package Types form view

[FW][FIX] account: add hook to get payment_mthod_code

[FW][FIX] l10n_it_edi: self-invoices require fiscal regime RF18

[FW][FIX] web: take into account 0s when aggregating

[FW][FIX] web: un-stored m2m field is not valid custom groupby

[FW][FIX] mrp: division by 0 when computing the production capacity

[FW][FIX] mail: no traceback when deleting a message

[FW][FIX] project: prevent opening the form of report.project.task.user model

[FW][FIX] hr_timesheet: fix warning message box width

[FW][FIX] mrp: improve perf of `_skip_bom_line`

[FW][FIX] web: kanbanRenderer can choose if it supports Sortable

[FW][FIX] account: fix report syntactic sugar and indentation of formulas

[FW][I18N] Remove zombie translation files

[FW][FIX] base: select appropriate address for SMTP connection check

[FW][FIX] event: fix report printable name

[FW][FIX] website_sale: fiscal position application

[FW][FIX] website_sale: display error if cart updated before payment

[FW][FIX] mail: only hide rating in chatter and not in message

[FW][FIX] l10n_uk_reports: fix tax report custom handler

[FW] Mail usage fixes

[FW][I18N] Remove zombie translation files

[FW][MERGE] web_studio: a kanban editor for the new WOWL KanbanView

[FW][FIX] documents_project: fix document folder creation for project

[FW][FIX] account_asset: dark mode

[FW][FIX] website_sale_subscription: fix tour

[FW][FIX] stock_barcode{,_picking_batch}: scan package for several SML

[FW][FIX] account_reports: bring back 0% tax in tax report

[FW][FIX] account_reports: fix _init_custom_options()

[FW][FIX] account_sepa_direct_debit: align 'sepa_direct_debit (acquirer)' with 'sdd'

[FW][IMP] project_account_asset: change groupby of assets_count

[FW][FIX] documents_spreadsheet: fix translation issue

[FW][FIX] sale_subscription : readonly recurrence

[FW][FIX] *: prevent default project_id on non timesheets

[FW][FIX] planning: hide the template_creation label if no planning manager

[FW][FIX] helpdesk: fix reduced space beween the' working hours' label and its value