Saturday, November 5, 2022
7 changes · master
Miscellaneous changes
Before this commit, when we create a new task in the project Gantt view, the default current user is assigned to the task instead of the corresponding user. So in this commit, assign the default user from context then if not found then assign the current user to the task. task-2920824 Forward-Port-Of: odoo/odoo#97866
Original PR description
Before this commit, when we create a new task in the project Gantt view, the default current user is assigned to the task instead of the corresponding user. So in this commit, assign the default user from context then if not found then assign the current user to the task. task-2920824 Forward-Port-Of: odoo/odoo#97866
Before this commit, the default order used in the project list/kanban view is only `sequence` but if all projects have the same sequence, the order is not really constent. This commit changes the default order to sort by `sequence`, `name` and `id` as it is defined in the python model. Forward-Port-Of: odoo/odoo#104886
Original PR description
Before this commit, the default order used in the project list/kanban view is only `sequence` but if all projects have the same sequence, the order is not really constent. This commit changes the default order to sort by `sequence`, `name` and `id` as it is defined in the python model. Forward-Port-Of: odoo/odoo#104886
Commit [1] broke some confirm dialogs because the confirm and cancel callbacks are not called with the same `this` anymore. E.g.: - Install website - Go to the page manager (/website/pages) - Clone a page (choose a name and confirm) => Crash (this.$ does not exist). Note that this flow was quickly fixed with [2] by changing the local code instead of fixing the root cause (this commit here actually technically reverts that change so it keeps working). The work done at [1] actually
Original PR description
Commit [1] broke some confirm dialogs because the confirm and cancel callbacks are not called with the same `this` anymore. E.g.: - Install website - Go to the page manager (/website/pages) - Clone a…
Commit [1] broke some confirm dialogs because the confirm and cancel callbacks are not called with the same `this` anymore. E.g.: - Install website - Go to the page manager (/website/pages) - Clone a page (choose a name and confirm) => Crash (this.$ does not exist). Note that this flow was quickly fixed with [2] by changing the local code instead of fixing the root cause (this commit here actually technically reverts that change so it keeps working). The work done at [1] actually needed some more rework than that to handle two other potential usecases: - If the confirm dialog handlers' promises are rejected, the dialog is not closed (rightfully, like for example allowing to fill an empty required input)... but [1] prevented to click on the button again forever. With the same example as above, it can be reproduced: if the RPC to clone the page fails, I cannot retry. - If not both confirm_callback and cancel_callback were given, [1] only prevented to multi-click on the related button (e.g. if you click on "Ok", a RPC which takes 10 seconds is made, you click on cancel immediately afterwards -> the dialog is closed while it should be prevented (and would be if cancel_callback was given, following [1])). That may not be entirely stable to make this change though but it seems to make sense and be better (just keeping what [1] wanted here). Note: this adds some more tests to check all of this + some more things that were found during development. For example: [1] relied on the fact that callbacks returned a Promise or nothing... while developers actually were returning random things (for no reason as no way to get the result anyway). Adding a test for this prevents to break that in stable (the first iteration here crashed in such cases). [1]: https://github.com/odoo/odoo/commit/4b8b079a7d9991a8dc481fe71a45185d672135c9 [2]: https://github.com/odoo/odoo/commit/8216341f5ad8d82ad0bcb0d1f01d874477d2de7b Closes https://github.com/odoo/odoo/pull/103712 opw-3033878 opw-3043224 opw-3046485 opw-3042542 Forward-Port-Of: odoo/odoo#104950 Forward-Port-Of: odoo/odoo#104220
Before this commit, when the deadline was false there was a traceback due to replace. So in this commit, check for the deadline, and if exist then only do the operation on it. task-2928549 Forward-Port-Of: odoo/enterprise#30269
Original PR description
Before this commit, when the deadline was false there was a traceback due to replace. So in this commit, check for the deadline, and if exist then only do the operation on it. task-2928549 Forward-Port-Of: odoo/enterprise#30269
industry_fsm_sale- Reproduction steps: - Instal industry_fsm_sale module - Create FSM task - Click on the product stat button - Click on the product record Issue: When we clicked on the product, the product image flickered. In this commit: We have stopped the product image flickering issue. Why the issue occurred : When we clicked on the product kanban card, the kanban record is reloaded. timesheet_grid: W
Original PR description
industry_fsm_sale-
Reproduction steps:
- Instal industry_fsm_sale module
- Create FSM task
- Click on the product stat button
- Click on the product record
Issue:
When we clicked on the product, the product image flickered.
In this commit:
We have stopped the product image flickering issue.
Why the issue occurred :
When we clicked on the product kanban card, the kanban record is reloaded.
timesheet_grid:
When there is group by first group (ex. department) > employee, the employee avatar widget appears
in a new row.it will be fixed in this commit.
Reproduction steps:
- Installe timesheet_grid module
- All Timesheets > Grid view
- Group By :
task > employee
task-2982214
Forward-Port-Of: odoo/enterprise#31289Issue 1: Before this commit, an avatar of the customer was glitched(too small) inside the sidebar of the ticket portal. So in this commit make the avatar proper and align the entire content of the sidebar. Issue 2: Before this commit, in planning configuration roles it was giving the error of active_id not found. So in this commit use, an id instead of active_id as active_id is not defined in the role menu. task-2928549 Forward-Port-Of: odoo/enterprise#30023
Original PR description
Issue 1: Before this commit, an avatar of the customer was glitched(too small) inside the sidebar of the ticket portal. So in this commit make the avatar proper and align the entire content of the sidebar. Issue 2: Before this commit, in planning configuration roles it was giving the error of active_id not found. So in this commit use, an id instead of active_id as active_id is not defined in the role menu. task-2928549 Forward-Port-Of: odoo/enterprise#30023
Before this commit,The dropdown of coupon program does not work properly and coupon program field also show promotions in helpdesk. After this commit, Dropdown of coupon program work properly and coupon program field show coupons only task : 2858529 Forward-Port-Of: odoo/enterprise#28426
Original PR description
Before this commit,The dropdown of coupon program does not work properly and coupon program field also show promotions in helpdesk. After this commit, Dropdown of coupon program work properly and coupon program field show coupons only task : 2858529 Forward-Port-Of: odoo/enterprise#28426