Monday, November 14, 2022
53 changes · master
Enhancements to existing features
This update adds missing automated tests for Odoo's background task scheduler, helping catch issues before they affect operations. It especially strengthens coverage for timing and concurrency scenarios that previously caused subtle reliability problems.
Original PR description
The cron subsystem is the system responsible of running background task at regular interval, it runs in multiple dedicated threads or workers that are independent of the regular HTTP threads/workers.…
The cron subsystem is the system responsible of running background task at regular interval, it runs in multiple dedicated threads or workers that are independent of the regular HTTP threads/workers. There was a major overhaul of the system in v15 (4b28f1162a8) to introduce cron triggers, a way to run a task at a given moment in addition to the regular configured interval. Although the cron system was not extensively tested before that v15 refactor, no new test were introduced with that refactor leaving the system mostly untested. Since then we had to fix multiple subtle concurrency bugs such as b940d1c25f8 and c06cee44fe1. Due to the lack of an existing test suite, no regression tests were added next to those fixes. With this commit we introduce the missing cron test suite. The test suite is separated in two different test cases: - A standard pre-install TransactionCase to test everything that can be tested with a single cursor. This case can be run the usual way with `--test-tags :TestIrCron`. - A non-standard post-install **database breaking** test case to run concurrency tests that often require multiple SQL transactions. This case requires the special `--test-tags database_breaking` to be executed. You MUST backup your current database before running that test or you'll loose data.
This update moves styling settings that are only used by Live Chat out of the broader Mail area and into the Live Chat module. This keeps the product code better organized and reduces unnecessary coupling between Mail and Live Chat, with no expected change for end users.
Administrators editing interface views can now select and open the related model from a proper linked field instead of editing only a text value. This makes configuration easier and reduces friction when reviewing or updating view settings.
Original PR description
When using the view "edit view" on the interface as administrator, the user can see and modify the model of the view as a string, but cannot navigate to the model easily or edit the model field by selecting the model in a list. This pull request adds the possibility to view and edit the model field as a many2one. task-id: 3007619 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes an unnecessary internal processing step when filtering records by a field name. It can make filtering faster on very large datasets, with minimal visible impact in everyday use.
Original PR description
The mapped call is supposed to populate the cache, but that's already taking care of by prefetching.
It ends up adding an overhead instead.
The perf improvement is more noticeable on large recordsets.
For example, on a database populated with 100k res.partner records.
Before:
```py
partners = env["res.partner"].search([])
partners.filtered("name") # warm up
timeit.timeit(lambda: partners.filtered("name"), number=100)
# result: 71.54
```
After:
```py
partners = env["res.partner"].search([])
partners.filtered("name") # warm up
timeit.timeit(lambda: partners.filtered("name"), number=100)
# result: 46.72
```
Although the perf imp is miniscule in real world cases, these lines can be misleading IMO.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe Mail module has been added to automated formatting and linting checks. This helps keep the codebase consistent and easier to maintain, reducing the risk of future issues without changing user-facing behavior.
The user notification alert has been moved from the mail area into the core web and base user form where it more naturally belongs. This makes the feature available without relying on mail-specific functionality and should simplify maintenance with little visible impact for users.
Original PR description
The code does not actually depend on mail features and it is intended to be used in the base form view of user.
The Helpdesk module now includes population logic to create sample or test data more easily. This helps teams evaluate, demonstrate, and test Helpdesk scenarios with more realistic data.
Original PR description
task-3035507
Resolved issues and error corrections
The Lead Generation Views screen now shows a meaningful record label in the navigation breadcrumb instead of a technical database-style name. This makes it easier for users to understand where they are when opening these reporting records.
Original PR description
**Description of the issue/feature this PR addresses:** in website_crm_iap_reveal module for the model crm.reveal.view there is no name field or rec_name for the model, thus when we open a record in this model the breadcrump is as follows: crm.reveal.view(1), so adding rec_name for the model for better breadcrump CRM -> Reporting -> Lead Generation Views **Current behavior before PR:** breadcrump while accesing the model record is as follows: crm.reveal.view(1) **Desired behavior after PR is merged:** better breadcrump for model crm.reveal.view --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Steps to reproduce ================== - Use a mobile phone / mobile view in devtools - Go to Purchase > Purchase Orders - Click on one item -> A traceback occurs, the uom is missing Cause of the issue ================== The field is declared as `<field name="product_uom" groups="uom.group_uom"/>` The raw value is accessed with `<t t-esc="record.product_uom.value"/>` Solution ======== Add the missing group opw-3033650 Forward-Port-Of: odoo/odoo#105283
Original PR description
Steps to reproduce ================== - Use a mobile phone / mobile view in devtools - Go to Purchase > Purchase Orders - Click on one item -> A traceback occurs, the uom is missing Cause of the issue ================== The field is declared as `<field name="product_uom" groups="uom.group_uom"/>` The raw value is accessed with `<t t-esc="record.product_uom.value"/>` Solution ======== Add the missing group opw-3033650 Forward-Port-Of: odoo/odoo#105283
The email marketing favorite filter helper now uses the same icon as the main mailing view. This creates a more consistent visual experience for users working with mailing filters.
Original PR description
This commit changes the favourtie filter helper icon to match the one in the mailing.mailing view. Task-3048050 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The wording for disabled duplicate and remove buttons in website forms has been updated to avoid referencing internal technical terms. This makes the interface clearer and less confusing for users editing website forms.
Original PR description
This commit updates the tooltips of disabled form field's duplicate & remove buttons so that they do not reference the concept of "model". task-2950433
Steps to reproduce: - Create a product and complete a sales order. - Then try to change the product type. - The following message is shown: "You cannot change the product type because it is already used in sales orders." However, we can close the message and save it. Problem: If some sales were already made, it should not be possible to change the product type. There is a warning message on the onchange but it's not blocking. This causes inconsistencies between the quantities and value
Original PR description
Steps to reproduce: - Create a product and complete a sales order. - Then try to change the product type. - The following message is shown: "You cannot change the product type because it is already used in sales orders." However, we can close the message and save it. Problem: If some sales were already made, it should not be possible to change the product type. There is a warning message on the onchange but it's not blocking. This causes inconsistencies between the quantities and value shown in the quants and in the valuation layers. Solution: Raise a user error when trying to save the changes. opw-3000886 Forward-Port-Of: odoo/odoo#105292 Forward-Port-Of: odoo/odoo#101547
Currently, In account.analytic.account model due to the extra space in name field string formatting. which generates the issue while searching on accounts. This PR fixes this issue by removing extra space and seperator. task-2997424 Forward-Port-Of: odoo/odoo#102305
Original PR description
Currently, In account.analytic.account model due to the extra space in name field string formatting. which generates the issue while searching on accounts. This PR fixes this issue by removing extra space and seperator. task-2997424 Forward-Port-Of: odoo/odoo#102305
Germany and Switzerland both use the DIN5008 paper layout and encoutered some issues while printing an invoice's pdf. In Germany, the display of pdf invoices changed with v16.0. The header and footer would always display borders, which would mess up the rest of the display. Adding the 'table-borderless' class solved this problem. In l10n_ch, this issue was also encountered, and the general display of the qr bill page was set off. This is problematic since this display is highly rigid.
Original PR description
Germany and Switzerland both use the DIN5008 paper layout and encoutered some issues while printing an invoice's pdf. In Germany, the display of pdf invoices changed with v16.0. The header and footer would always display borders, which would mess up the rest of the display. Adding the 'table-borderless' class solved this problem. In l10n_ch, this issue was also encountered, and the general display of the qr bill page was set off. This is problematic since this display is highly rigid. Those changes seem to be linked to wkhtmltopdf unability to process some of the Bootstrap5 changes. While waiting for a more long term solution regarding wkhtmltopdf and BS5 compatibility, calling directly the adequate external_layout allows us to get back a correct QR Bill. task-3037921 Forward-Port-Of: odoo/odoo#105349
Smooth-scroll-on-drag offset is eliminated, resulting in correct placement of scroll-sensitive areas. task-2979060 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100676
Original PR description
Smooth-scroll-on-drag offset is eliminated, resulting in correct placement of scroll-sensitive areas. task-2979060 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100676
Adapt community to make it possible to add employee cost when calculate bom cost. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104732
Original PR description
Adapt community to make it possible to add employee cost when calculate bom cost. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104732
Fix the matrix question type preview display on small and medium screen size. Task-3006768 Forward-Port-Of: odoo/odoo#102191
Original PR description
Fix the matrix question type preview display on small and medium screen size. Task-3006768 Forward-Port-Of: odoo/odoo#102191
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104411
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104411
Before this commit, performing a search in a m2o can block your ui despite the result already being displayed. Why? When you perform your search in a m2o, a set of RPC queries are made with the different search values (name_search). If the last search value (the one that will be used by the m2o in its autocomplete) has already been resolved, but one of the other RPCs has still not been resolved, then the screen will remain blocked until all the rpc's have been resolved. Solution: Since w
Original PR description
Before this commit, performing a search in a m2o can block your ui despite the result already being displayed. Why? When you perform your search in a m2o, a set of RPC queries are made with the…
Before this commit, performing a search in a m2o can block your ui despite the result already being displayed. Why? When you perform your search in a m2o, a set of RPC queries are made with the different search values (name_search). If the last search value (the one that will be used by the m2o in its autocomplete) has already been resolved, but one of the other RPCs has still not been resolved, then the screen will remain blocked until all the rpc's have been resolved. Solution: Since we are only interested in the last rpc, we will cancel all the others. So with each new rpc, we will cancel the previous one. How to reproduce: - Go to a form view with a m2o field - Edit this field +- slowly (several rpc will be done with different values) - Receive the result of the search. (The autocomplete is displayed with the right values) Before this commit: If one of the other rpc's is not yet resolved, the ui will block until all rpc's are resolved. After this commit: The ui will not block. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104984 Forward-Port-Of: odoo/odoo#104415
The class that Odoo adds to nested list items to display them nicely was not whitelisted for pasting so pasting nested lists ended up looking ugly. task-3050150 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105300
Original PR description
The class that Odoo adds to nested list items to display them nicely was not whitelisted for pasting so pasting nested lists ended up looking ugly. task-3050150 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105300
Steps to reproduce: - go to eLearning app; - select a course and go to its website page; - the course may (or not) be published; - join the course; - click on a course material which is not pusblished. (the course material has to allow preview) (the course material does not have to be completed before) (on loading slide on full-screen mode) (in debug mode, it is not a "pop-up" but a classic error) Issue: A message "Odoo Session Expired" appeard
Original PR description
Steps to reproduce:
- go to eLearning app;
- select a course and go to its website page;
- the course may (or not) be published;
- join the course;
- click on a course material which is not pusblished.
(the course material has to allow preview)
(the course material does not have to be completed before)
(on loading slide on full-screen mode)
(in debug mode, it is not a "pop-up" but a classic error)
Issue:
A message "Odoo Session Expired" appeard.
Cause:
The course is not marked as completed. The `canSelfMarkCompleted` attribute is always False and will raise the error because we will continue the flow as if the slide is completed and this is not the case.
Solution:
We have to test this `canSelfMarkCompleted` attribute to decide whether or not we continue.
opw-3033797
Forward-Port-Of: odoo/odoo#105172Commit [1] introduced "text/odoo-editor" clipboard content so as not to alter html copied from within the editor but since it prevented the default assignment of html to the clipboard, it did so in a different way than the browser, which led to said html being different anyway. This lets the browser do its thing and simply flags the content as coming from the editor so we know it can be pasted safely. [1]: https://github.com/odoo/odoo/pull/101566/commits/64fe38776fdeda7f617a737b6fcdac77aff28c
Original PR description
Commit [1] introduced "text/odoo-editor" clipboard content so as not to alter html copied from within the editor but since it prevented the default assignment of html to the clipboard, it did so in a different way than the browser, which led to said html being different anyway. This lets the browser do its thing and simply flags the content as coming from the editor so we know it can be pasted safely. [1]: https://github.com/odoo/odoo/pull/101566/commits/64fe38776fdeda7f617a737b6fcdac77aff28c57 task-3050150 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105302
**Description of the issue/feature this PR addresses:** the separator string "Module Update Result" is expected to visible only in the state done but currently it is displaying always without any meaning. I expect the separator is added to show the result of the update app list process along with the fields updated and added. Impacted version: 13.0 - 16.0 **Current behavior before PR:** meaningless separator is displayed always ![Screenshot from 2022-11-13 12-47-14](https://user-image
Original PR description
**Description of the issue/feature this PR addresses:** the separator string "Module Update Result" is expected to visible only in the state done but currently it is displaying always without any meaning. I expect the separator is added to show the result of the update app list process along with the fields updated and added. Impacted version: 13.0 - 16.0 **Current behavior before PR:** meaningless separator is displayed always  **Desired behavior after PR is merged:** separator visible only in state done --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105630
Prevent "per line" rounding taxes when tax rounding method is round globally. Manual fwd port of https://github.com/odoo/odoo/commit/46504495664be211cf2ddbf2fa7532c022b1e5f0 Task: opw-2963947 Closed prev conflicted fwd port pr : https://github.com/odoo/odoo/pull/105373 Forward-Port-Of: odoo/odoo#105460
Original PR description
Prevent "per line" rounding taxes when tax rounding method is round globally. Manual fwd port of https://github.com/odoo/odoo/commit/46504495664be211cf2ddbf2fa7532c022b1e5f0 Task: opw-2963947 Closed prev conflicted fwd port pr : https://github.com/odoo/odoo/pull/105373 Forward-Port-Of: odoo/odoo#105460
Upon updates, the `active` field of `ir.ui.view` behaves differently depending on whether the view is defined by using the `<template>` tag or the `<record>` tag. When using `<record>`, it behaves like any other field and gets updated with the new value. When using `<template>`, if the view record already existed, it is not updated since [1], except for new records since [2]. This commit adds a comment to the `active` field to help developers find out about this difference. See this [dis
Original PR description
Upon updates, the `active` field of `ir.ui.view` behaves differently depending on whether the view is defined by using the `<template>` tag or the `<record>` tag. When using `<record>`, it behaves like any other field and gets updated with the new value. When using `<template>`, if the view record already existed, it is not updated since [1], except for new records since [2]. This commit adds a comment to the `active` field to help developers find out about this difference. See this [discussion]. [1]: 2d296cb#diff-175c28787c272a219b9275f79262a48af9aa029e718f45077fd609737559e84eR803-R804 [2]: f1c70d4#diff-175c28787c272a219b9275f79262a48af9aa029e718f45077fd609737559e84eR801-R804 [discussion]: https://github.com/odoo/odoo/pull/104836#discussion_r1013155860 task-2963840 Forward-Port-Of: odoo/odoo#105524
It's needed to use "Automatic Risk assessment" feature in Adyen. Technical docs: https://docs.adyen.com/risk-management/configure-manual-risk/required-risk-field-reference opw-3004646 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105587 Forward-Port-Of: odoo/odoo#102094
Original PR description
It's needed to use "Automatic Risk assessment" feature in Adyen. Technical docs: https://docs.adyen.com/risk-management/configure-manual-risk/required-risk-field-reference opw-3004646 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105587 Forward-Port-Of: odoo/odoo#102094
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105526
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105526
[FIX] *: override save checks that the save is valid The goal of this commit is to avoid the execution of code depending on the validity of the save of a Record. Before this commit, several override save functions in Record execute code after the record's save without checking if the record's save has taken place. Override before: ```js export class NewRecord extends Record { async save() { const isSaved = await super.save(...arguments); // doAction
Original PR description
[FIX] *: override save checks that the save is valid The goal of this commit is to avoid the execution of code depending on the validity of the save of a Record. Before this commit, several override…
[FIX] *: override save checks that the save is valid
The goal of this commit is to avoid the execution of code depending
on the validity of the save of a Record.
Before this commit, several override save functions in Record execute
code after the record's save without checking if the record's save has
taken place.
Override before:
```js
export class NewRecord extends Record {
async save() {
const isSaved = await super.save(...arguments);
// doAction
return isSaved;
}
}
``
Override after:
```js
export class NewRecord extends Record {
async save() {
const isSaved = await super.save(...arguments);
if (isSaved) {
// doAction
}
return isSaved;
}
}
```
How to reproduce the problem:
Go to a form view with a Record having its save override function.
Edit a record in such a way to have an invalid field
Click on the save button
Before this commit:
The doAction is executed
After this commit:
The doAction is not executed
Forward-Port-Of: odoo/odoo#105468Before this commit, when using the `many2one_avatar_user` on the `user_id` field of the crm tree views, an error was thrown because the domain of `user_id` refers to `user_company_ids` which the view did not have access to, so it wasn't yet computed. The field was added in invisible to the tree views so that it can be computed before being accessed. Task-3053146 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105556
Original PR description
Before this commit, when using the `many2one_avatar_user` on the `user_id` field of the crm tree views, an error was thrown because the domain of `user_id` refers to `user_company_ids` which the view did not have access to, so it wasn't yet computed. The field was added in invisible to the tree views so that it can be computed before being accessed. Task-3053146 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105556
**Issue:** When moving a record in a kanban view from one column to another, it is possible to keep holding the record, hover it in one column for a moment, then move again to another column then eventually drop the record. Doing this where a folded column is the intermediate column results to visual issue, such that the darker highlight of a folded column is lost. The desired behavior is to keep the background color of a folded column. **Solution:** When moving a record, the h
Original PR description
**Issue:** When moving a record in a kanban view from one column to another, it is possible to keep holding the record, hover it in one column for a moment, then move again to another column then…
**Issue:** When moving a record in a kanban view from one column to another, it is possible to keep holding the record, hover it in one column for a moment, then move again to another column then eventually drop the record. Doing this where a folded column is the intermediate column results to visual issue, such that the darker highlight of a folded column is lost. The desired behavior is to keep the background color of a folded column. **Solution:** When moving a record, the hovered column is highlighted, and right after leaving the column, we remove the highlight. And we are doing this without exempting the folded column, thus, its darker highlight is lost during the record-moving-hovering process. Instead of adding/removing .bg-100 during unhover/hover on each kanban column to make sure of the "greenish" tint of the column when hovered, we just make background of the .o_kanban_hover to be important. **Bug report:** > [aju] https://watch.screencastify.com/v/PdiHt8Qh3iVfCx5nzHkh open the kanban view of tasks or tickets > create stages A and B (B should be folded by default) > create a task in stage A > drag this task and hover stage B without dropping the task > stage B goes from grey to transparent --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105557
**Description of the issue/feature this PR addresses:** the model is not imported in the init file and not used any where **Current behavior before PR:** removed unused directory **Desired behavior after PR is merged:** clean the source code --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105586
Original PR description
**Description of the issue/feature this PR addresses:** the model is not imported in the init file and not used any where **Current behavior before PR:** removed unused directory **Desired behavior after PR is merged:** clean the source code --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105586
This PR aims to fix several indeterminate crashes in the tests. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105564
Original PR description
This PR aims to fix several indeterminate crashes in the tests. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105564
This commit changes the json widget to no longer edit the `props` of the component as it might cause reactivity issues. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105608
Original PR description
This commit changes the json widget to no longer edit the `props` of the component as it might cause reactivity issues. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105608
Description of the issue/feature this PR addresses: * Fix wrong translations for taxes, tax grids, accounts and tax groups. * Remove auto_apply for fiscal position israel, because partner from israel can also lead to other fiscal positions (self invoice, eilat,etc). * Remove the duplicate account Income tax withheld - customers -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104774 Forward-Port-Of: odoo/odoo#99377
Original PR description
Description of the issue/feature this PR addresses: * Fix wrong translations for taxes, tax grids, accounts and tax groups. * Remove auto_apply for fiscal position israel, because partner from israel can also lead to other fiscal positions (self invoice, eilat,etc). * Remove the duplicate account Income tax withheld - customers -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#104774 Forward-Port-Of: odoo/odoo#99377
Define a route that is website but not multilang, e.g. @route('/example', website=True, multilang=False) Login to the frontend, change the website lang to another (non-default) lang (e.g. install french, keep english as default lang, log in the french website) then access the '/example' controller by typing it directly in your address bar. You are being redirected to '/fr/example', you should not. This commit restore the behavior pre-httpocalypse, that is the address is kept as-i
Original PR description
Define a route that is website but not multilang, e.g.
@route('/example', website=True, multilang=False)
Login to the frontend, change the website lang to another (non-default) lang (e.g. install french, keep english as default lang, log in the french website) then access the '/example' controller by typing it directly in your address bar.
You are being redirected to '/fr/example', you should not.
This commit restore the behavior pre-httpocalypse, that is the address is kept as-is.
Note: in the comment, the 4th and 5th cases were inverted, we use this commit as an opportunity to reorder the two.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#104999
Forward-Port-Of: odoo/odoo#104337**Description of the issue/feature this PR addresses:** in hr module fields: hr_presence_control_ip and hr_presence_control_email are defined with config_parameter hr_presence.hr_presence_control_ip and hr_presence.hr_presence_control_email, but in the hr_presence module the same key is referred/access with different key's. issue reported: https://github.com/odoo/odoo/issues/105502 **Current behavior before PR:** data is not retrieved from config parameter by get_param method **D
Original PR description
**Description of the issue/feature this PR addresses:** in hr module fields: hr_presence_control_ip and hr_presence_control_email are defined with config_parameter hr_presence.hr_presence_control_ip and hr_presence.hr_presence_control_email, but in the hr_presence module the same key is referred/access with different key's. issue reported: https://github.com/odoo/odoo/issues/105502 **Current behavior before PR:** data is not retrieved from config parameter by get_param method **Desired behavior after PR is merged:** data is retrieved from config parameter by get_param method --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105510
Add a setUpClass with a dummy payment provider to ensure that at least one is always available when the tour is running and set the company country_id to None before starting the tour to avoid any country dependant fields blocking the tour during the checkout process. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105657
Original PR description
Add a setUpClass with a dummy payment provider to ensure that at least one is always available when the tour is running and set the company country_id to None before starting the tour to avoid any country dependant fields blocking the tour during the checkout process. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105657
- Project in filter projects for `Late Milestones` filter Before this commit, when the user uses the `Late Milestones` filter in the project views, all the projects in the views are used, but some projects could have the feature disabled and so those ones should be ignored in the filtered. - Project in hide "Milestone" action button in project kanban card Before this commit, when the Milestones feature is globally enabled in the project app, the "Milestones" action
Original PR description
- Project in filter projects for `Late Milestones` filter Before this commit, when the user uses the `Late Milestones` filter in the project views, all the projects in the views are used, but some projects could have the feature disabled and so those ones should be ignored in the filtered. - Project in hide "Milestone" action button in project kanban card Before this commit, when the Milestones feature is globally enabled in the project app, the "Milestones" action button displayed in the dropdown of the kanban card are always visible even if the project has the feature disabled in its settings. This commit changes the visibility of that action button to also take into account the settings of each project. task-3033041 Forward-Port-Of: odoo/odoo#103537
Before this commit, the allocated hours of a project are set when the linked sale order are confirmed. And then, the project manager can change the allocated hours. However, if the sale manager changes a qty in the sale order, then the allocated hours of the project are recomputed according to the changes made in the sale order and so the allocated hours set by the project manager are erased. This commit removes the compute of allocated hours and so only the default value computed when
Original PR description
Before this commit, the allocated hours of a project are set when the linked sale order are confirmed. And then, the project manager can change the allocated hours. However, if the sale manager changes a qty in the sale order, then the allocated hours of the project are recomputed according to the changes made in the sale order and so the allocated hours set by the project manager are erased. This commit removes the compute of allocated hours and so only the default value computed when the linked sale order is confirmed are set to the allocated hours field of the project. task-2955983 Forward-Port-Of: odoo/odoo#105714 Forward-Port-Of: odoo/odoo#99785
1) Before this commit, In Planning > Configuration > Materials list view while enabling flexible hours field Working time field was displayed After this commit, In Planning > Configuration > Materials list view while enabling flexible hours field Working time field was NOT displayed 2) Before this commit, while creating fsm project we were able to see sale order item After this commit, while creating fsm project sale order item is hide task-2979890 Forward-Port-Of: odoo/enterpri
Original PR description
1) Before this commit, In Planning > Configuration > Materials list view while enabling flexible hours field Working time field was displayed After this commit, In Planning > Configuration > Materials list view while enabling flexible hours field Working time field was NOT displayed 2) Before this commit, while creating fsm project we were able to see sale order item After this commit, while creating fsm project sale order item is hide task-2979890 Forward-Port-Of: odoo/enterprise#31630
The design of the daterangepicker in the eCommerce pages has been improved. The Rent Online task (branch: [master-website-sale-renting-tle](https://runbot.odoo.com/runbot/bundle/99192)) uses the daterangepicker in the website and more specifically in the eCommerce pages. [task-2790379](https://www.odoo.com/web/#id=2790379&menu_id=4720&cids=1&action=333&active_id=587&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#29800
Original PR description
The design of the daterangepicker in the eCommerce pages has been improved. The Rent Online task (branch: [master-website-sale-renting-tle](https://runbot.odoo.com/runbot/bundle/99192)) uses the daterangepicker in the website and more specifically in the eCommerce pages. [task-2790379](https://www.odoo.com/web/#id=2790379&menu_id=4720&cids=1&action=333&active_id=587&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#29800
[FIX] *: override save checks that the save is valid The goal of this commit is to avoid the execution of code depending on the validity of the save of a Record. Before this commit, several override save functions in Record execute code after the record's save without checking if the record's save has taken place. Override before: export class NewRecord extends Record { async save() { const isSaved = await super.save(...arguments); // doAction return
Original PR description
[FIX] *: override save checks that the save is valid The goal of this commit is to avoid the execution of code depending on the validity of the save of a Record. Before this commit, several override…
[FIX] *: override save checks that the save is valid
The goal of this commit is to avoid the execution of code depending
on the validity of the save of a Record.
Before this commit, several override save functions in Record execute
code after the record's save without checking if the record's save has
taken place.
Override before:
export class NewRecord extends Record {
async save() {
const isSaved = await super.save(...arguments);
// doAction
return isSaved;
}
}
Override after:
export class NewRecord extends Record {
async save() {
const isSaved = await super.save(...arguments);
if (isSaved) {
// doAction
}
return isSaved;
}
}
How to reproduce the problem:
Go to a form view with a Record having its save override function.
Edit a record in such a way to have an invalid field
Click on the save button
Before this commit:
The doAction is executed
After this commit:
The doAction is not executed
Forward-Port-Of: odoo/enterprise#33817…ree view This field was there when the statement lines was visible on the bank statement form view. Now, it's a tree view on the bank reconciliation widget but this field has been lost during the refactoring. Forward-Port-Of: odoo/enterprise#33860
Original PR description
…ree view This field was there when the statement lines was visible on the bank statement form view. Now, it's a tree view on the bank reconciliation widget but this field has been lost during the refactoring. Forward-Port-Of: odoo/enterprise#33860
Open any move having assets from the accounting report lines, by clicking view journal entry and click the Deferred Expense smart button in the move form view, trackback is raised as default_move_type does not exist in the context. Or Create a Deferred Expenses from Deferred Expenses menu, click on Posted Entries smart button, click and open any entry, click the smart button in the view. https://user-images.githubusercontent.com/27989791/200539643-11410c1f-5d13-4885-a605-d48f4fde4a4f.mp4
Original PR description
Open any move having assets from the accounting report lines, by clicking view journal entry and click the Deferred Expense smart button in the move form view, trackback is raised as default_move_type does not exist in the context. Or Create a Deferred Expenses from Deferred Expenses menu, click on Posted Entries smart button, click and open any entry, click the smart button in the view. https://user-images.githubusercontent.com/27989791/200539643-11410c1f-5d13-4885-a605-d48f4fde4a4f.mp4 Affected version: 14, 15, 16  Forward-Port-Of: odoo/enterprise#33766 Forward-Port-Of: odoo/enterprise#33742
In some relatively huge databases (>1M account_move) the installation of l10n_mx_edi raises a MemoryError because of the computation of the computed stored field `l10n_mx_edi_external_trade`. To avoid such issue, overwrite the _auto_init method to create and update the field's column through sql instead. Should be up-to 13.0 v14 PR: odoo/enterprise#31506 opw-2951837 Forward-Port-Of: odoo/enterprise#31654 Forward-Port-Of: odoo/enterprise#30929
Original PR description
In some relatively huge databases (>1M account_move) the installation of l10n_mx_edi raises a MemoryError because of the computation of the computed stored field `l10n_mx_edi_external_trade`. To avoid such issue, overwrite the _auto_init method to create and update the field's column through sql instead. Should be up-to 13.0 v14 PR: odoo/enterprise#31506 opw-2951837 Forward-Port-Of: odoo/enterprise#31654 Forward-Port-Of: odoo/enterprise#30929
Missing Employee cost when calculating product cost from BoM Forward-Port-Of: odoo/enterprise#33502
Original PR description
Missing Employee cost when calculating product cost from BoM Forward-Port-Of: odoo/enterprise#33502
After some changes in the list renderer css, the one2many field signer_ids layout started having wrong layout. This commit removes the unwanted outlines and borders from the table generated by that field. The sample sign template is now automatically duplicated if the original sample template already has sign requests. task-2979060 Forward-Port-Of: odoo/enterprise#31554
Original PR description
After some changes in the list renderer css, the one2many field signer_ids layout started having wrong layout. This commit removes the unwanted outlines and borders from the table generated by that field. The sample sign template is now automatically duplicated if the original sample template already has sign requests. task-2979060 Forward-Port-Of: odoo/enterprise#31554
This PR fixes various bugs in Version 16.0 task-2997424 Forward-Port-Of: odoo/enterprise#32337
Original PR description
This PR fixes various bugs in Version 16.0 task-2997424 Forward-Port-Of: odoo/enterprise#32337
Traceback when the instagram's connection failed, _action_disconnect_accounts was called with response as arg that was already a json. The traceback may hide the warnings on the disconnection issue. OPW-3033101 Forward-Port-Of: odoo/enterprise#33850
Original PR description
Traceback when the instagram's connection failed, _action_disconnect_accounts was called with response as arg that was already a json. The traceback may hide the warnings on the disconnection issue. OPW-3033101 Forward-Port-Of: odoo/enterprise#33850
Lithuania requires companies to submit SAF-T. The generic template contains less information than necessary for xsd validation (and needed to be extended). Changes: - generic SAF-T report generation/template updated - LT XML template extended - LT XML generation - Tests to validate XML format and content (xsd, ...) Task id=2721914 Forward-Port-Of: odoo/enterprise#33761 Forward-Port-Of: odoo/enterprise#23631
Original PR description
Lithuania requires companies to submit SAF-T. The generic template contains less information than necessary for xsd validation (and needed to be extended). Changes: - generic SAF-T report generation/template updated - LT XML template extended - LT XML generation - Tests to validate XML format and content (xsd, ...) Task id=2721914 Forward-Port-Of: odoo/enterprise#33761 Forward-Port-Of: odoo/enterprise#23631
…tner For performance reason, we no longer want to match an accounted partner by parsing the statement line textual data. Forward-Port-Of: odoo/enterprise#33772
Original PR description
…tner For performance reason, we no longer want to match an accounted partner by parsing the statement line textual data. Forward-Port-Of: odoo/enterprise#33772
…he statement line This reverts commit 3f200dc53f423d12af5bbafc144af4e56b2e3e32. Forward-Port-Of: odoo/enterprise#33852
Original PR description
…he statement line This reverts commit 3f200dc53f423d12af5bbafc144af4e56b2e3e32. Forward-Port-Of: odoo/enterprise#33852
Steps to reproduce ================== - Go to any app - Open studio - Click on +New Model - Enter a name - Click on the primary button twice Cause of the issue ================== When called from the legacy widget `NewModelItem`, ev.detail is undefined. Instead, it is called ev.data opw-3037861 Forward-Port-Of: odoo/enterprise#33481
Original PR description
Steps to reproduce ================== - Go to any app - Open studio - Click on +New Model - Enter a name - Click on the primary button twice Cause of the issue ================== When called from the legacy widget `NewModelItem`, ev.detail is undefined. Instead, it is called ev.data opw-3037861 Forward-Port-Of: odoo/enterprise#33481