Odoo Changelog — 2022-12-16

Friday, December 16, 2022

36 changes · master

Improvements(3)

Enhancements to existing features

[IMP] event: add avatar widget to responsible

Coremasterevent

The event form now displays the responsible person with an avatar, making it easier for users to recognize who owns an event at a glance. This is a small usability improvement that adds visual context without changing event workflows.

Original PR description

This commit adds the avatar widget to the responsible field in the event form view.

Task-3100951



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#events#usability#avatar

[IMP] test_lint: detect useless manifest content

PR #107735

Coremasterbase_address_extendedgoogle_accounthr_recruitment_skillshttp_routingl10n_bgl10n_din5008l10n_eg_edi_etal10n_gcc_invoicel10n_gcc_posl10n_hkl10n_hrl10n_it_edil10n_kel10n_latam_checkl10n_rol10n_sa_posl10n_siphone_validationportalpos_stripe

This update removes unnecessary content from several app manifest files and adds an automated check to keep them concise in the future. It helps maintainers more easily spot meaningful custom behavior and reduces future cleanup work, with no expected impact on day-to-day users.

[IMP] l10n_be_hr_payroll_fleet: add fuel info on contract form view

PR #34883

Enterprisemasterl10n_be_hr_payroll_fleet

Employee contract forms in the Belgian payroll fleet module now show the vehicle fuel type. This helps HR and payroll teams see relevant fleet information directly on the contract, reducing the need to look it up elsewhere.

Original PR description

This commit adds the fuel type in the form view of hr.contract.

task-3092624

#payroll#fleet#contracts#Belgium

Bug Fixes(1)

Resolved issues and error corrections

[FIX] stock_barcode: test_gs1_receipt_lot_serial

PR #35046

Enterprisemasterstock_barcode

This fixes an automated barcode receipt test so it waits until the confirmation button is ready before proceeding. It helps prevent false test failures in the inventory barcode workflow, improving confidence in future updates without changing user-facing behavior.

Original PR description

The tour `test_gs1_receipt_lot_serial` tests we can manually write and confirm a barcode, but by checking that, it doesn't wait the "Apply" button is clickable (it's disabled if the input is empty).

runbot error id: 13671

#barcode#inventory#testing

Refactoring(1)

Code cleanup and technical improvements

[FIX] *: clean manifests

PR #34903

Enterprisemasteraccount_bank_statement_import_camtaccount_bank_statement_import_csvaccount_bank_statement_import_ofxcrm_helpdeskdocuments_fsml10n_be_hr_payroll_dimonal10n_mx_edi_stock_40test_l10n_be_hr_payroll_accountwebsite_appointment_crmwebsite_sale_renting_product_configurator

This update removes unnecessary empty configuration entries from several Odoo app manifests. It does not change business functionality, but keeps module definitions cleaner and easier to maintain.

Other(31)

Miscellaneous changes

[FW][FIX] hr_recruitment: show properly message field in Send Email

PR #108102

Coremasterhr_recruitment

The field was not taking the full size it was allowed to, hence it was not possible to write the content. task-3087717 Forward-Port-Of: odoo/odoo#108057

Original PR description

The field was not taking the full size it was allowed to, hence it was not possible to write the content.

task-3087717

Forward-Port-Of: odoo/odoo#108057

[FW][FIX] stock: t-foreach without index

PR #105182

The tour `test_gs1_receipt_lot_serial` tests we can manually write and confirm a barcode, but by checking that, it doesn't wait the "Apply" button is clickable (it's disabled if the input is empty). runbot error id: 13671

Steps to reproduce the bug: - Installe `sale_stock` - Create a storable product “P1” - Create a SO: - Add the product “P1” - Save - click on `See the Forecasted View.` Problem: A User error is triggered `”Record does not exist or has been deleted. (Record: product.template(43,), User: 2)”` Because the id of `product.product` is used in the model `product.template` When the button is clicked, https://github.com/odoo/odoo/blob/73155293d503e3a9dd65898b8e1ac489e279c33c/addons/sale_stock/static/src/widgets/qty_at_date_widget.xml#L63 The `openForecast` function on the js side is triggered, the correct report and model are set: https://github.com/odoo/odoo/blob/73155293d503e3a9dd65898b8e1ac489e279c33c/addons/sale_stock/static/src/widgets/qty_at_date_widget.js#L16-L19 Then, the `_getReportValues` function is triggered, in which we check if it is a template or a variant. So we get the `active.model` from the context https://github.com/odoo/odoo/blob/e176ba0b77aa692c16160a1e7bf471e19719e3fb/addons/stock/static/src/stock_forecasted/stock_forecasted.js#L40 but then we set the `res.model` to false, because `original_action` is not false and `originalContextAction` has no `active.model` https://github.com/odoo/odoo/blob/e176ba0b77aa692c16160a1e7bf471e19719e3fb/addons/stock/static/src/stock_forecasted/stock_forecasted.js#L46-L49 so : https://github.com/odoo/odoo/blob/e176ba0b77aa692c16160a1e7bf471e19719e3fb/addons/stock/static/src/stock_forecasted/stock_forecasted.js#L52 Will be true opw-3100964 Forward-Port-Of: odoo/odoo#108113

# Current behaviour In the project update dashboard, invoices and bills that are created directly (without sales order or purchase order) are not taken into account in the calculations for profits/costs. # Expected behaviour They should be taken into account, as long as the line on them has the analytic account line on it. # Steps to reproduce - Install Project, Sales, Purchase, Accounting - Activate "Analytic Accounting" in Settings - Create a new Project and create a new analytic account for the project - Create a Bill with a product (storable/consumable) and the analytic account on the line - Post the bill - Go to your project update dashboard and notice the cost of the bill is not taken into account, but we do have a smart button that goes to the bills # Reason for the problem Profits/Costs calculations are done based on the sales/purchase orders, missing the "orphaned" invoices and bills. A side effect of this problem, storable products on sales are also not taken into account, since Sales Orders don't have an analytic account per line before version 16, unless that product is a service (all services intrinsically have an analytic account) # Fix Get all invoices/bills that have lines with the project's analytic account, and removing from those the lines that were already accounted for. # Affected versions - saas-15.3 - 16.0 - master --- opw-3058198 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108110 Forward-Port-Of: odoo/odoo#107307

## Rationale Some ir_logging created during a test have a pathname pointing to case.py, runner.py,... This is mainly a side effect of the way unitest manages errors and mainly in subtests: an exception inside a subtest will have only a partial traceback, not containing the line triggering the error in the test method. This can also affect debugging since a part of the stack is missing. ## Expected tracebacks example ```python def test_assertQueryCount(self): with self.assertQueryCount(system=0): self.env.cr.execute('SELECT 1') ``` Before/After ```patch Traceback (most recent call last): + File "/home/xdo/osrc/14.0/odoo/odoo/addons/base/tests/test_test_suite.py", line 178, in test_assertQueryCount + self.env.cr.execute('SELECT 1') + File "/usr/lib/python3.8/contextlib.py", line 120, in __exit__ + next(self.gen) File "/home/xdo/osrc/14.0/odoo/odoo/tests/common.py", line 458, in assertQueryCount self.fail(msg % (login, count, expected, funcname, filename, linenum)) AssertionError: Query count more than expected for user __system__: 1 > 0 in test_assertQueryCount at base/tests/test_test_suite.py:178 ``` Another simpler example without contextmanager magic and a higer stack: ```python def test_call_stack_subtest(self): def a(): b() def b(): with self.subTest(): c() def c(): raise Exception('This is an error') a() ``` Before/After ```patch Traceback (most recent call last): + File "/home/xdo/osrc/14.0/odoo/odoo/addons/base/tests/test_test_suite.py", line 174, in test_call_stack_subtest + a() + File "/home/xdo/osrc/14.0/odoo/odoo/addons/base/tests/test_test_suite.py", line 168, in a + b() File "/home/xdo/osrc/14.0/odoo/odoo/addons/base/tests/test_test_suite.py", line 171, in b c() File "/home/xdo/osrc/14.0/odoo/odoo/addons/base/tests/test_test_suite.py", line 173, in c raise Exception('This is an error') Exception: This is an error ``` This can also have a slight impact on test ran with decorators (see test_with_decorators): ```patch Traceback (most recent call last): + File "<decorator-gen-118>", line 2, in test_with_decorators File "/home/xdo/osrc/14.0/odoo/odoo/tests/common.py", line 1583, in _users func(*args, **kwargs) File "<decorator-gen-117>", line 2, in test_with_decorators File "/home/xdo/osrc/14.0/odoo/odoo/tests/common.py", line 1606, in warmup func(*args, **kwargs) File "/home/xdo/osrc/14.0/odoo/odoo/addons/base/tests/test_test_suite.py", line 130, in test_with_decorators raise Exception('This is an error') Exception: This is an error ``` Even if in this case, this information is not really relevant, this is more "correct" Note that for this last example we could decide to remove the decorator part. This could actually be done by tweaking the `# remove traceback root part` but this is more a new specification to do than a change that should be done in the scope of this test. Having this information could be actually useful/ ## Solution Finding a solution for this was not trivial and lead to a solution quite defendant on the unittest implementation, but there wasn't any clean way to hook inside the library, and this was actually an opportunity to make another improvement. The OdooTestResult was historically created in order to log failure as close as possible from the test logs, in order to keep the temporal information of when the error occurred. But the logs are still only outputted at the end of the test method. This was mainly a problem for subtests, and the need to get the full traceback exactly when the error occurs and so on hooks where the information occurs gives the possibility to output the error when it occurs. ### unitest main interesting parts How _outcome is managed and tests parts ar ran: ```python outcome = _Outcome(result) try: self._outcome = outcome with outcome.testPartExecutor(self): self._callSetUp() if outcome.success: outcome.expecting_failure = expecting_failure with outcome.testPartExecutor(self, isTest=True): self._callTestMethod(testMethod) outcome.expecting_failure = False with outcome.testPartExecutor(self): self._callTearDown() self.doCleanups() # also uses testPartExecutor for test, reason in outcome.skipped: self._addSkip(result, test, reason) self._feedErrorsToResult(result, outcome.errors) ... outcome.errors.clear() ``` How a subtest contextmanager works: ```python @contextlib.contextmanager def subTest(self, msg=_subtest_msg_sentinel, **params): ... with self._outcome.testPartExecutor(self._subtest, isTest=True): yield ... ``` testPartExecutor usage of _outcome ```python class _Outcome(object): def __init__(self, result=None): self.result = result self.errors = [] ... @contextlib.contextmanager def testPartExecutor(self, test_case, isTest=False): ... try: yield ... except: exc_info = sys.exc_info() ... self.errors.append((test_case, exc_info)) ``` Those snipets shows almost all usages of `Tescase._outcome.errors` and testPartExecutor ### Proposed solution We can substitute Tescase._outcome.errors in a custom object and fix the traceback on append. Moreover, also replaces the list append behaviour call _feedErrorsToResult immediatly. Then the only last part is to combine the exception traceback with the current frame without adding to much noise. This is done by `complete_tb`, finding a common frame between the traceback and the current traceback and stitching them together. The current solution is maybe not the cleanest but is trying to take care of as much use case as possible, improvements are still possible. Alternative solutions could have been to override subTest but this would have created more duplicated code from unittest, or monkey patch the _Outcome class with the same. ## Side changes - users.wrapper was renamed in users._users to improve traceback readability. (expecting other black magic alternative fix proposal for this one actually) - `getErrorCallerInfo` will ensure that we have the root test to get the method name. Before that the test could be a **subtest** and the method name will always be `runTest`in this case and the caller info would fallback on `logger.findCaller` - postpone return_infos to the end of the traceback. This is mainly to avoid getting an intermediate frame but not the root frame. With this pr, some of this logic could event be simplified since the frame we are interested in is most likely the last one. Most of the logic in OdooTestResult could maybe be simplified, moved or removed with this pr but this is a target master. ## To discuss Note that the frame to traceback transformation was a concern about reference cycles. Strongly believing in the garbage collector but looking at a little piece of code in testPartExecutor ... ```python # explicitly break a reference cycle: exc_info = None ``` ... this may need to be discussed. ## To be done before merging - [x] Add a test for setup failures - [x] Add a test for teardown failures - [x] Add a test for cleanup failures - [x] more assertions on logged errors, mainly the traceback. - [x] combination of all and error order, mainly with subtests with logs Forward-Port-Of: odoo/odoo#108170 Forward-Port-Of: odoo/odoo#107572

Improvements(3)

[IMP] event: add avatar widget to responsible

[IMP] test_lint: detect useless manifest content

[IMP] l10n_be_hr_payroll_fleet: add fuel info on contract form view

Bug Fixes(1)

[FIX] stock_barcode: test_gs1_receipt_lot_serial

Refactoring(1)

[FIX] *: clean manifests

Other(31)

[FW][FIX] hr_recruitment: show properly message field in Send Email

[FW][FIX] stock: t-foreach without index

Improvements(3)

[IMP] event: add avatar widget to responsible

[IMP] test_lint: detect useless manifest content

[IMP] l10n_be_hr_payroll_fleet: add fuel info on contract form view

Bug Fixes(1)

[FIX] stock_barcode: test_gs1_receipt_lot_serial

Refactoring(1)

[FIX] *: clean manifests

Other(31)

[FW][FIX] hr_recruitment: show properly message field in Send Email

[FW][FIX] stock: t-foreach without index

[FW][FIX] portal: fix user dropdown in boxed header template

[FW][FIX] mrp: kanban card settings fix

[FW][FIX] l10n_ph: moves_to_export field alignment

[FW][CLA] Updating CLA initos.md

[FW][FIX] website_sale: show empty cart icon before starting animation

[FW][FIX] base: prevent uninstalling of web module

[FW][FIX] auth_signup: fix password reset

[FW][FIX] note: support link in note created from the systray

[FW][FIX] web_editor: prevent html in odoo field

[FW][FIX] stock: access the forecast report from an SOL

[FW][FIX] payment_stripe: use idempotency key only when offline

[FW][FIX] web_editor: enable the use of the save option only on snippet

[FW][FIX] website_livechat:tests: fix chatbot flow step "Hello! I'm a bot"

[FW][FIX] account: required default account on journal

[FW][I18N] website_sale_comparison: add source terms for view placeholder

[FW][FIX] web_editor: command prompt not displaying on focus

[FW][FIX] project: account invoices/bills in project update dashboard

[FW][FIX] account: aml's `partner_id` modified after the move has been posted when using the hash

[FW][FIX] hr: fix the detailed reason width in Employee Termination wizard

[FW][FIX] web_editor: ensure correct root for wysiwyg in iframe

[FW][FIX] mrp_subcontracting: convert supplier price into company currency

[FW][FIX] tests: better test traceback

[FW][FIX] website: fix resizing columns out of parent

[FW][FIX] l10n_co_edi: bump narration limit

[FW][FIX] documents_spreadsheet: indeterministic test link chart to odoo …

[FW][FIX] account_accountant: opening reconciliation in canceled entries

[FW][FIX] knowledge: display permission panel loader

[FW][FIX] marketing_automation: fix activity view

[FW][FIX] stock_barcode: scan location after package