Monday, December 19, 2022
39 changes · master
Enhancements to existing features
New tags in the Notes app are now automatically given a random color. This ensures they show up properly in the Kanban view, making tags visible and usable without extra setup.
Original PR description
Currently, when we creating a tag, it does not appear in the Kanban view because the tag does not have a default color. This commit solve above problem by adding default random color in tag. task-3089296
This update removes unnecessary view type metadata from many Odoo screen definitions. It simplifies internal configuration and helps keep multiple apps easier to maintain without changing day-to-day user workflows.
Original PR description
remove type from ir.ui.view records related: https://github.com/odoo/enterprise/pull/35031 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change adds coverage to ensure customers can open record links from emails in the right place: the internal system when authorized, or the customer portal otherwise. It also checks that modified links are blocked, helping protect record access.
Original PR description
The tests consist in sending a mail related to a record to a customer and checking that the record can be viewed through the embedded link: - either in the backend if the user is connected and has the right to - or in the portal otherwise Task-2797311 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Thread stack dumps now include extra timing and query details, helping technical teams spot where time is spent during troubleshooting. This improves visibility for support and operations without changing normal user workflows.
Original PR description
Before this commit: Thread details gave information regarding the database the UID and the URL. After this commit: It also informs on the "performance times": - `qc` = query count - `qt` = query time - `pt` = python time. It should in theory be "remaining time", but it won't be use as its acronym `rt` is too ambiguous/confusing --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update removes an outdated technical setting from view records across several Odoo apps. The change keeps configuration files cleaner and better aligned with the current platform behavior, with no expected day-to-day impact for users.
Original PR description
remove type from ir.ui.view records
Resolved issues and error corrections
This fixes visual regressions in HTML editor fields after a recent layout change. Users will see correct borders, spacing, and editor height behavior again in areas such as Notes, CRM forms, and the mail composer.
Original PR description
Commit [1] added a div around the `.note-editable` node of the html editor. This broke some css rules. For instance, the html field in form view's notebooks should have a transparent bottom border when focused, this was no longer the case (e.g. crm lead form view). Moreover, we sometimes want to control the height of the editor (e.g. in Notes or in the mail full composer). That was broken as well due to the added div. This commit fixes those issues. It also fixes a typo in a selector. [1] https://github.com/odoo/odoo/commit/60ac6be0d3545# Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
The email marketing editor no longer has its own separate option for resizing images horizontally. This avoids duplicate behavior because the same capability is already available through the standard website builder tools.
Original PR description
`mass_mailing` had a special snippet option just for resizing images horizontally. Since this exists in the website builder as well, there is no need for a separate snippet with a different behavior for `mass_mailing`. task-2615373 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
To Reproduce ============ - change language to Arabic Syria - go to any form that has a Date field and try to change the date the Date won't change Problem ======= the default numbering system of Arabic Syria is not defined so we take the default one which is `latn`, when parsing dates using this numbering system we got a parsing error because `latn` is not compatible with Arabic Date. Solution ======== Numbers in Arabic Syria have the same format as the numbers in Arabic (Default o
Original PR description
To Reproduce ============ - change language to Arabic Syria - go to any form that has a Date field and try to change the date the Date won't change Problem ======= the default numbering system of Arabic Syria is not defined so we take the default one which is `latn`, when parsing dates using this numbering system we got a parsing error because `latn` is not compatible with Arabic Date. Solution ======== Numbers in Arabic Syria have the same format as the numbers in Arabic (Default one), so we add Arabic Syria to the pattern. opw-3081285 Forward-Port-Of: odoo/odoo#107810
A spelling mistake in the Belgian payroll individual accounts label was corrected. This improves clarity for users by ensuring the field name appears correctly in the interface.
Original PR description
The field "Individual accounts" was misspelled as "Indivual account". FW - port: master opw-3100494
Opening Knowledge articles with read-only access no longer causes the app to crash. The update safely handles cases where editing controls, such as the emoji button, are not available to the user.
Original PR description
This commit fixes a crash of the application when trying to open an article on which the user can only read, or when trying to open another article from one that he can only read. This was linked to the fact the new `openArticle` function tried to access the emoji button of the said article even though it doesn't exist for the user that is only able to read. Now we check if the button exists before trying to modify its classes. task-3076075
Before this commit, following this flow: - Add a form - Add a selection field - Add an option starting with a number - Save => The created form's option value is only the number From the website_form options, the options HTMLElement of a form field are generated using the field's records ids for their html element value attribute (see FormEditor._renderField). When [1] refactored the website_form options to use a generic ListUserValueWidget, the list records id computation changed
Original PR description
Before this commit, following this flow: - Add a form - Add a selection field - Add an option starting with a number - Save => The created form's option value is only the number From the website_form options, the options HTMLElement of a form field are generated using the field's records ids for their html element value attribute (see FormEditor._renderField). When [1] refactored the website_form options to use a generic ListUserValueWidget, the list records id computation changed to use parseInt instead of strings. This commit changes the detection of parsable int to match only strings that are made only of digits, and less than 16 of them so that their value is not lost. [1]: https://github.com/odoo/odoo/commit/9304f8fa7bb94f21dd4caa83f9679ffd1642691b opw-2980760 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#107831 Forward-Port-Of: odoo/odoo#103825
Before this commit, the values of selection `service_policy` field are given with a function and so the choices are dynamically given according to the modules installed and the project settings. The problem is the string for those values are not translated because the ORM cannot do it automatically since the values are dynamically given and so those string should be translated with `_` function. This commit translates the string of those values with `_` function to be sure the strings are tra
Original PR description
Before this commit, the values of selection `service_policy` field are given with a function and so the choices are dynamically given according to the modules installed and the project settings. The problem is the string for those values are not translated because the ORM cannot do it automatically since the values are dynamically given and so those string should be translated with `_` function. This commit translates the string of those values with `_` function to be sure the strings are translated in the language of the current user. X-original-commit: 50ffc339991b1 Forward-Port-Of: odoo/odoo#108135
The method domain_remove_leaf is used to remove leaves from a domain corresponding to given fields. The particular case ['|', leaf_to_remove, leaf_to_remove] is replaced by [true_leaf] however the check of the second element of this subdomain was incorrectly done. This fix addresses this issue. Fixes https://github.com/odoo/odoo/pull/93225 Forward-Port-Of: odoo/odoo#108164
Original PR description
The method domain_remove_leaf is used to remove leaves from a domain corresponding to given fields. The particular case ['|', leaf_to_remove, leaf_to_remove] is replaced by [true_leaf] however the check of the second element of this subdomain was incorrectly done. This fix addresses this issue. Fixes https://github.com/odoo/odoo/pull/93225 Forward-Port-Of: odoo/odoo#108164
**[IMP] l10n_it_edi: Tax exemption kind N7 description** New specs from October 1st 2022: https://www.doxee.com/it/blog/fatturazione-elettronica/nuove-specifiche-tecniche-per-la-fattura-elettronica-2022-in-vigore-dal-1-ottobre/ The description of Tax Exemption kind N7 is changed to: "IVA assolta in altro stato UE (prestazione di servizi di telecomunicazioni, tele-radiodiffusione ed elettronici ex art. 7-octies, comma 1 lett. a, b, art. 74-sexies DPR 633/72)" Courtesy of Tony Mascii
Original PR description
**[IMP] l10n_it_edi: Tax exemption kind N7 description** New specs from October 1st 2022:…
**[IMP] l10n_it_edi: Tax exemption kind N7 description** New specs from October 1st 2022: https://www.doxee.com/it/blog/fatturazione-elettronica/nuove-specifiche-tecniche-per-la-fattura-elettronica-2022-in-vigore-dal-1-ottobre/ The description of Tax Exemption kind N7 is changed to: "IVA assolta in altro stato UE (prestazione di servizi di telecomunicazioni, tele-radiodiffusione ed elettronici ex art. 7-octies, comma 1 lett. a, b, art. 74-sexies DPR 633/72)" Courtesy of Tony Mascii **[FIX] l10n_it_edi: San Marino self-invoice from paper** San Marino is a very small country completely enclosed in Italy. That country has special agreements with Italian as far as e-invoicing is concerned. When a paper invoice is received from San Marino, any Italian company has the responsability to submit that invoice integrated with Italian tax information to the Tax Agency, indicating in the e-invoice filling the Document Type field with the special value 'TD28'. **[IMP] l10n_it: Round globally by default in Italian CoA** The Italian Tax Agency (and therefore any business in Italy) makes it mandatory to compute roundings based on a Round Globally policy. Invoices not rounded globally are refused by Italian EDI. **[IMP] l10n_it, l10n_it_edi, l10n_it_stock_ddt: Deferred invoice** Context: The Italian State allows making one invoice per month to recurrent clients buying goods several times a month. This process is called "Deferred invoice" (Fattura differita) in contrast to Direct invoice (Fattura immediata). To enable this, the vendor must issue one Transport Document per client delivery. The Document is attached to the goods themselves. Many Transport Documents (DDTs) delivered can then be invoiced together in a single invoice up to the 15th day of the following month. This task allows the Italian EDI to correctly communicate the Deferred invoices data to the Tax Authority An export test has been added. Official FAQ (n.21) - https://www.agenziaentrate.gov.it/portale/documents/20143/287582/15+Tutte+le+faq+%28aggiornate+al+11+maggio+2021%29+.pdf/2db944b9-22c3-fa80-7c14-dfa0bcbbd65e Reference task link: https://www.odoo.com/web#model=project.task&id=1914640 Forward-Port-Of: odoo/odoo#106797
Since 2515482d5a70, the duration expected of a workorder was always set to the real duration at the validation of the workorder. This commit ensure the duration expected is left unchanged even if the date_planned_finished is updated. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108189
Original PR description
Since 2515482d5a70, the duration expected of a workorder was always set to the real duration at the validation of the workorder. This commit ensure the duration expected is left unchanged even if the date_planned_finished is updated. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108189
This PR (https://github.com/odoo/odoo/pull/105748) introduced a bug by having an extra `OR` operator in the domain. This commit fixes the error. opw-3099849 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#107819
Original PR description
This PR (https://github.com/odoo/odoo/pull/105748) introduced a bug by having an extra `OR` operator in the domain. This commit fixes the error. opw-3099849 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#107819
# Current behaviour Project Update doesn't take into consideration the `analytic_distribution` percentage of the analytic_account on the line of the purchase orders. # Expected behaviour Account correctly for the % of the analytic account for the project, just like in the Accounting app. # Steps to reproduce - Install Accounting, Sales, Purchase, Timesheet, Inventory, Project - Activate "Analytic accounts" in Settings - Create a product service which is creating a project at sales -
Original PR description
# Current behaviour Project Update doesn't take into consideration the `analytic_distribution` percentage of the analytic_account on the line of the purchase orders. # Expected behaviour Account…
# Current behaviour Project Update doesn't take into consideration the `analytic_distribution` percentage of the analytic_account on the line of the purchase orders. # Expected behaviour Account correctly for the % of the analytic account for the project, just like in the Accounting app. # Steps to reproduce - Install Accounting, Sales, Purchase, Timesheet, Inventory, Project - Activate "Analytic accounts" in Settings - Create a product service which is creating a project at sales - Create a new SO, add the service, confirm the SO and invoice - Create a new PO, add some random product, on that same line add 2 analytic account, 50% of the SO project we just created, and 50% from any other. - Confirm the PO - Go to the SO's project update section, observe the cost is 100% of the line cost, not 50% # Reason for the problem `analytic_distribution` ratios are not taken into account when calculation the costs of the project. # Fix Get the ratio of the `analytic_distribution` and multiply by it when processing the costs # Affected versions - 16.0 - master --- opw-3079537 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#107422
This module implements communication with the fiscal device for submitting invoices to the KRA (Kenya Revenue Authority). The device supported in this module is the Tremol G03. -- COMMUNICATION FLOW SUMMARY -- 1. "Send Invoice To Device" on account move is clicked 2. l10n_ke_action_cu_post triggers a client action, with serialised invoice data. (more details below) 3. The client action uses the 'post_send' function defined in javascript to forward the request to the /hw_proxy/l10n_ke_cu_se
Original PR description
This module implements communication with the fiscal device for submitting invoices to the KRA (Kenya Revenue Authority). The device supported in this module is the Tremol G03. -- COMMUNICATION FLOW…
This module implements communication with the fiscal device for submitting invoices to the KRA (Kenya Revenue Authority). The device supported in this module is the Tremol G03. -- COMMUNICATION FLOW SUMMARY -- 1. "Send Invoice To Device" on account move is clicked 2. l10n_ke_action_cu_post triggers a client action, with serialised invoice data. (more details below) 3. The client action uses the 'post_send' function defined in javascript to forward the request to the /hw_proxy/l10n_ke_cu_send endpoint on the proxy server (more details below) 4. The proxy server wraps the serialised data with the appropriate bytes (for instance, a couple of a checksum bytes), and sends them to the device through serial communication (more details below) 5. The data returned from the fiscal device is communicated back in the request. The client action 'post_send' then triggers the 'l10n_ke_cu_response' with an rpc call, with the aforementioned data from the fiscal device (more details) 2. The module l10n_ke_edi_tremol inherits from the account_move model in order to provide methods for serialising the data of the account_move and sending it to the proxy server. Fields have been added to the product template to define the HS Code and HS Name (data which is required by the KRA in some circumstances). A field has also been added to the company defining the address of the proxy server. The fields added on the account move are populated by the data returned by the fiscal device, this includes the device serial number, the invoice number on the device, the URL of the invoice on the KRA web portal, and the date/time the invoice was signed. 3. Communication between the client database and the proxy server is defined using a client action defined in l10n_ke_edi_tremol/static/src/js/send_invoice.js. This allows users who aren't on-premise to communicate with the device, provided the proxy is accessible on the network that the user is on. 4. The proxy server is an intermediary server that should be connected to the tremol G03, and running the IOT drivers from hw_drivers. The driver that supports communication between the proxy server and the fiscal device has been defined in this commit inside of hw_drivers/iot_handlers/drivers//L10nKeEDISerialDriver.py. The proxy server can be run on the IOT box, or on odoo community by running: ./odoo-bin addons-path=.... -d dbname --load hw_drivers --proxy-mode ** all messages are encoded/decoded with cp1251, as defined in the protocol. The company vat code is sent along with the request to compare that sent with that of the device. The 'serial_number' of the device is always returned along with the request, since it is required for the invoice details, and it is retrieved as part of the query to find the registered VAT code on the device. --- DATA and VIEWS --- product_view: adds HS Name, and HS Code on the product product and product template form views. report_invoice: adds to the invoice qweb template such that a section including the fiscal device / KRA details is included at the bottom of the invoice when the invoice is rendered as a pdf. res_config_settings_view: adds makes the proxy address field editable from the config settings. account_move_view: add a tab for the tremol device details and the qr code on the account move form view. The KRA invoice number is also added as an optional field on the account move tree view, and the invoice search view is inherited to make this field searchable too. (l10n_ke) account_tax_report_data, account_tax_template_data: The tax report is defined for Kenya, and tax tags that link to the lines on this tax report are defined on the existing taxes. This allows the classification of the tax, between zero-rated and exempt, during the serialisation. task-id: 2950308 Forward-Port-Of: odoo/odoo#106653
Only show the stress-days of the enabled companies. task-3098721 Forward-Port-Of: odoo/odoo#107754
Original PR description
Only show the stress-days of the enabled companies. task-3098721 Forward-Port-Of: odoo/odoo#107754
price list report is not aligning properly in html and pdf print out due to offset class. Steps to reproduce: 1. open any products 2. click Get Pricelist Report from action button https://user-images.githubusercontent.com/27989791/208172949-ecbda959-a9a9-403b-b81c-2039a037a7ed.mp4 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108234
Original PR description
price list report is not aligning properly in html and pdf print out due to offset class. Steps to reproduce: 1. open any products 2. click Get Pricelist Report from action button https://user-images.githubusercontent.com/27989791/208172949-ecbda959-a9a9-403b-b81c-2039a037a7ed.mp4 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108234
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108259
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108259
**Description of the issue/feature this PR addresses:** upon creating a work entry from the form view without setting the To and Period value and on clicking the create button exception is raised as the value for the required field contract_id(which is computed/set based on to and period) is not set. 1. Payroll -> Work Entries -> Work Entries 2. Switch to list view, click create 3. Keeping To and Duration field empty, click create button  is not set. 1. Payroll -> Work Entries -> Work Entries 2. Switch to list view, click create 3. Keeping To and Duration field empty, click create button  **Impacted Versions**: 14.0, 15.0 & 16.0 **Current behavior before PR:** exception is raised on creating work entry from the form view without entering to and period values in the form. **Desired behavior after PR is merged:** exception wont be raised --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#105375
add missing neutralization script for module `l10n_ke_edi_tremol` introduced in Odoo 16 with b0be9e074a1ecf1f6de7a03c71df0c63868501e3 Forward-Port-Of: odoo/odoo#107503
Original PR description
add missing neutralization script for module `l10n_ke_edi_tremol` introduced in Odoo 16 with b0be9e074a1ecf1f6de7a03c71df0c63868501e3 Forward-Port-Of: odoo/odoo#107503
Description of the issue/feature this PR addresses: in ir.profile model currently the qweb field is not getting invisible when the value is empty. Settings -> Technical -> Database Structure -> Profiling Current behavior before PR: field is not getting invisible when there is no value Desired behavior after PR is merged: field will be invisible when there is no value --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odo
Original PR description
Description of the issue/feature this PR addresses: in ir.profile model currently the qweb field is not getting invisible when the value is empty. Settings -> Technical -> Database Structure -> Profiling Current behavior before PR: field is not getting invisible when there is no value Desired behavior after PR is merged: field will be invisible when there is no value --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108192 Forward-Port-Of: odoo/odoo#107051
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#103722
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#103722
This commit fixes two things: - The owl compatibility layer adds an `on` and `off` method on owl's EventBus so that it can keep being used as it used to in owl 1. To do this, it needs to keep track of the the callbacks that are attached to it and by whom. To do this it keeps a Map where the "owners" are keys. When calling `off` to remove event listeners, we remove the callbacks but did not remove the owner from the Map, causing the EventBus to always hold a strong reference to any objec
Original PR description
This commit fixes two things: - The owl compatibility layer adds an `on` and `off` method on owl's EventBus so that it can keep being used as it used to in owl 1. To do this, it needs to keep track…
This commit fixes two things: - The owl compatibility layer adds an `on` and `off` method on owl's EventBus so that it can keep being used as it used to in owl 1. To do this, it needs to keep track of the the callbacks that are attached to it and by whom. To do this it keeps a Map where the "owners" are keys. When calling `off` to remove event listeners, we remove the callbacks but did not remove the owner from the Map, causing the EventBus to always hold a strong reference to any object that was given as the owner to the `on` method, preventing the item from being garbage collected. Objects that do this are typically components, and components hold a reference to their owl application that contains the entire tree of components. This was particularly problematic in tests where components are created and destroyed at a rapid pace. - The mock websocket creates a MessageChannel so that it can mock the server side of the websocket, but it never closes that MessageChannel's MessagePorts, which can cause garbage collection to be slow to happen [1] (in practice it looks like these are basically never garbage collected unless closed). This commit registers a cleanup to close the message ports after the execution of the current test. [1]: https://html.spec.whatwg.org/dev/web-messaging.html#ports-and-garbage-collection Forward-Port-Of: odoo/odoo#108184
An error is raised when trying to create sale order lines with tax on a sale order without any customer (with debug mode enabled) Steps to reproduce: 1. Install Sales 2. Create a new sale order without any customer 3. Add a new sale order line and a tax to this line 4. An error is raised `Invalid props for component 'TaxGroupComponent': 'currency' is undefined` Solution: Make prop `currency` optional (and format the total without any currency) Problem: When trying to render the ta
Original PR description
An error is raised when trying to create sale order lines with tax on a sale order without any customer (with debug mode enabled) Steps to reproduce: 1. Install Sales 2. Create a new sale order without any customer 3. Add a new sale order line and a tax to this line 4. An error is raised `Invalid props for component 'TaxGroupComponent': 'currency' is undefined` Solution: Make prop `currency` optional (and format the total without any currency) Problem: When trying to render the tax total of a sale order without any pricelist, an error is raised as the `currency` prop is missing, which depends on the pricelist opw-3098020 Forward-Port-Of: odoo/odoo#108207
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108272
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108272
Reexport everything, getting the new `odoo-python` comments Forward-Port-Of: odoo/odoo#108071
Original PR description
Reexport everything, getting the new `odoo-python` comments Forward-Port-Of: odoo/odoo#108071
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108289
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108289
# Description of the issue/feature this PR addresses: Bug with the first print of a PDF with wkhtmltopdf and permanently crash with kwkhtmltopdf https://github.com/acsone/kwkhtmltopdf # Current behavior before PR: When printing a pdf on a new database, the css in the header is missing You can see it in the log of odoo, that the css is missing ``` werkzeug: "GET /web/assets/200-c71dbab/web.report_assets_pdf.min.css HTTP/1.1 404 - 2 0.002 0.006 WARNING odoo odoo.addons.base.mode
Original PR description
# Description of the issue/feature this PR addresses: Bug with the first print of a PDF with wkhtmltopdf and permanently crash with kwkhtmltopdf https://github.com/acsone/kwkhtmltopdf # Current…
# Description of the issue/feature this PR addresses: Bug with the first print of a PDF with wkhtmltopdf and permanently crash with kwkhtmltopdf https://github.com/acsone/kwkhtmltopdf # Current behavior before PR: When printing a pdf on a new database, the css in the header is missing You can see it in the log of odoo, that the css is missing ``` werkzeug: "GET /web/assets/200-c71dbab/web.report_assets_pdf.min.css HTTP/1.1 404 - 2 0.002 0.006 WARNING odoo odoo.addons.base.models.ir_actions_report: wkhtmltopdf: b'Exit with code 1 due to network error: ContentNotFoundError\n' ``` So the first pdf printed is invalid, but as the report is printed the asset is commited in db and the next print will be valid. If you use kwkhtmltopdf, as the pdf is not generated (kwkhtmltopdf is more strict), then you have an error instead of a broken pdf and the asset is not commit, so you printing is always broken. (note before that PR https://github.com/odoo/odoo/pull/104594, the asset was commited at the end even if we had an error) # Desired behavior after PR is merged: The first print is ok, kwkhtmltopdf is always working # Note A better implementation for the report will be to isolate the asset generation in a new cursor, to avoid commiting in the current cursor, but this is a bigger task. @rco-odoo @pivi-odoo @nboulif @Julien00859 @vrenaville @sbidoul @pedrobaeza @legalsylvain --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108261
Enterprise part of odoo/odoo#108071 Forward-Port-Of: odoo/enterprise#35036
Original PR description
Enterprise part of odoo/odoo#108071 Forward-Port-Of: odoo/enterprise#35036
Form view archs should not contain `t-att-` directives, as it is not qweb. Worse, they can't use implementation details of the js view used to render it (in this case `isBlocked`, even though it was not defined, so always falsy). Forward-Port-Of: odoo/enterprise#33740
Original PR description
Form view archs should not contain `t-att-` directives, as it is not qweb. Worse, they can't use implementation details of the js view used to render it (in this case `isBlocked`, even though it was not defined, so always falsy). Forward-Port-Of: odoo/enterprise#33740
Forward-Port-Of: odoo/enterprise#34932 Forward-Port-Of: odoo/enterprise#34896
Original PR description
Forward-Port-Of: odoo/enterprise#34932 Forward-Port-Of: odoo/enterprise#34896
This commit corrects a typo in the template for the personalised article of each user. task-3100145 Forward-Port-Of: odoo/enterprise#34951
Original PR description
This commit corrects a typo in the template for the personalised article of each user. task-3100145 Forward-Port-Of: odoo/enterprise#34951
When creating a QC from a SML, if the SML has a lot name, it will be also defined on the new QC. However, when updating the lot name of the SML, nothing updates the one of the QC OPW-3081060 Forward-Port-Of: odoo/enterprise#35058 Forward-Port-Of: odoo/enterprise#34966
Original PR description
When creating a QC from a SML, if the SML has a lot name, it will be also defined on the new QC. However, when updating the lot name of the SML, nothing updates the one of the QC OPW-3081060 Forward-Port-Of: odoo/enterprise#35058 Forward-Port-Of: odoo/enterprise#34966
The fields l10n_it_codice_fiscale and l10n_it_tax_system are in l10n_it_edi, which is not a requirement for l10n_it_reports. Furthermore, they serve no purpose in the test, so they can be removed. This fixes the nightly `l10n_all` build for `l10n_it_reports`. It also affects v16 but it's masked by the `auto_install` of the `l10n_it_edi` there. Forward-Port-Of: odoo/enterprise#34905
Original PR description
The fields l10n_it_codice_fiscale and l10n_it_tax_system are in l10n_it_edi, which is not a requirement for l10n_it_reports. Furthermore, they serve no purpose in the test, so they can be removed. This fixes the nightly `l10n_all` build for `l10n_it_reports`. It also affects v16 but it's masked by the `auto_install` of the `l10n_it_edi` there. Forward-Port-Of: odoo/enterprise#34905
Steps to reproduce: - Go to settings -> technical -> sequences & identifiers -> sequences -> and change the number of 'next number' - Create a new ticket in helpdesk - Go to helpdesk portal Issue: The id of the ticket is shown instead of the reference Cause: It's the id which is passed in the templates Solution: - Pass the ticket_ref in the portal template - Pass the ticket_ref in the ticket notification mail template - Add an index on helpdesk.ticket.ticket_ref opw-3085030
Original PR description
Steps to reproduce: - Go to settings -> technical -> sequences & identifiers -> sequences -> and change the number of 'next number' - Create a new ticket in helpdesk - Go to helpdesk portal Issue: The id of the ticket is shown instead of the reference Cause: It's the id which is passed in the templates Solution: - Pass the ticket_ref in the portal template - Pass the ticket_ref in the ticket notification mail template - Add an index on helpdesk.ticket.ticket_ref opw-3085030 Forward-Port-Of: odoo/enterprise#35021 Forward-Port-Of: odoo/enterprise#34957
Test introduced in #34414 considered that `website` was always installed, which is not the case on the runbot in single app-builds. Forward-Port-Of: odoo/enterprise#34931
Original PR description
Test introduced in #34414 considered that `website` was always installed, which is not the case on the runbot in single app-builds. Forward-Port-Of: odoo/enterprise#34931