Thursday, December 29, 2022
12 changes · master
Enhancements to existing features
The manufacturing BoM Overview now shows route information together with lead times when that filter is selected. This makes the overview clearer because lead times depend on the routes that determine them, helping users understand planning information in context.
Original PR description
In the BoM Overview, routes were always displayed regardless of the display options selected in the filter. Since lead times are only relevant when checking their associated routes (as they determine them), it makes sense to add the display of the routes in the lead times filter. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When creating custom appointment share links, the calendar now uses the last slot duration selected during the current session instead of always defaulting to 30 minutes. This reduces repeated manual resizing when users add several slots with the same preferred duration.
Original PR description
When clicking on the calendar when adding slots to the custom share link in preparation, the default duration is always 30 minutes. However, when selecting several slots with another preferred duration, one must drag the slot every time. Therefore, as long as the user is on the calendar page, the slot duration will be by default the last one used if any, or 30 minutes. Task-3107362
Miscellaneous changes
Moving an answer of a multiple choice was triggering a traceback. This solves the problem. Technical note: the method _applyX2ManyChange which try to apply commands on local data was trying to read field information for suggested_answer_ids on the list view but that view was lacking that field. Adding that field as invisible on that view solves the problem. Task-3106406 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo
Original PR description
Moving an answer of a multiple choice was triggering a traceback. This solves the problem. Technical note: the method _applyX2ManyChange which try to apply commands on local data was trying to read field information for suggested_answer_ids on the list view but that view was lacking that field. Adding that field as invisible on that view solves the problem. Task-3106406 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#108450
Home action is first action to do on opening Odoo. Usually, it's an action to open specific menu. The `action_id` field doesn't have domain and user may select any action. This commit prevents user selecting action with "reload" tag, because it would lead to infinite page reloading. STEPS: * Set `Open POS Menu` as a Home Action * reload the page opw-2900439 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged:
Original PR description
Home action is first action to do on opening Odoo. Usually, it's an action to open specific menu. The `action_id` field doesn't have domain and user may select any action. This commit prevents user selecting action with "reload" tag, because it would lead to infinite page reloading. STEPS: * Set `Open POS Menu` as a Home Action * reload the page opw-2900439 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#95988
Before this commit, when the user tries to access to the project update view of a project and at least one timesheet of that project has `timesheet_invoice_type='timesheet_revenues'`, a traceback is occured saying the `timesheet_revenues` does not exist in a dict used for the sequence to display the project profitability in a certain order. ``` Traceback (most recent call last): File "/home/odoo/src/version/16.0/odoo/odoo/http.py", line 1579, in _serve_db return service_model.ret
Original PR description
Before this commit, when the user tries to access to the project update view of a project and at least one timesheet of that project has `timesheet_invoice_type='timesheet_revenues'`, a traceback is…
Before this commit, when the user tries to access to the project update
view of a project and at least one timesheet of that project has
`timesheet_invoice_type='timesheet_revenues'`, a traceback is occured
saying the `timesheet_revenues` does not exist in a dict used for
the sequence to display the project profitability in a certain order.
```
Traceback (most recent call last):
File "/home/odoo/src/version/16.0/odoo/odoo/http.py", line 1579, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/home/odoo/src/version/16.0/odoo/odoo/service/model.py", line 134, in retrying
result = func()
File "/home/odoo/src/version/16.0/odoo/odoo/http.py", line 1608, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/home/odoo/src/version/16.0/odoo/odoo/http.py", line 1805, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/home/odoo/src/version/16.0/odoo/addons/website/models/ir_http.py", line 235, in _dispatch
response = super()._dispatch(endpoint)
File "/home/odoo/src/version/16.0/odoo/odoo/addons/base/models/ir_http.py", line 144, in _dispatch
result = endpoint(**request.params)
File "/home/odoo/src/version/16.0/odoo/odoo/http.py", line 698, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/home/odoo/src/version/16.0/odoo/addons/web/controllers/dataset.py", line 42, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/home/odoo/src/version/16.0/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/home/odoo/src/version/16.0/odoo/odoo/api.py", line 461, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/home/odoo/src/version/16.0/odoo/odoo/api.py", line 448, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/home/odoo/src/version/16.0/odoo/addons/sale_timesheet/models/project.py", line 306, in get_panel_data
panel_data = super(Project, self).get_panel_data()
File "/home/odoo/src/version/16.0/odoo/addons/sale_project/models/project.py", line 258, in get_panel_data
panel_data = super().get_panel_data()
File "/home/odoo/src/version/16.0/enterprise/project_account_budget/models/project.py", line 53, in get_panel_data
panel_data = super().get_panel_data()
File "/home/odoo/src/version/16.0/odoo/addons/project/models/project.py", line 854, in get_panel_data
profitability_items = self._get_profitability_items()
File "/home/odoo/src/version/16.0/odoo/addons/sale_timesheet/models/project.py", line 499, in _get_profitability_items
return self._get_profitability_items_from_aal(
File "/home/odoo/src/version/16.0/odoo/addons/sale_timesheet/models/project.py", line 481, in _get_profitability_items_from_aal
{'data': convert_dict_into_profitability_data(revenues_dict, False), 'total': total_revenues},
File "/home/odoo/src/version/16.0/odoo/addons/sale_timesheet/models/project.py", line 444, in convert_dict_into_profitability_data
data = {'id': invoice_type, 'sequence': sequence_per_invoice_type[invoice_type], **vals}
KeyError: 'timesheet_revenues'
```
This commit adds the missing key in the dict and also in the label
displayed in the project profitability.
Forward-Port-Of: odoo/odoo#108545The revision 65a012c2bba0ed81d9b525a7779c726043b17707 changed the behavior of method _read() when invoked on a record with id None. Before the change, the method would consider that no records have been fetched because the id is falsy. After the change, it keeps the id None in the fetched records, and attempts to make subsequent SQL queries like "column IN ()", which is syntactically incorrect. OPW 3104957 Forward-Port-Of: odoo/odoo#108771
Original PR description
The revision 65a012c2bba0ed81d9b525a7779c726043b17707 changed the behavior of method _read() when invoked on a record with id None. Before the change, the method would consider that no records have been fetched because the id is falsy. After the change, it keeps the id None in the fetched records, and attempts to make subsequent SQL queries like "column IN ()", which is syntactically incorrect. OPW 3104957 Forward-Port-Of: odoo/odoo#108771
This commit adds a void action on the survey main form. This is done to avoid the user clicking on the submit button *before* the JavaScript code is loaded, which will by default trigger a page reload. That situation can happen on slow connections, and as it reloads the page, the user keeps clicking on "start" and it keeps reloading, creating frustration. We also visually disable the button until the JavaScript is loaded. Task-3111551 Forward-Port-Of: odoo/odoo#108685
Original PR description
This commit adds a void action on the survey main form. This is done to avoid the user clicking on the submit button *before* the JavaScript code is loaded, which will by default trigger a page reload. That situation can happen on slow connections, and as it reloads the page, the user keeps clicking on "start" and it keeps reloading, creating frustration. We also visually disable the button until the JavaScript is loaded. Task-3111551 Forward-Port-Of: odoo/odoo#108685
A traceback was shown when 'None' background was chosen to configure the onboarding panel's background image (css class). Supposing no one built anything with a `o_onboarding_False` class, we also clean the result for a `False` value while we are here. Task-3104723 Forward-Port-Of: odoo/odoo#108251
Original PR description
A traceback was shown when 'None' background was chosen to configure the onboarding panel's background image (css class). Supposing no one built anything with a `o_onboarding_False` class, we also clean the result for a `False` value while we are here. Task-3104723 Forward-Port-Of: odoo/odoo#108251
When `link_tools` was introduced [1], `_onURLInput` did only update the configuration form and did not touch the edited DOM - it was therefore called without issue from `start`. At a later stage [2] a DOM modification was introduced in `_onURLInput` which indirectly made the refactored [3] `link`'s `start` modify the edited DOM. This commit extracts a part of the `_onURLInput` into `_adaptForm` and makes `start` adapt only the form and not the edited DOM. For `link_tools` the "preview" i
Original PR description
When `link_tools` was introduced [1], `_onURLInput` did only update the configuration form and did not touch the edited DOM - it was therefore called without issue from `start`. At a later stage [2]…
When `link_tools` was introduced [1], `_onURLInput` did only update the configuration form and did not touch the edited DOM - it was therefore called without issue from `start`. At a later stage [2] a DOM modification was introduced in `_onURLInput` which indirectly made the refactored [3] `link`'s `start` modify the edited DOM. This commit extracts a part of the `_onURLInput` into `_adaptForm` and makes `start` adapt only the form and not the edited DOM. For `link_tools` the "preview" is updated on `_onURLInput`. For `link_dialog` the preview is updated during `_adaptForm` because it is s part of the form. Steps to reproduce: - Edit Home page - Drop a "Banner" block - Select the "Contact Us" button - Select "Custom" style in the link tool - Select a fill color - Deselect the button by clicking on the Banner's text - Select the button again => Button is redrawn without its color This PR also fixes selectors that prevented visibility updates in the link forms. [1]: https://github.com/odoo/odoo/commit/740168ce8d27da3d6a7156d2d79655a898394923 [2]: https://github.com/odoo/odoo/commit/226c4c4032c26d3d8f622b29fb151fa8e78ba70a [3]: https://github.com/odoo/odoo/commit/4a1d776243b059d423152bd026bb8bc758477224 opw-3086198 task-3096806 Forward-Port-Of: odoo/odoo#108783 Forward-Port-Of: odoo/odoo#108213
**Before this commit:** Users with access "Can READ" should not be able to create a private copy of an article via the button [Create a copy] on the kebab menu, as it is not visible. **After this commit:** Made the button visible for users to create a copy of an article with read access. **Task**-3104706 Forward-Port-Of: odoo/enterprise#35171
Original PR description
**Before this commit:** Users with access "Can READ" should not be able to create a private copy of an article via the button [Create a copy] on the kebab menu, as it is not visible. **After this commit:** Made the button visible for users to create a copy of an article with read access. **Task**-3104706 Forward-Port-Of: odoo/enterprise#35171
This commit fixes a bug which caused a crash if you do not select a destination when you want to move an article via the MoveTo dialog. Now if we do not get any data from the input we simply return from the event until the input contains a destination. task-3112187 Forward-Port-Of: odoo/enterprise#35248
Original PR description
This commit fixes a bug which caused a crash if you do not select a destination when you want to move an article via the MoveTo dialog. Now if we do not get any data from the input we simply return from the event until the input contains a destination. task-3112187 Forward-Port-Of: odoo/enterprise#35248
Since semantic changes of what is done by the tag <group> due to switch from BS4 to BS5. The link of the job possition to share was not correctly displayed. So we've adapted the wizard view. Forward-Port-Of: odoo/enterprise#35267
Original PR description
Since semantic changes of what is done by the tag <group> due to switch from BS4 to BS5. The link of the job possition to share was not correctly displayed. So we've adapted the wizard view. Forward-Port-Of: odoo/enterprise#35267