Thursday, December 29, 2022
5 changes · master
Enhancements to existing features
Shipping method settings are simplified by hiding margin fields that do not apply to fixed-price or rules-based carriers. Other carrier types gain a fixed margin option, making shipping pricing easier to configure consistently.
Original PR description
Description of the issue/feature this PR addresses: Multiple fields were unused / redundant in the shipping methods : "Margin on rate" with provider "Fixed Price" "Margin on rate", "Free if order amount is above" and "Amount" with provider "Based on Rules" as we can put them in the rules Add the field fixed margin for the other providers Current behavior before PR: removed "Margin on rate" for "Fixed Price" and "Based on Rules" added "Fixed Margin" for all the other providers Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Bank reconciliation now prioritizes journal items whose remaining amount matches the bank statement transaction. This helps users find the right accounting entries faster while avoiding duplicate results in the list.
Original PR description
The bank recon widget needs to display move lines that match the bank statement transaction value first. The ORM does not allow a complicated order by clause, and if it did, it would have a significant performance impact. Modify the search_read method to find matching records, then concatenate with the default search result. To avoid duplicates, the domain and limits are modified Task-3042547 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The bank reconciliation widget now prioritizes move lines that match the bank transaction amount, making likely matches easier to find. This helps accounting users reconcile transactions faster and with less manual searching.
Original PR description
The bank recon widget needs to display move lines that match the bank transaction value first. This is done in the corresponding odoo community commit. Here we set a context key to modify the search_read behaviour Task-3042547
Resolved issues and error corrections
The activity view now consistently shows only records that actually have activities, preventing crashes when users adjust filters. This keeps product and other activity-based views stable and reliable for day-to-day use.
Original PR description
Since https://github.com/odoo/odoo/pull/107916, the ActivityModel did not include `["activity_ids", "!=", false]` in its domain, causing incoherence in some views and resulting in crashes. To reproduce the issue: - In the runbot, navigate to Website -> eCommerce -> Product. - Switch to the activity view. - Remove the Published filter. - The view crashes due to an incoherence between the data records in the `web_search_read` and the `get_activity_data` calls. This commit resolves the issue by correctly setting the domain.
Website light and dark design colors now follow the gray settings configured by users instead of being automatically derived from the main brand color. This makes eCommerce and other website elements better match the chosen theme settings and gives businesses more predictable visual control.
Original PR description
Commit [1] made the "light" and "dark" colors of bootstrap be very light and dark variations of the "main" color ("alpha" at the time, now "o-color-1", which is used as bootstrap "primary" color). It…
Commit [1] made the "light" and "dark" colors of bootstrap be very light and dark variations of the "main" color ("alpha" at the time, now "o-color-1", which is used as bootstrap "primary" color). It was already not a very good idea, although slightly better than nothing (at the time navbar and footer colors could not be changed at all, so without this, they would use a gray with a blueish hue not related to the main color).
Since then, 2.5 years later, [2] and [3] were made which gave some control over bootstrap default grays via two widgets controlling the new "gray-hue" and "gray-extra-saturation" params. At that time, the light and dark overrides made at [1] should have been removed as "light" and "dark" normally default to two bootstrap grays, which we would have had control over since [2] and [3]. This was however, not a big problem since "light" and "dark" were not used by the website templates (well it was by some but not a lot) and the overrides to gray colors related to the main color was not "stupid", just less nice as less control over it.
However, since the many improvements made with [4] more than 1 year later, the "light" color started to be used to achieve more detailed designed for the eCommerce. And it is planned to use it in further design elements later on. The fact that those "light" elements are not following the "grays" configuration made by the user is thus starting to be a problem.
This commit fixes the issue in master (>= 16.1): "light" and "dark" colors will now follow the configured grays. In the future, we might even improve the control over those two particular grays or maybe improve their default value according to the theme color palette. It was judged that stable versions can stay as they are right now. As explained, it is not critical and you can still force your own CSS rules if you are really unhappy with the "hardcoded" grays (related to the main color) at some places.
[1]: https://github.com/odoo/odoo/commit/22c4311e283af95eafe1ba85ee1234bb8102110e
[2]: https://github.com/odoo/odoo/commit/35d27a6c1d3dab621de7f059565d7619ae004412
[3]: https://github.com/odoo/odoo/commit/e08184103c42eaf7f6bfb70655cb90b51e79913a
[4]: https://github.com/odoo/odoo/pull/98558
Related to task-3097005