Thursday, January 12, 2023
5 changes · master
Resolved issues and error corrections
This fixes a timing issue that could make Kanban progress bars show incorrect or empty information after creating a new item in a grouped column. The change improves reliability in automated builds and helps ensure users see accurate progress information immediately after quick creation.
Original PR description
Before this commit, test "click on the progressBar of a new column" deterministically failed on split builds. It only passed with all addons installed, and passed by chance with all addons installed.…
Before this commit, test "click on the progressBar of a new column" deterministically failed on split builds. It only passed with all addons installed, and passed by chance with all addons installed. The reason is that the flow of quick creating a record in a grouped kanban with progressbars wasn't concurrency proof at all. Commit [1] simply added a hook at the end of the `_save` function of the model, which highlighted the problem: the progressbars were updated before the group's count was incremented, so if the quick created record was the only record of the group, the progressbar was still empty after the quick creation. This commit makes the quick create code more robust. We couldn't find a way to write a qunit test for this, but it still fixes an error in nightly builds. [1] a882b725bb6bf3d11c898a69e3fa5502802c1b78 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Survey users will no longer see a technical traceback when a handled save or validation error occurs. Dialog buttons are restored correctly when validation blocks saving, making survey interactions smoother and less confusing.
Original PR description
Due to changes in errorService added in dd6f103b, a traceback was shown due to our (handled) "unhandled" rejected promise that wasn't an "Error" object. Using the original error works now for our handleSurveyError function. The only additional requirement was to restore the buttons of the dialog when saving is blocked due to our validation process. Task-3128957
Payment-related tests were adjusted to reflect updated rules for matching payment providers with supported currencies. This helps keep automated checks reliable after the currency compatibility logic changed, reducing the risk of false test failures.
Original PR description
Following 90af85c2e4fdec0a6ac7d70663f90443fad120d2, the management of the compatible providers was modified by their available currency. Some tests weren't adapted to that change.
Updated internal tests so they no longer assume every company uses USD. This prevents localization test failures when a country-specific setup uses the local company currency instead.
Original PR description
Since https://github.com/odoo/odoo/commit/3752b3166ec6bbb5c6ea55f96bb521381bf2b2d9, the currency of the test architecture is not fixed anymore to USD (but is by default). Therefore, the nightly runbot tests of the localization (l10n_* modules) all fail when verifying the company currency is USD (because the localization sets the company currency to the country one). This commit adapts those checks to stop enforcing the USD currency as base, only enforcing that the currency used is the company one. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Enterprise web interface will now be installed automatically when the standard web app is present, even if an optional setup component is not installed. This prevents customers from missing Enterprise web features after recent dependency changes.
Original PR description
Since the merge of PWA in enterprise the dependency of `web_enterprise` has changed (`base_setup` was added) and so the `auto_install` rules isn't satisfied anymore. This commit forces to auto install `web_enterprise` when web is installed also when `base_setup` is not. PS: another fix will be to set `auto_install: True` in `base_setup`. Ref [1] odoo/enterprise#35322