Monday, January 30, 2023
24 changes · master
Enhancements to existing features
The Danish localization data has been updated so the source text is maintained in English and translated back into Danish through the standard translation process. This improves consistency, maintainability, and translation quality for Danish accounting and tax localization content.
Original PR description
Before this PR, all this localisation was written in Danish, but all the localisation have to be written in english and then translated back in the native language. This PR correct that. Task-id: 3151027 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update streamlines an internal account access rule by removing an unnecessary company check. It can help keep database queries simpler and may improve performance without changing how users work with accounting records.
Original PR description
Checking company_id=False on records having a required company is useless and leads to more complex queries. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update changes the Ecuador localization content so the source text is maintained in English and translated back into Ecuadorian Spanish. This improves consistency with Odoo localization standards and makes future translations easier to manage.
Original PR description
Before this PR, all this localisation was written in spanish, but all the localisation have to be written in english and then translated back in the native language. This PR correct that. Task-id: 3119934 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Honduras accounting localization now uses English as the source language, with Spanish provided through translations. This makes the module easier to maintain and aligns it with Odoo's localization standards without changing business functionality.
Original PR description
Before this PR, all this localisation was written in spanish, but all the localisation have to be written in english and then translated back in the native language. This PR correct that. Task-id: 3149182& --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes an outdated internal setting from several Odoo areas, simplifying the code without changing how users work. It helps keep the system easier to maintain and reduces unnecessary technical clutter across accounting, HR, inventory, point of sale, portal, and localization components.
Original PR description
A bit of code cleanup. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Danish localization reports now use English as the source text, with Danish provided through the standard translation files. This improves consistency and makes future maintenance and translation updates easier without changing report functionality.
Original PR description
Before this PR, all this localisation was written in Danish, but all the localisation have to be written in english and then translated back in the native language. This PR correct that. Task-id: 3151027
The social feed refresh ribbon has been made shorter so it takes up less space on the screen. Its hover and focus styling was also adjusted to look cleaner, including in dark mode.
Original PR description
This reduces the feed refresh ribbon height that was too big. Technical note: the ribbon uses a bootstrap alert which has more padding in master than in 15.3. To solve the problem, we have forced the padding to the former values. Task-3105171
Resolved issues and error corrections
The Guatemala localization content has been converted from Spanish source text to English, with Spanish translations added separately. This keeps the module aligned with Odoo localization standards and helps maintain accurate translations for Spanish-speaking users.
Original PR description
All the localisation should be written in english and then translated to the native language of the country. In this case, the Guatemala localisation was written is Spanish, this PR translate the module in english and add the corresponding PO file in spanish. Task-id: 3145295 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Update of taxes could create name collision due to uniqueness of (name, company, scope, type) on taxes. We add "[old]" before the tax name to avoid this problem. Related: #108571 Forward-Port-Of: odoo/odoo#110815
Original PR description
Update of taxes could create name collision due to uniqueness of (name, company, scope, type) on taxes. We add "[old]" before the tax name to avoid this problem. Related: #108571 Forward-Port-Of: odoo/odoo#110815
Prior to this commit and on Firefox 109, clicking on a link while in edit mode on the website app would trigger a traceback. This is caused by the fact that the LinkPopover widget is contained inside the iframe while use the ClipboardJS global defined in the top window. Indeed, ClipboardJS checks if the target (the button to copy the link) is an HTMLElement. To do so, it uses the "instanceof" keyword. However, the instance of the target is not an HTMLElement from the top window but from th
Original PR description
Prior to this commit and on Firefox 109, clicking on a link while in edit mode on the website app would trigger a traceback. This is caused by the fact that the LinkPopover widget is contained inside the iframe while use the ClipboardJS global defined in the top window. Indeed, ClipboardJS checks if the target (the button to copy the link) is an HTMLElement. To do so, it uses the "instanceof" keyword. However, the instance of the target is not an HTMLElement from the top window but from the iframe instead. (for more information see [1]). This commit fixes that by using the ClipboardJS from the popover's window. So for the website in edit mode it will bethe iframe, and for the rest of Odoo it will be the top window, as before. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof#instanceof_and_multiple_realms Forward-Port-Of: odoo/odoo#110872
Install MX CoA "Cash" and "Bank Suspense Account" are missing the tag "Transferencias bancarias moneda extranjera" account is using the wrong tag opw-3033611 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#110456 Forward-Port-Of: odoo/odoo#106089
Original PR description
Install MX CoA "Cash" and "Bank Suspense Account" are missing the tag "Transferencias bancarias moneda extranjera" account is using the wrong tag opw-3033611 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#110456 Forward-Port-Of: odoo/odoo#106089
In the forward-port to 15.0 of https://github.com/odoo/odoo/commit/b4cd54a3c9227370667913ff2e170e24539c6328 the migration folder was renamed from 5.1 to 15.0.5.1, which causes the forward-port to 16.0 to not take into account this migration. This change renames the folder back to 5.1, such that the migration will run in 16.0 as well. Related to task-2993087 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#111255
Original PR description
In the forward-port to 15.0 of https://github.com/odoo/odoo/commit/b4cd54a3c9227370667913ff2e170e24539c6328 the migration folder was renamed from 5.1 to 15.0.5.1, which causes the forward-port to 16.0 to not take into account this migration. This change renames the folder back to 5.1, such that the migration will run in 16.0 as well. Related to task-2993087 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#111255
When unlinking or writing a tax report line, the related tags used to be deleted. This means when a new version of a report was deployed, the history was lost and the user didn't get notified. This was especially annoying for customers that got migrated automatically. We now archive tags instead of deleting them if they are still used in account.move.line and display a banner in report that let the user know there might be a problem and invite him to correct tax tags. Task: 3084028 Forward-P
Original PR description
When unlinking or writing a tax report line, the related tags used to be deleted. This means when a new version of a report was deployed, the history was lost and the user didn't get notified. This was especially annoying for customers that got migrated automatically. We now archive tags instead of deleting them if they are still used in account.move.line and display a banner in report that let the user know there might be a problem and invite him to correct tax tags. Task: 3084028 Forward-Port-Of: odoo/odoo#108562 Forward-Port-Of: odoo/odoo#107705
The fiscal device is refered to as the 'fiscal device' in some places, and 'control unit' in others. This commit changes the references to the fiscal device to always be 'fiscal device'. This commit was accidentaly dropped when fixing a forward-port rebase https://github.com/odoo/odoo/pull/109434, and has thus been reintroduced in v16 in its own PR. Forward-Port-Of: odoo/odoo#109523
Original PR description
The fiscal device is refered to as the 'fiscal device' in some places, and 'control unit' in others. This commit changes the references to the fiscal device to always be 'fiscal device'. This commit was accidentaly dropped when fixing a forward-port rebase https://github.com/odoo/odoo/pull/109434, and has thus been reintroduced in v16 in its own PR. Forward-Port-Of: odoo/odoo#109523
When trying to duplicate a service in sale > products with "Subcontract Service" enabled, a error message will appear. This is due to the fact that when you are duplicating a product, every vendor in the purchase tab are not carried over to the copy. To fix this easily, we need to disable the "Subcontract Service" on duplicates entry during their creations. opw-3115827 Forward-Port-Of: odoo/odoo#111128 Forward-Port-Of: odoo/odoo#109172
Original PR description
When trying to duplicate a service in sale > products with "Subcontract Service" enabled, a error message will appear. This is due to the fact that when you are duplicating a product, every vendor in the purchase tab are not carried over to the copy. To fix this easily, we need to disable the "Subcontract Service" on duplicates entry during their creations. opw-3115827 Forward-Port-Of: odoo/odoo#111128 Forward-Port-Of: odoo/odoo#109172
Steps to reproduce the bug: - Go to the warehouse and enable the “2 steps” in the “Outgoing Shipments” - Create a So: - add a storable product - 2 pickings are created (pick and a delivery) - Go to pos and open a session: - Select the created quotation - Click on payment - select “Cash” - Click on Validate Problem: The delivery order linked to the SO is correctly cancelled, but the pick order remains in the “ready” state opw-3117002 Forward-Port-Of: odo
Original PR description
Steps to reproduce the bug:
- Go to the warehouse and enable the “2 steps” in the “Outgoing Shipments”
- Create a So:
- add a storable product
- 2 pickings are created (pick and a delivery)
- Go to pos and open a session:
- Select the created quotation
- Click on payment
- select “Cash”
- Click on Validate
Problem:
The delivery order linked to the SO is correctly cancelled, but the pick order remains in the “ready” state
opw-3117002
Forward-Port-Of: odoo/odoo#109515Since the migration from bootsrap 4 to bootstrap 5 and more precisely since [this commit], the tooltips on too-long titles are not displayed anymore in the mail editor. Steps to reproduce the bug: - Go to the email marketing application - Create a new mail (other than plain text) - Go to the design tab of the editor - Put your mouse over the title "Secondary Butt..." => The tooltip to display the entire title does not appear. This commit allows to correct this bug and to display the tool
Original PR description
Since the migration from bootsrap 4 to bootstrap 5 and more precisely since [this commit], the tooltips on too-long titles are not displayed anymore in the mail editor. Steps to reproduce the bug: - Go to the email marketing application - Create a new mail (other than plain text) - Go to the design tab of the editor - Put your mouse over the title "Secondary Butt..." => The tooltip to display the entire title does not appear. This commit allows to correct this bug and to display the tooltip as it was the case before the change of version of bootstrap. [this commit]: https://github.com/odoo/odoo/commit/23facbfb76c6e8b23137cddda5f5113273555498 task-2777738 Forward-Port-Of: odoo/odoo#109218
Misc fix and bugprovement following fiscalis feedbacks Task id # 3138441 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#110397
Original PR description
Misc fix and bugprovement following fiscalis feedbacks Task id # 3138441 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#110397
Since [1] when the translations becames stored as JSONB, the translations of website-specific views were lost when adding a new language. [2] did fix a similar problem when installing an App, but did not solve this. This commit makes sure to only change the requested translations without impacting the existing ones when a language is added. Steps to reproduce: - Add French language to the website - Add the number snippet on the homepage - Translate "Useful options" -> "Options util
Original PR description
Since [1] when the translations becames stored as JSONB, the translations of website-specific views were lost when adding a new language. [2] did fix a similar problem when installing an App, but did not solve this. This commit makes sure to only change the requested translations without impacting the existing ones when a language is added. Steps to reproduce: - Add French language to the website - Add the number snippet on the homepage - Translate "Useful options" -> "Options utiles" - Go to setting -> Languages -> Activate any language (not even on a website) => French translation disappeared. [1]: https://github.com/odoo/odoo/commit/ef00294e7189359c47638c4a71626f1937395edb [2]: https://github.com/odoo/odoo/commit/91a9c870eede96040ac49d2375fe0e18342342e1 opw-3120079 Forward-Port-Of: odoo/odoo#111297 Forward-Port-Of: odoo/odoo#111060
…ment_id field An attachment has complex access rights. If there is no res_model/res_id, the access rights are admin (not exactly but let's say that). When an EDI like Facturx/E-FFF generates an attachment not linked to any model, you don't have access to it except if you are admin. However, here we have a security issue since everyone is able to write any 'id' on the 'attachment_id' field. If you do that using Facturx, knowing this EDI will embed its attachment inside the invoice PDF repo
Original PR description
…ment_id field An attachment has complex access rights. If there is no res_model/res_id, the access rights are admin (not exactly but let's say that). When an EDI like Facturx/E-FFF generates an…
…ment_id field
An attachment has complex access rights. If there is no res_model/res_id, the access rights are admin (not exactly but let's say that).
When an EDI like Facturx/E-FFF generates an attachment not linked to any model, you don't have access to it except if you are admin.
However, here we have a security issue since everyone is able to write any 'id' on the 'attachment_id' field.
If you do that using Facturx, knowing this EDI will embed its attachment inside the invoice PDF report in sudo mode, you have now a way to extract any attachment from the database including the ones you shouldn't have access to.
Furthermore, a different api introduced by OWL makes the form view of account.edi.document popping from the one2many inside the invoice form.
Instead of "options={'no_open': '1'}", the new api is now to put directly "no_open='1'" on the root node.
If you combine both issues above, you currently have a way to extract any 'attachment_id' from the database and odoo is kind enough to give you the form view to do it.
Solution: "account.edi.document.attachment_id" is now accessible to the admin only.
Forward-Port-Of: odoo/odoo#110965Move citizen_identification field added in l10n_be_report. Task id #3138441 Forward-Port-Of: odoo/enterprise#36100
Original PR description
Move citizen_identification field added in l10n_be_report. Task id #3138441 Forward-Port-Of: odoo/enterprise#36100
When unlinking a tax report line, the related tags used to be deleted. This means when a new version of a report was deployed, the history was lost and the user didn't get notified. This was especially annoying for customers that got migrated automatically. We now archive tags instead of deleting them if they are still used in account.move.line and display a banner in report that let the user know there might be a problem and invite him to correct tax tags. Task: 3084028 Forward-Port-Of: odo
Original PR description
When unlinking a tax report line, the related tags used to be deleted. This means when a new version of a report was deployed, the history was lost and the user didn't get notified. This was especially annoying for customers that got migrated automatically. We now archive tags instead of deleting them if they are still used in account.move.line and display a banner in report that let the user know there might be a problem and invite him to correct tax tags. Task: 3084028 Forward-Port-Of: odoo/enterprise#35195 Forward-Port-Of: odoo/enterprise#34888
With an MX company COA setup Go to Accounting>Reportin>Trial Balance Export "COA SAT (XML)" Several accounts will be missing opw-3033611 Forward-Port-Of: odoo/enterprise#36063 Forward-Port-Of: odoo/enterprise#34138
Original PR description
With an MX company COA setup Go to Accounting>Reportin>Trial Balance Export "COA SAT (XML)" Several accounts will be missing opw-3033611 Forward-Port-Of: odoo/enterprise#36063 Forward-Port-Of: odoo/enterprise#34138
Steps to reproduce: > open odoo 16 db with spanish/espanol as language (only language) > create recurring product > publish product Issue: > see in website that the "per month" is not translated from english opw-3086716 Co-authored-by: Liu Jinjiu (jili) <jili@odoo.com> Forward-Port-Of: odoo/enterprise#35136
Original PR description
Steps to reproduce: > open odoo 16 db with spanish/espanol as language (only language) > create recurring product > publish product Issue: > see in website that the "per month" is not translated from english opw-3086716 Co-authored-by: Liu Jinjiu (jili) <jili@odoo.com> Forward-Port-Of: odoo/enterprise#35136