Monday, February 6, 2023
2 changes · master
Features or functions removed from Odoo
This change removes an internal benchmarking suite from the web module because it was not providing enough practical value. Developers will rely on browser profiling tools instead, with no expected impact on day-to-day users.
Original PR description
It was never really as useful as I hoped it would be. It turns out that creating a benchmarking suite is quite difficult. In practice, it is much better to use the browser profiler: this makes it easier to see what code actually takes a lot of time, and why. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Odoo websites no longer include an unused company name data field in the page markup. This is a small cleanup that reduces obsolete code without changing website behavior for users or visitors.
Original PR description
The `<html>` element of websites had a `data-oe-company-name` attribute which was dead code since a long time. This commit removes it. Some history: - [1] introduced the SEO dialog which suggested…
The `<html>` element of websites had a `data-oe-company-name` attribute which was dead code since a long time. This commit removes it. Some history: - [1] introduced the SEO dialog which suggested the company name as keyword value. That value was retrieved through a `<meta>` which was added in the DOM at the time. - [2] converted the `<meta>` tag into valid HTML code, by introducing `data-oe-company-name`. - [3] suddenly stopped caring about the company name value... but left `data-oe-company-name` as dead code, alongside a JS method reading it (in the SEO dialog class). - [4] removed the JS method dead code by refactoring the whole SEO dialog during the website-in-backend refactoring... but still left the `data-oe-company-name` dead code. This commit finally cleans it. It was judged that not using the company name value (as step [3] decided) is ok. [1]: https://github.com/odoo/odoo/commit/f50b273ae12493e227806670d9a866b6be162551 [2]: https://github.com/odoo/odoo/commit/e28c8101232d527c2d3ea2e619013ca70602d957 [3]: https://github.com/odoo/odoo/commit/d52ec7fc42cbeecafea921ea30d1d0723a59078a [4]: https://github.com/odoo/odoo/commit/ac55f2bb113ecf7c774fe6e96d28e716184a97d1