Friday, March 24, 2023
7 changes · master
Resolved issues and error corrections
This fixes a problem that could cause crashes when users sent messages in the chatter. The change keeps temporary message tracking internal so messages can be matched correctly without disrupting normal business communication.
Original PR description
Since [1], the `temporary_id` of a message is passed to the `message_post` route in order to renconciliate the temporary message on the client side and the real message created by the server. This led to crashes when sending message on the chatter because this parameter was not allowed as a `_notify_thread` parameter. Since this parameter is highly specific and isn't linked to any business/model code, this parameter is now passed via the context thus solving this issue. [1]: https://github.com/odoo/odoo/pull/116085
The mail unread counter now better matches the actual messages users still need to read. This prevents notification-only items from inflating the count and ensures messages are marked as read correctly when a conversation is first opened.
Original PR description
This PR fixes several issues with the unread counter: - Notifications being considered as unread messages (which is not the case on the server side which resulted in inconsistencies). - Counter greater than it should be when the last seen message is not loaded. - Messages not marked as read on first thread opening. task-3239957
The mobile main flow tour now checks for small screen size instead of requiring a specific mobile device identity. This makes automated testing more reliable and removes unnecessary browser configuration for custom user agents.
Original PR description
Main Flow Tour Mobile shouldn't require a specific `user_agent` as it targets a small screen and not a mobile platform (iOS, Android...). Actually, during refactoring of the tours (odoo/odoo@3a798039d6f200f8e28448ddb6a2d3c46654a203), a confusion was made between the legacy `isMobile`, which represents a small screen (cf. `env.isSmall`) and `isMobileOS`, which targets "mobile" platforms (ie. iOS, Android...) independently of the screen size. This commit applies the proper condition (isSmall) for the tours management and removes the useless `user_agent` property. It also removes the logic added to support custom user_agent in the Chrome automation for testing. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When a shipping method is added to a confirmed sales order, the related undelivered delivery will now receive the correct carrier information. This helps keep delivery records accurate and avoids manual corrections for orders where shipping details are added after confirmation.
Original PR description
Before this commit ================== when SO is confirmed and Delivery is created then add the shipping method in SO, in this case, the shipping carrier is not set in the existing undelivered delivery of that SO. After this commit ================= So in this commit, we set the shipping carrier for that delivery. TaskId: 2946360
Domain rules in the web interface now catch more invalid entries before they can cause problems. This helps users and administrators spot configuration mistakes earlier, reducing errors in filters and field behavior.
Original PR description
We make the class Domain detect more invalid domains.
This fixes an issue where mail notification processing could stop early when one channel in a batch was not recognized. Other notifications in the same batch will now continue to be handled, improving reliability of message read-status updates.
Original PR description
Before this commit, the `mail.channel/seen` notification handler would have returned if the channel was unknown. This is incorrect since it would prevent other notifications from the same batch from being processed. This commit fixes the issue.
Fixed an issue where Knowledge articles with cover images could fail to load on the public-facing frontend. The update uses the correct cover image setting and adds test coverage to help prevent the problem from returning.
Original PR description
Purpose: ======== Replace the nonexistent `article.cover_height` field by the correct `article.cover_image_position` field in the frontend view. This commit also adds a cover to an article in the frontend tour to make sure that covers do not make knowledge crash in frontend. Task-3221175