Sunday, April 2, 2023
3 changes · master
Miscellaneous changes
Commit [1] renamed the "js_subscribe_email" class into "js_subscribe_value" as the same subscription feature layout is now available for sms (not only email). The problem was that no upgrade script was made to convert the old class in old databases... so newly migrated users have a traceback on all pages which contain a newsletter. For now, this patches the JS to support both class names. In the future, we'll probably have to remove the compatibility and make an upgrade script about the old c
Original PR description
Commit [1] renamed the "js_subscribe_email" class into "js_subscribe_value" as the same subscription feature layout is now available for sms (not only email). The problem was that no upgrade script was made to convert the old class in old databases... so newly migrated users have a traceback on all pages which contain a newsletter. For now, this patches the JS to support both class names. In the future, we'll probably have to remove the compatibility and make an upgrade script about the old class. [1]: https://github.com/odoo/odoo/commit/bd6ef64f4c79b9c04dc8b85dc2daccb61d55cad0 opw-3243399 opw-3244080 opw-3246089 opw-3246194 opw-3246435 opw-3248473 Forward-Port-Of: odoo/odoo#117270 Forward-Port-Of: odoo/odoo#117209
Before this commit, when clicking on a column in the "Blog Posts" snippet (only with the "Big picture layout" template), the options for that column were displayed in the editor panel, even if options should never be displayed for the columns of dynamic snippets. We had already prevented the appearance of options for elements in a dynamic snippet in this commit [1] and also in this one [2], using a 'pointer-events: none' to prevent clicking on the elements. However, as this also removed
Original PR description
Before this commit, when clicking on a column in the "Blog Posts" snippet (only with the "Big picture layout" template), the options for that column were displayed in the editor panel, even if…
Before this commit, when clicking on a column in the "Blog Posts"
snippet (only with the "Big picture layout" template), the options for
that column were displayed in the editor panel, even if options should
never be displayed for the columns of dynamic snippets.
We had already prevented the appearance of options for elements in a
dynamic snippet in this commit [1] and also in this one [2], using a
'pointer-events: none' to prevent clicking on the elements. However, as
this also removed the mouse hover effect, the 'pointer-events: none' was
changed to 'pointer-events: auto', in this other commit [3], for the
"Big picture layout" template of the "Blog Posts" snippet, so that the
user could see the hover effects in edit mode. And by doing so, we
inadvertently allowed the options to appear again.
In the end, this 'pointer-events: none' was not the right solution, as
for example, for the dynamic "Products" snippet, it may be useful in
edit mode to be able to switch between slides by clicking on arrow
buttons, or to see the mouse hover effects on images (slight zoom).
In this commit, we proceeded differently by hiding the options for
elements that are inside an 'o_not_editable' element (unless they have
the attribute and value 'contenteditable="true"'), excluding them when
generating options so that they don't have associated options.
Steps to reproduce the bug:
- In edit mode, drop a "Blog Posts" snippet in the page.
- Click on the first blog image ("Sierra Tarahumara").
- Bug => Resize options are visible when they shouldn't. The options in
the "column" part of the right panel should also not be visible.
[1]: https://github.com/odoo/odoo/commit/64b663fb42ddca67a06cb067c897abb5a3c4dd70
[2]: https://github.com/odoo/odoo/commit/1345e879d809f811641ea3ad388b5d2c0b16f005
[3]: https://github.com/odoo/odoo/commit/3c0d98bcd8adf9325ee3497eb8d25ec7f904d6a5
task-3054763
Forward-Port-Of: odoo/odoo#117265
Forward-Port-Of: odoo/odoo#109008When clicking on "X Payment(s) to send via SEPA" on the accounting dashboard (on a bank journal), the view that was opened was a reduced version of the one accessed via Vendors > Payments, hiding the "Create Batch" button and some columns. This commit opens the same "full" view via the link on the dashboard. It also adds a space between the number and "Payments to send ...". Finally, to be able to quickly see the status of a batch payment in the payments view, we add the batch payment stat
Original PR description
When clicking on "X Payment(s) to send via SEPA" on the accounting dashboard (on a bank journal), the view that was opened was a reduced version of the one accessed via Vendors > Payments, hiding the "Create Batch" button and some columns. This commit opens the same "full" view via the link on the dashboard. It also adds a space between the number and "Payments to send ...". Finally, to be able to quickly see the status of a batch payment in the payments view, we add the batch payment status in its name retrieved in the list view. [task-3205654](https://www.odoo.com/web#id=3205654&cids=1&menu_id=4720&action=4043&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#38891 Forward-Port-Of: odoo/enterprise#37569