Thursday, April 6, 2023
5 changes · master
Code cleanup and technical improvements
This change removes unused internal logic from Point of Sale invoice generation related to cash rounding. It does not change expected behavior, but helps keep the code simpler and easier to maintain.
Original PR description
When generating invoice for PoS orders, if a cash rounding is applied, a cash rounding line is generated. Thus it is not possible to have `rounding_applied` and NOT `rounding_line`. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update simplifies how Odoo's web views prepare and load data by removing unused internal parameters. It does not introduce visible feature changes, but it helps keep the web interface code easier to maintain and less error-prone over time.
Original PR description
This commit removes the onCreate param in Kanban, as it is no longer useful since [1]. It also removes the beforeLoadProm param and replaces it by an onWillStart option, which is slightly cleaner (there was no reason for this to be a model param as it is only used by the useModel hook). [1] 067bcac53336b5f66f695b1c10b333d8c722225d Part of task 3179751 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update modernizes the Point of Sale internals by removing older technical dependencies and centralizing how customer-facing displays are managed. It also adds basic testing infrastructure, helping future PoS changes be delivered with more confidence and fewer regressions.
Original PR description
This PR continues the ongoing refactoring work on the PoS. It removes the use of the legacy environment, refactors the way the customer display is handled, and introduces a bit of unit testing infrastructure. More information can be found in the individual commits Enterprise: https://github.com/odoo/enterprise/pull/39123
Message lists now load in a continuous order, preventing gaps that could make some messages unreachable when scrolling or reloading conversations. This improves reliability in Mail, Discuss, and live chat conversations and prepares the system for future conversation jump features.
Original PR description
Adapt code of message fetch so that fetching of (needaction) messages are controlled in a way to keep continuous sequence of messages at all time. This code design solves the "holes" problem in a message list by not allowing holes. This fixes many scenario that generated these holes, resulting in unfetchable messages. Example of such a scenario: - post 40 messages - post a new message that is reply of the oldest message - page reload and scroll up until load more => 10 messages are missing in-between replied message and following message (that should have been 11 messages apart) This code is also in preparation to allow jumps in a conversation.
This update adapts Point of Sale enterprise modules to a newer internal structure for customer displays and device integrations. It helps keep certified localizations and IoT-connected POS setups compatible with the latest platform changes, with little direct change for end users.
Original PR description
Community: https://github.com/odoo/odoo/pull/117290