Friday, April 7, 2023
4 changes · master
Resolved issues and error corrections
This fixes an internal database classification issue where certain PostgreSQL system tables could be mistaken for temporary tables. The change improves reliability of core database handling and reduces the risk of incorrect behavior during model or table checks.
Original PR description
17c4f47b0ae7a0eec78b5555d52eeb0bb5e3cc5a updated table_kind to return `pg_class.relkind`, however the semantics are *not* the same, and that was ignored: `relkind = t` is for *toast* tables, not *temporary* tables. In `pg_class` the temporary-ness is instead signaled by `relpersistence` (which applies to both tables and sequences), temp (and unlogged) tables have `relkind = r`. `existing_tables` does that correctly, possibly unwittingly. While at it, upgrade `table_kind` to return an `enum` (whose value is the old discriminant, except for the previously unclassified values which all get shoved into `Other` for now, maybe they should error instead?).
This fixes an unreliable guest messaging scenario where a returning guest could receive a chat notification before the messaging system was ready. The change helps prevent failed automated checks and improves confidence in the stability of public chat channel behavior.
Original PR description
This PR fixes the `19916` issue on the `test_mail_channel_public_page_as_guest` test. The messaging service subscribes to bus notifications before it is fully initialized. This test is composed of two tours. In the first one, the guest joins the channel and receives the "guest has joined the channel" message. Then, the second tour starts and the local storage is cleared. Since the local storage has been cleared, the guest receives this message again, potentially before messaging has been initialized which leads to a `channel_pin` rpc. This RPC fails with `SessionExpired` error and the tour is stuck and eventually, fails.
The mail app no longer automatically opens an OdooBot chat window when a user logs in. This prevents an unnecessary pop-up and keeps the login experience cleaner and less distracting.
Messages without a linked author now display the email sender instead of leaving the sender information blank. This helps users identify who sent a message and reduces confusion when reviewing communications.