Monday, April 17, 2023
1 change · master
Code cleanup and technical improvements
This update removes outdated and unused styling rules from the Knowledge app after recent widget updates and Bootstrap 5 adoption. It should make the interface code easier to maintain without changing day-to-day user workflows.
Original PR description
Now that the widgets have been reworked and migrated to owl and now that we use Bootstrap 5, many css rules of Knowledge become outdated, unused or unnecessary over time. Changes and justifications:…
Now that the widgets have been reworked and migrated to owl and now that we use Bootstrap 5, many css rules of Knowledge become outdated, unused or unnecessary over time. Changes and justifications: - Since the first release of Knowledge, the `CopyClipboardChar` widget has been updated. The css adjustments we made are now no longer necessary. We can therefore remove them. - There are some leftover from the old emoji picker of Odoo. The related rules no longer apply to any element and can therefore be removed. - Some css rules like `user-select: none`, etc can be replaced with their inline bootstrap class counterpart (i.e: `user-select-none`). - Bootstrap already defines classes like `min-w-0`. There is therefore no need to re-define them in the Knowledge module. - There are some minor css adjustments for the property that are scoped to the editor container. As the property fields are not placed in that container, the rules do not apply and can be removed. - Some css adjustments for the embedded view will be moved to the dedicated file. task-3210683