Thursday, April 20, 2023
14 changes · master
Resolved issues and error corrections
Opening Discuss from a chat window now keeps the app name consistent in breadcrumbs. This prevents users from seeing a confusing "Unnamed" label when navigating to channel settings.
Original PR description
Before this commit, when opening Discuss from chat window and then accessing the settings page of a channel, the breadcrumb showed "Unamed" as the name of the App instead of "Discuss". This happens because the client action was not named when expanding the chat window by opening Discuss app.
This fixes a visual glitch where the “read more” button briefly appeared while users quickly created a new Kanban card. The change makes the Kanban view feel smoother and avoids momentary confusion during record creation.
Original PR description
Before this commit, when quick creating a new record in a kanban view, the "read more" button is briefly shown (flickering). This issue occurs because, when creating a new record, we increment the number of records in the group before adding the record to the list of displayed records. This means that for a brief moment the number of records of the group is bigger than the number of displayed records, therefore the "load more" button is show. Now, we increment the number of records on the group after we added the record to the displayed records' list.
Opening Discuss from a chat window now keeps the app name set correctly when users navigate to channel settings. This prevents the breadcrumb from showing an unclear “Unnamed” label, making navigation clearer and more professional.
Original PR description
Before this commit, when opening Discuss from chat window and then accessing the settings page of a channel, the breadcrumb showed "Unamed" as the name of the App instead of "Discuss". This happens because the client action was not named when expanding the chat window by opening Discuss app.
This fixes an issue where selecting fields such as Sales Team on mobile could show the wrong list view in newer Odoo versions. The change updates how related kanban views are referenced so users see the intended selection interface across Sales, CRM, POS Sales, and website sales flows.
Original PR description
Steps to reproduce: - Install Sales. - Go to any quotation and toggle mobile device mode in the browser. - Go to Other Info > click in Sales Team field. Issue: We stop supporting the 'kanban_view_ref' in newer versions of odoo. So we won't be able to get proper view. Solution: Changed the way we ref the kanban view to use context to get the referenced kanban view. Related to #[39499](https://github.com/odoo/enterprise/pull/39499) opw-3152174
Manufacturing orders for serial-tracked products can now be completed correctly after using Mass Produce. This prevents an error that blocked users from validating split production orders, helping production teams finish batches without manual workarounds.
Original PR description
Description of the issue/feature this PR addresses: Issue : When mass producing a tracked product, an User Error is raised on validation of splitted MO. Reproduction : - Create Serial storable product "Component A", Lot storable product "Component B", Serial Storable product "Finished Serial Product" - Immediate Transfer 10 * "Component A" and 20 * "Component B" - Create a BoM for "Finished Serial Product", consuming 1 * "Component A" and 2 * "Component B" - Create a Manufacturing Order for 10 * "Finished Serial Product" and Confirm - Click on "Mass Produce", Set "First SN", Generate all the serials and Apply - Click on "Produce All" on the splitted MO Current behavior before PR: User Error Desired behavior after PR is merged: Working fine Task : 3274962 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update keeps PDF-related font handling working with newer versions of the fonttools library. It helps avoid failures when generating or processing PDFs after dependency updates, with no expected change to normal user workflows.
Original PR description
Support recent version of fonttools. In particular, class `_TTGlyphSet` was refactored between 4.37.1 and 4.37.2 and no longer has an `_htmx` attribute. Instead, the new attribute `hMetrics` can be used to get the metrics from htmx. see: https://github.com/fonttools/fonttools/compare/4.37.1...4.37.2
The chat window now shows a subtle divider between the header and message content when content is present. This makes the interface easier to read and reduces visual confusion for users.
Original PR description
Before this commit, content inside chat window could visually fuse with the header in a way that makes it hard to see the separation between the header and the content. This commit fixes the issue by adding a small border below header when there is some content. Before/After <img width="341" alt="before-w" src="https://user-images.githubusercontent.com/6569390/233338963-78705781-5653-4d05-9c5e-0a78cdd19435.png"> <img width="340" alt="after-w" src="https://user-images.githubusercontent.com/6569390/233338988-1f463737-7804-4b92-a372-1fb1c36c1283.png"> <img width="347" alt="before-d" src="https://user-images.githubusercontent.com/6569390/233339057-057eff6d-bfdb-4e6f-bb25-b7a4afdc3525.png"> <img width="338" alt="after-d" src="https://user-images.githubusercontent.com/6569390/233339088-7be3371f-18a2-4da1-b5ad-72055116968c.png">
This fix prevents parts of a website table of contents block from being dragged outside of their original block. It helps avoid broken page navigation when editors arrange content in the website builder.
Original PR description
In the table of content snippet, both its generated entries and its content wrapper can be dropped outside of it. This cannot be allowed because the entries are generated from the wrapped content that belongs to the same table of content snippet. If any of them is missing, the feature is broken. This commit prevents this by hiding the drag handle from the generated table of content and from the content wrapper. Note that they can still be moved using the arrows. task-2752391
This fixes an issue in the Mail app where clicking a reply preview could trigger across an overly wide area of the conversation. The clickable area now matches the reply text itself, making message interactions more predictable and reducing accidental clicks.
Original PR description
Before this commit, clickable of a reply-to message mistakenly extended all the way to the other end of the conversation. # Before <img width="980" alt="Screenshot 2023-04-20 at 16 15 11" src="https://user-images.githubusercontent.com/6569390/233393944-eeed82d4-5334-47c9-b23d-8994f29abfc7.png"> # After <img width="978" alt="Screenshot 2023-04-20 at 16 11 06" src="https://user-images.githubusercontent.com/6569390/233393731-f6671292-ab3d-4eda-8621-38ad74e38058.png">
A recent internal refactoring accidentally removed handling for simple notification alerts used by several Odoo apps. This fix restores those alerts so users continue to see important messages with the expected warning or danger level.
Original PR description
* = base_geolocalize, calendar, website_crm_partner_assign Oversight of discuss refactoring. Code is restored into bus module as it does not depend on any mail or discuss feature. ----- Note: default type (unless `warning` was specified) was `danger` before https://github.com/odoo/odoo/blob/5da763a8ef0503286fa5cc55e32970f4d785825a/addons/mail/static/src/models/messaging_notification_handler.js#L429 and now the default from notification service is kept (it is `warning`) so `danger` is added in code to keep the same behavior.
Odoo Studio now correctly ignores fields that a user is not allowed to access when opening or editing views. This prevents access rights errors and lets users continue working in Studio even when a view contains restricted fields.
Original PR description
Commit @baebb6a5b05ac8d59501a6071a5513e31a4ca047 introduced a universal way to handle multiple instances of the same field in a view arch. To do so, it separates what fields are to be fetched (activeFields) from the "instances" of those fields in the arch (fieldNodes). Studio's code was only partially ready, relying on the fact that the key for fieldNode was the field's name, which isn't true any longer. This commit fixes that, and removes from the fieldNodes the ones that have studio_no_fetch and more importantly removes them from activeFields. To reproduce: have a field with a group declared in python, which the user doesn't have. Open studio with a view that has that field in the arch. Before this commit, there was an access rights crash. After this commit, there is no crash.
Users can now insert links to Odoo menus in spreadsheets without being unexpectedly sent back to the Odoo home page. The menu picker also better reflects the currently selected item and includes apps, making accidentally removed app links easier to restore.
Original PR description
This PR fixes the problem when inserting a link to an odoo menu, clicking the menu item in the dropdown will jump to odoo home page, and the insertion fails. The root cause is the menu item uses `a` tag and has a `href` leading to home page. The solution is to prevent the default clicking behavior. This PR also fixs a small bug of showing currently selected menu item. task [3159543](https://www.odoo.com/web#id=3159543&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)
This fix ensures selection popups, such as choosing a sales team on a quotation in mobile view, open with the correct layout in newer Odoo versions. It updates affected areas to use the supported method for loading kanban-style selection views, preventing broken or unsuitable displays.
Original PR description
Steps to reproduce: - Install Sales. - Go to any quotation and toggle mobile device mode in the browser. - Go to Other Info > click in Sales Team field. Issue: We stop supporting the 'kanban_view_ref' in newer versions of odoo. So we won't be able to get proper view. Solution: Changed the way we ref the kanban view to use context to get the referenced kanban view. Related to #[116031](https://github.com/odoo/odoo/pull/116031) opw-3152174
Inviting people to a Knowledge article no longer duplicates the article name in the breadcrumb trail. The invite window now stays open after sending invitations so users can see confirmation, while the relevant panels refresh only when needed.
Original PR description
Purpose: - Currently, after inviting someone to an article using the invite modal, the article is added to the breadcrumbs even though we stay on the same article (we thus have the same article name twice in the breadcrumbs). This happens because the `action_invite_members` action returns an action window to reload the form view (to reload the sidebar in case the article went from private to shared). After this commit, the action won't return an action window anymore, but closing the invite modal will reload the permission panel and the sidebar only if the article changed from category. This also allows to keep the invite modal open after inviting new members on an article, allowing the user to get a visual feedback that the members have been invited. Task-3159149