Odoo Changelog — 2023-05-05

Friday, May 5, 2023

9 changes · master

Bug Fixes(9)

Resolved issues and error corrections

[FIX] project: fix validation error of quick create view and assignment notification email structure

Coremasterproject

Creating a project task without a title now shows a clear notification instead of a technical validation error. Task assignment emails are also formatted correctly so the subject and message body are easier to read.

Original PR description

- In the quick create view, do not enter a value in the Task Title field and try to create a task, a validation error is showing instead of a toast notification highlighting that a required field is not set.
- In your inbox, when you are assigned to a task, you receive mail from the project. In that mail, the mail subject and body are displayed in one line.


In this PR, 
display_name field is set as a required field, meaning that if the field is left empty, a notification will appear in the form of a toast message instead of a validation error.
The mail template's 'assignee_name' field currently has a 'span' tag, which may cause inline subject and body issues. To prevent this, it is recommended to use a 'div' tag instead.

#tasks#notifications#email

[FIX] project: fix stat button in project

PR #118305

Coremastersale_project

The project app now only shows the Sales Order button for a task when that task has its own linked sales order line. This prevents users from seeing a misleading sales order link after it has been removed from the task.

Original PR description

[[FIX] project: fix sale order stat button in project](https://github.com/odoo/odoo/pull/118305/commits/e76acba91c2a8d8ba63bdffef0d6ff051ef5a07e)

Steps:

    install sale_project
    set SOL on project
    set SOL on task and remove it

Issue:

    when we set SOL on task SO stat button is visible but when we remove SOL from
    task SO stat button is visible

Cause:

    compute of SO was tasking SO from task SOL but when there is no SOL on the task
    it is taking SO from Project SOL

Fix:

    make SO related to SOL from the task because SO stat button should be visible
    according to task SOL

task-3251672

#project#sales order#task

[FIX] mail: arrow up/down should change selection inside composer

PR #120657

Coremastermail

Fixed an issue where the up and down arrow keys did not move correctly between lines when writing multi-line messages. This also prevents accidental editing of the last message unless the message box is empty, making message composition more predictable.

Original PR description

Before this commit, when composer had some text content in
multi-line, arrow up/down was not jumping to previous/next
line.

This happens because the navigable list is active even when not
shown, and was preventing all keydown events.

This commit fixes the issue by limiting handling of keydown
events of navigable list to when it is shown.

Also fixes a bug where the quick edit of last message was triggered
when composer text was non-empty with ArrowUp. This should only
be triggered when the composer text input is empty.

#composer#keyboard navigation#messages

[IMP] core: make onchange2 work with properties fields

PR #120457

Coremasterwebcrmtest_new_apibaseMedium

This change improves how Odoo handles property-style fields when records are updated dynamically, preventing incorrect or empty values during onchange flows. It also avoids saving invalid property names in some edge cases, making record creation and updates more dependable for users.

Original PR description

The issue with properties fields is that the value in the record snapshot is not correct.  This is caused by `convert_to_record()` combining the values with the definition, and in the case of `onchange()`, the values don't match the definition, which causes the method to return the empty list `[]`.

We fix the root cause by changing `convert_to_record()` to return the `dict` itself.  The combination of the values with the definition is now only done in `convert_to_read()`.  Method `convert_to_onchange()` has only one hack to retrieve the current definition record from the record snapshot, as because of cache invalidation, its value is no longer available.

#properties#onchange#data consistency

[DRAFT][FIX] spreadsheet_edition: design fixes for milk

PR #40781

Enterprisemasterspreadsheet_editionaccount_accountantaccount_assetaccount_auto_transferaccount_bank_statement_import_ofxaccount_bank_statement_import_qifaccount_batch_paymentaccount_consolidationaccount_followupaccount_reportsdocumentsweb_enterprisehr_appraisalhr_appraisal_skillsplanningsignsocialstock_barcodeweb_studioweb_gantt

[FIX] marketing_automation: filter test traces on activity domain

PR #39391

Enterprisemastermarketing_automationMedium

Marketing campaign tests now apply the same activity filters as live campaigns, so test runs only process records that match the intended rules. This helps teams validate campaigns more accurately before launch and reduces misleading test results.

Original PR description

Before this commit, when launching a test for a marketing campaign, activity domains are ignored - records are processed even if they don't respect the domain.

With this commit, tests behave as real campaigns, meaning the domains are taken into account.

Task-3138559

#marketing#campaign testing#filters

[IMP] account_accountant: add a default currency on bank/cash journals

PR #26809

Enterprisemasteraccount_accountantaccount_reportsaccount_sepa_direct_debit

This update adjusts accounting-related tests so they correctly handle default currencies on bank and cash journals. It helps keep reconciliation, cash flow, and SEPA payment checks reliable after the journal currency behavior change.

Original PR description

Task 2834678

Adding a default currency on bank and cash journals breaks reconciliation tests.
This PR fixes the tests by adjusting currency_id.

#accounting#journals#currency#tests

[IMP] mail: Show reorder template response

PR #35466

Enterprisemasterhelpdeskhelpdesk_mail_pluginMedium

Helpdesk ticket messages now appear in the correct chronological order when created from incoming emails or related flows. This makes conversations easier to follow and updates internal checks to match the new tracking message behavior.

Original PR description

Update parts of the code that relied on tracking being
handled during the creation process and tracking tests 
that expected 'notification' message type.

Task-2834304

#helpdesk#messages#email#tracking

[FIX] web_studio: No options shown in kanban default group by

PR #40640

Enterprisemasterweb_studio

Odoo Studio now correctly shows available fields when setting the default grouping for Kanban views. This lets users configure Kanban organization from the sidebar as expected, avoiding confusion and failed setup changes.

Original PR description

Before this commit:
In the Kanban view sidebar editor, the default group by would not show
any choices.

After this commit:
The default group by options shows the proper field choices and
choosing one updates the view.

Task Id: 3274711

#kanban#studio#grouping

- In the quick create view, do not enter a value in the Task Title field and try to create a task, a validation error is showing instead of a toast notification highlighting that a required field is not set. - In your inbox, when you are assigned to a task, you receive mail from the project. In that mail, the mail subject and body are displayed in one line. In this PR, display_name field is set as a required field, meaning that if the field is left empty, a notification will appear in the form of a toast message instead of a validation error. The mail template's 'assignee_name' field currently has a 'span' tag, which may cause inline subject and body issues. To prevent this, it is recommended to use a 'div' tag instead.

[[FIX] project: fix sale order stat button in project](https://github.com/odoo/odoo/pull/118305/commits/e76acba91c2a8d8ba63bdffef0d6ff051ef5a07e) Steps: install sale_project set SOL on project set SOL on task and remove it Issue: when we set SOL on task SO stat button is visible but when we remove SOL from task SO stat button is visible Cause: compute of SO was tasking SO from task SOL but when there is no SOL on the task it is taking SO from Project SOL Fix: make SO related to SOL from the task because SO stat button should be visible according to task SOL task-3251672

Before this commit, when composer had some text content in multi-line, arrow up/down was not jumping to previous/next line. This happens because the navigable list is active even when not shown, and was preventing all keydown events. This commit fixes the issue by limiting handling of keydown events of navigable list to when it is shown. Also fixes a bug where the quick edit of last message was triggered when composer text was non-empty with ArrowUp. This should only be triggered when the composer text input is empty.

The issue with properties fields is that the value in the record snapshot is not correct. This is caused by `convert_to_record()` combining the values with the definition, and in the case of `onchange()`, the values don't match the definition, which causes the method to return the empty list `[]`. We fix the root cause by changing `convert_to_record()` to return the `dict` itself. The combination of the values with the definition is now only done in `convert_to_read()`. Method `convert_to_onchange()` has only one hack to retrieve the current definition record from the record snapshot, as because of cache invalidation, its value is no longer available.

Before this commit, when launching a test for a marketing campaign, activity domains are ignored - records are processed even if they don't respect the domain. With this commit, tests behave as real campaigns, meaning the domains are taken into account. Task-3138559

Before this commit: In the Kanban view sidebar editor, the default group by would not show any choices. After this commit: The default group by options shows the proper field choices and choosing one updates the view. Task Id: 3274711