Friday, May 19, 2023
2 changes · master
Enhancements to existing features
This update makes internal transaction handling process environments in a predictable order, avoiding inconsistent behavior that could vary between system runs. It also adds tests to confirm the new behavior remains stable without affecting cleanup of unused resources.
Original PR description
The Weakset Used for envs can lead to unpredictible behaviour when calling flush on the transaction because we iterate on the `envs`. Since WeakSet.data is a set, the iteration will depends on the python hash seed. This commit proposes to replace Transaction.envs.data by an OrderedSet to solve this issue. Some test demonstrates that it does not affect the garbage collection and that the order is now deterministic. The question to now if we should reverse the envs to find the most suitable envs remains.
The mail attachment previewer can now be closed through an internal event, enabling related apps like Documents to dismiss previews automatically when needed. This improves workflow consistency and reduces manual user actions when navigating or updating document views.
Original PR description
Purpose ======= In documents, we want to close the previewer using bus event. Task-3290796