Tuesday, May 23, 2023
8 changes · master
Resolved issues and error corrections
A broken cleanup call was removed from a web test after the browser testing tools changed. This keeps automated checks running reliably without affecting everyday users.
Original PR description
As the ChromeBrowser API was simplified in 2b0d9fa6a9, the terminate_browser method was removed but the shiny author forgot to remove the call in the click_everywhere test.
This update adds a shared way for Odoo tests to create realistic server errors. It helps prevent misleading test results where an error dialog appeared for the wrong reason, improving confidence in future quality checks without changing customer-facing behavior.
Original PR description
In this commit we add the makeServerError utility which allows you to easily create a valid RPCError in the tests. We have added this utility to prevent the use of invalid or incomplete errors. We will give default values for all the parameters needed for a valid RPCError. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Reports no longer show unwanted blank space below embedded content. This removes an unnecessary vertical scrollbar, making report viewing cleaner and less distracting for users.
Original PR description
This commit removes whitespace below iframes in reports, which also caused an unnecessary vertical scrollbar to appear. task-3334745 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where automated website tours could attach to the wrong Chrome page and get stuck. The test runner now identifies the correct blank page more carefully and avoids first-run browser popups, making test execution more dependable.
Original PR description
It's not clear when and how this happened but apparently "headful" chrome has a built-in background_page for hangouts which appears before the `about:blank` page in the list of targets, and possibly…
It's not clear when and how this happened but apparently "headful" chrome has a built-in background_page for hangouts which appears before the `about:blank` page in the list of targets, and possibly appears before the `about:blank` page has opened at all.
odoo/odoo#111422 was tested with chromium which apparently doesn't have this feature either (or does it?), which probably contributes to having no idea when it appears.
This feature also doesn't respond to `--disable-extensions`, despite its url marking it as one:
chrome-extension://nkeimhogjdpnpccoofpliimaahmaaome/background.html
The result was that the tour runner would hook onto the hangouts target and try to load pages, which it would reject with `net::ERR_ABORTED`, hence the tours just getting stuck.
Fix by improving the heuristic to find a content page: look for a target of type `page`, and with the url `about:blank`, rather than just take whichever tab target is listed first. Requires modifying `stop` as it can now be called after we've started the browser, but before we've created the websocket connection.
Also move `--no-first-run` from the headless to the default switches to avoid Chrome's migration & default browser popup, apparently it doesn't cause Chromium grief anymore (???). If this turns out to be a concern, add a condition on the `executable` or something.This update cleans up and reorganizes mass mailing code and tests while fixing how subscription-related fields are calculated. It helps ensure mailing list subscription and unsubscription information stays accurate, with no major visible change expected for users.
Images attached to expenses now display centered in the attachment area instead of appearing misplaced. This improves the visual consistency of expense records and makes attached receipts easier to review.
Original PR description
Before this pr, when attaching an image to an expense, the image was misplaced. By adding a display flex and justify the content in the center, the image is now vertically align in the center. task-id: 3329707 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Web Studio XML editor sidebar can no longer be resized beyond the visible screen width. This prevents layout issues and reduces unexpected behavior while users resize the panel.
Original PR description
Before this commit: When resizing the XmlEditor the user could resize the panel beyond the screen width. After this commit: - The maximum width of the panel is now 100% of the screen width. - The resize event now also stops propagation and prevents default which prevent some unexpected behaviours when the mouse hovers other elements while resizing. **Retargeted to saas-16.3 https://github.com/odoo/enterprise/pull/41359**
The Knowledge sidebar close button works again after its page structure changed. This restores a small but visible interaction so users can hide the sidebar as expected while working with articles.
Original PR description
Currently, the button allowing the user to close the sidebar when the sidebar is revealed no longer work. The id "knowledge_search_bar" has been moved in the dom hierarchy. As a result, the css selector `#knowledge_search_bar > a` used to select the button and add the click listener to close the sidebar does not match with an element. Therefore, the button doesn't do anything. This commit will fix the issue by updating that css selector. Related: https://github.com/odoo/enterprise/commit/ccdcc00da36c03754f37198c31ce272214148c09 task-3326414