Tuesday, June 6, 2023
24 changes · master
Enhancements to existing features
This update refreshes and aligns app icons across several Odoo apps and localization modules, reducing inconsistencies between icon formats. Business users should see more consistent app branding and cleaner module presentation, with no expected workflow changes.
Original PR description
task-2766273
Several Helpdesk-related workflows now open medium-sized pop-up dialogs instead of large ones. This makes common wizard screens feel less oversized and easier to use without changing the underlying business process.
Original PR description
Reduce the size of the wizard dialog in helpdesk and timesheet app In this commit, in this commit, We have changed the size of wizard dialog to medium instead of large. task-3259212
Resolved issues and error corrections
The Documents app now automatically closes the preview panel when a document is archived, restored, or deleted after being archived. This avoids showing users a preview of a document that is no longer active or available in the current view.
Original PR description
How to reproduce: - In the apps document - Click on a document to open its preview - Archive it through the document inspector on the right - The preview is still open while the document is archived With this fix, the preview is automatically closed when archiving the document. The same behavior happens when un-archiving a document or when deleting an archived document. So the same fix has been applied for those conditions as well. Task-3326468
Features or functions removed from Odoo
* sale_subscription_dashboard, project_timesheet_synchro before this commit, wrong directories are added by following commit https://github.com/odoo/enterprise/commit/20f01dc1de6933e32749e960e0e8a1b4abd310af after this commit, wrong directories are removed
Original PR description
* sale_subscription_dashboard, project_timesheet_synchro before this commit, wrong directories are added by following commit https://github.com/odoo/enterprise/commit/20f01dc1de6933e32749e960e0e8a1b4abd310af after this commit, wrong directories are removed
Miscellaneous changes
Before this commit, in the `_l10n_be_parse_soda_file` function, `journal_company_id` used the `default_journal_id` from context to find the existing account. However if `default_journal_id` did not exist in the context, `journal_company_id` would be `False` and is not able to find the account, if it existed. It then tries to create the account, leading to this violation of a SQL constraint and causing this error: ``` psycopg2.errors.UniqueViolation: duplicate key value violates unique constrai
Original PR description
Before this commit, in the `_l10n_be_parse_soda_file` function, `journal_company_id` used the `default_journal_id` from context to find the existing account. However if `default_journal_id` did not exist in the context, `journal_company_id` would be `False` and is not able to find the account, if it existed. It then tries to create the account, leading to this violation of a SQL constraint and causing this error: ``` psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint \"account_account_code_company_uniq\" ``` opw-3302504 Forward-Port-Of: odoo/enterprise#41803
In the helpdesk setting, the related documentation pages are updated following the change of URL introduced by the doc PR https://github.com/odoo/documentation/pull/3974/ task-3251828 Forward-Port-Of: odoo/enterprise#42006 Forward-Port-Of: odoo/enterprise#41789
Original PR description
In the helpdesk setting, the related documentation pages are updated following the change of URL introduced by the doc PR https://github.com/odoo/documentation/pull/3974/ task-3251828 Forward-Port-Of: odoo/enterprise#42006 Forward-Port-Of: odoo/enterprise#41789
The cause: tour clicks can occur faster than ochange events The bank recon view is managed almost entirely with onchange events, for example, when a new statement line is selected, the field todo_command is changed to trigger_matching_rules, and when a move line is mounted the todo_command changes to add_new_amls The tour steps were: - remove the not matched filter (which would select a statement line, and trigger an onchange) - change the pager (which would do the same, even though the sta
Original PR description
The cause: tour clicks can occur faster than ochange events The bank recon view is managed almost entirely with onchange events, for example, when a new statement line is selected, the field…
The cause: tour clicks can occur faster than ochange events The bank recon view is managed almost entirely with onchange events, for example, when a new statement line is selected, the field todo_command is changed to trigger_matching_rules, and when a move line is mounted the todo_command changes to add_new_amls The tour steps were: - remove the not matched filter (which would select a statement line, and trigger an onchange) - change the pager (which would do the same, even though the statement line is not changing) - mount an AML (which needs the onchange queue to be free, for the line to actually mount) In some rare cases (non-deterministic), the onchange responses are not received as fast as the clicks, and since there is not always a change to the view (pager step) there is no way to determine whether an onchange is still processing. The solution: Since this flow would rarely occur in real life user scenarios, we can simply move some tour steps around The steps are now: - remove the not matched filter - mount the aml and validate it the recon - change the pager when the statement line is updated in the UI - continue after the pager change is visible in the UI Solves runbot build error 15764 Forward-Port-Of: odoo/enterprise#41424
**How to reproduce the bug** ======================== 1. select multiple documents in a workspace. 2. click on "Create a task" action button. => a singleton traceback is raised. **Technical** ========= documents._get_html_link() is getting multiple ids and because of that a singleton traceback is raised. **After this commit:** ================== Now the singleton traceback will not raise and a task will be properly created. Task-3305373 Forward-Port-Of: odoo/enterprise#41383
Original PR description
**How to reproduce the bug** ======================== 1. select multiple documents in a workspace. 2. click on "Create a task" action button. => a singleton traceback is raised. **Technical** ========= documents._get_html_link() is getting multiple ids and because of that a singleton traceback is raised. **After this commit:** ================== Now the singleton traceback will not raise and a task will be properly created. Task-3305373 Forward-Port-Of: odoo/enterprise#41383
Since https://github.com/odoo/odoo/commit/926c4d4769db1846d94e2ab5a3e9b02308b0b160 the gantt view retrieves unavailabilities only for workcenter rows leading to erroneous accumulations when grouping, for example, by stage or by production. We are now retrieving unavailabities so that the accumulations are correct. We notice also, but only in Firefox, that moving the mouse over total pills sometimes gives TypeError: ev.target.closest is not a function find (/web_gantt/static/src/ga
Original PR description
Since https://github.com/odoo/odoo/commit/926c4d4769db1846d94e2ab5a3e9b02308b0b160 the gantt view retrieves unavailabilities only for workcenter rows leading to erroneous accumulations when grouping, for example, by stage or by production. We are now retrieving unavailabities so that the accumulations are correct. We notice also, but only in Firefox, that moving the mouse over total pills sometimes gives TypeError: ev.target.closest is not a function find (/web_gantt/static/src/gantt_renderer.js:1867) onMouseMove (/web_gantt/static/src/gantt_renderer.js:1869) This because the event's target may be - #text "01:28" (TextPrototype) rather than - <span class="o_gantt... (HTMLSpanElementPrototype) or - <div class="o_gantt... (HTMLDivElementPrototype) task: 3305266 Forward-Port-Of: odoo/enterprise#41927
It shouldn't be an api.model since all other caret options aren't. Forward-Port-Of: odoo/enterprise#41271
Original PR description
It shouldn't be an api.model since all other caret options aren't. Forward-Port-Of: odoo/enterprise#41271
The Vehicle split filter was showing up on all the reports when it should only appear on the disallowed expense report. Forward-Port-Of: odoo/enterprise#41269
Original PR description
The Vehicle split filter was showing up on all the reports when it should only appear on the disallowed expense report. Forward-Port-Of: odoo/enterprise#41269
Before this PR, when printing a report the title was missing, this has already been addressed in this PR: https://github.com/odoo/enterprise/pull/36163. In addition, we had to add the vat number and the address in the header of the report in addition some other changes has been done: * When selecting an options for comparison or analytic, it seems that the percent / debug icon was present in each line of the header, by adding another condition, it solves the problem * The ir_filter options
Original PR description
Before this PR, when printing a report the title was missing, this has already been addressed in this PR: https://github.com/odoo/enterprise/pull/36163. In addition, we had to add the vat number and the address in the header of the report in addition some other changes has been done: * When selecting an options for comparison or analytic, it seems that the percent / debug icon was present in each line of the header, by adding another condition, it solves the problem * The ir_filter options does not exist anymore in 16.0, it has been replaced by horizontal group. * The options filter wasn't displayed in the pdf, by adding a new template to avoid duplicated code the commit allow to add that * The cash basis options displayed next to the filter options was not displayed either, i've added that and also creating a new template to avoid duplicating code. Task-id: 3171683 Forward-Port-Of: odoo/enterprise#41680 Forward-Port-Of: odoo/enterprise#36760
On the contract, the salary structure type should be selected after the field employee/job position/contract template/salary structure type, in case it is set. task - 3302330 Forward-Port-Of: odoo/enterprise#40840
Original PR description
On the contract, the salary structure type should be selected after the field employee/job position/contract template/salary structure type, in case it is set. task - 3302330 Forward-Port-Of: odoo/enterprise#40840
Current behavior: The field URL for attachments is being hidden after it is edited, this is incorrect as the user can't no longer see the value saved in the field. https://www.loom.com/share/a4ec3e2b9c5b432e9909483d12696f75 Expected behavior: The field l10n_co_edi_attachment_url should remain visible after it is edited. Task id: 333064 Forward-Port-Of: odoo/enterprise#41239
Original PR description
Current behavior: The field URL for attachments is being hidden after it is edited, this is incorrect as the user can't no longer see the value saved in the field. https://www.loom.com/share/a4ec3e2b9c5b432e9909483d12696f75 Expected behavior: The field l10n_co_edi_attachment_url should remain visible after it is edited. Task id: 333064 Forward-Port-Of: odoo/enterprise#41239
fieldInfo contains the information needed by the model to fetch the data, but doesn't reflect what the arch imposes the view to display. Before this commit, when a field appeared multiple times, and one clicked on the second to view its properties it was the second field's attributes that were displayed After this commit, the right field's attributes are displayed in the sidebar opw-3199875 Forward-Port-Of: odoo/enterprise#39474 Forward-Port-Of: odoo/enterprise#39417
Original PR description
fieldInfo contains the information needed by the model to fetch the data, but doesn't reflect what the arch imposes the view to display. Before this commit, when a field appeared multiple times, and one clicked on the second to view its properties it was the second field's attributes that were displayed After this commit, the right field's attributes are displayed in the sidebar opw-3199875 Forward-Port-Of: odoo/enterprise#39474 Forward-Port-Of: odoo/enterprise#39417
Have a stat button, open studio on that form view. Click on the button, activate rainbow man. Deactivate it. Before this commit, the VieweditorSidbar failed to display the rainbow man as off. After this commit it does. opw-3277139 Forward-Port-Of: odoo/enterprise#41892 Forward-Port-Of: odoo/enterprise#41797
Original PR description
Have a stat button, open studio on that form view. Click on the button, activate rainbow man. Deactivate it. Before this commit, the VieweditorSidbar failed to display the rainbow man as off. After this commit it does. opw-3277139 Forward-Port-Of: odoo/enterprise#41892 Forward-Port-Of: odoo/enterprise#41797
-Improve wording: -Emp_code -> Employee Code -Joining date -> Joining Date - Net color: #875A7B -> #00A09D - we insert buttom border in the net component. Forward-Port-Of: odoo/enterprise#41924
Original PR description
-Improve wording:
-Emp_code -> Employee Code
-Joining date -> Joining Date
- Net color: #875A7B -> #00A09D
- we insert buttom border in the net component.
Forward-Port-Of: odoo/enterprise#41924If the user does not have access to any of the Belgian companies, hide the menuitem 'Belgium'. task - 3332926 Forward-Port-Of: odoo/enterprise#41770
Original PR description
If the user does not have access to any of the Belgian companies, hide the menuitem 'Belgium'. task - 3332926 Forward-Port-Of: odoo/enterprise#41770
The hierarchy level of unfolded lines is buggy in the partner ledger. Every line is put on the same indent level => We want to fix that. task-3301169 Forward-Port-Of: odoo/enterprise#41136
Original PR description
The hierarchy level of unfolded lines is buggy in the partner ledger. Every line is put on the same indent level => We want to fix that. task-3301169 Forward-Port-Of: odoo/enterprise#41136
Steps to repoduce: - Install the helpdesk module. - Go to helpdesk, go inside any team and select any ticket. - Now use your browser to inspect and toggle device toolbar (or use a real smartphone). - Now inside the ticket view form, try to change the ticket helpdesk team. Issue: We can't change the helpdesk team as we don't get a proper view adapted to mobile view that allows us to easily change the team. Solution: Added proper context with `kanban_view_ref` to ref to the prope
Original PR description
Steps to repoduce: - Install the helpdesk module. - Go to helpdesk, go inside any team and select any ticket. - Now use your browser to inspect and toggle device toolbar (or use a real smartphone). - Now inside the ticket view form, try to change the ticket helpdesk team. Issue: We can't change the helpdesk team as we don't get a proper view adapted to mobile view that allows us to easily change the team. Solution: Added proper context with `kanban_view_ref` to ref to the proper view for the helpdesk team. This fix is similar to: https://github.com/odoo/enterprise/pull/39499/ opw-3282805 Forward-Port-Of: odoo/enterprise#41733 Forward-Port-Of: odoo/enterprise#41012
When the "Prevent Sale of Zero Priced Product" parameter is activated, a rental product with a zero price period will always display its information. With this commit, the display will be the same as for a product with a sale price of zero, i.e. just the message to warn that it is not available and a "Contact Us" button. opw-3323271 Forward-Port-Of: odoo/enterprise#41535
Original PR description
When the "Prevent Sale of Zero Priced Product" parameter is activated, a rental product with a zero price period will always display its information. With this commit, the display will be the same as for a product with a sale price of zero, i.e. just the message to warn that it is not available and a "Contact Us" button. opw-3323271 Forward-Port-Of: odoo/enterprise#41535
This commit corrects some behaviours or issues caused by the migration to OWL of Studio with regards to the Studio Approvals flow. - When enabling approvals, there should be a new rule added by default. - Preview icons in the button should be reactive, update when the rules are. - Some styling has also been fixed and improved. Task id: 3291968 (Retarget of https://github.com/odoo/enterprise/pull/40900) Forward-Port-Of: odoo/enterprise#41332
Original PR description
This commit corrects some behaviours or issues caused by the migration to OWL of Studio with regards to the Studio Approvals flow. - When enabling approvals, there should be a new rule added by default. - Preview icons in the button should be reactive, update when the rules are. - Some styling has also been fixed and improved. Task id: 3291968 (Retarget of https://github.com/odoo/enterprise/pull/40900) Forward-Port-Of: odoo/enterprise#41332
(i) The tax support named '01' doesn't support document types with code '09'. Use document types with code '01' by default in withhold tests to better reflect real scenarios. (ii) Changed partner b to a because its identification type is RUC and covers most of the real scenarios that withholds can be generated, so it is suggested to keep most of the unit tests with this partner. (iii) For withholds from foreign partners specifically, the tax support should be '02' and not '01'. The related
Original PR description
(i) The tax support named '01' doesn't support document types with code '09'. Use document types with code '01' by default in withhold tests to better reflect real scenarios. (ii) Changed partner b…
(i) The tax support named '01' doesn't support document types with code '09'. Use document types with code '01' by default in withhold tests to better reflect real scenarios. (ii) Changed partner b to a because its identification type is RUC and covers most of the real scenarios that withholds can be generated, so it is suggested to keep most of the unit tests with this partner. (iii) For withholds from foreign partners specifically, the tax support should be '02' and not '01'. The related test is fixed and improved: - Partner b is kept instead of the new default partner, because this partner is used for unit tests with real scenarios of local people with VAT or Passport identification type and foreign people. - Partner b is adapted to use 'vat' identification because it is a document for a foreign partner and the XML must show certain tags such as tipoSujetoRetenido, which only appears when the identification type code in tipoIdentificacionSujetoRetenido tag is '08' and that was not currently being displayed by the unit test. - Custom withhold lines are created with appropriate taxes/values This screenshot of the Ecuadorian ATS data sheet shows the document types are supported per tax support. The tax support is in the first column, and the supported document type codes are in the third column.  Forward-Port-Of: odoo/enterprise#41219
Follow up of https://github.com/odoo/enterprise/pull/41549 Apparently the fix does not work starting from 16.2, likely due to the introduction of orm fetch method, which changes when fields are loaded in cache and when access rights are checked (the previous code was assuming res_id was already accessible but it is not guaranteed and it is now no longer the case). Part of task-3266643 Forward-Port-Of: odoo/enterprise#41957
Original PR description
Follow up of https://github.com/odoo/enterprise/pull/41549 Apparently the fix does not work starting from 16.2, likely due to the introduction of orm fetch method, which changes when fields are loaded in cache and when access rights are checked (the previous code was assuming res_id was already accessible but it is not guaranteed and it is now no longer the case). Part of task-3266643 Forward-Port-Of: odoo/enterprise#41957