Tuesday, June 6, 2023
29 changes · master
Miscellaneous changes
When the "Prevent Sale of Zero Priced Product" parameter is activated, a rental product with a zero price period will always display its information. With this commit, the display will be the same as for a product with a sale price of zero, i.e. just the message to warn that it is not available and a "Contact Us" button. opw-3323271 Forward-Port-Of: odoo/enterprise#41535
Original PR description
When the "Prevent Sale of Zero Priced Product" parameter is activated, a rental product with a zero price period will always display its information. With this commit, the display will be the same as for a product with a sale price of zero, i.e. just the message to warn that it is not available and a "Contact Us" button. opw-3323271 Forward-Port-Of: odoo/enterprise#41535
This commit corrects some behaviours or issues caused by the migration to OWL of Studio with regards to the Studio Approvals flow. - When enabling approvals, there should be a new rule added by default. - Preview icons in the button should be reactive, update when the rules are. - Some styling has also been fixed and improved. Task id: 3291968 (Retarget of https://github.com/odoo/enterprise/pull/40900) Forward-Port-Of: odoo/enterprise#41332
Original PR description
This commit corrects some behaviours or issues caused by the migration to OWL of Studio with regards to the Studio Approvals flow. - When enabling approvals, there should be a new rule added by default. - Preview icons in the button should be reactive, update when the rules are. - Some styling has also been fixed and improved. Task id: 3291968 (Retarget of https://github.com/odoo/enterprise/pull/40900) Forward-Port-Of: odoo/enterprise#41332
(i) The tax support named '01' doesn't support document types with code '09'. Use document types with code '01' by default in withhold tests to better reflect real scenarios. (ii) Changed partner b to a because its identification type is RUC and covers most of the real scenarios that withholds can be generated, so it is suggested to keep most of the unit tests with this partner. (iii) For withholds from foreign partners specifically, the tax support should be '02' and not '01'. The related
Original PR description
(i) The tax support named '01' doesn't support document types with code '09'. Use document types with code '01' by default in withhold tests to better reflect real scenarios. (ii) Changed partner b…
(i) The tax support named '01' doesn't support document types with code '09'. Use document types with code '01' by default in withhold tests to better reflect real scenarios. (ii) Changed partner b to a because its identification type is RUC and covers most of the real scenarios that withholds can be generated, so it is suggested to keep most of the unit tests with this partner. (iii) For withholds from foreign partners specifically, the tax support should be '02' and not '01'. The related test is fixed and improved: - Partner b is kept instead of the new default partner, because this partner is used for unit tests with real scenarios of local people with VAT or Passport identification type and foreign people. - Partner b is adapted to use 'vat' identification because it is a document for a foreign partner and the XML must show certain tags such as tipoSujetoRetenido, which only appears when the identification type code in tipoIdentificacionSujetoRetenido tag is '08' and that was not currently being displayed by the unit test. - Custom withhold lines are created with appropriate taxes/values This screenshot of the Ecuadorian ATS data sheet shows the document types are supported per tax support. The tax support is in the first column, and the supported document type codes are in the third column.  Forward-Port-Of: odoo/enterprise#41219
Follow up of https://github.com/odoo/enterprise/pull/41549 Apparently the fix does not work starting from 16.2, likely due to the introduction of orm fetch method, which changes when fields are loaded in cache and when access rights are checked (the previous code was assuming res_id was already accessible but it is not guaranteed and it is now no longer the case). Part of task-3266643 Forward-Port-Of: odoo/enterprise#41957
Original PR description
Follow up of https://github.com/odoo/enterprise/pull/41549 Apparently the fix does not work starting from 16.2, likely due to the introduction of orm fetch method, which changes when fields are loaded in cache and when access rights are checked (the previous code was assuming res_id was already accessible but it is not guaranteed and it is now no longer the case). Part of task-3266643 Forward-Port-Of: odoo/enterprise#41957