Wednesday, June 7, 2023
20 changes · master
Enhancements to existing features
The Knowledge app now uses clearer wording in an embedded dialog, asking users what items they want to manage. The dialog layout was also adjusted so the text and input align on one line, making the form easier to read and use.
Original PR description
This commit rewords the embedded dialog form *What do you want to manage ?* to *What items do you want to manage ?* and we also realign the text and input on single line. task-3138759
Code cleanup and technical improvements
This update reorganizes internal test setup code for Odoo Studio so it can be adjusted more easily in future work. It has no expected direct impact on users, but helps keep Studio development aligned with related platform changes.
Original PR description
Adapt from changes in community. Part of task-3265211 https://github.com/odoo/odoo/pull/124066
Miscellaneous changes
Without this change we may get an error later in `industry_fsm.view_task_form2_inherit` view. Example: ``` File "/home/odoo/src/odoo/saas-16.2/odoo/addons/base/models/ir_ui_view.py", line 768, in _raise_view_error raise err from from_exception ValueError: Element '<field name="planned_date_end">' cannot be located in parent view ``` This issue was observed during upgrades, more than 10 cases. Forward-Port-Of: odoo/enterprise#42043
Original PR description
Without this change we may get an error later in
`industry_fsm.view_task_form2_inherit` view.
Example:
```
File "/home/odoo/src/odoo/saas-16.2/odoo/addons/base/models/ir_ui_view.py", line 768, in _raise_view_error
raise err from from_exception
ValueError: Element '<field name="planned_date_end">' cannot be located in parent view
```
This issue was observed during upgrades, more than 10 cases.
Forward-Port-Of: odoo/enterprise#42043The User Agent was started before the VoIP configuration could be fetched, resulting in it being initialized in an unexpected state, preventing normal use of the application. Task-3355307 Forward-Port-Of: odoo/enterprise#42099
Original PR description
The User Agent was started before the VoIP configuration could be fetched, resulting in it being initialized in an unexpected state, preventing normal use of the application. Task-3355307 Forward-Port-Of: odoo/enterprise#42099
A fix of computeReportMeasures brought by https://github.com/odoo/odoo/pull/108526 makes necessary to add the group_operator key to the fields we want to be available as measures in the cohort view tests. We adapt serverData accordingly. opw-3061776 Forward-Port-Of: odoo/enterprise#42010
Original PR description
A fix of computeReportMeasures brought by https://github.com/odoo/odoo/pull/108526 makes necessary to add the group_operator key to the fields we want to be available as measures in the cohort view tests. We adapt serverData accordingly. opw-3061776 Forward-Port-Of: odoo/enterprise#42010
Have a foreign customer with country Germany Create a Bill for the customer and register payment Go to Accounting > Reporting > Transactions with Third Parties [DIOT] Export the 'DIOT (TXT)" file Issue: When customers try to upload the .txt on SAT, they get the error: Linea: 40 Cmapo: 6 - "Pais de residence: DE (No existe en el catalog) SE DETECTARON ERRORES" Country code in Odoo do not match the value expected by SAT Germany in Odoo has country code DE, but in SAT classification
Original PR description
Have a foreign customer with country Germany Create a Bill for the customer and register payment Go to Accounting > Reporting > Transactions with Third Parties [DIOT] Export the 'DIOT (TXT)" file Issue: When customers try to upload the .txt on SAT, they get the error: Linea: 40 Cmapo: 6 - "Pais de residence: DE (No existe en el catalog) SE DETECTARON ERRORES" Country code in Odoo do not match the value expected by SAT Germany in Odoo has country code DE, but in SAT classification the country code is DD opw-3176604 Forward-Port-Of: odoo/enterprise#41441 Forward-Port-Of: odoo/enterprise#40926
Purpose: - In website_knowledge, the portal view can be accessed as a public user. However, the route used to load more articles in the sidebar requires users to be logged in. Therefore, clicking on the load more button when not logged does not work. This commit changes the `auth` parameter of the load more route so that public users can also use the load more button. Note: [This commit](https://github.com/odoo/enterprise/pull/40703/commits/5b27306e24b493e4ddfebb62d4c2eb2039f7f570)
Original PR description
Purpose: - In website_knowledge, the portal view can be accessed as a public user. However, the route used to load more articles in the sidebar requires users to be logged in. Therefore, clicking on the load more button when not logged does not work. This commit changes the `auth` parameter of the load more route so that public users can also use the load more button. Note: [This commit](https://github.com/odoo/enterprise/pull/40703/commits/5b27306e24b493e4ddfebb62d4c2eb2039f7f570) has not been forwarded as the "shared with you" section is not used anymore and was therefore not relevant. Task-3300677 Forward-Port-Of: odoo/enterprise#40703
before this commit, on clicking the quick create + button from the subscription kanban view, is asking to input a value in the quick create pop up which is currently stored no where in the record. initially when the create get called from name_create the sequence is assigned for the code field and entered name in the quick create pop up is passed to the name field, when the user enter the further details like customer, subscription template and hit save, the value from the code which
Original PR description
before this commit, on clicking the quick create + button from the subscription kanban view, is asking to input a value in the quick create pop up which is currently stored no where in the record.…
before this commit, on clicking the quick create + button from the subscription kanban view, is asking to input a value in the quick create pop up which is currently stored no where in the record. initially when the create get called from name_create the sequence is assigned for the code field and entered name in the quick create pop up is passed to the name field, when the user enter the further details like customer, subscription template and hit save, the value from the code which contains sequential value is saved to the name field, thus we loose the value entered in the quick create pop up. * open subscription kanban * click + button * enter some values in the pop up and save * enter further details and save * entered value quick pop up is not stored anywhere in record after this commit, the quick create option from the subscription kanban will be removed. https://github.com/odoo/enterprise/assets/27989791/aa084fab-7f02-4cda-b3c2-ad8209aec290 Forward-Port-Of: odoo/enterprise#42030 Forward-Port-Of: odoo/enterprise#37261
This commit addresses an issue where the default filter accounts were not applied when opening the running balance from the accounting dashboard.. We extend the ControlPanel class in order to load the filter in the _attachAdditionalContent method. Steps: - Go to the Accounting Dashboard - On the bank journal card, click on 'Running Balance' -> The filter on accounts is not applied, it should be set with the Bank account of the journal. opw-3285660 Forward-Port-Of: odoo/enter
Original PR description
This commit addresses an issue where the default filter accounts were not applied when opening the running balance from the accounting dashboard.. We extend the ControlPanel class in order to load the filter in the _attachAdditionalContent method. Steps: - Go to the Accounting Dashboard - On the bank journal card, click on 'Running Balance' -> The filter on accounts is not applied, it should be set with the Bank account of the journal. opw-3285660 Forward-Port-Of: odoo/enterprise#41221 Forward-Port-Of: odoo/enterprise#40889
When doing the refactoring of account_reports for v16.0, we forgot to add a generic_tax_report template, the template_tax_report. Forward-Port-Of: odoo/enterprise#41320 Forward-Port-Of: odoo/enterprise#40632
Original PR description
When doing the refactoring of account_reports for v16.0, we forgot to add a generic_tax_report template, the template_tax_report. Forward-Port-Of: odoo/enterprise#41320 Forward-Port-Of: odoo/enterprise#40632
task - 3245846 Forward-Port-Of: odoo/enterprise#42042 Forward-Port-Of: odoo/enterprise#40365
Original PR description
task - 3245846 Forward-Port-Of: odoo/enterprise#42042 Forward-Port-Of: odoo/enterprise#40365
task-id : 3283540 Forward-Port-Of: odoo/enterprise#41965 Forward-Port-Of: odoo/enterprise#40990
Original PR description
task-id : 3283540 Forward-Port-Of: odoo/enterprise#41965 Forward-Port-Of: odoo/enterprise#40990
**Steps to reproduce the bug:** - Go to purchase order view form: - Add in any button an approval condition like: “Untaxed Amount” > 1000” - Create a purchase order: - Add any product with a price “< 1000” - save - edit - set the price to “> 1000” - save - click on that button **Problem:** Before this commit, the call to check the approvals was done before calling the "write" function. **Solution:** After this commit, we ensure that we save the reco
Original PR description
**Steps to reproduce the bug:**
- Go to purchase order view form:
- Add in any button an approval condition like: “Untaxed Amount” > 1000”
- Create a purchase order:
- Add any product with a price “< 1000”
- save
- edit
- set the price to “> 1000”
- save
- click on that button
**Problem:**
Before this commit, the call to check the approvals was done before calling the "write" function.
**Solution:**
After this commit, we ensure that we save the record before checking the approvals and before executing the wanted action.
opw-3170786
Forward-Port-Of: odoo/enterprise#42007Purpose: -------- Commit [1] refactored the breadcrumbs. Since then, renaming an embedded view did not show the new name until the view was reloaded (because the active element has not the same class as before). This commit uses the new class of the active element to update the name of the embedded view. [1]: https://github.com/odoo/odoo/commit/caef16ee4e5351142ef04f02798999ccb38a56bc Task-3329989 Forward-Port-Of: odoo/enterprise#41766
Original PR description
Purpose: -------- Commit [1] refactored the breadcrumbs. Since then, renaming an embedded view did not show the new name until the view was reloaded (because the active element has not the same class as before). This commit uses the new class of the active element to update the name of the embedded view. [1]: https://github.com/odoo/odoo/commit/caef16ee4e5351142ef04f02798999ccb38a56bc Task-3329989 Forward-Port-Of: odoo/enterprise#41766
Before this commit: When we go to the 'documents' app and try to upload a file to any child workspace inside the 'Projects' workspace, it gives an 'Internal Server Error'. Reason: We are passing recordset of 'documents.folder' as a key to sort instead of id. After this commit: Now the files are uploaded without any error. task-3284108 Forward-Port-Of: odoo/enterprise#40833
Original PR description
Before this commit: When we go to the 'documents' app and try to upload a file to any child workspace inside the 'Projects' workspace, it gives an 'Internal Server Error'. Reason: We are passing recordset of 'documents.folder' as a key to sort instead of id. After this commit: Now the files are uploaded without any error. task-3284108 Forward-Port-Of: odoo/enterprise#40833
The related change sets the default tax closing accounts for the localizations in the constant `COUNTRIES_WITHOUT_CLOSING_ACCOUNT`. The constant is removed from `TestAllReportsGeneration`, such that these localizations get tested again. task-3082332 Related to https://github.com/odoo/odoo/pull/111960 Forward-Port-Of: odoo/enterprise#41989 Forward-Port-Of: odoo/enterprise#37541
Original PR description
The related change sets the default tax closing accounts for the localizations in the constant `COUNTRIES_WITHOUT_CLOSING_ACCOUNT`. The constant is removed from `TestAllReportsGeneration`, such that these localizations get tested again. task-3082332 Related to https://github.com/odoo/odoo/pull/111960 Forward-Port-Of: odoo/enterprise#41989 Forward-Port-Of: odoo/enterprise#37541
This commit adds a test, forward-ported from https://github.com/odoo/enterprise/pull/39417 Have multiple occurences of the same field. Clicking on each one of them should show the right properties for that field in the sidebar. opw-3199875 Forward-Port-Of: odoo/enterprise#42019
Original PR description
This commit adds a test, forward-ported from https://github.com/odoo/enterprise/pull/39417 Have multiple occurences of the same field. Clicking on each one of them should show the right properties for that field in the sidebar. opw-3199875 Forward-Port-Of: odoo/enterprise#42019
task-3275256 Forward-Port-Of: odoo/enterprise#40350
Original PR description
task-3275256 Forward-Port-Of: odoo/enterprise#40350
- have a single 'create button' slot entry and add all extra buttons as susceptible to be modified to a dropdown if space is lacking - re-style the searchbar - include searchbar and filters in the same control panel slot to stay on one line, since the search is a simple input (no dropdown, autocompletion, etc.) it does not seem like it needs that much space to be useful Forward-Port-Of: odoo/enterprise#41287
Original PR description
- have a single 'create button' slot entry and add all extra buttons as susceptible to be modified to a dropdown if space is lacking - re-style the searchbar - include searchbar and filters in the same control panel slot to stay on one line, since the search is a simple input (no dropdown, autocompletion, etc.) it does not seem like it needs that much space to be useful Forward-Port-Of: odoo/enterprise#41287
Forward port of https://github.com/odoo/odoo/pull/121293 The same issue occurs in versions 15 and 16 cc @william-andre Forward-Port-Of: odoo/enterprise#41018
Original PR description
Forward port of https://github.com/odoo/odoo/pull/121293 The same issue occurs in versions 15 and 16 cc @william-andre Forward-Port-Of: odoo/enterprise#41018