PR odoo/odoo#109511 added in a related expiration_date field linked to its lot_id's expiration_date. This field was added as stored + readonly=False though, which was a mistake due to the following issues it causes:

- bug - the related dates (use_date, removal_date, alert_date) won't
   correctly update, this is easily fixable
- bug - [mostly a nuisance, but will be confusing for users], if there are
   2 lines for the same lot (e.g. different locations) then updating
   the expiration_date for one line won't show in the other lines
   without a view refresh (could be fixed with custom JS, but not
   ideal)
- bad UX - cluttered view of editable values
- redundancy - the ability to edit the expiration_date is easily done by
   clicking on the lot name within the view
- db bloat - the field is unnecessarily stored since it should always be
  consistent with the lot_id.expiration date anyways

For stable we will make this field readonly, for master we will remove it from the db and leave it as an informative related field only (as well as the not used `removal_date`?)

opw-3328901



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#123138

When the value line.discount = 100 in 'get_total_discount' method, the traceback
is generated. The main reason is because of 'BODMAS Rule - Bracket, Order,
Division, Multiplication, Addition, and Subtraction

Steps To Produce:-
1. Install point_of_sale module
2. Go to Point Of Sale Configuration
3. Make 'Line Discounts' True and save it
4. Create New Storable Product, ordered quantity with 100 cost and sales price
    then remove taxes and Vendor Taxes
5. Open POS Session and select the newly created product
6. Apply discount = 100 % and validate payment and close the session
7. Go to Reporting > Sales Details, and add the date range based on the current
   pos order, click on the 'Print' button.

Traceback will be generated.

See Traceback:-
```
ZeroDivisionError: float division by zero
  File "addons/web/controllers/report.py", line 120, in report_download
    response = self.report_routes(reportname, converter=converter, context=context, **data)
  File "odoo/http.py", line 715, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/report.py", line 42, in report_routes
    pdf = report.with_context(context)._render_qweb_pdf(reportname, docids, data=data)[0]
  File "addons/account/models/ir_actions_report.py", line 57, in _render_qweb_pdf
    return super()._render_qweb_pdf(report_ref, res_ids=res_ids, data=data)
  File "odoo/addons/base/models/ir_actions_report.py", line 801, in _render_qweb_pdf
    collected_streams = self._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "addons/account_edi/models/ir_actions_report.py", line 14, in _render_qweb_pdf_prepare_streams
    collected_streams = super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "addons/account/models/ir_actions_report.py", line 20, in _render_qweb_pdf_prepare_streams
    return super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "odoo/addons/base/models/ir_actions_report.py", line 702, in _render_qweb_pdf_prepare_streams
    html = self.with_context(**additional_context)._render_qweb_html(report_ref, res_ids_wo_stream, data=data)[0]
  File "home/odoo/src/enterprise/saas-16.2/web_studio/models/ir_actions_report.py", line 19, in _render_qweb_html
    return super(IrActionsReport, self)._render_qweb_html(report_ref, docids, data)
  File "odoo/addons/base/models/ir_actions_report.py", line 877, in _render_qweb_html
    data = self._get_rendering_context(report, docids, data)
  File "odoo/addons/base/models/ir_actions_report.py", line 892, in _get_rendering_context
    data.update(report_model._get_report_values(docids, data=data))
  File "addons/point_of_sale/models/report_sale_details.py", line 321, in _get_report_values
    data.update(self.get_sale_details(data['date_start'], data['date_stop'], configs.ids, data['session_ids']))
  File "addons/point_of_sale/models/report_sale_details.py", line 241, in get_sale_details
    discount_amount += session.get_total_discount()
  File "addons/point_of_sale/models/pos_session.py", line 2026, in get_total_discount
    original_price = line.price_subtotal_incl / (1 - line.discount / 100)
```

Applying these changes will resolve this issue.

sentry-4216418906


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#123087

"ValueError: No record found for unique ID point_of_sale.product_product_tip. It may have been deleted."
is generated when user delete 'Tips' from the product and try to enable tip payment from the POS setting.

Step to produce:
1. Install point_of_sale
2. Open product and delete 'Tips' product
3. Open POS > Configure > Setting
4. Enable Tips in payment > select any product in tip product
5. click save >>> Traceback generated

Tracebak on sentry:
```
ValueError: No record found for unique ID point_of_sale.product_product_tip. It may have been deleted.
  File "odoo/http.py", line 2114, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1699, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "odoo/service/model.py", line 133, in retrying
    result = func()
  File "odoo/http.py", line 1726, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 1921, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 716, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 30, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 26, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 462, in call_kw
    model.env.flush_all()
  File "odoo/api.py", line 706, in flush_all
    self._recompute_all()
  File "odoo/api.py", line 702, in _recompute_all
    self[field.model_name]._recompute_field(field)
  File "odoo/models.py", line 6377, in _recompute_field
    field.recompute(records)
  File "odoo/fields.py", line 1365, in recompute
    apply_except_missing(self.compute_value, recs)
  File "odoo/fields.py", line 1338, in apply_except_missing
    func(records)
  File "odoo/fields.py", line 1387, in compute_value
    records._compute_field_value(self)
  File "odoo/models.py", line 4486, in _compute_field_value
    fields.determine(field.compute, self)
  File "odoo/fields.py", line 99, in determine
    return needle(*args)
  File "addons/point_of_sale/models/pos_config.py", line 248, in _compute_tip_product_id
    pos_config.tip_product_id = self.env.ref("point_of_sale.product_product_tip")
  File "odoo/api.py", line 575, in ref
    raise ValueError('No record found for unique ID %s. It may have been deleted.' % (xml_id))
```

This commit solves the above issue by passing 'raise_if_not_found=False' to ensure
it does not throw an error when the tip product is not found.

sentry-4232555961

Forward-Port-Of: odoo/odoo#124055

When user tries to quick create a field where model is not specified, the error will occur.

Steps to reproduce:
1. Turn on developer mode.
2. Go to Settings > Technical > Fields Selection.
3. Create a new record and quick create a field.

Traceback will be generated.
See this traceback:
```
AssertionError: missing model name for {'field_description': 'image'}
  File "odoo/http.py", line 2115, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1698, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1725, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 1922, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "addons/website/models/ir_http.py", line 234, in _dispatch
    response = super()._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 715, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 28, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 24, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 457, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File "odoo/api.py", line 430, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File "odoo/models.py", line 1603, in name_create
    record = self.create({self._rec_name: name})
  File "<decorator-gen-32>", line 2, in create
  File "odoo/api.py", line 409, in _model_create_multi
    return create(self, [arg])
  File "odoo/addons/base/models/ir_model.py", line 890, in create
    assert vals.get('model'), f"missing model name for {vals}"
```

Applying this commit will fix this issue.

sentry-3956146718

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#123667

In case of error, the send & print wizard is crashing or log an error on the invoice chatter. In that case, nothing is send to the end-customer. This is problematic for all flows in which we want to send a mail to the customer automatically. For example, e-commerce with automatic invoicing or subscription/recurring invoices.

To avoid that, the current logic of the send & print has been reshaped. In case of error, a proforma PDF is sent instead. This is exactly the same document as the PDF but without the legal layer.

To do that, a lot of refactoring has been necessary to always provide the cumulated data for invoices to be able to access the generated proforma report and to allow the overrides to know exactly in which mode the hooks are called.

Also, this commit renames the method by something less generic about invoices. Indeed, this wizard needs to be usable for others documents than invoices. That's the purpose of the invoice_single/invoice_multi mode. For that reason, all methods about invoices are now expricitely prefixed by 'invoice'.

Fix also a performance issue on multi-invoices since the invoice_pdf_report_id document was invalided for the whole model instead of the current record. When dealing with X invoices, the whole model was invalidated X times. 

Task 3339352.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#124093
Forward-Port-Of: odoo/odoo#122451

When user change the move_type of account_move to 'entry'. And when user try to access 'partner_credit' field from the from view using debug mode. The error will be generated.

Steps to Produce:-

1. Install 'account_accountant' and 'sales' module
2. Change move_type of account_move to 'entry'
3. Go to 'Edit View : Form' of Journal Entries in account_accountant using debug mode
4. Add field 'partner_credit' to the form view and click on save
5. Click on any Journal Entry

Trace-back in sentry -
```
KeyError: 1
  File "odoo/api.py", line 958, in get
    cache_value = field_cache[record._ids[0]]
CacheMiss: 'account.bank.statement.line(1,).partner_credit'
  File "odoo/fields.py", line 1158, in __get__
    value = env.cache.get(record, self)
  File "odoo/api.py", line 965, in get
    raise CacheMiss(record, field)
KeyError: 2
  File "odoo/api.py", line 958, in get
    cache_value = field_cache[record._ids[0]]
CacheMiss: 'account.move(2,).partner_credit'
  File "odoo/fields.py", line 1158, in __get__
    value = env.cache.get(record, self)
  File "odoo/api.py", line 965, in get
    raise CacheMiss(record, field)
TypeError: 'bool' object is not subscriptable
  File "odoo/http.py", line 2116, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1698, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1725, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 1923, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "addons/website/models/ir_http.py", line 234, in _dispatch
    response = super()._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 715, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 28, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 24, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 461, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "odoo/api.py", line 448, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "odoo/models.py", line 3004, in read
    return self._read_format(fnames=fields, load=load)
  File "odoo/models.py", line 3191, in _read_format
    vals[name] = convert(record[name], record, use_name_get)
  File "odoo/models.py", line 5942, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "odoo/fields.py", line 1209, in __get__
    self.compute_value(recs)
  File "odoo/fields.py", line 1387, in compute_value
    records._compute_field_value(self)
  File "odoo/models.py", line 4312, in _compute_field_value
    fields.determine(field.compute, self)
  File "odoo/fields.py", line 102, in determine
    return needle(records, *args)
  File "odoo/fields.py", line 706, in _compute_related
    record[self.name] = self._process_related(value[self.related_field.name])
  File "odoo/models.py", line 5942, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "odoo/fields.py", line 1209, in __get__
    self.compute_value(recs)
  File "odoo/fields.py", line 1387, in compute_value
    records._compute_field_value(self)
  File "addons/mail/models/mail_thread.py", line 395, in _compute_field_value
    return super()._compute_field_value(field)
  File "odoo/models.py", line 4312, in _compute_field_value
    fields.determine(field.compute, self)
  File "odoo/fields.py", line 99, in determine
    return needle(*args)
  File "addons/sale/models/account_move.py", line 155, in _compute_partner_credit
    move.tax_totals['amount_total'],
```
Applying these changes will resolve this issue.

Sentry-4222621594

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#123659

## Current behaviour
In the timesheet's grid view, if we set the timesheet's UOM to `Days/Half days` in the settings, the cells are toggle buttons that cycle between 0 -> 0.5 -> 1 -> 0 ... When we click on the magnifier glass on a cell, which should open a new view and show the analytic lines related to that day, a click on the cell goes through, editing the content of the cell.

## Expected behaviour
When we click on the magnifier glass, the cell shouldn't be edited.

## Steps to reproduce
- Install Timesheets
- Timesheets App > Configuration > Settings > change the encoding method to `Days/Half days`
- Go the Timesheet's app main grid view
- Click on a magnifier glass of one of the cells (for example a cell that has 0 as value).
- A new list view opens, but the value is 0.5, when you go back via the breadcrumbs, you can see the cell's value has changed to 0.5, should have stayed 0.

## Reason for the problem
There are 2 `onClick` listeners, 1 on the cell component, another one the magnifier glass component, which is inside the cell component. So when we press the magnifier glass, it's `onClick` is triggered, then the `click` event *bubbles* up the components, and triggers the `onClick` of the cell component, which updates the content of the cell.

## Fix
Use the target of the click event to know on what we clicked and trigger
the `onChange` based on that.

## Affected versions
- saas-16.2
- saas-16.3
- master
---
opw-3325115

Forward-Port-Of: odoo/enterprise#41388