When user tries to enter extra info from Configure Form from 'settings' so 
'website.sale_get_order' method does not get any order.

Steps to reproduce:
1) Install website_sale module.
2) Click on settings > activate 'Extra Step During Checkout' > click on 'Save' 
   button.
3) Now in 'settings', click on 'Configure Form' under 
  'Extra Step During Checkout'.
4) Now, click on 'Discard' button on top right of screen.
5) Enter something in textbox 'Give us your feedback' > click on 'Next' button 
   and traceback will be generated in backend. 

```
ValueError: not enough values to unpack (expected 1, got 0)
  File "odoo/models.py", line 5379, in ensure_one
    _id, = self._ids
ValueError: Expected singleton: sale.order()
  File "odoo/http.py", line 2114, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1699, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "odoo/service/model.py", line 133, in retrying
    result = func()
  File "odoo/http.py", line 1726, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 1840, in dispatch
    return self.request.registry['ir.http']._dispatch(endpoint)
  File "addons/website/models/ir_http.py", line 234, in _dispatch
    response = super()._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 716, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/website_sale/controllers/main.py", line 117, in website_form_saleorder
    order._message_log(
  File "addons/mail/models/mail_thread.py", line 2589, in _message_log
    self.ensure_one()
  File "odoo/models.py", line 5382, in ensure_one
    raise ValueError("Expected singleton: %s" % self)

```
Error: ValueError: Expected singleton: sale.order() traceback will be generated
because in method '_message_log' it is expecting a record.

Sentry-4126876202

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#124428

This PR fixes some Editor behaviors related to `contenteditable="false"`
and `data-oe-protected="true"` elements.

The following is an outline of the changes, please read each commit message for
a more detailed explanation.

- Prevent some commands of the editor to affect `contenteditable="false"` nodes,
  mainly to avoid OWL crashes in Knowledge (`Behavior` anchors are always
  `contenteditable="false"` and their child nodes are managed by OWL). But this
  change makes sense even without considering OWL crashes (prevent changes on
  non-editable elements).

- Prevent custom editor selection of protected tables. Those tables are managed
  by OWL, and should not be altered by the editor to avoid OWL crashes.

- Allow the editor to fix the selection for `contenteditable="false"` elements
  if they are under a `data-oe-protected="true"` element, only if the the
  selection does not target an `input` or a `textarea`. This is to avoid being
  able to remove element using "Backspace" after clicking on a non-editable
  protected element.

- Fixes `getNormalizedCursorPosition` so that it does not return a non-editable
  position.

task-3280704

Forward-Port-Of: odoo/odoo#124799
Forward-Port-Of: odoo/odoo#121249

For a `pos.payment.method`, it is possible to define an outstanding account, but if this account is not defined as an outstanding account in the company settings nor in the journal, the payment will not be considered in the bank reconciliation, nor in the bank reconciliation report.

Steps to reproduce (demo-data with POS and Accounting installed): 
-go to 'Point of Sale/Configuration/Payment Methods'.
-click on the "Bank" payment method.
-add an 'Outstanding Account' which is not the default outstanding account of the company, nor an outstanding account of an `account.payment.method.line`.  So for example "Liquidity Transfer".
-then open a POS session, sell smth, pay with the Bank method, validate, then close the session.
-If you go to 'Accounting/Customers/Payments', you can see that an `account.payment` has been created, with the outstanding account being "Liquidity Transfer".
->It is not possible to reconcile that payment with a `bank.statement.line`. If you go to the accounting dashboard, then click the reconcile button of the journal "Bank", then on a statement line with no partner, you will not see the outstanding line of that payment.
->If you open the 'Reconciliation Report' of the journal "Bank" (accessible from the journal dashboard, by clicking the options of the journal), the line will not show in the 'Outstanding Receipts' category.

FIX:
Override the `_get_journal_inbound_outstanding_payment_accounts` method of `account.journal`, to add the accounts from each `pos.payment.method` linked to the journal.  Using the field `pos_payment_method_ids` from `account.journal`.

opw-3271090

Forward-Port-Of: odoo/odoo#121158

When user changes the default_account_id on a journal and tries to open a statement line, they will get the traceback.

Note: This is reproduceable by using account_accountant only.

Steps to reproduce:
1) open configuration of bank journal
2) change default_account_id (bank account) from bank to cash 
3) open bank statement
4) open any statement line
5) by following these steps, traceback occurs.

```shell
Traceback (most recent call last):
  File "/data/build/odoo/odoo/http.py", line 1698, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/data/build/odoo/odoo/service/model.py", line 134, in retrying
    result = func()
  File "/data/build/odoo/odoo/http.py", line 1725, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/data/build/odoo/odoo/http.py", line 1922, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/data/build/odoo/addons/website/models/ir_http.py", line 234, in _dispatch
    response = super()._dispatch(endpoint)
  File "/data/build/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/data/build/odoo/odoo/http.py", line 715, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/data/build/odoo/addons/web/controllers/dataset.py", line 28, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/data/build/odoo/addons/web/controllers/dataset.py", line 24, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/data/build/odoo/odoo/api.py", line 461, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/data/build/odoo/odoo/api.py", line 448, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/data/build/enterprise/account_accountant/models/bank_rec_widget.py", line 923, in onchange
    return super(BankRecWidget, self.with_context(recursive_onchanges=False)).onchange(values, field_name, field_onchange)
  File "/data/build/odoo/odoo/models.py", line 6529, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/data/build/odoo/odoo/models.py", line 6240, in _onchange_eval
    method_res = method(self)
  File "/data/build/enterprise/account_accountant/models/bank_rec_widget.py", line 662, in _onchange_todo_command
    self._process_todo_command(command_split[0], command_split[1:])
  File "/data/build/enterprise/account_accountant_batch_payment/models/bank_rec_widget.py", line 131, in _process_todo_command
    super()._process_todo_command(command_name, command_args)
  File "/data/build/enterprise/account_accountant/models/bank_rec_widget.py", line 617, in _process_todo_command
    self._action_trigger_matching_rules()
  File "/data/build/enterprise/sale_account_accountant/models/bank_rec_widget.py", line 15, in _action_trigger_matching_rules
    matching = super()._action_trigger_matching_rules()
  File "/data/build/enterprise/account_accountant/models/bank_rec_widget.py", line 1506, in _action_trigger_matching_rules
    matching = reconcile_models._apply_rules(self.st_line_id, self.partner_id)
  File "/data/build/enterprise/account_accountant/models/account_reconcile_model.py", line 181, in _apply_rules
    res = rec_model._get_invoice_matching_amls_result(st_line, partner, candidate_vals)
  File "/data/build/enterprise/account_accountant/models/account_reconcile_model.py", line 558, in _get_invoice_matching_amls_result
    status = self._check_rule_propositions(st_line, kepts_amls_values_list)
  File "/data/build/enterprise/account_accountant/models/account_reconcile_model.py", line 583, in _check_rule_propositions
    amls_amount_curr = sum(
  File "/data/build/enterprise/account_accountant/models/account_reconcile_model.py", line 584, in <genexpr>
    st_line._prepare_counterpart_amounts_using_st_line_rate(
  File "/data/build/odoo/addons/account/models/account_bank_statement_line.py", line 531, in _prepare_counterpart_amounts_using_st_line_rate
    journ_amount_currency = journal_currency.round(balance * rate_comp2journal_curr)
  File "/data/build/odoo/odoo/addons/base/models/res_currency.py", line 208, in round
    self.ensure_one()
  File "/data/build/odoo/odoo/models.py", line 5202, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: res.currency()

``` 

This commit will prevent the above traceback.

sentry - 4059226840

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#122428

Process has been refactor on 16.2:
https://github.com/odoo/odoo/commit/955091e707df1206ccda8314f1f182e2a37a8362

Steps to reproduce on fresh SaaS~16.2:
Connected as Admin:

Install localization module LUX l10n_lu,
Switch to the LU company

Modify a res.partner, on the tab "Invoicing":
Handle his electronic invoicing to use the format ubl_bis3
described as Peppol BIS Billing 3.0
Select any value in the field Peppol e-address (EAS)
And put any value in the field Peppol Endpoint(I used 1234567890)

On the tab "Sales&Purchaes", inner group "MISC",
Add anything in the reference field (required for Peppol)

Create an invoice, selection the partner modified,
add a product and a recipient bank

Confirm & Send&Print button, save the document layout.
On the Send Wizard: uncheck all except "Peppol BIS Billing 3.0",
hit Save&Print button.

If you create a new Invoice for the same customer as Marc Demo,
You should also see that the icon on the attached xml is of
mimetype "application/xml". Which is displayed on the icon
as "</>".

Prior to this fix:
If you do the same steps with a user that does not have
the write access right to the model ir_ui_view
(see _check_contents in base), the attachment will be
of type text/plain.

The issue that this trigger, is that the email going out
will have the wrong Content-Type for the attachments.
Which will lead to incorrect management on other provider.

We can bypass the security here as the XML is generated
by Odoo.

opw-3263542

Forward-Port-Of: https://github.com/odoo/odoo/pull/125059
Forward-Port-Of: https://github.com/odoo/odoo/pull/124507

[FIX] web_editor: show background image options after save

Steps to reproduce the bug:
- Add a cover snippet on the website.
- Change the background image with one of your own.
- Save and edit again.

=> Options such as "Filter", "Width" and "Quality" do not appear
anymore.

The problem is that the `src` attribute of the background image is not
correctly updated when initializing the image. This is because the
target used to recover the URL of the background image is the snippet
and not the image itself. This problem is resolved by ensuring that the
argument of the function `getBgImageURL` is the background image. Now
that the `src` attribute is correctly updated, the `computeVisibility`
function of the the `BackgroundOptimize` option works properly and the
options "Filter", "Width" and "Quality" are displayed as wanted.

Note that now, the dataset of the target is filtered with a "white list"
(BACKGROUND_IMAGE_ATTRIBUTES) before being copied in the dataset of
`this.img`. Indeed, if the parallax is set to "None" for example, we do
not want data attributes such as `data-snippet` to be copied in the
dataset of `this.img`.

task-3287330

------------------------------------------------------------------------------------------------------------------------------------------------------------------

[FIX] web_editor: modify background element at option change

For background images, modifying options such as "Filter" does not
directly lead to the modification of their corresponding data attributes
in the DOM as those modifications are done at the save request. This
should not be the case. The goal of this commit is to, as for regular
images, modify their corresponding DOM data attributes at the option
update.

Steps to reproduce the bug:
- Add a Cover snippet on the website.
- Replace the background image by one of your own.
- Add a filter to the background image.
- Inspect the Cover snippet.

=> The `data-gl-filter` attribute has not been added in the DOM and you
have to click on "Save" for it to be actually added.

task-3287330

------------------------------------------------------------------------------------------------------------------------------------------------------------------

[FIX] *: transfer the dataset when changing background options target
*: web_editor, website

Steps to reproduce the bug:
- Add a Cover snippet on the website.
- Put a "Blur" filter on the background image.
- Save.
- Change the parallax from "Fixed" to "None".
- Save and edit.
=> The "Filter" option displays "None" but should display "Blur".

When changing the parallax, `setTarget()` is called. The goal of this
function is to transfer the `background-image` from the old target to
the new one. The commit modifies this function by adding the transfer of
the dataset information relative to the background image from the old
target to the new one. It also transfers the `o_modified_image_to_save`
class from the old target to the new one if needed.

Upgrade PR: https://github.com/odoo/upgrade/pull/4767

task-3287330


Forward-Port-Of: odoo/odoo#123182
Forward-Port-Of: odoo/odoo#119596

The bank recon custom view relies on the noContentHelper. (When there are no records, a custom noContentHelper is  displayed including buttons to clear filters)

When the view is activated from a RedirectWarning, the action's help text is not marked up therefore displaying raw html in the UI.

With this fix, the actions help key is marked up (very similar to the doActionButton)

To reproduce:
- On a DB with demo data
- Accounting -> Actions -> Lock Dates
- Set a lock date for all users (after the last unreconciled date, ensure there are no unposted moved before this date)
- You will be presented with a Redirect Warning Dialog
- Click Show Unreconiled Bank Statement Lines
- If there are lines, use the filter to search for "SomethingThatWontReturnRecords"
- You will see raw html

<img width="951" alt="Screenshot 2023-06-15 at 17 17 30" src="https://github.com/odoo/odoo/assets/5903536/5d1ed377-460c-47cd-a539-7dbd2407d238">


Task-3366470

Forward-Port-Of: odoo/odoo#125254

## Current behaviour
If an user doesn't have any employee rights, they can't clock timesheets using the header timer bar, they are met with an Access Error, that only approvers can validate a timesheet.

## Expected behaviour
An user with no employee rights should be able to clock timesheets using the header bar in the Timesheets app.

## Steps to reproduce
- Install Timesheets
- Remove employee rights of Marc Demo
- Login as Marc Demo
- Go to Timesheets > (any of the view you have the timer header, so grid/list/kanban)
- Start the timer, add a project
- Add a task (AccessError!)

## Reason for the problem
The AccessError is triggered by the check `_check_can_write`, which checks for *presence* of the field `'validated'`. All theses views I've mentioned define this field as invisible, since it is used for a few display conditions of the items displayed in the views. When we start the timer, a new front-end `timesheet` record is created, which uses the fields defined from the view, so `validated` included. When we add the task, the hook is saving the current state of the timesheet by initiating a write with the content of the record, which includes the field `validated` with the value `false`. This trips up the check, because our current user doesn't have the group `hr_timesheet.group_hr_timesheet_approver` and the key `validated` is present.

## Fix
To avoid having OWL send the field for writing, a solution is to set such field as readonly, since readonly fields are dropped before sending the write call to the server. The field is invisible all cases, so it is safe (it can't be modified by the user anyway). The only specificity is for the kanban-view. *All* fields that are defined in kanban view are implicitly `force_save='1'` if not specified otherwise. Since the presence of `force_save` on the field `validated` would force OWL to send the field for writing, we override that attribute to `force_save='0'` for the instance where the `validated` field is in the kanban view.

## Affected versions
- saas-16.2
- saas-16.3
- master
---
opw-3334853

Forward-Port-Of: odoo/enterprise#42638
Forward-Port-Of: odoo/enterprise#42560

This issue occurs when user attempting to remove the default value of 'date_to' while creating employee payslips, and subsequently clicking outside the form before saving the record.

see stack trace:
```
TypeError: combine() argument 1 must be datetime.date, not None
  File "odoo/http.py", line 2114, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1699, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "odoo/service/model.py", line 133, in retrying
    result = func()
  File "odoo/http.py", line 1726, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 1921, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 716, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 30, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 26, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 461, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "odoo/api.py", line 448, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "odoo/models.py", line 6670, in onchange
    record.modified(todo)
  File "odoo/models.py", line 6263, in modified
    for field, records, create in tocompute:
  File "odoo/models.py", line 6315, in _modified_triggers
    records = self[invf.name]
  File "odoo/models.py", line 6122, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "odoo/fields.py", line 4301, in __get__
    return super().__get__(records, owner)
  File "odoo/fields.py", line 2801, in __get__
    return super().__get__(records, owner)
  File "odoo/fields.py", line 1155, in __get__
    self.recompute(record)
  File "odoo/fields.py", line 1365, in recompute
    apply_except_missing(self.compute_value, recs)
  File "odoo/fields.py", line 1338, in apply_except_missing
    func(records)
  File "odoo/fields.py", line 1387, in compute_value
    records._compute_field_value(self)
  File "addons/mail/models/mail_thread.py", line 396, in _compute_field_value
    return super()._compute_field_value(field)
  File "odoo/models.py", line 4486, in _compute_field_value
    fields.determine(field.compute, self)
  File "odoo/fields.py", line 99, in determine
    return needle(*args)
  File "home/odoo/src/enterprise/saas-16.3/hr_payroll/models/hr_payslip.py", line 931, in _compute_worked_days_line_ids
    self.mapped('contract_id')._generate_work_entries(generate_from, generate_to)
  File "addons/hr_work_entry_contract/models/hr_contract.py", line 296, in _generate_work_entries
    date_stop = datetime.combine(fields.Datetime.to_datetime(date_stop), datetime.max.time())

```
After applying this commit will fix this issue.

sentry-4228660216

Forward-Port-Of: odoo/enterprise#42373
Forward-Port-Of: odoo/enterprise#41997

This PR is a set of Bug Fixes for the `/article` command and other Behavior
issues.

This is an overview of all the fixes, more details are available in each
sub-commit.

- Prevent usage of `/article` command in website and iframes, because
  `Behaviors` do not properly support those environments currently.
- Properly remove the editor lock added by a `Behavior` if it is destroyed
  before it is mounted.
- Prevent the `updateBehaviors` mutex from being indefinitely locked (because
  OWL never resolves an `App.mount` promise if the App is destroyed before it is
  mounted. Allows `Behaviors` mounting in parallel, which will improve
  performances.
- Await the `updateBehaviors` mutex during `commitChanges` operations, such as
  `_toInline` and `updateValue`. Those operations need the final value of the
  `html_field` and should wait for all `Behavior` to be fully mounted, to avoid
  missing some nodes for their operations.
- Restore a `Behavior` anchor to its parent outside of the DOM after it has been
  destroyed in the DOM. We had to move it in the DOM temporarily because OWL
  does not support destroying outside of it.
- Add a test for the `/article` command in the `Email Composer` which has the
  particularity of being an `style-inline` `html_field` inside a `dialog`, and
  as such has some quirks that we have to support.
- Remove the useless patch file for the template Behavior


task-3280704

Co-authored-by: Thomas Josse <thjo@odoo.com>
Co-authored-by: Damien Abeloos <abd@odoo.com>

Forward-Port-Of: odoo/enterprise#42450
Forward-Port-Of: odoo/enterprise#40062