Odoo Changelog — 2023-06-21

Wednesday, June 21, 2023

53 changes · master

Improvements(8)

Enhancements to existing features

[IMP] point_of_sale: remove dead code

Coremasterpoint_of_sale

This change removes leftover code in the Point of Sale area that was no longer being used after a previous update. It reduces unnecessary maintenance burden without changing how users interact with the system.

Original PR description

before this commit, in point_of_sale module
a super call is made for the function
_get_reconciled_vals , but this function has
 been removed/changed in this commit: https://github.com/odoo/odoo/commit/785d49f3f0a21720d8c929d597d4041918ab7f41

currently this is deadcode and not called from
any where and left over during this: https://github.com/odoo/odoo/commit/785d49f3f0a21720d8c929d597d4041918ab7f41

after this commit, the dead function will be
removed.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#cleanup#maintenance#point of sale

[IMP] hr_appraisal_survey: adapt survey inherited views to appraisal

PR #121283

Coremastersurvey

Survey print actions now open in a new window so appraisal-related survey flows work more smoothly. This improves the user experience when surveys are reused within employee appraisal processes.

Original PR description

see odoo/enterprise#37387

#surveys#appraisals#printing

[IMP] account_edi: change banner

PR #125574

Coremasteraccount_edi

The e-invoicing banner text has been shortened so it fits on one line. This makes the message easier to read and reduces visual clutter for users working with invoices.

Original PR description

Goal of this pr is to improve the banner on top of all e-invoicing by shorten the text and make it one line

task:3374897




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#e-invoicing#banner#usability

[IMP] l10n_mx: Update description manifest

PR #24735

Enterprisemasterl10n_mx_edi_extended

This update adds a missing description to the Mexican EDI Extended module manifest. It improves clarity for users and administrators reviewing the module, without changing business workflows or functionality.

Original PR description

There is no description in the current manifest. This proposed change is to add this description to the manifest.

#localization#Mexico#module description

[IMP] hr_appraisal_survey: adapt survey inherited views to appraisal

PR #37387

Enterprisemasterhr_appraisal_survey

The appraisal survey screens have been adjusted to better match the employee appraisal workflow. Unused survey buttons are hidden and view names are clarified, making the appraisal process cleaner and easier for users to navigate.

Original PR description

remove buttons not used in appraisal flow and rename views

https://www.odoo.com/web#id=3127424&menu_id=4720&cids=1&action=333&active_id=1251&model=project.task&view_type=form

#appraisal#survey#user interface

[IMP] helpdesk: rename Team to Helpdesk Team

PR #40609

Enterprisemasterhelpdesk

Helpdesk team labels have been updated to say “Helpdesk Team” instead of the more generic “Team.” This makes it easier for users to distinguish helpdesk teams from teams used in other Odoo apps such as Sales, CRM, Maintenance, or Quality.

Original PR description

Several apps in odoo have the notion of team (crm/sales, maintenance, quality...). We need to differentiate helpdesk teams from the other kind of teams.

task-3251737

#helpdesk#usability#naming

[IMP] hr_contract_salary,hr_payroll: hide some fields and Index Contracts btn in contract templates

PR #41764

Enterprisemasterhr_contract_salaryhr_payroll

Contract templates now hide fields and actions that are only relevant when an employee is linked. This reduces empty information and unnecessary options, making the template view clearer for HR users.

Original PR description

A contract is a template when there is no employee linked to it, so the employee,
payslips column of the view will always be empty and the index contract button should 
not need to be there, we hide it.

task-3343545

#contracts#templates#hr#payroll

display no_open/no_create option in inherited many2one

PR #20216

Enterprisemasterweb_studio

Odoo Studio now shows the disable creation and disable opening settings for partner and product configurator selection fields. This gives users the same configuration controls across related field types, improving consistency when customizing forms.

Original PR description

PURPOSE
In Studio, the 'Disable creation' (no_create) and 'Disable opening' (no_open) options have been made available in the configuration tab of many2one widgets.

The purpose of this task is simply to also displayed those options for the following two widgets that inherit from the many2one widget:
    res_partner_many2one
    product_configurator

SPECIFICATION
In the studio configuration tab, add the 'Disable creation' (no_create) and 'Disable opening' (no_open) options to the res_partner_many2one and product_configurator widgets.

TASK 2608073

#studio#configuration#many2one

Bug Fixes(6)

Resolved issues and error corrections

[FIX] hr: remove deadcode of KanbanView/openChat

PR #125753

Coremasterhr

This change removes obsolete HR code that was no longer responsible for opening employee chats. The existing chat widget continues to handle the feature, reducing maintenance risk without changing the user experience.

Original PR description

OpenChat feature in `hr` is managed by the view widget "hr_employee_chat", which is added in kanban template.
The override of Kanban View to add openChat feature is not called at all, so this commit removes this dead code, and the js_class, as its only purpose was adding openChat.

https://github.com/odoo/enterprise/pull/42897

#hr#cleanup#chat

[FIX] pos_preparation_display: fix template name

Removals(1)

Features or functions removed from Odoo

[REM] hr,hr_holidays: remove deprecated code

PR #125894

Coremasterhrhr_holidays

Outdated code in the HR and Time Off areas has been removed after being previously deprecated. This keeps the system cleaner and easier to maintain, with low expected impact on day-to-day users.

Original PR description

Remove deprecated code from odoo/odoo#96545

#cleanup#maintenance#time-off

Other(38)

Miscellaneous changes

[FW][FIX] web_editor: keep the observer active while adding link hint class

PR #125793

Coremasterweb_editor

Original PR description

After preventing "async" code on link tools update in [1], the `'link_tools'` test is still failing because of another race condition issue: The click on "save" after setting the link style to…

After preventing "async" code on link tools update in [1], the `'link_tools'` test is still
failing because of another race condition issue:

The click on "save" after setting the link style to secondary triggers an event handler
that destroys the link tools widget (see `Wysiwyg` > `destroyLinkTools()`), leading to
calling the `_removeHintClasses()` method first (both `_addHintClasses()` and 
`_removeHintClasses()` will disable the editor observer while adding / removing the 
link hint class to prevent their mutations to be recorded...).

Since the observer is inactive, the changes made to the link using the link tools will
not be processed, and the block will not be set as `.o_dirty`.

As mentioned previously, (and starting from [2]) the editor observer is inactive (while
handling the `.oe_edited_link` class) in order to prevent recording the mutations...
But since [3], the editor had the ability to prevent some classes (including 
`.oe_edited_link`) from being taken into consideration in the `filterMutationRecords()`
method...

The goal of this commit is to fix this race condition issue by simply keeping the
observer activated while handling the link hint class...

Remarks:

- These changes are supposed to fix the `link_tools` test that fails on 16.0+, but 15.0
was targeted here since the `.oe_edited_link` class is ignored by the editor starting
from 15.0 and also to prevent any future issue linked to disabling the observer...

- Adding and removing the `active` class should not affect the history, since it targets
the `linktTools` toolbar button...

[1]: https://github.com/odoo/odoo/pull/109250/commits/f42715fdc89a6a88446c5f88ecec29e6a9c96fe1
[2]: https://github.com/odoo/odoo/pull/90064/commits/26377710a6e3ad61a8c266e9f7c0b8ade98f657d
[3]: https://github.com/odoo/odoo/commit/1c25ddb42393b136cac2a0ee0b9b7280fd803e7d

runbot-18747

Forward-Port-Of: odoo/odoo#121622

before this commit, in point_of_sale module a super call is made for the function _get_reconciled_vals , but this function has been removed/changed in this commit: https://github.com/odoo/odoo/commit/785d49f3f0a21720d8c929d597d4041918ab7f41 currently this is deadcode and not called from any where and left over during this: https://github.com/odoo/odoo/commit/785d49f3f0a21720d8c929d597d4041918ab7f41 after this commit, the dead function will be removed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Goal of this pr is to improve the banner on top of all e-invoicing by shorten the text and make it one line task:3374897 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

A contract is a template when there is no employee linked to it, so the employee, payslips column of the view will always be empty and the index contract button should not need to be there, we hide it. task-3343545

PURPOSE In Studio, the 'Disable creation' (no_create) and 'Disable opening' (no_open) options have been made available in the configuration tab of many2one widgets. The purpose of this task is simply to also displayed those options for the following two widgets that inherit from the many2one widget: res_partner_many2one product_configurator SPECIFICATION In the studio configuration tab, add the 'Disable creation' (no_create) and 'Disable opening' (no_open) options to the res_partner_many2one and product_configurator widgets. TASK 2608073

OpenChat feature in `hr` is managed by the view widget "hr_employee_chat", which is added in kanban template. The override of Kanban View to add openChat feature is not called at all, so this commit removes this dead code, and the js_class, as its only purpose was adding openChat. https://github.com/odoo/enterprise/pull/42897

After preventing "async" code on link tools update in [1], the `'link_tools'` test is still failing because of another race condition issue: The click on "save" after setting the link style to secondary triggers an event handler that destroys the link tools widget (see `Wysiwyg` > `destroyLinkTools()`), leading to calling the `_removeHintClasses()` method first (both `_addHintClasses()` and `_removeHintClasses()` will disable the editor observer while adding / removing the link hint class to prevent their mutations to be recorded...). Since the observer is inactive, the changes made to the link using the link tools will not be processed, and the block will not be set as `.o_dirty`. As mentioned previously, (and starting from [2]) the editor observer is inactive (while handling the `.oe_edited_link` class) in order to prevent recording the mutations... But since [3], the editor had the ability to prevent some classes (including `.oe_edited_link`) from being taken into consideration in the `filterMutationRecords()` method... The goal of this commit is to fix this race condition issue by simply keeping the observer activated while handling the link hint class... Remarks: - These changes are supposed to fix the `link_tools` test that fails on 16.0+, but 15.0 was targeted here since the `.oe_edited_link` class is ignored by the editor starting from 15.0 and also to prevent any future issue linked to disabling the observer... - Adding and removing the `active` class should not affect the history, since it targets the `linktTools` toolbar button... [1]: https://github.com/odoo/odoo/pull/109250/commits/f42715fdc89a6a88446c5f88ecec29e6a9c96fe1 [2]: https://github.com/odoo/odoo/pull/90064/commits/26377710a6e3ad61a8c266e9f7c0b8ade98f657d [3]: https://github.com/odoo/odoo/commit/1c25ddb42393b136cac2a0ee0b9b7280fd803e7d runbot-18747 Forward-Port-Of: odoo/odoo#121622

We have introduced a new tag `website_nightly` which is linked to a custom build on the nightly. It has been introduced with this commit [1]. The goal is to extract the `external` tagged tests linked to the website app to another special build linked to the website team. Otherwise, we would not see when the test fail, as the `external` build of the nightly is always red and we don't check why all the time. Encapsulating this in a new build and linking to our team means that whenever the test fail in a nightly, we will be visually warned on the runbot homepage by a red warning, see screenshot on the PR of this commit. Sadly, before 16.4, as there is not yet `website_nightly` tours, the build is considered failed, showing the error. Another solution would have been to somehow disable this tour on Odoo versions < 16.4 but it we opted for this solution as: - It's simpler, no need to add yet another custom stuff in runbot - It will work out of the box should be introduce such a test in those versions: we won't need to ask runbot to activate the test in another version, should we even think about it.. [1]: https://github.com/odoo/odoo/commit/a0d0afb20594aa103eb1d0476d53012b9821e861 ------------ The warning / error show to our team for this build is the following: ![image](https://github.com/odoo/odoo/assets/30048408/886c6588-a708-4ebd-bb6c-e18181e226c0) Spec: https://discord.com/channels/678381219515465750/704997651833159831/1118887457581187112 Forward-Port-Of: odoo/odoo#125676 Forward-Port-Of: odoo/odoo#125662

When the user click on the 'import' button without lots in the import serial/lots wizard in stock then this issue is generated. Steps to reproduce: - Install Inventory. - Inventory >> Operations >> Receipts >> create the new Receipt - Add product to the receipt which has tracking 'by lots', Save the Receipts - Click on the button in a tree view which opens the detailed operation wizard, And click on Import Serial/Lots in it - In Import Serial/ Lots wizard click on the import button without passing any value in the lots field - Traceback will be generated Traceback: ```TypeError: argument of type 'bool' is not iterable File "odoo/http.py", line 2114, in __call__ response = request._serve_db() File "odoo/http.py", line 1699, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1726, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1921, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 716, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 34, in call_button action = self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 461, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 448, in _call_kw_multi result = method(recs, *args, **kwargs) File "addons/stock/wizard/stock_import_lot.py", line 20, in action_import_lot self.move_id._import_lots(self.lots, location_id=self.location_dest_id) File "addons/stock/models/stock_move.py", line 934, in _import_lots if (breaking_char not in lots and separation_char not in lots and ';' not in lots): ``` Applying these changes will resolve this issue. sentry-4244975188 Forward-Port-Of: odoo/odoo#125029

When the user allows multi employee per session and the portal user tries to access the pos with the URL /pos/ui?config_id=1 then the error will be generated. Steps to reproduce: - Installed point_of_sale module. - In Configuration > Point of Sale > activate Multi Employees per Session option and save it. - In another window, do log in as a demo user and start the pos session. - From the Admin user, make Marc Demo as a portal user. - Then refresh the demo user session. - Traceback will be generated see the traceback: KeyError: 'user_companies' File "odoo/http.py", line 2115, in __call__ response = request._serve_db() File "odoo/http.py", line 1698, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1725, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1838, in dispatch return self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 154, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 715, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/point_of_sale/controllers/main.py", line 57, in pos_web session_info['user_companies'] = {'current_company': company.id, 'allowed_companies': {company.id: session_info['user_companies']['allowed_companies'][company.id]}} Applying these changes will resolve this issue. sentry - 3958755602 Forward-Port-Of: odoo/odoo#121140

Add a step to ensure that the first kanban view is fully loaded before trying to insert the next one in `knowledge_items_search_favorites_tour`, because it could cause an undeterministic error as the view was not inserted when trying to insert the second one too fast. Change the triggers to ensure that a view is loaded to be more explicit about what should be loaded: `o_knowledge_embedded_view` is only present when the embedded view is loaded by the manager (and it could happen after the embedded_view Behavior was loaded (see lazy loading)). Technical issue explanation: - Rendering of Behaviors is asynchronous in regards to the execution of the `/command`. - Since [1], Behaviors are rendered in parallel. - This means that the `preserveCursor` call for 2 `/command` that are executed in succession faster than the time it takes for Owl to mount the result of those commands can be done on the same node, let say `p`. - The `insert` command of the editor, in case the insertion has to be done in between content, will split the editor node with `splitElement`. - `splitElement` creates 2 clones of the original targetted node, and removes the original. - This means that one of the `preserveCursor` has registered a position inside a node that will be removed by the `insert` caused in the process involving the other `preserveCursor` and therefore will fail, resulting in only one of the two `insert` succeeding. This issue is not humanly realistic, because the user would have to type two commands in the same node faster than it takes for Owl to mount the first Behavior, and currently Behaviors are rendered without heavy `onWillStart` rpc calls, because we want the user to have a visual feedback as fast as possible. [1]: https://github.com/odoo/enterprise/commit/b25f4c9ea93f0b7d357fea71d84132efbb6bb234 task-3373322 Forward-Port-Of: odoo/enterprise#42601

When user creates an event and sets the communication notification type as social post and when 'Event: Mail Scheduler' scheduled action is executed the error occurs. See this traceback: ``` AttributeError: 'mail.template' object has no attribute 'account_ids' File "addons/event/models/event_mail.py", line 258, in schedule_communications self.browse(scheduler.id).execute() File "home/odoo/src/enterprise/saas-16.2/event_social/models/event_mail.py", line 39, in execute social_posts_values = [ File "home/odoo/src/enterprise/saas-16.2/event_social/models/event_mail.py", line 42, in <listcomp> if scheduler.template_ref.account_ids ``` Steps to reproduce: 1. Install event_social module. 2. Go to event module and create an event. 3. Now in event's form view go to the communication page. 4. Click add a line and set notification type as social post then save it. 5. Go to Settings > Technical > Scheduled Actions > Event: Mail Scheduler. 6. Click on run manually button. 7. The error will occur. Applying this commit will fix this issue. Community PR: https://github.com/odoo/odoo/pull/122026 sentry-4195133685 Forward-Port-Of: odoo/enterprise#42827 Forward-Port-Of: odoo/enterprise#41322

Before this commit, when the user goes to `Planning > Schedule > By Project` and he has no access to Project app or no access to one project linked to his shifts then an access error is occurred. The reason is because the allocated hours of each project linked to the shifts displayed in the gantt view to be able to display the progress bar per project and so if the user cannot access to at least one project then the access error is raised when we try to fetch the allocated hours of that project. Steps to reproduce the issue: ---------------------------- 1. install `project_timesheet_forecast` module (with demo data) 2. log in as Marc Demo 3. go to `Planning > Schedule > By Project` Actual behavior: --------------- An access error is occurred because Marc Demo cannot read `Research & Development` project and so the allocated hours cannot be fetched for the progress bar. Expected behavior: ----------------- The user should see the gantt view and also the progress bar even if he cannot access to at least one project linked to the shifts displayed in the gantt view. Related to the fix done in 16.0: https://github.com/odoo/enterprise/pull/42869 Forward-Port-Of: odoo/enterprise#42868

Improvements(8)

[IMP] point_of_sale: remove dead code

[IMP] hr_appraisal_survey: adapt survey inherited views to appraisal

[IMP] account_edi: change banner

[IMP] l10n_mx: Update description manifest

[IMP] hr_appraisal_survey: adapt survey inherited views to appraisal

[IMP] helpdesk: rename Team to Helpdesk Team

[IMP] hr_contract_salary,hr_payroll: hide some fields and Index Contracts btn in contract templates

display no_open/no_create option in inherited many2one

Bug Fixes(6)

[FIX] hr: remove deadcode of KanbanView/openChat

[FIX] pos_preparation_display: fix template name

Removals(1)

[REM] hr,hr_holidays: remove deprecated code

Other(38)

[FW][FIX] web_editor: keep the observer active while adding link hint class

Improvements(8)

[IMP] point_of_sale: remove dead code

[IMP] hr_appraisal_survey: adapt survey inherited views to appraisal

[IMP] account_edi: change banner

[IMP] l10n_mx: Update description manifest

[IMP] hr_appraisal_survey: adapt survey inherited views to appraisal

[IMP] helpdesk: rename Team to Helpdesk Team

[IMP] hr_contract_salary,hr_payroll: hide some fields and Index Contracts btn in contract templates

display no_open/no_create option in inherited many2one

Bug Fixes(6)

[FIX] hr: remove deadcode of KanbanView/openChat

[FIX] pos_preparation_display: fix template name

Removals(1)

[REM] hr,hr_holidays: remove deprecated code

Other(38)

[FW][FIX] web_editor: keep the observer active while adding link hint class

[FIX] hr_appraisal: remove deadcode of KanbanView/openChat

add test to check focus is in app creator input

[FIX] hr_recruitment_reports: ignore deleted columns

studio opening report without record

[FW][FIX] account: fixed account group with same granularity

[FW][IMP] http_routing: server_redirect in case of 404

[FW][IMP] account: prevent the deletion of tag when set on tax

[FW][FIX] event_sms: check model of sms template

[FW][FIX] mail: Wrong selector for attachment in full composer tour test

[FW][FIX] website: Fix footer Slide Hover glitching on Safari

[FW][IMP] website: make website_nightly build work before 16.4

[FW][FIX] mrp_subcontracting: only import needed files

[FW][FIX] mass_mailing: update iframe size on pick template

[FW][FIX] web_editor: properly convert svg shapes

[FW][FIX] stock{_dropshipping}: dropship tracked product

[FW][FIX] point_of_sale: apply cogs on delivery picking only

[FW][FIX] l10n_es_edi_facturae: Fix Send & Print

[FW][FIX] web: focus html field

[FW][FIX] stock: prevent traceback when lots is empty in import serial/lots

[FW][FIX] base_geolocalize: update log when request to openstreetmap fails

[FW][FIX] mail: usable ListActivity widget in many2many subview

[FW][FIX] point_of_sale: prevent traceback while open session with the portal user

[FW][FIX] web_editor: avoid failing switching mode while image is selected

[FW][IMP] l10n_nl: add triangular tax

[FW][IMP] account: make multivat great again

[FW][FIX] web: reposition popover when image is loaded

[FW][FIX] knowledge: fix search favorites tour

[FW][FIX] l10n_be_reports: 281.50 negative lines

[FW][FIX] l10n_mx_edi_40: add l10n_mx_edi_fiscal_regime to pdf report

[FW][FIX] account_reports: prevent traceback of none type in 'number_period'

[FW][FIX] l10n_nl_intrastat: adapt EC Sales report to triangular

[FW][IMP] l10n_ec: Change author to follow standard

[FW][FIX] hr_payroll: missing aggregate total for salary attachments

[FW] 16.0 opw 3340830 fix agr

[FW][FIX] voip: dialing panel style improvements

[FW][IMP] l10n_in_reports_gstr: remove TDS when matching GSTR-2B

[FW][FIX] l10n_pe_edi_stock: conditionally define readonly

[FW][FIX] mrp_subcontracting_*: adapt to commuity assets import

[FW][FIX] event_social: prevent traceback when notification type is social post

[FW][FIX] project_timesheet_forecast: get allocated_hours of project

[FW][FIX] sale_planning: fix wrong allocated hour calculation