Odoo Changelog — 2023-06-27

Tuesday, June 27, 2023

3 changes · master

Bug Fixes(3)

Resolved issues and error corrections

[FIX] website: use the domain on the form fields

PR #121903

CoremasterwebsiteMedium

Website form fields now respect the filters configured for each form action. This prevents choices such as external users from appearing where only internal users should be selectable, improving accuracy when creating records like sales opportunities.

Original PR description

For each form action, existing fields can be defined. These existing fields are references to objects in the ORM. It is possible to put a domain on the field in order to filter the elements you want. For example, the "Create an opportunity" action has a "Salesperson" field that refers to users. This field filters the external users of the company in order to have only the internal users. Unfortunately, although this domain is present, it was not taken into account when displaying the values for the field. This commit fixes this problem and takes into account the defined domain.

Steps to reproduce the bug fixed by this commit:
- Have the website_crm module installed
- Put a form on a page of the website
- Set the form action to "Create an Opportunity"
- Add a new field
- Set the field type to "Salesperson"

=> The list of users displayed contains external users of the company.

task-3095745

#website forms#crm#field filters

[FIX] pos*: Fix order removal

PR #126442

Coremasterpoint_of_salepos_restaurantMedium

Fixes an issue where deleting an order in the restaurant point of sale could accidentally process the same order twice. This helps keep POS order records accurate and avoids duplicate entries during order removal.

Original PR description

pos*: point_of_sale, pos_restaurant

When deleting an order, the restaurant override of the deletion function in `point_of_sale` interferes with the logic in such a way that we end up writing the order that needs to be deleted 2 times.

This is obviously not the expected bahaviour. In this PR we remove the `override` from `pos_restaurant`, as it is no longer needed and we also add a mechanism that ensures that orders cannot be duplicated.

Task: 3383043

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#pos#restaurant#orders#deletion

[FIX] account_report: load more functionality

PR #43182

Enterprisemasteraccount_reportsMedium

The 'load more' action in accounting reports now works without errors and correctly displays the additional records. This helps users review longer reports smoothly without missing lines or encountering interruptions.

Original PR description

The issue:
When attempting to load additional records by clicking on 'load more...', we encounter a traceback. This occurs because, during the initial report load, the option next_progress is sent as a JSON string instead of a JSON object. Consequently, when accessing this object in the _get_aml_line function at line 612, a traceback is raised due to its string format. Upon addressing this traceback, a new issue arises where the lines are correctly received from the backend but do not appear in the UI. This issue stems from the visibility of these lines not being updated, resulting in their absence from the user interface.

The fix:
- Sending the next_progress as json object
- updating the visibility of the loaded lines

opw-3379697

#accounting#reports#load more#user interface

For each form action, existing fields can be defined. These existing fields are references to objects in the ORM. It is possible to put a domain on the field in order to filter the elements you want. For example, the "Create an opportunity" action has a "Salesperson" field that refers to users. This field filters the external users of the company in order to have only the internal users. Unfortunately, although this domain is present, it was not taken into account when displaying the values for the field. This commit fixes this problem and takes into account the defined domain. Steps to reproduce the bug fixed by this commit: - Have the website_crm module installed - Put a form on a page of the website - Set the form action to "Create an Opportunity" - Add a new field - Set the field type to "Salesperson" => The list of users displayed contains external users of the company. task-3095745

pos*: point_of_sale, pos_restaurant When deleting an order, the restaurant override of the deletion function in `point_of_sale` interferes with the logic in such a way that we end up writing the order that needs to be deleted 2 times. This is obviously not the expected bahaviour. In this PR we remove the `override` from `pos_restaurant`, as it is no longer needed and we also add a mechanism that ensures that orders cannot be duplicated. Task: 3383043 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The issue: When attempting to load additional records by clicking on 'load more...', we encounter a traceback. This occurs because, during the initial report load, the option next_progress is sent as a JSON string instead of a JSON object. Consequently, when accessing this object in the _get_aml_line function at line 612, a traceback is raised due to its string format. Upon addressing this traceback, a new issue arises where the lines are correctly received from the backend but do not appear in the UI. This issue stems from the visibility of these lines not being updated, resulting in their absence from the user interface. The fix: - Sending the next_progress as json object - updating the visibility of the loaded lines opw-3379697