Saturday, July 8, 2023
6 changes · master
Miscellaneous changes
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#127022
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#127022
Before this commit, the icon and label of the attachment button in chatter topbar was not aligned. Before / After   Forward-Port-Of: odoo/odoo#127848
Original PR description
Before this commit, the icon and label of the attachment button in chatter topbar was not aligned. Before / After   Forward-Port-Of: odoo/odoo#127848
The "Add Followers" button felt too close to top of menu, and the last item was to close to bottom of menu. Before / After   Forward-Port-Of: odoo/odoo#127849
Original PR description
The "Add Followers" button felt too close to top of menu, and the last item was to close to bottom of menu. Before / After   Forward-Port-Of: odoo/odoo#127849
This commit fixes a bug (corner case) concerning payments to yourself where an early payment discount is applied. **Details / steps to reproduce the bug:** 1. Create an invoice 2. Select your own (currently selected) company as customer 3. Select some payment term with early payment discount (e.g. '2/7 Net 30') 4. Confirm the invoice. 5. Click "Register Payment" and keep the default values (i.e. "Mark as fully paid" should be selected) 6. Click "Create Payment" 7. A User Error like the
Original PR description
This commit fixes a bug (corner case) concerning payments to yourself where an early payment discount is applied. **Details / steps to reproduce the bug:** 1. Create an invoice 2. Select your own…
This commit fixes a bug (corner case) concerning payments to yourself where an early payment discount is applied. **Details / steps to reproduce the bug:** 1. Create an invoice 2. Select your own (currently selected) company as customer 3. Select some payment term with early payment discount (e.g. '2/7 Net 30') 4. Confirm the invoice. 5. Click "Register Payment" and keep the default values (i.e. "Mark as fully paid" should be selected) 6. Click "Create Payment" 7. A User Error like the following should appear (with different journal entry names): "Journal Entry Draft Entry PBNK1/2023/00001 (INV/2023/00005) is not valid. In order to proceed, the journal items must include one and only one receivable/payable account (with an exception of internal transfers)." **Why the bug happens:** The early payment discount adds some extra lines to the journal entry associated with the payment. Currently those extra lines are classified as "counterpart lines" since the customer is our own company. But there must be exactly 1 "counterpart line". **How the bug is fixed:** The condition that classifies the extra lines as "counterpart lines" was only intended for internal transfers. Each company has a related "transfer account" that is used as an intermediary account for internal transfers. Thus the old condition (c.f. commit diff) when checking whether a line is a "counterpart line" can be replaced by checking whether the account associated with the line is the "transfer account" of our company. task-3388294 Forward-Port-Of: odoo/odoo#127412
Steps to reproduce the bug: - Go to Apps, and install the Knowledge App. - Go to Knowledge and create an article, and a child article. - Inside the child article, go to Properties tab and add a property. - Go to edit the property, and inside the popover,click on the delete button, atleast 2 times. - Now we got more than 1 popover to confirm the delete of the property, click delete on all of them. Issue: Once the first popover is confirmed, we properly delete
Original PR description
Steps to reproduce the bug:
- Go to Apps, and install the Knowledge App.
- Go to Knowledge and create an article, and a child article.
- Inside the child article, go to Properties tab and add a property.
- Go to edit the property, and inside the popover,click on the delete button, atleast 2 times.
- Now we got more than 1 popover to confirm the delete of the property, click delete on all of them.
Issue:
Once the first popover is confirmed, we properly delete the property
but now we are going to get an error because the property is already
deleted and we won't be able to find the property to delete.
Solution:
We need to check if we can find the property we want to delete
before doing any further actions.
Fw bot up to master
opw-3371753
Forward-Port-Of: odoo/odoo#126457
Forward-Port-Of: odoo/odoo#125407Steps to reproduce: 1. Install partner_commission, stock 2. Create two commission plans - 1. Name = 10, Rules: Product Category = All, Rate = 20 - 2. Name = 20, Rules: Product Category = All, Rate = 20 3. Create product P - Product Type = Storable, Sales Price = 100 - Sales Tab: Invoicing Policy = Ordered Quantity 4. Create or modify a contact C - Partner Assignment: Commission Plan = 10 5. Create sales order - Customer = any, Referrer = C, Commission Plan: 20 - Order Lines:
Original PR description
Steps to reproduce: 1. Install partner_commission, stock 2. Create two commission plans - 1. Name = 10, Rules: Product Category = All, Rate = 20 - 2. Name = 20, Rules: Product Category = All, Rate =…
Steps to reproduce: 1. Install partner_commission, stock 2. Create two commission plans - 1. Name = 10, Rules: Product Category = All, Rate = 20 - 2. Name = 20, Rules: Product Category = All, Rate = 20 3. Create product P - Product Type = Storable, Sales Price = 100 - Sales Tab: Invoicing Policy = Ordered Quantity 4. Create or modify a contact C - Partner Assignment: Commission Plan = 10 5. Create sales order - Customer = any, Referrer = C, Commission Plan: 20 - Order Lines: Product = P, Quantity = 1 - Confirm sales order, Create and view invoice - Confirm invoice, Register full payment 6. Go to Purchase, see the RfQ generated for the sales order Issue: The commission price on the RfQ is 10, instead of the expected 20. This happens because when we create the RfQ, we only consider the commission plan of the referrer, but not the commission plan specified on the sales order. Solution: Consider the commission plan on the sales order when creating the RfQ. opw-3217890 Forward-Port-Of: odoo/enterprise#43784 Forward-Port-Of: odoo/enterprise#42770