Odoo Changelog — 2023-07-10

Monday, July 10, 2023

47 changes · master

Improvements(4)

Enhancements to existing features

[IMP] web: use useAutoFocus hook in SelectMenu

Coremasterweb

Select menu search fields now use Odoo's standard focus behavior when the menu opens. This keeps the user experience the same while simplifying maintenance and reducing the chance of future inconsistencies.

Original PR description

This commit makes use of the useAutoFocus hook to focus the input when the SelectMenu opens. This usage of the hook can replace the manual focus that was applied when the dropdown opened.

The feature can hardly be tested with newer tests, since the behavior is identical, and the focus on the input was already tested.

#select menu#focus#usability

[IMP] mail: add missing type def

PR #127868

Coremastermail

This update adds missing internal type information in the mail module. It helps developers maintain the messaging code more reliably without changing what users see.

#mail#maintenance#developer-quality

[IMP] knowledge: re-activate the view arch validation

PR #43168

Enterprisemasterknowledge

The Knowledge app now restores standard validation checks for its form views after previously incompatible directives were removed. This helps catch invalid view definitions earlier, reducing the risk of future display or stability issues for users.

Original PR description

Now that the forbidden `t-` owl directives have been removed from the arch of the form view of Knowledge, we will re-enable the default arch view validator. That way, we will be able to detect usage of forbidden directives, attributes, etc and prevent potential issues.

Follow up of task: 3094058

task-3385229

#knowledge#validation#stability

[IMP] sign: change recipient text

PR #42986

Enterprisemastersign

The signing flow updates the wording shown for recipients when sending signature requests. This makes the message clearer for users preparing documents and helps reduce confusion for recipients.

Original PR description

task-id: 3284359

#signatures#recipients#wording

Bug Fixes(3)

Resolved issues and error corrections

[FIX] web: fix checkbox component's width

PR #127118

Coremasterweb

Checkboxes and toggles now only respond when users click directly on the control itself. This reduces accidental changes caused by clicking nearby empty space, improving reliability in forms and settings.

Original PR description

This commit simply restricts the clickable with of any checkbox component to be restricted to the checkbox (or toggle) itself so that the user can no longer toggle it accidentally from a possibly long range.

opw-3378955

#checkbox#usability#forms

[FIX] core: missing escaping in sql constraint name_manual_field

Other(40)

Miscellaneous changes

[FW][FIX] web_editor: prevent losing text-gradient class on gradient preview

PR #127810

Coremasterweb_editor

Steps to reproduce: - Drop a Title block in a webpage. - Select text. - Set the text color to a custom gradient. (Not the background color) - Hover a gradient preset. - Leave the gradient preset. gradient color applied on the background. In this PR, Modified the condition which was blocking some mutations from being processed. Before this commit condition got executed successfully on an empty array(`excludedClasses`) too, which should not be. PR:[118872](https://github.com/odoo/

Original PR description

Steps to reproduce:

- Drop a Title block in a webpage.
- Select text.
- Set the text color to a custom gradient. (Not the background color)
- Hover a gradient preset.
- Leave the gradient preset.
gradient color applied on the background.

In this PR,
Modified the condition which was blocking some mutations from being
processed. Before this commit condition got executed successfully on an empty
array(`excludedClasses`) too, which should not be.

PR:[118872](https://github.com/odoo/odoo/pull/118872)
task-3120090

Forward-Port-Of: odoo/odoo#118872

This commit makes use of the useAutoFocus hook to focus the input when the SelectMenu opens. This usage of the hook can replace the manual focus that was applied when the dropdown opened. The feature can hardly be tested with newer tests, since the behavior is identical, and the focus on the input was already tested.

Now that the forbidden `t-` owl directives have been removed from the arch of the form view of Knowledge, we will re-enable the default arch view validator. That way, we will be able to detect usage of forbidden directives, attributes, etc and prevent potential issues. Follow up of task: 3094058 task-3385229

This commit simply restricts the clickable with of any checkbox component to be restricted to the checkbox (or toggle) itself so that the user can no longer toggle it accidentally from a possibly long range. opw-3378955

While creating an invoice if the user chooses a payment term with an early discount, saves the invoice without adding invoice date and tries to preview it or prints it, then the user will face the error. steps to produce: - Create an invoice without entering invoice date, with a payment term having early discount through 'Invoicing > Customers > Invoices'. eg: (Payment Term with early discount: 2/7 Net 30 ) - Now click on 'Preview' to preview the invoice or print the invoice report. By following above steps you will be able to produce the error. ``` TypeError: unsupported operand type(s) for +: 'bool' and 'relativedelta' File "<683>", line 2250, in template_683 File "<683>", line 2232, in template_683_content File "<683>", line 1916, in template_683_t_call_0 File "addons/account/models/account_move.py", line 1862, in _is_eligible_for_early_payment_discount and reference_date <= self.invoice_payment_term_id._get_last_discount_date(self.invoice_date)\ File "addons/account/models/account_payment_term.py", line 233, in _get_last_discount_date return date_ref + relativedelta(days=self.discount_days or 0) if self.early_discount else False QWebException: Error while render the template TypeError: unsupported operand type(s) for +: 'bool' and 'relativedelta' Template: account.report_invoice_document Path: /t/t/div[2]/div[3]/div[2]/t/div/div/t[1]/td/span[1] Node: <span t-options="{"widget": "monetary", "display_currency": o.currency_id}" t-out="o.invoice_payment_term_id._get_amount_due_after_discount(o.amount_total, o.amount_tax)"/> File "odoo/http.py", line 2114, in __call__ response = request._serve_db() File "odoo/http.py", line 1699, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1726, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1840, in dispatch return self.request.registry['ir.http']._dispatch(endpoint) File "addons/website/models/ir_http.py", line 234, in _dispatch response = super()._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 716, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/account/controllers/portal.py", line 121, in portal_my_invoice_detail return self._show_report(model=invoice_sudo, report_type=report_type, report_ref='account.account_invoices', download=download) File "addons/portal/controllers/portal.py", line 491, in _show_report report = getattr(ReportAction, method_name)(report_ref, list(model.ids), data={'report_type': report_type})[0] File "odoo/addons/base/models/ir_actions_report.py", line 887, in _render_qweb_html return self._render_template(report.report_name, data), 'html' File "odoo/addons/base/models/ir_actions_report.py", line 626, in _render_template return view_obj._render_template(template, values).encode() File "addons/website/models/ir_ui_view.py", line 440, in _render_template return super()._render_template(template, values=values) File "odoo/addons/base/models/ir_ui_view.py", line 2164, in _render_template return self.env['ir.qweb']._render(template, values) File "odoo/tools/profiler.py", line 292, in _tracked_method_render return method_render(self, template, values, **options) File "odoo/addons/base/models/ir_qweb.py", line 588, in _render result = ''.join(rendering) File "<689>", line 90, in template_689 File "<689>", line 72, in template_689_content File "<689>", line 60, in template_689_t_call_0 File "<683>", line 2256, in template_683 ``` sentry-4250888430 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#125193

## Current behaviour When creating a new quotation from an FSM task, if we use a template that adds a line that is a service that would have added a task on SO confirmation, no new task is generated. ## Expected behaviour A new task should be created, just like when we add manually the line with service without using a quotation template. ## Steps to reproduce - Install FSM - Activate "Extra Quotations" from Settings - Create a new service that generates a task on SO confirmations - Create a new quotation template, add a line that uses the service we created. - In a FSM task, click on "New Quotation" - Add the template to the quotation and confirm it - Observe there is no Task attached to the SO. No new task was created. ## Reason for the problem When we create a new quotation view the action "New Quotation", we add in the context a key `default_task_id` with the current task that generated the quotation. When we add a template, an onchange is triggered which creates the lines for the SO, and since we have a `default_task_id` in the context, the related task of the new line is set to the task we came from. This prevent subsequently the creation of a task if the service was supposed to generate a new task on SO confirmation. ## Fix Add an override when generating the data used to create the lines when the onchange is triggered, explicitly setting the `task_id` on the line to `False` if the key is in the context and the service would've generated a task. ## Affected versions - 15.0 - saas-15.2 - 16.0 - saas-16.1 - saas-16.2 - saas-16.3 - master --- opw-3360403 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#127741 Forward-Port-Of: odoo/odoo#126720

If user tries to publish or unpublish the forum post from forum posts list view, a traceback will appear. Steps to reproduce the issue: - Install website_forum - Configure website - Go to Website -> site -> Forum Posts - Select any post -> Action -> 'Publish' or 'Unpublish' Traceback: ``` ValueError: Invalid field 'is_published' on model 'forum.post' File "odoo/http.py", line 2123, in __call__ response = request._serve_db() File "odoo/http.py", line 1699, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1726, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1927, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "addons/website/models/ir_http.py", line 234, in _dispatch response = super()._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 716, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 30, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 461, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 448, in _call_kw_multi result = method(recs, *args, **kwargs) File "addons/website_forum/models/forum_post.py", line 388, in write res = super(Post, self).write(vals) File "addons/mail/models/mail_thread.py", line 312, in write result = super(MailThread, self).write(values) File "odoo/models.py", line 3943, in write raise ValueError("Invalid field %r on model %r" % (fname, self._name)) ``` https://github.com/odoo/odoo/blob/551685368971161975d64f480e9bec326db8931e/addons/website/static/src/components/views/page_list.js#L69 Here we will receive 'forum.post' in this.props.resModel. is_published field is not present in the 'forum.post' model, So it will lead to above traceback. sentry-4256037237 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#127225 Forward-Port-Of: odoo/odoo#126648

The website frontend apps menu list is not working when the user has a `Home Action` defined on his user. The `Home Action` is meant to redirect to the defined action whenever that user is login in. But since the backend menu links on the website have most of the time no `action` defined but just a `menu_id` defined, the `Home Action` will kick in and take over the redirection, the same way as if the user just type `/web` without any params. To solve that, we simply force the `action` of those links (if they don't already have one). This will make sure that the redirect is working as it should for users having a `Home Action` set. --- Technical hints --- There is multiple methods to get the list of menus in Odoo: - `load_web_menus`: called by the web client rpc, calling `load_menus`. If a top/app menu has no action defined on it, it sets the first found action of their children menus to it. It returns the full (flat) list of menus, not only the top/app ones. This method is not ormcached but is calling an ormcached method and just doing some tiny work on the data. - `load_menus_root`: called only by website backend template to add the app list on the website (in the frontend) to jump to the backend. It does not force the action if a menu has no action set on it. It returns only the top/app menus. This method is ormcached. Note that this method seems only used by the website module. - `load_menus`: returns the full (flat) list of menus without a force action This method is ormcached. Fixes https://github.com/odoo/odoo/issues/119971 Forward-Port-Of: odoo/odoo#127512 Forward-Port-Of: odoo/odoo#125801

When the user deletes the certificate of facturae EDI invoices on Spain and tries to send an invoice from the `Send & Print`, button error will be produced says, the local variable 'xml_content' referenced before the assignment. Steps to produce: - Install the 'l10n_es_edi_facturae' module and change the company to ES Company. - Accounting > Configuration > Spain Facturae EDI > Certificates. - Delete all the certificate(s). - Now create one Invoice > Confirm > Send & Print > Click on `Send & Print` button from the wizard. - Error will be produced. Fix this issue by using the variable `xml_content = b''`. If it fails to get xml_content from the try block, an error will be handled. Sentry-4265566923 Traceback: ``` UnboundLocalError: local variable 'xml_content' referenced before assignment File "odoo/http.py", line 2123, in __call__ response = request._serve_db() File "odoo/http.py", line 1699, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1726, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1927, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 716, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 34, in call_button action = self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 461, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 448, in _call_kw_multi result = method(recs, *args, **kwargs) File "addons/account/wizard/account_move_send.py", line 593, in action_send_and_print self._generate_invoice_documents(moves_data, allow_fallback_pdf=allow_fallback_pdf) File "addons/account/wizard/account_move_send.py", line 514, in _generate_invoice_documents form._hook_invoice_document_before_pdf_report_render(invoice, invoice_data) File "addons/l10n_es_edi_facturae/models/account_move_send.py", line 71, in _hook_invoice_document_before_pdf_report_render 'raw': xml_content, ``` Forward-Port-Of: odoo/odoo#126029

Steps to reproduce: ------------------- - with timezone "Europe/Brussels" (UTC +02:00); - create an attendance that starts at 1:00 AM; - go to pivot view in Reporting tab. Issue: ------ Attendance appears to be a day early. Cause: ------ When converting a date to UTC for database storage, it's possible that the date may change (due to a large offset or hours close to 00:00). Therefore, when we use `CAST(check_in as DATE)`, we will keep the date that has potentially changed. Solution: --------- Use postgresql's `at time zone <timezone_name>` statement to convert the recorded attendance to UTC in the employee's timezone. Note: ----- On an employee's form view, the "Working Hours" field (`resource_calendar_id`) is required. The `resource_calendar_id` field is a Many to One to the `resource.calendar` model. The `resource.calendar` model contains the `tz` field, which is required. As a result, it will always be possible to find an employee's timezone via his calendar resource. Hypothesis: ----------- Attendances are created using the browser's timezone. It is normal to think that the employee's calendar timezone is the same as his browser timezone. opw-3370874 Forward-Port-Of: odoo/odoo#127035

Improvements(4)

[IMP] web: use useAutoFocus hook in SelectMenu

[IMP] mail: add missing type def

[IMP] knowledge: re-activate the view arch validation

[IMP] sign: change recipient text

Bug Fixes(3)

[FIX] web: fix checkbox component's width

[FIX] core: missing escaping in sql constraint name_manual_field

Other(40)

[FW][FIX] web_editor: prevent losing text-gradient class on gradient preview

Improvements(4)

[IMP] web: use useAutoFocus hook in SelectMenu

[IMP] mail: add missing type def

[IMP] knowledge: re-activate the view arch validation

[IMP] sign: change recipient text

Bug Fixes(3)

[FIX] web: fix checkbox component's width

[FIX] core: missing escaping in sql constraint name_manual_field

Other(40)

[FW][FIX] web_editor: prevent losing text-gradient class on gradient preview

Various fixes related to onchange2()

[FW][FIX] account: preview invoice if invoice_date not given

[FW][FIX] packaging: remove useless soft links

[FW][FIX] website: fix failing unsplash beacon test

[FW][FIX] sale_project: create task when confirm SO from template

[FW][FIX] sale, account_payment: fix saleman payment transactions access error

[FW][FIX] project: add index on `project.task` `state`

[FW][FIX] l10n_eg_edi_eta, l10n_sa: Adapting barcode API to the new one

[FW][FIX] web_editor: change icon of table menu

[FW][FIX] website: hide publish and unpublish actions

[FW][FIX] web_editor: prevent traceback on convert single-col align stretch

[FW][FIX] web: kanban header vertical padding

[FW][FIX] website: change translate btn to lowercase

[FW][FIX] mail: standardize way to get guest from context

[FW][FIX] website: allow `load_menus_root` to force action

[FW][FIX] project: improve performance for project_root_id search

[FW][FIX] Project: tooltip misleading

[FW][FIX] web_editor: avoid fetching optimized images which can't be shown

[FW][FIX] hr_expense: set correct account_id on upload

[FW][FIX] l10n_es_edi_facturae: certificates deleted for facturae EDI

[FW][FIX] website_slides: fix access error when user lists its own courses

[FW][FIX] sale: fix amount to invoice for credit notes

[FW][FIX] website_sale: unable to confirm zero-amount cart

[FW][FIX] web_editor: properly close all connections during PTP stop

[FW][FIX] account: currency change not propagated

[FW][FIX] website: add test for website filter in list view

[FW][FIX] website: don't error on inaccessible model

[FW][FIX] point_of_sale: Update raspberry pi os for iot use

[FW][FIX] web: fix calendar buttons spacing

[FW][FIX] mail: close chatter button in attachment view

[FW][FIX] hr_attendance: correct timezone in report

[FW][FIX] hr_timesheet: fix access error on 'all timesheets' list view

[FW][FIX] l10n_ke_hr_payroll: fixing salary rule in Kenyan payroll

[FW][FIX] voip: properly display number of missed calls

[FW][FIX] sale_subscription: fix sub. confirmation for user wo/ acct access

[FW][FIX] project_enterprise,web_gantt: fix schedule task from gantt

[FW][FIX] account_reports: Cash Flow report: handle multiple account tags

[FW][FIX] mrp_workorder: tablet form background

[FW][FIX] documents: drag&drop don't crash in list view

[FW][FIX] l10n_cl_edi: allow download of DTE attachment