Wednesday, July 26, 2023
43 changes · master
Enhancements to existing features
Odoo now includes Sierra Leone's new SLE currency and uses it as the country's default currency. This helps businesses record transactions and country data with the current official currency.
Original PR description
- adds a new currency SLE for new leones. - sets the default currency for Sierra Leone to the new SLE currency. task-3355038
Sales orders marked as fully invoiced will now show the amount left to invoice as zero. This prevents confusion by keeping the displayed invoicing amount aligned with the order's invoicing status.
Original PR description
For sale orders, if the invoice status is set to "Fully Invoiced", the mount to invoice is forced to zero. task-3347812
The manufacturing work order test tour was updated to stay aligned with recent changes in the related production workflow. This helps ensure automated checks continue to validate employee-based production scenarios reliably without affecting day-to-day users.
Original PR description
This commit adapts the test_production_with_employee tour to cope with the changes made in https://github.com/odoo/odoo/pull/121943 Task-3167110
The VoIP interface was updated to use newer platform capabilities and avoid unnecessary data conversion when displaying repeated items. This is a small internal improvement that can help keep the calling interface cleaner and more efficient without changing user workflows.
Original PR description
As of Owl 2.2, it is now possible to use iterable directly in t-foreach without having to convert it to array first. This commit takes advantage of this new feature to remove the unnecessary array conversions from the VoIP code. Community: https://github.com/odoo/odoo/pull/129765
Resolved issues and error corrections
The web test suite now includes the needed Monokai editor theme so test editors can load correctly and clean up memory. This reduces memory leaks during automated testing, helping keep development and quality checks more stable.
Original PR description
When attempting to instantiate an ace editor with a given theme, ace will first create the editor with the default theme (textmate) which is always loaded, and register a callback to be called after the non-default theme has been loaded. This callback holds a reference to the editor's renderer which can itself retain large objects such as an entire owl application. These callbacks are not cleared even if the corresponding editor is destroyed. Because in tests, the theme "monokai" was not included and ace cannot load it on its own, all tests that attempt to create an ace editor with that theme will leak memory. This commit fixes the issue by adding theme-monokai to the qunit suite assets. Enterprise: https://github.com/odoo/enterprise/pull/44594
Code cleanup and technical improvements
This update removes obsolete internal web code and legacy test helpers that are no longer needed after Odoo's newer web framework migration. It helps reduce maintenance overhead and keeps CRM, web, mail, manufacturing, point of sale, and project areas aligned with the modern platform, with little direct impact on day-to-day users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Before this PR, failing to persist a livechat thread would stuck the livechat session in an incoherent state, preventing the user to open a livechat. This PR ensures the thread service does not write anything if there is no session. Forward-Port-Of: odoo/odoo#129596
Original PR description
Before this PR, failing to persist a livechat thread would stuck the livechat session in an incoherent state, preventing the user to open a livechat. This PR ensures the thread service does not write anything if there is no session. Forward-Port-Of: odoo/odoo#129596
The user menu now displays the dark mode option with proper alignment, preventing the selection button from overlapping the description. This makes the menu easier to read and gives users a cleaner, more polished experience.
Original PR description
before this commit, the dark mode button is not aligned properly in the user menu. the radio button is coming on top of the dark mode description. after this commit, the dark mode will be aligned well in user menu Before:  After:  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restores missing steps in the Restaurant Point of Sale automated tour that were accidentally removed by a recent change. This helps keep automated validation stable and prevents avoidable build failures, with no expected impact on daily users.
Original PR description
A recent PR removed some lines in the pos_restaurant tour ( odoo/odoo#124157 ). This commit put them back to avoid runbot error. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a new column in kanban views grouped by many-to-many or one-to-many fields no longer causes a crash. This improves reliability for users organizing records in grouped kanban boards.
Original PR description
Before this commit, in a kanban view grouped on a x2m, when we created a new column, we had a crash. Why did this happen? When a column is created, a resequence is triggered on the columns in order to have the correct position. Currently, we always use the DynamicGroupList handle field, which is not correct because if we are grouped on an x2m we use another resModel, so we want to use the default handle field (sequence). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a loading issue in the Project app by ensuring the editor components it depends on are included upfront. Users should see the project web interface behave correctly where rich text editing features are needed.
Original PR description
Since #118966, the `web_editor.assets_wysiwyg` assets are not lazy loaded anymore and therefore need to be included in `project.webclient`. task-3434068 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a new partner from a grouped Knowledge kanban view no longer assigns an unrelated parent company/contact. This prevents incorrect partner hierarchy data when users add partners directly from embedded Knowledge article views.
Original PR description
Bug === In an embed kanban view, if you group the article by a "res.partner", you will be able to create new partner from there (by creating new column). Because the context key "default_parent_id" is set, and because "res.partner" also have a "parent_id" field, the parent of the newly created partner was set to a random one (that have the same id of the parent article). Task-3358295
The enterprise web client now properly removes a permission-change listener when it closes. This prevents leftover application data and page elements from affecting automated tests, improving test reliability especially around Studio.
Original PR description
In order to add the push-notification capability to the PWA in enterprise, the enterprise webclient needs to listen for changes in permissions. The listener was not correctly cleared on destroy, which caused tests that use the enterprise webclient to leak the entire owl application and its corresponding DOM (this was mostly visible in studio tests) This commit fixes that by removing the event listener when the webclient is destroyed. Community: https://github.com/odoo/odoo/pull/129704
Enterprise test code was updated to work after older shared test helpers were removed in the main Odoo codebase. This keeps automated checks for Documents and Spreadsheet reliable without changing day-to-day user functionality.
Original PR description
This PR is the enterprise counterpart of odoo/odoo#129725 where we remove several legacy test helpers. We thus had to adapt some tests that were still using them. Part of task~3439226
Forward-Port-Of: odoo/odoo#129555
Original PR description
Forward-Port-Of: odoo/odoo#129555
Steps to reproduce: ------------------- - go to the hr leave form; - select "By Employee" mode; - select an employee-based leave type; (example: Paid Time Off (20 remaining out of 20 days)) - change mode with "By Company"; Issue: ------ A specific leave to one employee can be validated for all employees of a company. Cause: ------ The `_compute_from_employee_id` method does not set the `holiday_status_id` field to `False` in this case. Solution: --------- When we detect an `
Original PR description
Steps to reproduce: ------------------- - go to the hr leave form; - select "By Employee" mode; - select an employee-based leave type; (example: Paid Time Off (20 remaining out of 20 days)) - change mode with "By Company"; Issue: ------ A specific leave to one employee can be validated for all employees of a company. Cause: ------ The `_compute_from_employee_id` method does not set the `holiday_status_id` field to `False` in this case. Solution: --------- When we detect an `employee_id` change and it is `False`, we must remove the current `holiday_status_id`. opw-3386332 Forward-Port-Of: odoo/odoo#129380 Forward-Port-Of: odoo/odoo#129311
This PR fixes the Calendar's font-size, reported in the milk-testing pad: - [BRD] Calendar : numbers too big ? https://www.awesomescreenshot.com/image/39615825?key=a8393b618be6cdd6ae8db55644930ab0 Tthe font-size of the days and weeks in the "month" view of the Calendar view were very large. Also, the circle highlighting "today" was not circular when "today" is a single digit. This PR reduces the font-size of the days and weeks and fixes the roundness of the circle. task-3326564 par
Original PR description
This PR fixes the Calendar's font-size, reported in the milk-testing pad: - [BRD] Calendar : numbers too big ? https://www.awesomescreenshot.com/image/39615825?key=a8393b618be6cdd6ae8db55644930ab0 Tthe font-size of the days and weeks in the "month" view of the Calendar view were very large. Also, the circle highlighting "today" was not circular when "today" is a single digit. This PR reduces the font-size of the days and weeks and fixes the roundness of the circle. task-3326564 part of task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#121359
Prior this commit, there was a problem with borders that were not displayed on the kanban header when the stage was folded and the user was trying to drag and drop in that stage. This commit removes the background set on `.o_kanban_header` when the stage is folded, so it doesn't overlap and hide the border set on `.o_kanban_group`. We can do that safely because a folded stage can't be scrolled Before:  After:  task-3423682 part of task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#128362
This PR aims to improve the look of the sidebar in the calendar view and app. Some spacing was off and some buttons had issues which have been fixed in this PR. The filter's checkboxes have been harmonized and the calendar's navigation improved to look like the one in gantt view. Enterprise PR : https://github.com/odoo/enterprise/pull/43686 task-3410165 part of task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-O
Original PR description
This PR aims to improve the look of the sidebar in the calendar view and app. Some spacing was off and some buttons had issues which have been fixed in this PR. The filter's checkboxes have been harmonized and the calendar's navigation improved to look like the one in gantt view. Enterprise PR : https://github.com/odoo/enterprise/pull/43686 task-3410165 part of task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#127413
This commit aims to give the same height to both `o_field_many2many_tags` and `o_field_many2many_avatar_user` when side by side and reduce the padding inside the notepad. To remove some visual clutter inside the inputs, we've removed the input's line (and the caret; without the line it seemed to be floating). To fix the padding we've removed the custom padding on (`.o_form_sheet`).  . To fix the padding we've removed the custom padding on (`.o_form_sheet`).   Note that this commit does not fix the status bar issue which should be done in a separate commit.  task-3420954 part of task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#128899
before this commit, if user try to regenerate the work entries from the button 'Regenerate Work Entries' in the work entries calendar view, the generated entries will not shown to the user immediately without reloading the screen. * payroll -> work entries -> work entries * switch to calendar view * click on Regenerate Work Entries button * select employee's and click Regenerate Work Entries * generated work entries will not be shown in calendar after this commit, the generated work en
Original PR description
before this commit, if user try to regenerate the work entries from the button 'Regenerate Work Entries' in the work entries calendar view, the generated entries will not shown to the user immediately without reloading the screen. * payroll -> work entries -> work entries * switch to calendar view * click on Regenerate Work Entries button * select employee's and click Regenerate Work Entries * generated work entries will not be shown in calendar after this commit, the generated work entries will be shown in the calendar immediately. https://github.com/odoo/odoo/assets/27989791/3bc66e37-694e-4131-983e-b47ca00da61f --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129506
This test can lead to a deadlock, when trying to drop the constraint on `ir_model_fields` during the registry loading, as the test opens a second cursor in addition to the cursor used for the registry loading, and drop a constraint on a table which is being read by the registry loading (`ir_model_fields`), leading to the deadlock.  This has been detected in the runbot nightly builds, which were pe
Original PR description
This test can lead to a deadlock, when trying to drop the constraint on `ir_model_fields` during the registry loading, as the test opens a second cursor in addition to the cursor used for the registry loading, and drop a constraint on a table which is being read by the registry loading (`ir_model_fields`), leading to the deadlock.  This has been detected in the runbot nightly builds, which were pending indefinitely because of that deadlock. To reproduce, just init a database with `-i base`, then restart the server with just `--test-tags .test_add_field_valid`. To avoid to drop the constraint during the registry loading, and hence to avoid the deadlock, tag the test as `post_install`. That way, the test is executed after the registry is loaded, not during, and the constraint can be drop safely, not leading to a deadlock. Forward-Port-Of: odoo/odoo#129512
See commits for detail, small design stuff Forward-Port-Of: odoo/odoo#129631
Original PR description
See commits for detail, small design stuff Forward-Port-Of: odoo/odoo#129631
[FIX] web_editor: correctly adapt the image mimetype on format change Steps to reproduce the bug: - Go on a product image and replace it by a ".jpeg" (note that the mimetype of the image is "image/webp" since [1]). - Change the format of the image and put it to "Original". The mimetype of the image is now "image/jpeg". - Add a shape on the image. - Change the format of the image. -> None is displayed. Let's preliminary recall that adding a shape on an image transforms its mimetype
Original PR description
[FIX] web_editor: correctly adapt the image mimetype on format change Steps to reproduce the bug: - Go on a product image and replace it by a ".jpeg" (note that the mimetype of the image is…
[FIX] web_editor: correctly adapt the image mimetype on format change Steps to reproduce the bug: - Go on a product image and replace it by a ".jpeg" (note that the mimetype of the image is "image/webp" since [1]). - Change the format of the image and put it to "Original". The mimetype of the image is now "image/jpeg". - Add a shape on the image. - Change the format of the image. -> None is displayed. Let's preliminary recall that adding a shape on an image transforms its mimetype into an "image/svg+xml" and that the `originalMimetype` attribute is used to record its original mimetype. This is needed in order to correctly reset the image mimetype when removing its shape. The problem here was that the `originalMimetype` attribute was not used correctly and that the mimetype of an image with a shape was not correctly updated at format change. [1]: https://github.com/odoo/odoo/commit/0449fe85cb0e1d639a4e1aeba26e90906f79254d task-3431015 Forward-Port-Of: odoo/odoo#128971
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129619
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129619
Before this commit, when a message had no text, the action list was placed above the message content, including attachments. This made it hard to find the action list for these messages, as all action lists of any messages are expected to always be next to the 1st line of the message content. This commit fixes the issue by placing action list next to text content if there are any (same as before), but if there are no text, then the actions are displayed next to attachments. The template
Original PR description
Before this commit, when a message had no text, the action list was placed above the message content, including attachments. This made it hard to find the action list for these messages, as all…
Before this commit, when a message had no text, the action list was placed above the message content, including attachments. This made it hard to find the action list for these messages, as all action lists of any messages are expected to always be next to the 1st line of the message content. This commit fixes the issue by placing action list next to text content if there are any (same as before), but if there are no text, then the actions are displayed next to attachments. The template requiring defining a shared container for text content and attachments, so that action list comes after. Also when the message has some text and some attachments, the action list is still expected to come inline of text content, which is why this commit conditionally places the action list accordingly. Part of Task-3340653 Before  After  Forward-Port-Of: odoo/odoo#129368 Forward-Port-Of: odoo/odoo#128940
Before this commit, autoresize input in Safari 16 had their size underestimated, thus truncating the content. For example, in the Discuss app, the header is a (disabled) autoresize input, which becomes enabled when the thread can be renamed. This is also used for threads that cannot be renamed for consistency of style. So some screens like "Inbox" had its name truncated to "In...". This problem is only present in Safari, not in Chrome or Firefox. Apparently the sizing of input and textarea i
Original PR description
Before this commit, autoresize input in Safari 16 had their size underestimated, thus truncating the content. For example, in the Discuss app, the header is a (disabled) autoresize input, which…
Before this commit, autoresize input in Safari 16 had their size underestimated, thus truncating the content. For example, in the Discuss app, the header is a (disabled) autoresize input, which becomes enabled when the thread can be renamed. This is also used for threads that cannot be renamed for consistency of style. So some screens like "Inbox" had its name truncated to "In...". This problem is only present in Safari, not in Chrome or Firefox. Apparently the sizing of input and textarea is incorrect, and it is fixed in Safari 17. Indeed, Safari 17 can be tested with Safari Technology Preview where the bug is not present. This commit fixes the issue by adding an offset to computing the scroll width of autoresize input, so that it matches the Safari 17 behaviour that is correct. Before / After <img width="741" alt="before" src="https://github.com/odoo/odoo/assets/6569390/157c6410-4ce8-43ab-9d40-0c3a581914d5"> <img width="743" alt="after" src="https://github.com/odoo/odoo/assets/6569390/eb3a5a6a-68a7-4394-81ac-30bcc3028a4f"> Forward-Port-Of: odoo/odoo#129178
### Current Behaviour In E-commerce, when you apply a ``LoyaltyCard`` which is not applicable on the ``SaleOrder``, in a specific case it displays a success message even if the coupon is not applied. ### Expected behaviour Don't display a success message when the coupon is not applicable ### Steps to reproduce - Create a program with 'coupon' type, a rule of 'minimum 1' and a reward on a specific product A. - Generate a coupon - Go to shop add product A to the cart, go to checkout and
Original PR description
### Current Behaviour In E-commerce, when you apply a ``LoyaltyCard`` which is not applicable on the ``SaleOrder``, in a specific case it displays a success message even if the coupon is not applied.…
### Current Behaviour In E-commerce, when you apply a ``LoyaltyCard`` which is not applicable on the ``SaleOrder``, in a specific case it displays a success message even if the coupon is not applied. ### Expected behaviour Don't display a success message when the coupon is not applicable ### Steps to reproduce - Create a program with 'coupon' type, a rule of 'minimum 1' and a reward on a specific product A. - Generate a coupon - Go to shop add product A to the cart, go to checkout and apply the coupon code(Everything goes well). - Delete the coupon and the product, and add a product B. - Go to checkout and try to apply the same coupon code. ### Issue Wrong success message  ### Reason of the problem The wrong message is displayed because on the python side we just check if there is 'error' in the ``Request.session`` but in this case there is also 'error_promo_code' that should be considered. opw-3355632 Forward-Port-Of: odoo/odoo#129315
`account_peppol_migration_key` is a related field, stored on the `account_edi_proxy_client.user`. We want to allow users to provide a migration key when they want to register as a new peppol participant, migrating their existing peppol registration from another smp. However, before they save and validate their registration, there is no `account_edi_proxy_client.user` associated with the company and hence the `migration_key` is never saved and never sent to the IAP server. The solution in master
Original PR description
`account_peppol_migration_key` is a related field, stored on the `account_edi_proxy_client.user`. We want to allow users to provide a migration key when they want to register as a new peppol participant, migrating their existing peppol registration from another smp. However, before they save and validate their registration, there is no `account_edi_proxy_client.user` associated with the company and hence the `migration_key` is never saved and never sent to the IAP server. The solution in master will be to move this field to `res.company` but in stable the workaround is to store it in `ir.config_parameter` and make it a computed field, where the config parameter is updated in the inverse method on `account_peppol_migration_key`. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129355
Release notes: https://github.com/odoo/owl/releases Commits: [IMP] runtime: add support for Map and other iterables in t-foreach [IMP] runtime: only destroy component in raf callback [REF] runtime: simplify implementation of batched [FIX] compiler: allow t-model.number to work with select [FIX] devtools: Fix crash when no root node [FIX] devtools: fix/imp env display [FIX] devtools: fix symbols handling and display Description of the issue/feature this PR addresses: Current behavio
Original PR description
Release notes: https://github.com/odoo/owl/releases Commits: [IMP] runtime: add support for Map and other iterables in t-foreach [IMP] runtime: only destroy component in raf callback [REF] runtime: simplify implementation of batched [FIX] compiler: allow t-model.number to work with select [FIX] devtools: Fix crash when no root node [FIX] devtools: fix/imp env display [FIX] devtools: fix symbols handling and display Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129365 Forward-Port-Of: odoo/odoo#128903
Base64 img src were converted to inline images but background images were omitted. This commit fixes that. opw-3374767 task-3425134 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129324 Forward-Port-Of: odoo/odoo#126794
Original PR description
Base64 img src were converted to inline images but background images were omitted. This commit fixes that. opw-3374767 task-3425134 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129324 Forward-Port-Of: odoo/odoo#126794
Step to reproduce: - Be sure to have `sale_quotation_builder` installed - Drag & drop the "Steps" snippet on a product in edit mode - Add this product on a SO in the backend - Click on Customer Preview -> The step snippet will not have the connector lines anymore This is because in Odoo 16, the step snippet connectors are now `svg` element (see [1]) which are removed by the sanitizer. ```py from lxml.html import clean svg='<svg><path/></svg>' clean.Cleaner().clean_html(svg) ```
Original PR description
Step to reproduce: - Be sure to have `sale_quotation_builder` installed - Drag & drop the "Steps" snippet on a product in edit mode - Add this product on a SO in the backend - Click on Customer…
Step to reproduce: - Be sure to have `sale_quotation_builder` installed - Drag & drop the "Steps" snippet on a product in edit mode - Add this product on a SO in the backend - Click on Customer Preview -> The step snippet will not have the connector lines anymore This is because in Odoo 16, the step snippet connectors are now `svg` element (see [1]) which are removed by the sanitizer. ```py from lxml.html import clean svg='<svg><path/></svg>' clean.Cleaner().clean_html(svg) ``` It's not the case in the `website_description` field of the product template as this field is defined with `sanitize_overridable=True` [2] which make it so the users with the right to do so can bypass the sanitation and use the Step snippet in this field. Since the quotation description can be a copy of that field, but without the same sanitize behavior, the connectors are lost. Note that most of the `sale_quotation_builder` description HTML fields were already set as `sanitize_overridable=True` with [2] and [3] but those ones were not. [1]: https://github.com/odoo/odoo/commit/aba31e9f2d8a44ce1586403f2a621a6caeed57b4 [2]: https://github.com/odoo/odoo/commit/44ae3f38da07c2215b1547d992f053a11829a8ac [3]: https://github.com/odoo/odoo/commit/811cf78ee1e63a7c41efe578fb64ee2deeca1dde opw-3380346 Forward-Port-Of: odoo/odoo#127738
Forward-Port-Of: odoo/odoo#129566 Forward-Port-Of: odoo/odoo#126271
Original PR description
Forward-Port-Of: odoo/odoo#129566 Forward-Port-Of: odoo/odoo#126271
Current behavior before PR: When the user shares a survey from the wizard and customize the field 'email_from' in the mail template configuration, the value of that field will be ignored, and the default value will be always used. Desired behavior after PR is merged: The customized value of field will be shown in the survey template. **Task**-3336596 Forward-Port-Of: odoo/odoo#129516 Forward-Port-Of: odoo/odoo#126700
Original PR description
Current behavior before PR: When the user shares a survey from the wizard and customize the field 'email_from' in the mail template configuration, the value of that field will be ignored, and the default value will be always used. Desired behavior after PR is merged: The customized value of field will be shown in the survey template. **Task**-3336596 Forward-Port-Of: odoo/odoo#129516 Forward-Port-Of: odoo/odoo#126700
Before this commit, the dropdown menu lacked spacing at the top and bottom when a user clicked on "Followers" in the chatter. This commit addresses the issue by adding the necessary spacing and also adjusting the hover state background color (when hovering followers details and actions) to improve the contrast with the text color. task-3338438 part of task task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#
Original PR description
Before this commit, the dropdown menu lacked spacing at the top and bottom when a user clicked on "Followers" in the chatter. This commit addresses the issue by adding the necessary spacing and also adjusting the hover state background color (when hovering followers details and actions) to improve the contrast with the text color. task-3338438 part of task task-3326263 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129649 Forward-Port-Of: odoo/odoo#122440
**Summary** Currently, you cannot access the Chilean Balance Sheet report. **Steps to reproduce** - Install Accounting - Install Chilean Accounting - On Chilean company, try to access Balance Sheet **Cause** Since the reports have been converted to owl, report line IDs are used as owl keys. Those keys have to be unique. However, currently, in the Chilean localization, some lines are assigned the same ID. As you can see in the snippet linked bellow, `_create_report_total_line()`
Original PR description
**Summary** Currently, you cannot access the Chilean Balance Sheet report. **Steps to reproduce** - Install Accounting - Install Chilean Accounting - On Chilean company, try to access Balance Sheet **Cause** Since the reports have been converted to owl, report line IDs are used as owl keys. Those keys have to be unique. However, currently, in the Chilean localization, some lines are assigned the same ID. As you can see in the snippet linked bellow, `_create_report_total_line()` is called multiple times, and each call creates a line whose ID is `total~~`. https://github.com/odoo/enterprise/blob/7decc48085d60202c5d6639f3ac1f6935956b46d/l10n_cl_reports/models/account_eightcolumns_report.py#L70-L80 opw-3414999 Forward-Port-Of: odoo/enterprise#44193
…n foreign currency Reconciling two lines of an account that is not receivable nor payable with one of the lines being in foreign currency throws an error. In that case we should reconcile in company currency and not in foreign currency. task-3420586 Forward-Port-Of: odoo/enterprise#44415 Forward-Port-Of: odoo/enterprise#44279
Original PR description
…n foreign currency Reconciling two lines of an account that is not receivable nor payable with one of the lines being in foreign currency throws an error. In that case we should reconcile in company currency and not in foreign currency. task-3420586 Forward-Port-Of: odoo/enterprise#44415 Forward-Port-Of: odoo/enterprise#44279
**[FIX] l10n_mx_edi: Fix CFDI with "to public" partner** We need to mention "Publico En General" only for global invoice. Event with "to public" partner, we still need to report the partner's name. Otherwise, the CFDI xml is rejected by the SAT. **[FIX] l10n_mx_edi[_stock]: Only add final CFDI attachments to chatter** We don't want to see the whole history of CFDI attempts on the chatter, only the relevant one. Forward-Port-Of: odoo/enterprise#44544
Original PR description
**[FIX] l10n_mx_edi: Fix CFDI with "to public" partner** We need to mention "Publico En General" only for global invoice. Event with "to public" partner, we still need to report the partner's name. Otherwise, the CFDI xml is rejected by the SAT. **[FIX] l10n_mx_edi[_stock]: Only add final CFDI attachments to chatter** We don't want to see the whole history of CFDI attempts on the chatter, only the relevant one. Forward-Port-Of: odoo/enterprise#44544
=== ISSUE === Commit[1] introduced a change on the `border-radius` property of app icons. It uses a `rounded` class where it supposed to be `rounded-3`. This causes inconsistency between these icons and custom app icons created with Studio. === AFTER === We reintroduce the changes we introduced in enterprise/#41047. We add a `rounded-3` class to the `img` tag in order to improve the consistency. commit[1]: 4ed891118e576fe623c192a7653cb369ff6936de task-3326580 part of ta
Original PR description
=== ISSUE === Commit[1] introduced a change on the `border-radius` property of app icons. It uses a `rounded` class where it supposed to be `rounded-3`. This causes inconsistency between these icons and custom app icons created with Studio. === AFTER === We reintroduce the changes we introduced in enterprise/#41047. We add a `rounded-3` class to the `img` tag in order to improve the consistency. commit[1]: 4ed891118e576fe623c192a7653cb369ff6936de task-3326580 part of task-3326263 Forward-Port-Of: odoo/enterprise#43697
The automatic PDF generation would use the report(s) defined in `_get_pdf_reports()`, however the "Print" button would only use the report defined on the Payroll Structure. This meant that using the "Print" button on an Holiday Attest (Belgium localization) payslip would only print the payslip itself and not the attest. Forward-Port-Of: odoo/enterprise#44493 Forward-Port-Of: odoo/enterprise#44214
Original PR description
The automatic PDF generation would use the report(s) defined in `_get_pdf_reports()`, however the "Print" button would only use the report defined on the Payroll Structure. This meant that using the "Print" button on an Holiday Attest (Belgium localization) payslip would only print the payslip itself and not the attest. Forward-Port-Of: odoo/enterprise#44493 Forward-Port-Of: odoo/enterprise#44214
This PR is related to the PR targeting 16.0 https://github.com/odoo/enterprise/pull/43754 task-3414580 part of task-3326263 Forward-Port-Of: odoo/enterprise#43776
Original PR description
This PR is related to the PR targeting 16.0 https://github.com/odoo/enterprise/pull/43754 task-3414580 part of task-3326263 Forward-Port-Of: odoo/enterprise#43776
The arrow wasn't centered in its button when the screen size is reduced. The icon has also been replaced with the nicer `oi` icon. Community PR : https://github.com/odoo/odoo/pull/127413 task-3410165 part of task-3326263 Forward-Port-Of: odoo/enterprise#43686
Original PR description
The arrow wasn't centered in its button when the screen size is reduced. The icon has also been replaced with the nicer `oi` icon. Community PR : https://github.com/odoo/odoo/pull/127413 task-3410165 part of task-3326263 Forward-Port-Of: odoo/enterprise#43686
Community: https://github.com/odoo/odoo/pull/129555 Forward-Port-Of: odoo/enterprise#44553
Original PR description
Community: https://github.com/odoo/odoo/pull/129555 Forward-Port-Of: odoo/enterprise#44553