Wednesday, July 26, 2023
9 changes · master
Resolved issues and error corrections
The web test suite now includes the needed Monokai editor theme so test editors can load correctly and clean up memory. This reduces memory leaks during automated testing, helping keep development and quality checks more stable.
Original PR description
When attempting to instantiate an ace editor with a given theme, ace will first create the editor with the default theme (textmate) which is always loaded, and register a callback to be called after the non-default theme has been loaded. This callback holds a reference to the editor's renderer which can itself retain large objects such as an entire owl application. These callbacks are not cleared even if the corresponding editor is destroyed. Because in tests, the theme "monokai" was not included and ace cannot load it on its own, all tests that attempt to create an ace editor with that theme will leak memory. This commit fixes the issue by adding theme-monokai to the qunit suite assets. Enterprise: https://github.com/odoo/enterprise/pull/44594
This fixes an issue where edits made in a pop-up form for a read-only related list could remain even after the user chose to discard changes. Users can now rely on discard actions to fully undo those edits and restore the original record state.
Original PR description
Before this commit, discard management was incorrect when you had a non-editable x2m. This could result in changes not being completely undone.
How to reproduce:
- Go to a form view with an uneditable x2m
- Click on a record in the x2m
- Edit the record in the form view dialog
- Click on save
- Reopen the same record
- Click on discard
- Click on the discard in the main form view
- Reopen the same record
Before this commit:
The change applied is still present
After this commit:
The applied change is no longer there. The original state has been restored.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe user menu now displays the dark mode option with proper alignment, preventing the selection button from overlapping the description. This makes the menu easier to read and gives users a cleaner, more polished experience.
Original PR description
before this commit, the dark mode button is not aligned properly in the user menu. the radio button is coming on top of the dark mode description. after this commit, the dark mode will be aligned well in user menu Before:  After:  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restores missing steps in the Restaurant Point of Sale automated tour that were accidentally removed by a recent change. This helps keep automated validation stable and prevents avoidable build failures, with no expected impact on daily users.
Original PR description
A recent PR removed some lines in the pos_restaurant tour ( odoo/odoo#124157 ). This commit put them back to avoid runbot error. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a new column in kanban views grouped by many-to-many or one-to-many fields no longer causes a crash. This improves reliability for users organizing records in grouped kanban boards.
Original PR description
Before this commit, in a kanban view grouped on a x2m, when we created a new column, we had a crash. Why did this happen? When a column is created, a resequence is triggered on the columns in order to have the correct position. Currently, we always use the DynamicGroupList handle field, which is not correct because if we are grouped on an x2m we use another resModel, so we want to use the default handle field (sequence). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an error that could occur when creating a new user. This helps administrators add users reliably without encountering a technical traceback.
Original PR description
The combination of the new basic model and this change dc4dcead6ed5e16eebdf7a9f79afea31b24ec33f made it so that creating a new user would fail with a traceback. This commit fixes the issue by making sure that the company_id that is used withing the initial onchange is a integer, and not a new-id. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a loading issue in the Project app by ensuring the editor components it depends on are included upfront. Users should see the project web interface behave correctly where rich text editing features are needed.
Original PR description
Since #118966, the `web_editor.assets_wysiwyg` assets are not lazy loaded anymore and therefore need to be included in `project.webclient`. task-3434068 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a new partner from a grouped Knowledge kanban view no longer assigns an unrelated parent company/contact. This prevents incorrect partner hierarchy data when users add partners directly from embedded Knowledge article views.
Original PR description
Bug === In an embed kanban view, if you group the article by a "res.partner", you will be able to create new partner from there (by creating new column). Because the context key "default_parent_id" is set, and because "res.partner" also have a "parent_id" field, the parent of the newly created partner was set to a random one (that have the same id of the parent article). Task-3358295
The enterprise web client now properly removes a permission-change listener when it closes. This prevents leftover application data and page elements from affecting automated tests, improving test reliability especially around Studio.
Original PR description
In order to add the push-notification capability to the PWA in enterprise, the enterprise webclient needs to listen for changes in permissions. The listener was not correctly cleared on destroy, which caused tests that use the enterprise webclient to leak the entire owl application and its corresponding DOM (this was mostly visible in studio tests) This commit fixes that by removing the event listener when the webclient is destroyed. Community: https://github.com/odoo/odoo/pull/129704