Wednesday, August 2, 2023
85 changes · master
Enhancements to existing features
This update simplifies how Odoo customizes and extends existing web behavior behind the scenes. It reduces debugging complexity and makes future maintenance safer, especially for asynchronous browser-side features, without introducing a direct change to everyday user workflows.
Original PR description
This PR refactors the patch function in order to simplify its code but also and most of all remove the `this._super` bound on each patched method call. The patch function now supports the javascript keyword `super` to get the parent's property. This removes constraints we had with `this._super`. We had to create a rather complicated intermediate function to bind `this._super` and this function was called each time before we called a patched method. It was annoying for debugging but necessary. Because of this intermediate function `this._super` was also had to re-bind each time we entered a patched method which was annoying with async method, we had to save the parent method in the patch before awaiting its execution. Finally, not a big issue but still, objects could not have a `_super` property as it would be hidden in the patch. task 3410198
This update keeps the Field Service inventory module aligned with a related platform change in Odoo. It is an internal compatibility improvement that helps ensure stock movements continue to work correctly after the shared function signature was updated.
Original PR description
This commit uses the the new function signature done in the community PR: odoo/odoo#116803
Resolved issues and error corrections
This fixes an internal test cleanup issue where repeated service startups could leave behind event listeners and consume extra memory. It helps keep automated tests stable and efficient without changing customer-facing product behavior.
Original PR description
In odoo/odoo#120893, the mail team changed their test utils so that they would always start all services. This can cause issues because services do not have any built-in destruction/cleanup…
In odoo/odoo#120893, the mail team changed their test utils so that they would always start all services. This can cause issues because services do not have any built-in destruction/cleanup mechanism, as in a production application they are only supposed to be started once. Some services add event listeners on global objects, in particular, the tour service adds an event listener on the tour registry which is global. If this event listener is not cleaned up, every time the tour service is started, a reference to the environment in which this tour service is being started is leaked. Since the environment contains all started services, it is typically a pretty heavy object, especially since in this context, all services are started instead of a select subset. This commit fixes that by patching the EventBus class to automatically remove event listeners that were added on an event bus after the test, in a similar fashion to what we do for some global objects like window or the document's body. 
Code cleanup and technical improvements
This internal change updates how website preview tours are registered so their steps are loaded only when needed. It prepares website editing and test tours for future translation support without changing the visible website experience for users.
Original PR description
As steps are encapsuled in an arrow function from 69a5d8e3ce47238 for steps tour definition to avoid direct Markup(_t()) interpretation, the same is done for registerWebsitePreviewTour() of "odoo/addons/website/static/src/js/tours/tour_utils.js" in this commit. This is done in anticipation of the use of _t() (import from @web/core/l10n/translation) with registerWebsitePreviewTour(). task-3292454 PR design-themes : https://github.com/odoo/design-themes/pull/678
Miscellaneous changes
The test test_product_quantity_rounding fails when the currency of the company rounds to the unit (decimal places = 0). This commit makes sure the test doesn't fail with that setup. Cf runbot build error 20612 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130209
Original PR description
The test test_product_quantity_rounding fails when the currency of the company rounds to the unit (decimal places = 0). This commit makes sure the test doesn't fail with that setup. Cf runbot build error 20612 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130209
Belgian accounting reconciliation templates now display in the expected language instead of only French. This improves usability for English, German, and Dutch-speaking users working with Belgian bank reconciliation items.
Original PR description
Versions: --------- - saas~16.2+ Steps to reproduce: ------------------- 1. Install Belgium accounting module 2. Switch to the company with the template 2. Go to Accounting -> Bank -> Reconcile Items Issue: ------ Translations are only being loaded in French Cause: ------ There is no translation assigned to the other expected language: English, German and Dutch, and the field name of `account_reconcile_model` did not have the parameter translate = True Solution: --------- To fix this issue we have to add the respective translations using name@Lang and add the parameter `translate = True` in the field name of `account_reconcile_model` so that the translations can be loaded to this field. OPW-3316716
Creating a new POS product category no longer triggers an error. This helps POS configuration users add categories reliably without being blocked by a traceback.
Original PR description
Impacted Version : Master only Issue: Traceback when clicking on the `New` button in the `POS Product category` view. Steps to reproduce : Step 1: Open POS Step 2: Go to Configuration Step 3: Open product category Step 4: Click on New -> traceback appears [Reference Video](https://drive.google.com/file/d/1_ATd7B7R1t4-2Rlpk5LTQ2kRXI5Ri78d/view?usp=sharing) [Traceback Log](https://pastebin.com/1WBqLyW7) The cause of the issue is trying to access properties on a record that is not yet created. The solution is simple: we adapt the code such that it can handle the case where the record is not yet created Task: 3450117 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Avatar contact cards now open only when there is a valid user profile to show, preventing confusing empty or incorrect popovers. User contact details are also displayed more consistently, prioritizing work phone and email when HR information is available.
Original PR description
This commit introduces various fixes regarding the avatar card. First one makes sure that the avatar card popover won't launch when there is no user image associated with the many2one_avatar_user_field. This would happen with the quick assign button. Second one prevents the card from opening when the related model is not "res.users". Third one allows to display the phone number of users even without hr installed and makes sure that the work_phone and work_email are shown in priority if available when hr is installed. Direct fix to Task-3167110
This fixes how shared setup data is prepared for mail-related tests so it happens once at the start of the test suite. It helps prevent test side effects and improves confidence that mail features are validated consistently.
Original PR description
Before this commit, an event listener was added on several registries to copy the required registry for mail tests. The registries should be copied once when the test suite begin to avoid side effects in tests. enterprise: https://github.com/odoo/enterprise/pull/45014
This fix updates the Time Off dialog to use the correct record reference after an underlying model change. It helps ensure the dialog continues to open and act on the right time off request, avoiding disruptions for HR users.
Original PR description
Since the relational model was rewritten (PR 114024), the record id is no longer present in data. We must replace record.data.id with record.resId. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Sales orders created from field service tasks now show free products as having nothing to invoice. This avoids incorrectly prompting teams to invoice items with a zero sales price.
Original PR description
Description of the issue: when product of sale price zero added to SO through field service it should show invoice status 'nothing to invoice' instead of 'to invoice' Desired behavior after PR is merged: product with a sales price of zero is added to SO through a field service, the invoice status is 'nothing to invoice' IMP: override _compute_invoice_status function in fsm sale_order and add condition to check product (total_amount <=0 and have task_id) task-3266856
A small issue in the timesheet grid test setup was corrected so copied setup data is registered properly. This helps keep automated checks reliable and reduces the risk of regressions reaching users.
Original PR description
community: https://github.com/odoo/odoo/pull/130461
This fixes an internal automated test setup for the accounting workflow between invoicing and accounting. It helps keep quality checks reliable after a recent technical change, reducing the risk of false failures during development.
Original PR description
The import system has changed, so the override is not working. (https://github.com/odoo/enterprise/commit/5a800d5e304d02e15def04ef76911543c633af92) We still need this import, even if we're just patching the registry, if the test is deactivated. Linked to runbot error 23638
The data merge list now refreshes correctly after merge-related actions following an internal model change. This prevents outdated or incorrect values from remaining visible, helping users see accurate information without disruption.
Original PR description
Since the relational model was rewritten (PR 114024), the removeRecord and removeGroup functions no longer exist. In this case, reloading the model is sufficient to display the correct values.
This change makes Odoo return linked record values in a consistent format in the web interface, even when those fields are hidden. This reduces edge cases that could cause inconsistent behavior for users or customizations relying on relational data.
Original PR description
Before this commit, in some cases (many2one invisible) unity returned an integer as value. Now, to be consistent, unity always return an object for many2one. Note that, web_read_group still returns an array as value for many2one. part-of task-id~3179751
This update streamlines how Odoo finds contacts, email addresses, phone numbers, and countries when sending messages, notifications, or SMS. It reduces duplicated logic across apps, making communication features easier to maintain and more consistent for users.
Original PR description
RATIONALE Simplify field management for mail / phone / sms flows. Make it working out of the box, easier to use and tweak. SPECIFICATIONS Move some helpers used in mail, phone_validation and sms…
RATIONALE Simplify field management for mail / phone / sms flows. Make it working out of the box, easier to use and tweak. SPECIFICATIONS Move some helpers used in mail, phone_validation and sms modules directly at BaseModel level. Those are used to find emails, partners, phone numbers and countries on records when sending them emails, notifications and sms. Improve default behavior of those helpers to cover most existing use case. Remove overrides now covered by standard behavior. Simplify phone / sms methods implementation. It was a bit messy with methods of sms overriding methods from phone. All this code can be simplified now that we have several years of usage in addons to see what people did with those modules. Globally * _sms_get_partner_fields is replaced by _mail_get_partner_fields; * _sms_get_number_fields is replaced by _phone_get_number_fields; * _sms_get_default_partners is replaced by _mail_get_partners; Add a generic phone formatting tool on BaseModel allowing to simplify most calls done to the phone_validation API. Remove custom definitions on some models as it is now available directly. Task-3422449 (Mail, Phone: Move and improve field helpers) Prepares Task-36879 (Mail: Support MultiCompany Aliases)
This change updates several Odoo Enterprise modules to work with a revised internal web patching mechanism. It helps keep custom screen behavior and tests compatible with the latest platform code, with little expected impact for end users.
Original PR description
This PR is the counterpart of https://github.com/odoo/odoo/pull/125716 task 3410198
This update removes old QWeb-based code from several Odoo Enterprise apps and moves affected screens and widgets toward newer frontend patterns. Users should see little to no immediate change, but the cleanup helps keep appointment booking, knowledge, helpdesk, payroll, social, VoIP, and website features easier to maintain going forward.
Bugfix. When installing l10n_eu_oss with l10n_de_skr03, an OSS account '17010 Unsatzsteuer 19% OSS' is created. However, this account has no account tags set on it, so it gets left out from the Balance Sheet report. (Note that in Germany, due to there being two CoAs, the Balance Sheet report still works using account tags.) The solution: when creating the OSS account, re-use the account tags of the account we are copying. Forward-Port-Of: odoo/odoo#130185
Original PR description
Bugfix. When installing l10n_eu_oss with l10n_de_skr03, an OSS account '17010 Unsatzsteuer 19% OSS' is created. However, this account has no account tags set on it, so it gets left out from the Balance Sheet report. (Note that in Germany, due to there being two CoAs, the Balance Sheet report still works using account tags.) The solution: when creating the OSS account, re-use the account tags of the account we are copying. Forward-Port-Of: odoo/odoo#130185
There was a traceback when right clicking on a spreaded cell beacause of the list "see record" context menu item. Fixed it. Task: [3425493](https://www.odoo.com/web#id=3425493&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-O
Original PR description
There was a traceback when right clicking on a spreaded cell beacause of the list "see record" context menu item. Fixed it. Task: [3425493](https://www.odoo.com/web#id=3425493&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#128585
Before this PR, the `nextMentionRpcFunction` was always undefined and therefor never used. This could lead to some RPC being lost if the previous one was too slow. This PR fix the issue by directly using the `rpcFunction` that is already assigned. Forward-Port-Of: odoo/odoo#130190
Original PR description
Before this PR, the `nextMentionRpcFunction` was always undefined and therefor never used. This could lead to some RPC being lost if the previous one was too slow. This PR fix the issue by directly using the `rpcFunction` that is already assigned. Forward-Port-Of: odoo/odoo#130190
There will be some access errors if an accountman tries to post an invoice To reproduce the issue: 1. Create a product category FIFO-AUTO 2. Receive a product of that category at $10 3. Sale, deliver and create the invoice for that product 4. Create a user with basic access to account app only 5. Switch into that user 6. Confirm the invoice Error: An error access is raised, he can not post the invoice In the invoice posting process, we try to read some other models (pos order, S
Original PR description
There will be some access errors if an accountman tries to post an invoice To reproduce the issue: 1. Create a product category FIFO-AUTO 2. Receive a product of that category at $10 3. Sale, deliver and create the invoice for that product 4. Create a user with basic access to account app only 5. Switch into that user 6. Confirm the invoice Error: An error access is raised, he can not post the invoice In the invoice posting process, we try to read some other models (pos order, SVL, and so on) but the user has not any access to them OPW-3302458 Forward-Port-Of: odoo/odoo#129758
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130153
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130153
The setup function was not correctly handeling Order.name when given in options. It was regenerating it instead of using the one given in option. For self orders it was changing the prefix from Self-Order to Order. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130193
Original PR description
The setup function was not correctly handeling Order.name when given in options. It was regenerating it instead of using the one given in option. For self orders it was changing the prefix from Self-Order to Order. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130193
## Issue Follow up on #128432, but this time it's removing expense lines from the pdf report when we print the Sales Order that has both timesheets, and posted expenses. ## Steps to reproduce - Install Sales, Timesheets, Expense - Create an SO and sell a service that creates a Task > Confirm - Log some timesheet on the task (3h for ex.) - Create an expense related to the SO, approve it and generate the journal entries. - Print > Timesheets on the SO - In the pdf, we have table row entr
Original PR description
## Issue Follow up on #128432, but this time it's removing expense lines from the pdf report when we print the Sales Order that has both timesheets, and posted expenses. ## Steps to reproduce -…
## Issue Follow up on #128432, but this time it's removing expense lines from the pdf report when we print the Sales Order that has both timesheets, and posted expenses. ## Steps to reproduce - Install Sales, Timesheets, Expense - Create an SO and sell a service that creates a Task > Confirm - Log some timesheet on the task (3h for ex.) - Create an expense related to the SO, approve it and generate the journal entries. - Print > Timesheets on the SO - In the pdf, we have table row entries for the expense lines. ## Cause The report is basing itself on `timesheet_ids` to print the report, those might include expense lines. ## Fix Add a domain on `timesheet_ids` to exclude lines that don't have a `project_id` set, those are not timesheet, so can be expenses. We want to exclude those. ## Affected versions 16.0 up to master ## Reference opw-3342274 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130257
steps: - install account module - Create company Odoo IN - Got to account > Configuration > analytic Plan - Open Project and set company as Odoo IN - install project module issue- Analytical plan and project both have different company so traceback come up. Fix: We have set company of analytic plan in project company. task-3138082 Forward-Port-Of: odoo/odoo#130206
Original PR description
steps: - install account module - Create company Odoo IN - Got to account > Configuration > analytic Plan - Open Project and set company as Odoo IN - install project module issue- Analytical plan and project both have different company so traceback come up. Fix: We have set company of analytic plan in project company. task-3138082 Forward-Port-Of: odoo/odoo#130206
Fixing runbot build error 20666 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130239 Forward-Port-Of: odoo/odoo#130196
Original PR description
Fixing runbot build error 20666 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130239 Forward-Port-Of: odoo/odoo#130196
Since [1] the mimetype used when calling `modify_image` was obtained from the data URL contained in the `src` attribute instead of the dataset. This is wrong for background images because they do not have an `src` attribute. Thanks to [2] which repaired the value contained in `dataset.mimetype`, this value can be used as it was before [1]. [1]: https://github.com/odoo/odoo/commit/0449fe85cb0e1d639a4e1aeba26e90906f79254d [2]: https://github.com/odoo/odoo/commit/40811e72c50faf146ccdf9f26c332d
Original PR description
Since [1] the mimetype used when calling `modify_image` was obtained from the data URL contained in the `src` attribute instead of the dataset. This is wrong for background images because they do not have an `src` attribute. Thanks to [2] which repaired the value contained in `dataset.mimetype`, this value can be used as it was before [1]. [1]: https://github.com/odoo/odoo/commit/0449fe85cb0e1d639a4e1aeba26e90906f79254d [2]: https://github.com/odoo/odoo/commit/40811e72c50faf146ccdf9f26c332db9ebc69fa9 task-3446438 Forward-Port-Of: odoo/odoo#130171
before this commit, the user error message on changing ZATKA submission mode was not translatable to user language after this commit, user error message will be shown in user's language --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129682 Forward-Port-Of: odoo/odoo#129108
Original PR description
before this commit, the user error message on changing ZATKA submission mode was not translatable to user language after this commit, user error message will be shown in user's language --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129682 Forward-Port-Of: odoo/odoo#129108
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130039
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130039
Since Odoo 16.0, the configurator is translated in the user language. Unfortunately, the theme previews are not yet translated in the user language, so the user sees the theme previews in the default language (English) but on a rtl page which causes alignment issues on the themes previews. This commit fixes this issue by forcing the container of themes previews to be in ltr. Steps to reproduce the issue fixed by this commit: - Set the Arabic (Syria) language for an internal user - With
Original PR description
Since Odoo 16.0, the configurator is translated in the user language. Unfortunately, the theme previews are not yet translated in the user language, so the user sees the theme previews in the default language (English) but on a rtl page which causes alignment issues on the themes previews. This commit fixes this issue by forcing the container of themes previews to be in ltr. Steps to reproduce the issue fixed by this commit: - Set the Arabic (Syria) language for an internal user - With the internal user, create a new website - Follow the configurator (in Arabic) until the theme selection step => Some text in the theme previews are not aligned correctly. task-3398707 Before:  After:  Forward-Port-Of: odoo/odoo#130311 Forward-Port-Of: odoo/odoo#127552
- Create a db with account installed (and a random loca) - Run the test "test_quick_edit_total_amount" => The test may fail (undeterministically), especially the first time The reason is that we don't have an order in "_get_frequent_account_and_taxes" So, if we have the same number of lines with the same account and with a tax or without one, we can not guarantee which tax is considered the most frequent. We now define the order by saying that we should take the taxes into account,
Original PR description
- Create a db with account installed (and a random loca) - Run the test "test_quick_edit_total_amount" => The test may fail (undeterministically), especially the first time The reason is that we don't have an order in "_get_frequent_account_and_taxes" So, if we have the same number of lines with the same account and with a tax or without one, we can not guarantee which tax is considered the most frequent. We now define the order by saying that we should take the taxes into account, so lines with taxes take precedence on lines without Linked to runbot error 23385 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130223
When creating a new expense sheet the payment_mode is empty by default. When adding a new expense to it, the payment mode of the expense itself should be filled with 'own_account' but if the payment mode of the expense sheet is set, the payment_mode of the expense related will be the same as the expense sheet. Task: 3382023 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130183 Forward-Port-Of: odoo/odoo#129582
Original PR description
When creating a new expense sheet the payment_mode is empty by default. When adding a new expense to it, the payment mode of the expense itself should be filled with 'own_account' but if the payment mode of the expense sheet is set, the payment_mode of the expense related will be the same as the expense sheet. Task: 3382023 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130183 Forward-Port-Of: odoo/odoo#129582
When having a cash rounding line on an invoice, base amount is taken twice into account in the tax report when grouping by account > tax or tax > account. Steps: - Activate cash rounding, and create one with 0.05 rounding, method 'HALF_UP' and 'biggest_tax' strategy - Create an invoice with a product line with unit price 1.24$, tax 15% (included in price) - Select the rounding method created above. - A rounding line for tax 15.0% and 0.02$ should have been created - Go to
Original PR description
When having a cash rounding line on an invoice, base amount is taken twice into account in the tax report when grouping by account > tax or tax > account. Steps: - Activate cash rounding, and create one with 0.05 rounding, method 'HALF_UP' and 'biggest_tax' strategy - Create an invoice with a product line with unit price 1.24$, tax 15% (included in price) - Select the rounding method created above. - A rounding line for tax 15.0% and 0.02$ should have been created - Go to tax report and group by Account->Tax or Tax->Account -> Base amount is 2.48 instead of 1.24 opw-3336398 Forward-Port-Of: odoo/odoo#130005 Forward-Port-Of: odoo/odoo#128975
When the user attempts to send an invoice to a partner whose country code is not set. Steps to produce: - Install sale_management,l10n_es_edi_facturae - Open invoicing module > Create a new invoice - Select a customer who does not have set country_id. - Click on Add a line > Select any product - Click on Confirm > Click on Send & Print > Click on save - Click on Send & Print - Error will be produced traceback on sentry: ``` KeyError: False File "odoo/http.py", line 2123, in __
Original PR description
When the user attempts to send an invoice to a partner whose country code is not set. Steps to produce: - Install sale_management,l10n_es_edi_facturae - Open invoicing module > Create a new invoice -…
When the user attempts to send an invoice to a partner whose country code is not set.
Steps to produce:
- Install sale_management,l10n_es_edi_facturae
- Open invoicing module > Create a new invoice
- Select a customer who does not have set country_id.
- Click on Add a line > Select any product
- Click on Confirm > Click on Send & Print > Click on save
- Click on Send & Print
- Error will be produced
traceback on sentry:
```
KeyError: False
File "odoo/http.py", line 2123, in __call__
response = request._serve_db()
File "odoo/http.py", line 1699, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1726, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1927, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "addons/website/models/ir_http.py", line 234, in _dispatch
response = super()._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 190, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 716, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 34, in call_button
action = self._call_kw(model, method, args, kwargs)
File "addons/web/controllers/dataset.py", line 26, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 461, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "odoo/api.py", line 448, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "addons/account/wizard/account_move_send.py", line 593, in action_send_and_print
self._generate_invoice_documents(moves_data, allow_fallback_pdf=allow_fallback_pdf)
File "addons/account/wizard/account_move_send.py", line 514, in _generate_invoice_documents
form._hook_invoice_document_before_pdf_report_render(invoice, invoice_data)
File "addons/l10n_es_edi_facturae/models/account_move_send.py", line 60, in _hook_invoice_document_before_pdf_report_render
xml_content, errors = invoice._l10n_es_edi_facturae_render_facturae()
File "addons/l10n_es_edi_facturae/models/account_move.py", line 358, in _l10n_es_edi_facturae_render_facturae
template_values, signature_values = self._l10n_es_edi_facturae_export_facturae()
File "addons/l10n_es_edi_facturae/models/account_move.py", line 286, in _l10n_es_edi_facturae_export_facturae
'other_party_country_code': COUNTRY_CODE_MAP[partner.country_id.code],
```
This commit addresses a `KeyError False` while the user attempts to send an invoice to a partner without a set country code. The function `_l10n_es_edi_facturae_export_facturae` uses the partner's country code but the partner doesn't have a set country code. As a result, a `KeyError` traceback is generated.
Sentry-4330095746
Forward-Port-Of: odoo/odoo#129286Steps to reproduce: (on Safari only) 1. Install Email Marketing and Mass mailing on sale orders 2. Open Email Marketing and try to open 'Our last promotions, just for you!' 3. An error is thrown Solution: Ignore errors raised in Safari Problem: Error "ResizeObserver loop completed with undelivered notifications." is raised by the ResizeObserver in `mailing_mailing_view_form_full_width.js`. However in Safari (and desipte the ResizeObserver flow being exactly the same than in other brow
Original PR description
Steps to reproduce: (on Safari only) 1. Install Email Marketing and Mass mailing on sale orders 2. Open Email Marketing and try to open 'Our last promotions, just for you!' 3. An error is thrown Solution: Ignore errors raised in Safari Problem: Error "ResizeObserver loop completed with undelivered notifications." is raised by the ResizeObserver in `mailing_mailing_view_form_full_width.js`. However in Safari (and desipte the ResizeObserver flow being exactly the same than in other browsers), the error message is "Script error." so we are not able to correctly discard it in the error listener of `error_service.js` opw-3339673 Forward-Port-Of: odoo/odoo#124286
[FIX] hr_expense: Fix reports and moves accounting date The accounting date on the report sheet and the linked moves are always set at the current date We want the accounting date to be the expense date, or the most recent expense date when possible [FIX] hr_expense: Fix rounding mismatch When paid by the company in another currency with at least one tax, there may be a rounding difference between the move and the expense [IMP] hr_expense: Make expense and sheet state more consist
Original PR description
[FIX] hr_expense: Fix reports and moves accounting date The accounting date on the report sheet and the linked moves are always set at the current date We want the accounting date to be the expense date, or the most recent expense date when possible [FIX] hr_expense: Fix rounding mismatch When paid by the company in another currency with at least one tax, there may be a rounding difference between the move and the expense [IMP] hr_expense: Make expense and sheet state more consistent This makes both the done state of expense and the expense sheet consistent in interface Task: 3390444 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130279 Forward-Port-Of: odoo/odoo#128105
When you drop a block containing a carousel, you can change the slide. Unfortunately, in edit mode, changing the slide creates a step in the history (you slide in the other direction by pressing CTRL-Z). This is not what you want. task-3356629 Forward-Port-Of: odoo/odoo#130356 Forward-Port-Of: odoo/odoo#124481
Original PR description
When you drop a block containing a carousel, you can change the slide. Unfortunately, in edit mode, changing the slide creates a step in the history (you slide in the other direction by pressing CTRL-Z). This is not what you want. task-3356629 Forward-Port-Of: odoo/odoo#130356 Forward-Port-Of: odoo/odoo#124481
The aim of this commit is to correct the tax data Context: The constrains linked to tax repartition line aren't triggered. This resulted in some invalid data to be merged. Before the commit: l10n_gr contains some invalid tax data After the commit: l10n_gr tax data are valid task-id: None Forward-Port-Of: odoo/odoo#130333
Original PR description
The aim of this commit is to correct the tax data Context: The constrains linked to tax repartition line aren't triggered. This resulted in some invalid data to be merged. Before the commit: l10n_gr contains some invalid tax data After the commit: l10n_gr tax data are valid task-id: None Forward-Port-Of: odoo/odoo#130333
As the "Create" button is renamed to "New" so update it and remove "top left" in helper to enhance clarity and avoid any confusion. Task-3420529 Forward-Port-Of: odoo/odoo#130222 Forward-Port-Of: odoo/odoo#128730
Original PR description
As the "Create" button is renamed to "New" so update it and remove "top left" in helper to enhance clarity and avoid any confusion. Task-3420529 Forward-Port-Of: odoo/odoo#130222 Forward-Port-Of: odoo/odoo#128730
Since [1] the messaging service is added to the livechat embed bundle. As a consequence, the bus service is started even when it is not needed. This is wrong since it would lead to lots of useless connections to be made. This PR prevent mail services from starting the bus eagerly in this context and adds a tour in order to prevent further errors on this matter. enterprise: https://github.com/odoo/enterprise/pull/44730 Forward-Port-Of: odoo/odoo#129312
Original PR description
Since [1] the messaging service is added to the livechat embed bundle. As a consequence, the bus service is started even when it is not needed. This is wrong since it would lead to lots of useless connections to be made. This PR prevent mail services from starting the bus eagerly in this context and adds a tour in order to prevent further errors on this matter. enterprise: https://github.com/odoo/enterprise/pull/44730 Forward-Port-Of: odoo/odoo#129312
task-3435244 Forward-Port-Of: odoo/odoo#129897
Original PR description
task-3435244 Forward-Port-Of: odoo/odoo#129897
***Summary:*** page with 2 popups (newsletter popup and regular popup), cookie bar all justaposed. Chatbot window also open. For some reason closestBlock(testedNode) is undefined (testedNode) is a #text Node. Change already in place for 16.3 ***Cause:*** no preventive measure for undefined value before creating a node iterator on the value. ***Solution:*** backport solution from 16.3, return false when currentNodeParentBlock is undefined, since preceding and following
Original PR description
***Summary:*** page with 2 popups (newsletter popup and regular popup), cookie bar all justaposed. Chatbot window also open. For some reason closestBlock(testedNode) is undefined (testedNode) is a #text Node. Change already in place for 16.3 ***Cause:*** no preventive measure for undefined value before creating a node iterator on the value. ***Solution:*** backport solution from 16.3, return false when currentNodeParentBlock is undefined, since preceding and following would also be undefined, return false. opw-3395673 Current behavior before PR: - error thrown on and block webpage edit Desired behavior after PR is merged: - no error thrown on and able to edit page --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130369
Follow-up of [1] Before this commit, when a message had both subtype description and tracking values, they were displayed horizontally instead of vertically. This happens because [1] set `d-flex` on `textContent`, which is horizontal by default. This assumes there's only 1 HTML node for actual `textContent` so that message action list could be positioned next to 1st text content line. However, when message has subtype description and tracking values, there is more than 1 HTML node in `t
Original PR description
Follow-up of [1] Before this commit, when a message had both subtype description and tracking values, they were displayed horizontally instead of vertically. This happens because [1] set `d-flex` on…
Follow-up of [1] Before this commit, when a message had both subtype description and tracking values, they were displayed horizontally instead of vertically. This happens because [1] set `d-flex` on `textContent`, which is horizontal by default. This assumes there's only 1 HTML node for actual `textContent` so that message action list could be positioned next to 1st text content line. However, when message has subtype description and tracking values, there is more than 1 HTML node in `textContent` and the intended visual is showing them in `d-block`. This `d-flex` made them display horizontally instead of `d-block`. This commit fixes the issue by having a single actual HTML node in `textContent` when there's a subtype description and some tracking values. This allows to position `textContent` parts as desired (e.g. with `d-block`) while having position of message action list working as intended in original template of `Message`. [1] https://github.com/odoo/odoo/pull/128940 Before / After   Forward-Port-Of: odoo/odoo#130360
The label was already Status on the field but not in the search view. "State" is always used for the meaning location. Sharing the same term meant it was not possible to have two different translations. Forward-Port-Of: odoo/odoo#130357
Original PR description
The label was already Status on the field but not in the search view. "State" is always used for the meaning location. Sharing the same term meant it was not possible to have two different translations. Forward-Port-Of: odoo/odoo#130357
When applying a coupon, the amount can be totally covered, with nothing left to pay. Express Checkout buttons should not be shown in that case. After this commit, Stripe's Express Checkout buttons will not be shown if the amount is not defined. opw-3427969 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130293
Original PR description
When applying a coupon, the amount can be totally covered, with nothing left to pay. Express Checkout buttons should not be shown in that case. After this commit, Stripe's Express Checkout buttons will not be shown if the amount is not defined. opw-3427969 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130293
Before this commit, all badge color matched the messaging menu color badge. Most badge counter in discuss show needaction counter, so it makes sense to have a catchy color scheme (e.g. white text on red background). For starred counter in discuss sidebar, the counter is meant to see at a glance how many messages are starred, without it being too catchy. This commit fixes the issue by introducing a `o-muted` modifier on `o-discuss-badge`, which displays a grey background for starred counter
Original PR description
Before this commit, all badge color matched the messaging menu color badge. Most badge counter in discuss show needaction counter, so it makes sense to have a catchy color scheme (e.g. white text on…
Before this commit, all badge color matched the messaging menu color badge. Most badge counter in discuss show needaction counter, so it makes sense to have a catchy color scheme (e.g. white text on red background). For starred counter in discuss sidebar, the counter is meant to see at a glance how many messages are starred, without it being too catchy. This commit fixes the issue by introducing a `o-muted` modifier on `o-discuss-badge`, which displays a grey background for starred counter. Also fixes a bug in dark mode where badge background color was incorrect. Before / After (white)   Before / After (dark)   Forward-Port-Of: odoo/odoo#130400
Chart of Account Update with their translations 2865568 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130249 Forward-Port-Of: odoo/odoo#129997
Original PR description
Chart of Account Update with their translations 2865568 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130249 Forward-Port-Of: odoo/odoo#129997
Complete refactor of the module, adding the tax report task-3098316 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129357
Original PR description
Complete refactor of the module, adding the tax report task-3098316 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129357
This commit focuses on fixing the UX for managing avatars and badges within `tagsList` in edition mode. The changes include: For Avatars: - Implemented an overlay effect on :hover, making it clearer which entry is currently selected, providing a visual cue for users. - The "remove" button now appears on :hover only, reducing visual clutter and improving visual scanning. For Badges: - Added visual feedback when hovering the "remove" button, making it more apparent and us
Original PR description
This commit focuses on fixing the UX for managing avatars and badges within `tagsList` in edition mode. The changes include: For Avatars: - Implemented an overlay effect on :hover, making it clearer which entry is currently selected, providing a visual cue for users. - The "remove" button now appears on :hover only, reducing visual clutter and improving visual scanning. For Badges: - Added visual feedback when hovering the "remove" button, making it more apparent and user-friendly. Enterprise: - https://github.com/odoo/enterprise/pull/44758 task-3439555 part of task-3326263 --- saas-16.3 https://github.com/odoo/odoo/assets/8558351/63be47d3-65d7-440c-9f2a-feadf461818d --- this PR https://github.com/odoo/odoo/assets/8558351/427f3d13-f896-4fff-9924-11e32e17f58b --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129991
Fix a minor issue introduced in this commit: https://github.com/odoo/odoo/commit/60465047df56c07e61623c1f7304fede28232581 The issue is that the left bottom section of the invoice layout is constraint on the left side, even if nothing is present on the right part. This caused an issue for example with the Mexican Localization where the text beside a QR code can not reach the full width of the page, making the QR code and the text on top of eachother. task-3444692 --- I confirm I have
Original PR description
Fix a minor issue introduced in this commit: https://github.com/odoo/odoo/commit/60465047df56c07e61623c1f7304fede28232581 The issue is that the left bottom section of the invoice layout is constraint on the left side, even if nothing is present on the right part. This caused an issue for example with the Mexican Localization where the text beside a QR code can not reach the full width of the page, making the QR code and the text on top of eachother. task-3444692 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130037
Exporting the EventConfiguratorRelationalModel and EventConfiguratorRecord classes allows us to easily extend them into other modules. This will allow us to add functionality to the event wizard of the sales lines without doing tricks. In the following file you can see the trick we had to do to extend the saving in the sales line. https://github.com/OCA/event/blob/162528b2d4271a863da1dfc6108a5420900b6ff1/event_sale_session/static/src/js/EventConfiguratorFormController.esm.js I confirm I
Original PR description
Exporting the EventConfiguratorRelationalModel and EventConfiguratorRecord classes allows us to easily extend them into other modules. This will allow us to add functionality to the event wizard of the sales lines without doing tricks. In the following file you can see the trick we had to do to extend the saving in the sales line. https://github.com/OCA/event/blob/162528b2d4271a863da1dfc6108a5420900b6ff1/event_sale_session/static/src/js/EventConfiguratorFormController.esm.js I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr cc @Tecnativa TT43669 ping @chienandalu @ivantodorovich @pedrobaeza Forward-Port-Of: odoo/odoo#129575 Forward-Port-Of: odoo/odoo#129541
This PR will introduce multiple display improvements. Here is the list: - In the accounting settings, the fiscal localization section has a button that was oddly placed. This PR solves that issue. - On the dashboard, when clicking the three dots on a card, the options "remove from favorites" and "configuration" were not aligned. - In ir_attachment, the label and field of "datas" will be aligned, and a gap will be added between the icons. - In the settings, the button links were in
Original PR description
This PR will introduce multiple display improvements. Here is the list: - In the accounting settings, the fiscal localization section has a button that was oddly placed. This PR solves that issue. - On the dashboard, when clicking the three dots on a card, the options "remove from favorites" and "configuration" were not aligned. - In ir_attachment, the label and field of "datas" will be aligned, and a gap will be added between the icons. - In the settings, the button links were inconsistent in terms of padding. This PR resolves that. - In the payment providers, two button links had text wrapping issues. By adding Bootstrap classes, this has been resolved. task: 3342969 Forward-Port-Of: odoo/odoo#124416
Description of the issue/feature this PR addresses: In V14, the cardholder name is send, but not in V16. @Feyensv --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130459
Original PR description
Description of the issue/feature this PR addresses: In V14, the cardholder name is send, but not in V16. @Feyensv --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#130459
Release notes: https://github.com/odoo/owl/releases Commits: [FIX] compiler: fix swapped key/value using t-foreach on Map [FIX] devtools: fix crash while highlighting env [FIX] *: move OwlError to common [FIX] playground: todo app clear complete tasks [IMP] compiler: improve error message when failing to compile template Forward-Port-Of: odoo/odoo#130464
Original PR description
Release notes: https://github.com/odoo/owl/releases Commits: [FIX] compiler: fix swapped key/value using t-foreach on Map [FIX] devtools: fix crash while highlighting env [FIX] *: move OwlError to common [FIX] playground: todo app clear complete tasks [IMP] compiler: improve error message when failing to compile template Forward-Port-Of: odoo/odoo#130464
https://github.com/odoo/odoo/pull/112114 added a new component that extended the Many2ManyAttendee component, including the setup method. However, the setup method that was extended was not calling super. This commit adds the super call to the component. task-3441130 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr For
Original PR description
https://github.com/odoo/odoo/pull/112114 added a new component that extended the Many2ManyAttendee component, including the setup method. However, the setup method that was extended was not calling super. This commit adds the super call to the component. task-3441130 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#129759
When trying to import a fec file, we're getting an error due to the 'name_nospaces' constraint. We replace spaces by underscores in the partner field and modify the test file to make tests accurate with this flow. Task links: www.odoo.com/web#id=3428627&model=project.task www.odoo.com/web#id=3376313&model=project.task opw-3428627 opw-3376313 Forward-Port-Of: odoo/enterprise#44789
Original PR description
When trying to import a fec file, we're getting an error due to the 'name_nospaces' constraint. We replace spaces by underscores in the partner field and modify the test file to make tests accurate with this flow. Task links: www.odoo.com/web#id=3428627&model=project.task www.odoo.com/web#id=3376313&model=project.task opw-3428627 opw-3376313 Forward-Port-Of: odoo/enterprise#44789
Put a class on the softphone header icon to allow it to be retrieved from the javascript code. Forward-Port-Of: odoo/enterprise#44962
Original PR description
Put a class on the softphone header icon to allow it to be retrieved from the javascript code. Forward-Port-Of: odoo/enterprise#44962
Issue: ====== When you download a document with a date in it's name and the date has dots (.) it will mess the with file at it expects the type of the file after the first dot. Steps to reproduce the error : ============================== 1-Install accounting 2-Install German Language 3-Go to accounting/customer/followup reports 4-Select an item and do follow up 5-Print the report. 6-You will get a report not in the pdf format. Solution: ========= I replaced the '.' with '/' in
Original PR description
Issue: ====== When you download a document with a date in it's name and the date has dots (.) it will mess the with file at it expects the type of the file after the first dot. Steps to reproduce the error : ============================== 1-Install accounting 2-Install German Language 3-Go to accounting/customer/followup reports 4-Select an item and do follow up 5-Print the report. 6-You will get a report not in the pdf format. Solution: ========= I replaced the '.' with '/' in the date formats of the name. opw-3425241 Forward-Port-Of: odoo/enterprise#44932
Currently we take the language of the user generating the payslip, instead of taking the employee's language, which might be different. task-3389231 Forward-Port-Of: odoo/enterprise#44942 Forward-Port-Of: odoo/enterprise#43272
Original PR description
Currently we take the language of the user generating the payslip, instead of taking the employee's language, which might be different. task-3389231 Forward-Port-Of: odoo/enterprise#44942 Forward-Port-Of: odoo/enterprise#43272
In the community PR, we have made several minor changes to improve the display, and this PR continues to build upon those improvements. Here's a summary of what has been done: - In the bank journal, an empty div was added by "account_online_synchronization" which caused some display issues with "qif_decimal_point" and "qif_qif_date_format." By adding the missing "attrs invisible" attribute, the display issue is now resolved. - In the settings, there was a field followed by a refresh bu
Original PR description
In the community PR, we have made several minor changes to improve the display, and this PR continues to build upon those improvements. Here's a summary of what has been done: - In the bank journal, an empty div was added by "account_online_synchronization" which caused some display issues with "qif_decimal_point" and "qif_qif_date_format." By adding the missing "attrs invisible" attribute, the display issue is now resolved. - In the settings, there was a field followed by a refresh button, but the input field was not aligned properly with the rest of the settings. - Additionally, in the settings, the button links were not consistent with the changes made in the community PR. This PR addresses that inconsistency and brings uniformity to the button links. task-id: 3342969 Forward-Port-Of: odoo/enterprise#42216
community: - https://github.com/odoo/odoo/pull/129991 task-3439555 part of task-3326263 Forward-Port-Of: odoo/enterprise#44758
Original PR description
community: - https://github.com/odoo/odoo/pull/129991 task-3439555 part of task-3326263 Forward-Port-Of: odoo/enterprise#44758
Adds Balance Sheet and Profit and Loss for Canadian localization task-3098316 Forward-Port-Of: odoo/enterprise#44479
Original PR description
Adds Balance Sheet and Profit and Loss for Canadian localization task-3098316 Forward-Port-Of: odoo/enterprise#44479
- Create Taiwan Accounting Reports task-2865568 Forward-Port-Of: odoo/enterprise#44875 Forward-Port-Of: odoo/enterprise#31818
Original PR description
- Create Taiwan Accounting Reports task-2865568 Forward-Port-Of: odoo/enterprise#44875 Forward-Port-Of: odoo/enterprise#31818
Forward-Port-Of: odoo/enterprise#44478
Original PR description
Forward-Port-Of: odoo/enterprise#44478
- In certain specific values, the calculation of the withholding taxes are affected by the rounding configuration 'round globally' creating a variation of 0.01 cents in the calculation of the field l10n_ec_withhold_tax_amount - This results in a difference between the totals for withholding tax lines and the lines in the accounting entries in the withholding - To avoid this problem, we ensure to send the 'round' variable as True by context in withholding taxes to force 'round per line' **De
Original PR description
- In certain specific values, the calculation of the withholding taxes are affected by the rounding configuration 'round globally' creating a variation of 0.01 cents in the calculation of the field…
- In certain specific values, the calculation of the withholding taxes are affected by the rounding configuration 'round globally' creating a variation of 0.01 cents in the calculation of the field l10n_ec_withhold_tax_amount - This results in a difference between the totals for withholding tax lines and the lines in the accounting entries in the withholding - To avoid this problem, we ensure to send the 'round' variable as True by context in withholding taxes to force 'round per line' **Description of the issue/feature this PR addresses:** -The 'Round globally' setting in the company produces an erroneous rounding in the amount of the withholding lines, causing a variation of one cent compared to the accounting entries **Current behavior before PR:** In some specific values, the value of the withholding amount varies with one cent to the accounting entry **Desired behavior after PR is merged:** Force 'Rounding per line' to ensure the correct calculation in withholdings Forward-Port-Of: odoo/enterprise#43843 Forward-Port-Of: odoo/enterprise#43404
momentToLuxon was removed in community, and is replaced by a util function in website_sale_renting for the datetimepicker. This commit fixes the import from the right file. Forward-Port-Of: odoo/enterprise#44980
Original PR description
momentToLuxon was removed in community, and is replaced by a util function in website_sale_renting for the datetimepicker. This commit fixes the import from the right file. Forward-Port-Of: odoo/enterprise#44980
Before, the only ordering that was made there put the reports without a country after the ones who had one. This was not consistent with the new sequence field introduced on account.report in saas-16.4. We fix that in order to make use of it. Forward-Port-Of: odoo/enterprise#44956
Original PR description
Before, the only ordering that was made there put the reports without a country after the ones who had one. This was not consistent with the new sequence field introduced on account.report in saas-16.4. We fix that in order to make use of it. Forward-Port-Of: odoo/enterprise#44956
When search mps by bom, currently we always use "ilike" as operator to search by name. This leads to wrong result when we search by id, bom with the "id" in its name will also be shown. To fix, we don't force to use "ilike". Allow it to change by different cases. Task-3337966 Forward-Port-Of: odoo/enterprise#42547
Original PR description
When search mps by bom, currently we always use "ilike" as operator to search by name. This leads to wrong result when we search by id, bom with the "id" in its name will also be shown. To fix, we don't force to use "ilike". Allow it to change by different cases. Task-3337966 Forward-Port-Of: odoo/enterprise#42547
This PR makes the bus service start lazily. Since the bus service start method is no longer async some tests need to adapt the order in which the routes are asserted during tests. community: https://github.com/odoo/odoo/pull/129312 Forward-Port-Of: odoo/enterprise#44730
Original PR description
This PR makes the bus service start lazily. Since the bus service start method is no longer async some tests need to adapt the order in which the routes are asserted during tests. community: https://github.com/odoo/odoo/pull/129312 Forward-Port-Of: odoo/enterprise#44730
Currently, the "Add a note" span is hidden from HTML view with a t-att-style. Receivers of the follow up report who view their emails in plain text will still see the "Add a note" line. The new change using t-if will properly hide the span for users that view the email in plain text. opw-3413962 Forward-Port-Of: odoo/enterprise#44994 Forward-Port-Of: odoo/enterprise#44657
Original PR description
Currently, the "Add a note" span is hidden from HTML view with a t-att-style. Receivers of the follow up report who view their emails in plain text will still see the "Add a note" line. The new change using t-if will properly hide the span for users that view the email in plain text. opw-3413962 Forward-Port-Of: odoo/enterprise#44994 Forward-Port-Of: odoo/enterprise#44657
Currently the default deferral amount computation is set to be based on days. Because mostly people want to calculate equal amounts per month, we change the default calculation to that. [task-3441004](https://www.odoo.com/web#id=3441004&menu_id=4720&cids=1&action=333&active_id=967&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44913
Original PR description
Currently the default deferral amount computation is set to be based on days. Because mostly people want to calculate equal amounts per month, we change the default calculation to that. [task-3441004](https://www.odoo.com/web#id=3441004&menu_id=4720&cids=1&action=333&active_id=967&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44913
The styling of the ellipsis clone button was not applied correctly. On clicking on the clone button, there is now a notification telling the user that the text was copied and it closes the popover. Forward-Port-Of: odoo/enterprise#44845
Original PR description
The styling of the ellipsis clone button was not applied correctly. On clicking on the clone button, there is now a notification telling the user that the text was copied and it closes the popover. Forward-Port-Of: odoo/enterprise#44845
7cd0563b762569484da1bef7af4ca84e189feca5: There were still old, hardcoded, colors being used in the sign module's PDF viewer. These have been replaced with the new ones, but Sign uses an iframe to render the PDF viewer and the variables weren't being applied. Some of the bootstrap classes, such as `.btn-primary` (changed to `.btn-secondary`), were already on some elements but were also not being applied. A copy of the current CSS variables was needed in the `iframe.scss` file in order t
Original PR description
7cd0563b762569484da1bef7af4ca84e189feca5: There were still old, hardcoded, colors being used in the sign module's PDF viewer. These have been replaced with the new ones, but Sign uses an iframe to…
7cd0563b762569484da1bef7af4ca84e189feca5: There were still old, hardcoded, colors being used in the sign module's PDF viewer. These have been replaced with the new ones, but Sign uses an iframe to render the PDF viewer and the variables weren't being applied. Some of the bootstrap classes, such as `.btn-primary` (changed to `.btn-secondary`), were already on some elements but were also not being applied. A copy of the current CSS variables was needed in the `iframe.scss` file in order to fix these issues. This also allows us to correct some of the viewer's color issues, which we override in this same file. Inputs with the class `o_input` just above the iframe weren't rendering well as they were white instead of being the same as the parent's background color. To solve this issue we override the value of the CSS variable being used by `.o_input`. fd29f9e8c9b9e225ec0955a54047bff86a5351c5: The PDF viewer used to be black. As it is now white, and the custom rotateCw arrow that is injected is a white `.png` image, it is no longer visible on the white background. There is also a sizing issue. The fix was to revert to the original rotateCw icon located in the PDF viewer and use the same way of working as for the other buttons. To do this a simple ID was needed on the element. task-3326565 part of task-3326263 Forward-Port-Of: odoo/enterprise#44577 Forward-Port-Of: odoo/enterprise#41035
When having a cash rounding line on an invoice, base amount is taken twice into account in the tax report when grouping by account > tax or tax > account. Steps: - Activate cash rounding, and create one with 0.05 rounding, method 'HALF_UP' and 'biggest_tax' strategy - Create an invoice with a product line with unit price 1.24$, tax 15% (included in price) - Select the rounding method created above. - A rounding line for tax 15.0% and 0.02$ should have been created - Go to tax report an
Original PR description
When having a cash rounding line on an invoice, base amount is taken twice into account in the tax report when grouping by account > tax or tax > account. Steps: - Activate cash rounding, and create one with 0.05 rounding, method 'HALF_UP' and 'biggest_tax' strategy - Create an invoice with a product line with unit price 1.24$, tax 15% (included in price) - Select the rounding method created above. - A rounding line for tax 15.0% and 0.02$ should have been created - Go to tax report and group by Account->Tax or Tax->Account -> Base amount is 2.48 instead of 1.24 opw-3336398 Forward-Port-Of: odoo/enterprise#44747 Forward-Port-Of: odoo/enterprise#44324
When the user will add the property, the property field values and Add a Property button are not well aligned with the property labels. Because in this commit https://github.com/odoo/enterprise/commit/22ce8a389ac0a1e03b32077a20caff88fb1ebe39, padding was applied only in property labels. Technical: Adding margin to the labels and padding to the values and Add a Property button. Now labels, values and Add a property button all are well aligned. **Task**-3381693 Forward-Port-Of: odoo/ent
Original PR description
When the user will add the property, the property field values and Add a Property button are not well aligned with the property labels. Because in this commit https://github.com/odoo/enterprise/commit/22ce8a389ac0a1e03b32077a20caff88fb1ebe39, padding was applied only in property labels. Technical: Adding margin to the labels and padding to the values and Add a Property button. Now labels, values and Add a property button all are well aligned. **Task**-3381693 Forward-Port-Of: odoo/enterprise#43227
This commit brings back the style of icons related to the fields available in the sidebar. During the refactor of the report editor, a lot of files present in the legacy folder were removed, and this scss was not yet ported to current stylesheets. With this fix, the mixin has been renamed to match the naming of the other ones, and the style related to the icons has been preserved to the studio_sidebar.scss file. task-3444791 Forward-Port-Of: odoo/enterprise#44837
Original PR description
This commit brings back the style of icons related to the fields available in the sidebar. During the refactor of the report editor, a lot of files present in the legacy folder were removed, and this scss was not yet ported to current stylesheets. With this fix, the mixin has been renamed to match the naming of the other ones, and the style related to the icons has been preserved to the studio_sidebar.scss file. task-3444791 Forward-Port-Of: odoo/enterprise#44837
Steps: - Install planning app without demo data. - Try to split shift of sample data. Cause: - The split shift feature was attempting to split shifts of sample data. Fix: - Modified the visibility of the scissor icon so that it only appears when there are actual shifts to split. Forward-Port-Of: odoo/enterprise#44844
Original PR description
Steps: - Install planning app without demo data. - Try to split shift of sample data. Cause: - The split shift feature was attempting to split shifts of sample data. Fix: - Modified the visibility of the scissor icon so that it only appears when there are actual shifts to split. Forward-Port-Of: odoo/enterprise#44844
Issue: ------ In the report of payroll application (pivot view), payslips (via its payslip lines) which contain no worked day won't be taken into account for the amounts displayed. It is therefore not possible to analyze them. A concrete example are the payslips of the 13th month in the Belgian localization. Cause: ------ To display these amounts, this SQL condition must be met: ```sql SELECT ... CASE WHEN wd.id = min_id.min_line THEN ...(display amount)... ELSE ... END ... FR
Original PR description
Issue: ------ In the report of payroll application (pivot view), payslips (via its payslip lines) which contain no worked day won't be taken into account for the amounts displayed. It is therefore…
Issue: ------ In the report of payroll application (pivot view), payslips (via its payslip lines) which contain no worked day won't be taken into account for the amounts displayed. It is therefore not possible to analyze them. A concrete example are the payslips of the 13th month in the Belgian localization. Cause: ------ To display these amounts, this SQL condition must be met: ```sql SELECT ... CASE WHEN wd.id = min_id.min_line THEN ...(display amount)... ELSE ... END ... FROM ... left join hr_payslip_worked_days wd on (wd.payslip_id = p.id) ... left join (select payslip_id, min(id) as min_line from hr_payslip_worked_days group by payslip_id) min_id on (min_id.payslip_id = p.id) ... ``` Payslips that do not have a working day won't be listed in the `hr_payslip_worked_days` table, so for these payslips we have: `wd.id = NULL` and `min_id.min_line = NULL`. In postgresql, the condition `NULL = NULL` is not true but unknown. Solution: --------- Modify the condition to handle the `NULL` value comparison like this: `wd.id = min_id.min_line OR (wd.id IS NULL AND min_id.min_line IS NULL)` This condition can be simplified as PostgreSQL supports `is not distinct from` operator: `wd.id IS NOT DISTINCT FROM min_id.min_line` opw-3429153 Forward-Port-Of: odoo/enterprise#44731
Forward-Port-Of: odoo/enterprise#44819 Forward-Port-Of: odoo/enterprise#44766
Original PR description
Forward-Port-Of: odoo/enterprise#44819 Forward-Port-Of: odoo/enterprise#44766
Bugfix. When sending an invoice to SUNAT, if the CDR is already registered on the server, SUNAT will respond with a 500 Server Error. The response content indicates that the invoice was already registered with other data. At the moment, we bail out as soon as we see the 500 Server Error, meaning that we don't check the response content and don't try to retrieve the CDR from the server even though that would be appropriate. With this commit, if we get a 500 Server Error, we still try to dec
Original PR description
Bugfix. When sending an invoice to SUNAT, if the CDR is already registered on the server, SUNAT will respond with a 500 Server Error. The response content indicates that the invoice was already registered with other data. At the moment, we bail out as soon as we see the 500 Server Error, meaning that we don't check the response content and don't try to retrieve the CDR from the server even though that would be appropriate. With this commit, if we get a 500 Server Error, we still try to decode the response content. Forward-Port-Of: odoo/enterprise#44489
In salary configurator some advantages may have requested documents. When the advantage is selected, the requested documents are shown and required, while when the advantage is not selected, the requested documents are hidden. Problem: On start, the requested documents of non-selected advantages are still showing. After this commit they will be hidden. task-3444804 Forward-Port-Of: odoo/enterprise#44849
Original PR description
In salary configurator some advantages may have requested documents. When the advantage is selected, the requested documents are shown and required, while when the advantage is not selected, the requested documents are hidden. Problem: On start, the requested documents of non-selected advantages are still showing. After this commit they will be hidden. task-3444804 Forward-Port-Of: odoo/enterprise#44849
Steps to reproduce: - Install CRM, Helpdesk. - Go to Settings > Discuss > Check `Custom Email Servers`, Alias Domain = `@example.com`. - CRM > Config > Sales teams > New > Enter Name = Team1 > Save. - Helpdesk > Create a new customer and record some tickets for them, or use an existing customer (e.g., Azure Interior). - CRM > Pipeline > New > Enter Contact = Azure Interior > Edit. - In the Extra Information tab, set Sales Team = Team1 > Save. - From the opportunity view, open the Azur
Original PR description
Steps to reproduce: - Install CRM, Helpdesk. - Go to Settings > Discuss > Check `Custom Email Servers`, Alias Domain = `@example.com`. - CRM > Config > Sales teams > New > Enter Name = Team1 > Save.…
Steps to reproduce: - Install CRM, Helpdesk. - Go to Settings > Discuss > Check `Custom Email Servers`, Alias Domain = `@example.com`. - CRM > Config > Sales teams > New > Enter Name = Team1 > Save. - Helpdesk > Create a new customer and record some tickets for them, or use an existing customer (e.g., Azure Interior). - CRM > Pipeline > New > Enter Contact = Azure Interior > Edit. - In the Extra Information tab, set Sales Team = Team1 > Save. - From the opportunity view, open the Azure Interior record through the internal link. - From the customer's profile, click on the Tickets stat button. Issue: Traceback: `Record does not exist or has been deleted.` This error occurs because the sales team of the opportunity is passed in the context as `default_team_id`. When clicking the stat button, we search for a helpdesk team using the same context variable, `default_team_id`. Since there is no helpdesk team with that id, the traceback appears. Solution: When clicking on the tickets stat button, our aim is to display all helpdesk tickets related to that customer, and the helpdesk team is not relevant in this context. Therefore, we can set `default_team_id` to False before displaying the tickets, and this change will not affect the results. opw-3371767 Forward-Port-Of: odoo/enterprise#44208
We added the feature to send the Tax Report to the Dutch government for our Dutch clients. This new module (which will be merged into l10n_nl_intrastat in master in a new task) will allow to send the Intra-Communautaire prestaties report (EC Sales List) the same way. Task : 3187020 Forward-Port-Of: odoo/enterprise#44709 Forward-Port-Of: odoo/enterprise#42849
Original PR description
We added the feature to send the Tax Report to the Dutch government for our Dutch clients. This new module (which will be merged into l10n_nl_intrastat in master in a new task) will allow to send the Intra-Communautaire prestaties report (EC Sales List) the same way. Task : 3187020 Forward-Port-Of: odoo/enterprise#44709 Forward-Port-Of: odoo/enterprise#42849
There was a traceback when right clicking on a spreaded cell beacause of the list "see record" context menu item. Fixed it. Task: [3425493](https://www.odoo.com/web#id=3425493&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44141
Original PR description
There was a traceback when right clicking on a spreaded cell beacause of the list "see record" context menu item. Fixed it. Task: [3425493](https://www.odoo.com/web#id=3425493&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44141