Wednesday, August 9, 2023
5 changes · master
Resolved issues and error corrections
This fixes an issue where Kanban cards could keep showing old field values after a user changed them through an embedded widget. Business users will see more accurate, up-to-date information in Kanban views without needing to refresh or reopen the page.
Original PR description
Before this commit, calls to record[fieldname][value/raw_value] in the arch of a kanban view did not take into account updates on the Record Datapoint. So if any data in the Record changed, the [raw_value/value] was not modified.
In a custom KanbanRecord, you should never use the record containing the value and raw_value. We will therefore replace this call by using the datapoint record directly.
How to reproduce:
- Have a kanban view with a record.my_field.value and a widget allowing
you to modify the value of my_field.
- Click on the widget
Before this commit:
The value of my_field does not change
After this commit:
The value of my_field has been updated.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prCancelled point of sale orders are now ignored when closing a POS session, preventing incorrect inventory movements and accounting differences. This helps shops and restaurants close sessions cleanly after deleting saved orders, while still retaining cancelled payment records for reference.
Original PR description
The POS orders can currently be saved in the database, then removed which in reality puts them in the cancelled state. Those cancelled orders are processed when their session is closed, which results…
The POS orders can currently be saved in the database, then removed which in reality puts them in the cancelled state. Those cancelled orders are processed when their session is closed, which results in unbalanced accounting lines and inventory pickings still created. Steps to reproduce: With a shop: - Set a trusted POS for the shop to use - Open a session for that shop - Create an order with 1 product - Click on the "Save" button of the trusted POS feature (in the product screen, above the numpad) - Open the orders with the top right dropdown menu - Click on the trash to delete the previously created and saved order - Close the session With a restaurant: - Open a session - Create an order with 1 product - Click on the "Back" button (to save the order in the database) - Open the orders with the top right dropdown menu - Click on the trash to delete the previously created and saved order - Close the session In both cases, the "Force Close Session" error popup appears. After closing the session with the "Close Session & Post Entries" backend button, the inventory picking is created and validated, accounting Product Sales and Tax lines are created, and there is a "difference at closing POS session". The fix consists of not processing cancelled orders when closing POS sessions. The payments of cancelled orders are still saved in the database, but not taken into account in the sessions closing process. task-id: 3452353
Belgian payroll now correctly includes up to 30 unpaid sick days when calculating 13th month payments. This helps ensure employees receive the correct year-end compensation and reduces payroll correction work.
The subscription report now calculates monthly recurring revenue from each subscription line instead of relying on the overall sales order value. This makes reported revenue more accurate when reviewing subscription performance and line-level details.
Original PR description
MRR on subscription report was computed for lines based on the SO MRR, it's now computed based on the line similar to how it's computed in python `_compute_recurring_monthly`. task-id : 3446444
Kanban cards now refresh field values correctly after a user changes data through an action or widget. This prevents outdated information from remaining visible on cards, improving confidence in day-to-day workflows such as document and social post management.
Original PR description
Before this commit, calls to record[fieldname][value/raw_value] in the arch of a kanban view did not take into account updates on the Record Datapoint. So if any data in the Record changed, the [raw_value/value] was not modified.
In a custom KanbanRecord, you should never use the record containing the value and raw_value. We will therefore replace this call by using the datapoint record directly.
How to reproduce:
- Have a kanban view with a record.my_field.value and a widget allowing
you to modify the value of my_field.
- Click on the widget
Before this commit:
The value of my_field does not change
After this commit:
The value of my_field has been updated.