Wednesday, August 9, 2023
11 changes · master
Resolved issues and error corrections
This fixes an issue where Kanban cards could keep showing old field values after a user changed them through an embedded widget. Business users will see more accurate, up-to-date information in Kanban views without needing to refresh or reopen the page.
Original PR description
Before this commit, calls to record[fieldname][value/raw_value] in the arch of a kanban view did not take into account updates on the Record Datapoint. So if any data in the Record changed, the [raw_value/value] was not modified.
In a custom KanbanRecord, you should never use the record containing the value and raw_value. We will therefore replace this call by using the datapoint record directly.
How to reproduce:
- Have a kanban view with a record.my_field.value and a widget allowing
you to modify the value of my_field.
- Click on the widget
Before this commit:
The value of my_field does not change
After this commit:
The value of my_field has been updated.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prDraft records in Mail now show a follower count of 0 instead of a loading spinner before they are saved. This avoids a confusing wait state and makes the record status clearer for users.
Original PR description
Before this commit, the follower loading spinner was shown for draft records until it was saved. This is incorrect, follower count should instead be 0. This commit fixes this issue.
Point of Sale now clearly highlights invalid money amounts in cash in/out and session closing popups. This helps cashiers spot entry mistakes immediately and reduces the chance of incorrect cash operations.
Original PR description
Since the use of Bootstrap, the money inputs using the useValidateCashInput hook are no longer correctly displayed when the user input is invalid. Steps to reproduce: - Open a session in a shop - Open the "Cash In/Out" menu with the top right dropdown menu - Enter an invalid amount, like "invalid" for example The input is not displayed with red borders. This commit fixes the display of invalid inputs in the Cash In/Out and Closing Session popups, using the Bootstrap is-invalid CSS class. task-id: 3444048
Cancelled point of sale orders are now ignored when closing a POS session, preventing incorrect inventory movements and accounting differences. This helps shops and restaurants close sessions cleanly after deleting saved orders, while still retaining cancelled payment records for reference.
Original PR description
The POS orders can currently be saved in the database, then removed which in reality puts them in the cancelled state. Those cancelled orders are processed when their session is closed, which results…
The POS orders can currently be saved in the database, then removed which in reality puts them in the cancelled state. Those cancelled orders are processed when their session is closed, which results in unbalanced accounting lines and inventory pickings still created. Steps to reproduce: With a shop: - Set a trusted POS for the shop to use - Open a session for that shop - Create an order with 1 product - Click on the "Save" button of the trusted POS feature (in the product screen, above the numpad) - Open the orders with the top right dropdown menu - Click on the trash to delete the previously created and saved order - Close the session With a restaurant: - Open a session - Create an order with 1 product - Click on the "Back" button (to save the order in the database) - Open the orders with the top right dropdown menu - Click on the trash to delete the previously created and saved order - Close the session In both cases, the "Force Close Session" error popup appears. After closing the session with the "Close Session & Post Entries" backend button, the inventory picking is created and validated, accounting Product Sales and Tax lines are created, and there is a "difference at closing POS session". The fix consists of not processing cancelled orders when closing POS sessions. The payments of cancelled orders are still saved in the database, but not taken into account in the sessions closing process. task-id: 3452353
This fixes a Point of Sale display issue where users could still access the top navigation bar while a temporary screen, such as the partner list, was open. The temporary screen now behaves as intended, keeping users focused on completing the required action before returning to the main flow.
Original PR description
With the introduction of Bootstrap in the PoS, the navbar was still accessible when showing a tempScreen as the PartnerListScreen. This is not intended as the tempScreen act "like a big popup" where the user must do the action on the tempScreen before doing anything else. The problem here is that the Bootstrap integretion forgot to add the correct style to the div "block-top-header" which is done in this PR (background-color, width, height and position). For example, the top of the PartnerListScreen looked like this before  and now looks like this  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The forum validation queue filter now shows the intended icon instead of an incorrect stray character. This makes the moderation filter menu look consistent and easier for administrators to understand.
Original PR description
before this commit, in the forum validation queue filter, along with the text filter instead of icon some hard coded value(圾) is shown as text. * create a user with very minimum XP * create a post from new user login * from admin login, click validation queue in the forum * click on filter in the validation queue after this commit, the text will be replaced with fa-font icon, so that all filters will look similar. Before:  After:  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Belgian payroll now correctly includes up to 30 unpaid sick days when calculating 13th month payments. This helps ensure employees receive the correct year-end compensation and reduces payroll correction work.
The subscription report now calculates monthly recurring revenue from each subscription line instead of relying on the overall sales order value. This makes reported revenue more accurate when reviewing subscription performance and line-level details.
Original PR description
MRR on subscription report was computed for lines based on the SO MRR, it's now computed based on the line similar to how it's computed in python `_compute_recurring_monthly`. task-id : 3446444
The appointment page now only shows the publish button to users who have permission to publish. This prevents crashes for users without the necessary access rights and creates a smoother experience.
Original PR description
Earlier, publish button was visible for all user type but caused crashes for the user who don't have the access to publish it. This commit addresses the issue. Now, only users with the appropriate access rights will see the button, preventing crashes. Task-3339257
The Knowledge app now shows the property helper only when no properties remain. This prevents confusing helper prompts from appearing while users are simply deleting individual properties.
Original PR description
**Before this PR**: Property helper was appear when deleting any property Because this issue was introduced in this commit https://github.com/odoo/enterprise/commit/127f512b1a72957eb23c41103ecab44e1fdce0e7 **After this PR**: Property helper will come only when there is no property **Task**-3450016
Kanban cards now refresh field values correctly after a user changes data through an action or widget. This prevents outdated information from remaining visible on cards, improving confidence in day-to-day workflows such as document and social post management.
Original PR description
Before this commit, calls to record[fieldname][value/raw_value] in the arch of a kanban view did not take into account updates on the Record Datapoint. So if any data in the Record changed, the [raw_value/value] was not modified.
In a custom KanbanRecord, you should never use the record containing the value and raw_value. We will therefore replace this call by using the datapoint record directly.
How to reproduce:
- Have a kanban view with a record.my_field.value and a widget allowing
you to modify the value of my_field.
- Click on the widget
Before this commit:
The value of my_field does not change
After this commit:
The value of my_field has been updated.