Daily updates from Odoo
Thursday, August 10, 2023
8 changes · master
Resolved issues and error corrections
Belgian payroll now handles cases with multiple public holidays and variable salary components more accurately. This helps ensure payslips and related accounting validations reflect the correct worked days and compensation amounts.
Original PR description
…alary
This fixes an automated accounting test flow that had stopped working after recent import changes. It helps ensure tax group import behavior is checked reliably, reducing the risk of accounting issues reaching users.
Original PR description
Following changes on the import (https://github.com/odoo/enterprise/commit/5a800d5e304d02e15def04ef76911543c633af92), the tour does not work. It was attempted in https://github.com/odoo/enterprise/commit/467613ace4e8cb0dac8274e6742984f01aacd1c9, but did not work (and silently, because the test is deactivated) Fixes runbot error 23638
This fixes internal references to a renamed action service so affected screens continue to work correctly. It helps prevent errors in Helpdesk and Quality worksheet views after the underlying service name changed.
Original PR description
the default model 'useAction' service is now named 'action' no longer 'actionService' Changed the reference where needed
This update fixes an unreliable automated test for the Web Studio icon creator. It helps keep quality checks stable so development and releases are not delayed by random test failures.
Original PR description
An apparently nondeterministic error occured on runbot while running js test "with initial web icon data" for the IconCreator. Cause of the error:
Sign template PDFs can no longer be edited or cleared from the template properties, reducing the risk of accidental replacement or deletion. This helps preserve document integrity and prevents validation issues caused by changing the underlying PDF in a template.
Original PR description
The sign.template datas field is writable, which makes it very easy to replace or delete the PDF. Modifying the underlying document doesn't make sense and causes integrity checks to fail. This commit prevents these issues by making the field readonly. Consequently, the Edit and Clear buttons in Template Properties are no longer visible. Note that the document itself can still be modified (for example, via the Documents app), causing integrity checks to fail. However, that is a separate topic. task-3455091
This fix prevents existing sign template items from being treated like newly created unsaved items when opening their detail popovers. It helps keep template editing smooth and avoids unnecessary delays or incorrect handling for items that are already saved.
Original PR description
https://github.com/odoo/enterprise/pull/43125 introduced a new relational model and since sign uses it to show x2many records in the sign item popover when editing a template. That PR also introduced a new approach to guarantee that new sign items are already saved in the server before we allow opening the popover. However, the logic for doing that was affecting items that already had an ID set in the server because it was checking for the updated property in the sign item, while it should be checking for a negative id only. This commit fixes this by adding only the negative ids to the negativeIds object, which contains promises for each id that are resolved when the item is saved in the server. task-3438789
This fixes a missed internal reference after a platform change renamed how actions are handled. It helps quality control worksheets continue opening and running actions reliably without disrupting users.
Original PR description
Since [new relational model](https://github.com/odoo/odoo/commit/8723f020c3587a900c811b8cc23f53fe34b98df3), actionService changed to action in the new relational model. This commit fixes one missed actionService.
This fix adjusts Belgian payroll fleet handling so the system uses the responsible user when no fleet manager is set. This prevents incorrect behavior in cases where a fleet manager is missing and keeps ownership or responsibility assignments consistent.
Original PR description
The behavior was not correct, we want nothing if there is no fleet manager task-3395095