Sunday, August 20, 2023
3 changes · master
Miscellaneous changes
Before this commit, closing a hidden chat window may crash. This happens because closing a chat window was always treated as the closing of a visible chat window, which should make the 1st hidden chat window visible, if any. This code should not be called when closing a hidden chat window, otherwise unexpected behaviour are to be expected, e.g. closing 2nd hidden chat window swaps last visible with 1st hidden chat window, or even a crash. This commit makes sure auto-swapping of 1st hi
Original PR description
Before this commit, closing a hidden chat window may crash. This happens because closing a chat window was always treated as the closing of a visible chat window, which should make the 1st hidden chat window visible, if any. This code should not be called when closing a hidden chat window, otherwise unexpected behaviour are to be expected, e.g. closing 2nd hidden chat window swaps last visible with 1st hidden chat window, or even a crash. This commit makes sure auto-swapping of 1st hidden chat window only occurs when closing a visible chat window. opw-3460466 Forward-Port-Of: odoo/odoo#132427 Forward-Port-Of: odoo/odoo#131605
Before this commit: JS errors on iOS with Safari's browser due to the date syntax not being supported: ```js new Date("2023-08-18 14:02:53") -> Invalid Date ``` This does prevent Odoo's backend to start up on the browser and the app on iOS devices. opw-3465337 Forward-Port-Of: odoo/odoo#132460 Forward-Port-Of: odoo/odoo#132327
Original PR description
Before this commit:
JS errors on iOS with Safari's browser due to the date syntax not being supported:
```js
new Date("2023-08-18 14:02:53")
-> Invalid Date
```
This does prevent Odoo's backend to start up on the browser and the app on iOS devices.
opw-3465337
Forward-Port-Of: odoo/odoo#132460
Forward-Port-Of: odoo/odoo#132327Before this commit, when chatter data were fetched, it shows spinner icon on attachments immediately until data are fetched. This RPC is quite fast, so it's annoying to see spinner and then no spinner whenever chatter is reloaded. This is even more bothersome when most chatters have no attachments and some followers, which gives the illusion loading affects followers rather than attachments, as the spinner takes place of attachment counter that is empty when no attachment. This commit fixe
Original PR description
Before this commit, when chatter data were fetched, it shows spinner icon on attachments immediately until data are fetched. This RPC is quite fast, so it's annoying to see spinner and then no…
Before this commit, when chatter data were fetched, it shows spinner icon on attachments immediately until data are fetched. This RPC is quite fast, so it's annoying to see spinner and then no spinner whenever chatter is reloaded. This is even more bothersome when most chatters have no attachments and some followers, which gives the illusion loading affects followers rather than attachments, as the spinner takes place of attachment counter that is empty when no attachment. This commit fixes the issue by having a 1 second delay for showing the loading icon next to attachment. This prevents most flickers when RPC is fast, while keeping it relevant when it's slow so it's clear data are still loading. Task-3356922 Before  After  Forward-Port-Of: odoo/odoo#132459 Forward-Port-Of: odoo/odoo#132237