Thursday, September 14, 2023
11 changes · master
Resolved issues and error corrections
Fixed an issue where file fields shown in list views ignored the configured filename. Users will now see and download files with the intended names, reducing confusion when handling attachments in records.
Original PR description
Steps to reproduce: - Make any list binary field with filename attribute Current behaviour: - The binary file does not use the filename field Expected behaviour: - The binary file should use the filename field Explanation: After the updates of list-specific binary field, the list binary cannot get the attributes field name of the record anymore. X-original-commit: f6dea9b
This fix ensures a newer database query method goes through Odoo's standard execution path, so SQL logging and performance test query counts remain accurate. It helps teams detect performance issues and monitor database activity reliably without changing business workflows.
Original PR description
psycopg2.extras.execute_values was introduced in PR https://github.com/odoo/odoo/pull/101237 however it pypasses the override logic for cr.execute. As a result 1. --log-sql cannot log these queries 2. assertQueryCount cannot notice these queries ... This commit create a new api cr.execute_values to support the same SQL feature without losing the override logic for cr.execute https://github.com/odoo/enterprise/pull/47374 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects a layout issue in the date and time picker where the calendar could show the wrong number of columns after week numbers were added. It helps keep the calendar display consistent and easier to use, with tests added to prevent the issue from returning.
Original PR description
Following the introduction of the `showWeekNumbers` prop on DateTimePicker component (see commit 7552284e781dc7e1c72a93d5f37d16b1b05bda4c), the number of column (CSS custom property) wasn't properly defined in the template. This commit fixes it and adds related asserts in QUnit tests. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a live chat issue that could occur when a website visitor starts without an existing saved chat session. It helps keep automated checks stable and supports a smoother chatbot experience for new visitors.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/135378 Commit above fixed a potential issue where guests may eventually have many livechats, so finding the livechat thread just by `type: livechat` is not enough. To be more specific, it relies on livechat session stored in cookie. However, when there's no livechat session, there's no id stored in cookie. The livechat thread uses a `TEMPORARY_ID`. Fix above forgot to handle this part, thus the getter was failing when there's no persistent livechat session.
Lead generation industry options have been corrected to match the external provider’s search terms. This helps users get relevant leads for industries that previously returned no results, improving the usefulness of lead mining searches.
Original PR description
The values used in the industry to obtain lead generations did not align with those of our provider. This posed a problem, as it meant that some queries inevitably returned zero leads. Description of the issue/feature this PR addresses: When a lead mining request was made using the lead generation tool, several industry categories returned no results when selected, even for countries such as the USA. Current behavior before PR: The user's query returned industry ids that did not match up correctly with the keywords used in the lead search. Desired behavior after PR is merged: Now users will be able to choose their industry from a revised list. In addition, the query sent will now contain the name of the industry rather than an id. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where users could no longer switch how products are displayed in the Point of Sale screen after a recent internal update. Restoring this option helps cashiers use their preferred product layout and keeps the checkout workflow consistent.
Original PR description
After the bootstrap refactoring introduced in this commit cc349515a4923874067705267bbaa383276556e6. The switch product view wasn't working anymore. This commit reintroduce the logic behind the switch product view option. Task-3500621
Fixed an issue where customers using self-order could sometimes miss the pay button after placing an order. This ensures a smoother checkout experience and adds tests to prevent the problem from returning.
Original PR description
*: pos_online_payment_self_order
Since https://github.com/odoo/odoo/commit/605943b5eaafe7e9224f0e7fb4fbdd020102c7a5, the pay button is not always displayed in the self-order UI after clicking on the "Order" button.
The issue is due to the selected_attributes value received from the server, that can be "false", while the JS code of self-order UI is designed with "{}" as the empty/null value.
When the local order of the self-order UI is updated with the data from the server, the false value was saved instead of the {}, resulting in the line being considered as "modified" according to the isChange method which uses JSON.stringify for comparing changes.
The fix consists in correctly updating the local order selected_attributes value when receiving data from the server.
This commits adds some tests for the pay after meal self-order mode, to check that the pay button is visible.
task-id: 3489173Project forms now correctly show the rating and document settings when the Documents app is installed. This restores access to configuration options that had been unintentionally hidden after a previous view update.
Original PR description
In the view refactor of https://github.com/odoo/enterprise/pull/35255, the condition to show the rating and documents section in the settings of the project form view was converted to `True` instead of `False`, meaning that the rating and documents settings are never visible with documents installed. This PR fixes the visibility so the section is always visible with documents installed instead.
This fix ensures a newer bulk database query method follows the same monitoring and logging path as standard queries. It helps Odoo teams keep performance tests and SQL logging accurate, reducing the risk of hidden slowdowns.
Original PR description
psycopg2.extras.execute_values was introduced in PR #101237 however it pypasses the override logic for cr.execute. As a result 1. --log-sql cannot log these queries 2. assertQueryCount cannot notice these queries ... This commit create a new api cr.execute_values to support the same SQL feature without losing the override logic for cr.execute [#odoo/131190](https://github.com/odoo/odoo/pull/131190)
The social CRM interface now hides the "Create Lead" button on posts published by the company itself. This prevents users from accidentally creating sales leads from their own social media content, keeping lead generation focused on external engagement.
Original PR description
Purpose ======= The button "Create Lead" is supposed to be hidden for our own posts, but it is always visible because we wrongly compute "isAuthor". Technical ========= A computed field is needed to fix the issue, because we don't have the account media id in JS (or it will require a RPC call). Task-3495203
The web client now fades in its background after login instead of switching abruptly from a blank white screen. This creates a smoother, faster-feeling transition for users entering the system.
Original PR description
DRAFT Description of the issue/feature this PR addresses: Provide a feeling of speed/a less jarring transition between the login and the loading of the web client. Current behavior before PR: The web client starts with a harsh transition from a white/empty background to the actual purple background. Desired behavior after PR is merged: The web client background fades in after login in.