Friday, September 15, 2023
8 changes · master
Resolved issues and error corrections
A warning in the automated test for users editing their own profile was corrected. This helps keep Odoo's test checks clean and reduces noise when validating the Mail module.
Original PR description
Follow up of https://github.com/odoo/odoo/pull/129239 Fixes runbot issue https://runbot.odoo.com/web#id=24581&view_type=form&model=runbot.build.error&menu_id=405&cids=1
This fixes an issue in the web interface where editing a form record and then moving to another record could incorrectly increase the pager count. Users will now see stable, accurate navigation counts while browsing records.
Original PR description
Before this commit, in form view, editing a record then switching page incremented the pager limit by 1. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error from appearing when users open the Timesheet list view in developer mode. It aligns the Timesheet list view configuration with the expected format, improving reliability for teams reviewing timesheet entries.
Original PR description
- 1 Issue
ListRenderer pros type is array/list and timesheet_grid inside pros type
is object, both mismatch so i think this issue is raised.
- 2 Fix:
We have replaced object with list type in list renderer pros.
Step to reproduce:
- Install Timesheet
- Turn on developer mode
- Go to timesheet
- Click on listview
task- 3507986This update corrects syntax mistakes in Web Studio page templates that could cause errors in certain screens. It also supports better automated checks so similar template issues are caught earlier, improving reliability for users.
Original PR description
New test from community catches syntax mistakes of qweb files. This PR fixes those issues. https://github.com/odoo/odoo/pull/128445
Performance test benchmarks were adjusted to match recent underlying platform changes. This keeps internal test checks accurate and helps avoid false failures in development workflows, with no expected impact on end users.
Original PR description
This commit modifies the query count of some performance tests to cope with changes made in https://github.com/odoo/odoo/pull/131355 task-3442819
Switching between bank reconciliation cards no longer triggers duplicate background requests. This reduces unnecessary processing and should make the reconciliation view feel more responsive and reliable for accounting users.
Original PR description
Since the new relational model https://github.com/odoo/odoo/pull/114024, in the kanban reconciliation view, when the card is switched, two similar "web_search_read" RPCs are executed. Why: Because two renderings are caused, one because of the update applied to the record datapoint and the second when the newState is applied to the kanban view. Solution: Customise the Relational Model to have a custom update for "todo_command". The changes will be applied when the newState is applied so that there is only one rendering.
The event barcode setup now updates registration barcodes in one batch instead of many separate database calls. This reduces installation time and database overhead, especially when the database is hosted separately, while focusing barcode generation on current and future events.
Original PR description
## Description During the installation of the module `event_barcode`, we have an override of `_init_column` for the `barcode`. We were using the psycopg's `executemany` which is just a syntactical…
## Description During the installation of the module `event_barcode`, we have an override of `_init_column` for the `barcode`. We were using the psycopg's `executemany` which is just a syntactical sugar for a loop over an `execute`. So we trigger 1 query (which incurs a network cost when deployed and the database is not on the same machine) per row, currently we have 27 queries (for demo data). ## Solution We can use SQL syntax: ```sql UPDATE ... SET ... FROM (VALUES ...) WHERE ... ``` which does 1 update for all rows in one go. ## Implementation details We could implement this query directly with a simple execute, but it requires a lot of manual construction with the help of `sql. Composed`, because of necessity to insert manually `sql.Literal` used for the tuples of the `VALUES`. Psycopg2 exposes a function called `execute_values` which is just for this case and makes to code way more legible. We also generate barcodes only for registrations linked to event that are ongoing or in the future, to improve the speed of the UPDATE itself (we update less rows). ## Reference task-3430406
The Belgian fleet expense calculation now shows rates as percentages instead of decimals. This prevents misleading values such as 0.5 appearing where 50 should be shown, helping users apply the correct disallowed expense rate.
Original PR description
Currently the rate is incorrectly computed (0.5 instead of 50)