Friday, September 22, 2023
3 changes · master
Resolved issues and error corrections
This update restores compatibility for existing links that use the previous company identifier format in the web address. It helps ensure links already sent in emails or saved by users continue to open correctly after the newer URL format was introduced.
Original PR description
Commit [1] changed the separator of cids in the url to make it better looking, by using a character that doesn't need to be encoded (namely, "-" instead of ","). However, by doing so, urls still using the former separator couldn't be correctly parsed anymore. This commit adds a small backward compatibility layer, s.t. links in emails for instance keep working as before. [1] abae4d4a5ce2a420581a0ce1b52349457019c66d Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents survey matrix row and column answers from showing incorrect labels or causing errors in survey response views. It also removes an unnecessary way to create answers outside a question, reducing confusion for users managing surveys.
Original PR description
We here fix the `SurveyQuestionAnswer._compute_display_name` method introduced in 55fa52be. `survey.question.answers` used as matrix rows and columns require different treatment as they are not used in triggers but are both shown on the `survey.user.input.line` views, where the display shouldn't change (nor cause a crash). It also doesn't make much sense to create answers outside the context of a question, so we remove the button that already wasn't shown on the tree view. As users may not fully upgrade their views though, we added a fallback question title in `compute_display_name`too. Task-3495142
This update adjusts internal tests so they verify the final back button behavior instead of counting how many times supporting code is called. This reduces false test failures during development without changing customer-facing features.
Original PR description
These tests assert overrideBackButton() is called only once. This makes the assumption that it tests only a single component that overrides the back button. Discuss tests mount many components at…
These tests assert overrideBackButton() is called only once. This makes the assumption that it tests only a single component that overrides the back button. Discuss tests mount many components at once, so that it test a functionally meaningful flows rather than tiny and irrelevant unit tests. Due to backbutton being override in many components, like chat windows and messaging menu, tests were prone to call the override back buttons many times. This is especially true in chat window tests, as opening a chat window usually requires to make use of the messaging menu, hence more than 1 override back button call. This commit fixes the tests by checking only the resulting state of enabled override back button. Note that these tests still sucks, because that doesn't mean the override is made by the component we really care... And even the design of the test sucks: it should actually simulate back button and assert expected UI changes from that. Since these tests were posing an immediate problem for a dev in progress, it was best to keep the tests while quick fixing the problem at hand. https://github.com/odoo/odoo/pull/134884