Friday, September 22, 2023
7 changes · master
Resolved issues and error corrections
The activity view now paginates records correctly when many items have multiple activities, so users see the expected number of records on each page. This prevents missing or confusing activity results when navigating large activity lists.
Original PR description
This solves the following problem: - Add 150 records with 2 activities each (ex. A call and a to do) - Go to the activity view (ex.: event through the systray) and clear filter - Only 50 of the 150 records are displayed (instead of 100) - Going to the next page, only 2 are displayed (instead of ~50) (will depends on the data already present) Technical notes: Not all activities were displayed because the search limit was applied on the activity search instead of searching all activity related to the records. The method fetchActivityData was doing half of the job because it was not assigning the activity data fetch on the server to the instance variable activityData, which was causing strange behavior when clicking on next page. To simplify and correct the code, that logic has been moved to that method instead of relying on the caller to do that assignation. Task-3508744
This fix ensures several field widgets refresh correctly when records are updated, preventing stale or incorrect information from being shown. It improves reliability in accounting, inventory, manufacturing, email marketing, and general web interface screens affected by recent model changes.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The web editor now avoids a crash that could happen when users switch between records containing editable HTML content. This makes navigation between items such as tasks or Knowledge articles more reliable and prevents interruptions while editing or reviewing content.
Original PR description
How to reproduce: - open a record with an html_field (i.e. todo or a Knowledge article) - switch back and forth with the pager or the knowledge sidebar between 2 records Current behavior: - traceback…
How to reproduce: - open a record with an html_field (i.e. todo or a Knowledge article) - switch back and forth with the pager or the knowledge sidebar between 2 records Current behavior: - traceback `this._elementHookMap.get(element)` is undefined Expected behavior: - no traceback Technical explanation: When changing the editable content (i.e. `resetContent` when changing record), there is no guarantee that `_intersectionObserverCallback` (intersectionObserver) won't be called before `_updateHooks` (mouseMove/resize after a mutation occured). This is an issue because `this._elementHookMap` may not yet have a hook element related to the editable element which stops intersecting the document. If such a case occurs, the next `_updateHooks` should be called when the mutationObserver flags `_resetHooksNextMouseMove` to `true` and then after the next `mouseMove` (or after the next resize). Ignore the hook style update if there is currently no hook for an element which stops intersecting. Remove a redundant check in `_getMovableElements` task-3506666
This update restores compatibility for existing links that use the previous company identifier format in the web address. It helps ensure links already sent in emails or saved by users continue to open correctly after the newer URL format was introduced.
Original PR description
Commit [1] changed the separator of cids in the url to make it better looking, by using a character that doesn't need to be encoded (namely, "-" instead of ","). However, by doing so, urls still using the former separator couldn't be correctly parsed anymore. This commit adds a small backward compatibility layer, s.t. links in emails for instance keep working as before. [1] abae4d4a5ce2a420581a0ce1b52349457019c66d Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents survey matrix row and column answers from showing incorrect labels or causing errors in survey response views. It also removes an unnecessary way to create answers outside a question, reducing confusion for users managing surveys.
Original PR description
We here fix the `SurveyQuestionAnswer._compute_display_name` method introduced in 55fa52be. `survey.question.answers` used as matrix rows and columns require different treatment as they are not used in triggers but are both shown on the `survey.user.input.line` views, where the display shouldn't change (nor cause a crash). It also doesn't make much sense to create answers outside the context of a question, so we remove the button that already wasn't shown on the tree view. As users may not fully upgrade their views though, we added a fallback question title in `compute_display_name`too. Task-3495142
Point of Sale orders shared between registers now include products even when the receiving register had not loaded them yet. This prevents incomplete orders and helps staff process cross-register sales accurately.
Original PR description
Prior to this commit if an order was sent to another pos with the cross order, if the product was missing in the target pos, the product will be missing in the order. This commit loads the products that are missing for the cross orders. Task-3504316
This update adjusts internal tests so they verify the final back button behavior instead of counting how many times supporting code is called. This reduces false test failures during development without changing customer-facing features.
Original PR description
These tests assert overrideBackButton() is called only once. This makes the assumption that it tests only a single component that overrides the back button. Discuss tests mount many components at…
These tests assert overrideBackButton() is called only once. This makes the assumption that it tests only a single component that overrides the back button. Discuss tests mount many components at once, so that it test a functionally meaningful flows rather than tiny and irrelevant unit tests. Due to backbutton being override in many components, like chat windows and messaging menu, tests were prone to call the override back buttons many times. This is especially true in chat window tests, as opening a chat window usually requires to make use of the messaging menu, hence more than 1 override back button call. This commit fixes the tests by checking only the resulting state of enabled override back button. Note that these tests still sucks, because that doesn't mean the override is made by the component we really care... And even the design of the test sucks: it should actually simulate back button and assert expected UI changes from that. Since these tests were posing an immediate problem for a dev in progress, it was best to keep the tests while quick fixing the problem at hand. https://github.com/odoo/odoo/pull/134884