Monday, September 25, 2023
13 changes · master
Resolved issues and error corrections
This fix prevents a rare page editor error that could occur when a page is reloaded at the same time the editor is updating content. It improves reliability by safely ignoring editor elements that are no longer present.
Original PR description
There is a traceback that could happen in a race condition when reloading the page. The reason is because `_intersectionObserverCallback` is async and could be called after an element has been removed in `_updateHooks`. This commit ensures the existence of the element to avoid a traceback. task-3519508 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Graph reports now handle empty or missing data point values correctly instead of crashing. This improves reliability when users view charts that include incomplete data.
Original PR description
This commit fixes a crash that could happen in graph view when the value of a datapoint is false and passed to the formatFloat method. In this case, it should use the field version of the formatFloat method to handle the case where the value is false properly.
Fixed an issue in the web editor where changing the color of an entire table cell could leave previously colored text unchanged. This makes table formatting more consistent and avoids confusing mixed colors when users update cell styling.
Original PR description
[FIX] web editor: color of whole cell should change This commit fixes the issue of partial coloring of table cells. Before this commit, if one colors part of the text in the cell and then seeks to color the whole cell, the last coloring would not apply on the previously colored text. We do that by preventing the cell coloring to be done differently than other elements except if we want to change the background color. Task-3454903
Fixed an issue in the website editor where clicking the table menu icon could cause an error instead of opening the menu. Users can now edit tables more reliably without interruptions.
Original PR description
**Current behaviour before commit:** In table, when clicking table menu icon it throws traceback. **Desired behaviour after commit:** Now, clicking table menu icon opens table menu without any traceback. task-3503806 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a display issue where an internal sales order line field appeared in the task timesheet section. Users creating or reviewing task timesheets will now see a cleaner screen with only relevant information.
Original PR description
Steps: Install Project ,timesheet_grid & sale_timesheet Open project module Click on projects card In list view ,create a new task Then in timesheet notebook page Issue: Unnecessary field in timesheet notebook page Cause: There was some unnecessary field issue. Fix: added hide optional in sale_timesheet module. task-3474577 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a broken link in the manufacturing product view that could prevent users from opening related manufacturing orders. The button now uses the current manufacturing order action, restoring expected navigation after an older action was removed.
Original PR description
In 6698406b92a598f24fa0a778a28b6ef727adc008, we removed action mrp.mrp_production_report. action_view_mos still using this action, we change it to use mrp.mrp_production_action instead. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Cashiers can now close Point of Sale sessions even when the POS setup does not include a cash payment method. This prevents a silent blocking error and keeps store closing workflows running smoothly, especially in databases without demo data.
Original PR description
Since a869ee87f28c517c67d782b132b65aaf86309d1e, the cashier can no longer close a session from the frontend UI if the POS config has not a cash payment method. Steps to reproduce: - Remove any cash payment method from the POS config you want to use - Open a POS session for the previous POS config - Make an order - Try to close the session A (silent) error is raised, the user cannot close the session. This error is particularly noticeable when we don't use demo data (--without-demo=True). The fix consists in correctly checking if there is a cash payment method or not. task-id: 3519547
This fixes an issue that prevented restaurant point-of-sale onboarding demo data from loading in databases created without demo data. Businesses can now use the guided demo setup without encountering an error caused by an incorrectly assigned food category logo.
Original PR description
The onboarding demo data cannot be loaded since f96ea753f35355e8344a30623f2b21aa284972f2. Steps to reproduce: - Start a database without demo data (--without-demo=True) - Open a POS session for the default shop - Click to load demo (onboarding) data An error is raised. The error is due to a mistake in the XML, the food category logo is not assigned to the right record. task-id: 3519677
This update fixes a problem in project portal testing where certain test assets were expected in a place where they are not loaded. It helps keep automated checks reliable without changing the customer-facing project sharing experience.
Original PR description
Step to reproduce: Go on [URL]/my/projects/[ID]/project_sharing with the assets tests activated. The project.webclient doesn't load the whole backend assets that tests depend on, so the dependencies for the tours have to be ignored. The tour didn't crash because the content of the iframe was present (below the traceback message) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where editing a related record in a form could trigger a failed automatic update on the parent record and leave the edited field in an unsafe state. The form now restores the previous valid value, helping users avoid inconsistent data after an error.
Original PR description
When the onchange triggered by an x2m fails on the parent record, we want to reuse a valid value (the one before the onchange).
How to reproduce:
- Go to a form view with an x2m (onchange=true) that contains at least one record
- Edit the record in the x2m
- onchange on parent record fails
Before this commit:
The value is unchanged.
After this commit:
The value of the edited field is replaced by its old value.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fixes how Italian electronic invoices decide whether they can be reset to draft, avoiding an incorrect cancellation flow. It matters because Italian EDI rules do not allow invoice cancellation, so users should be guided toward compliant correction steps such as issuing a full refund credit note.
Original PR description
In the odoo/odoo#122194 PR I incorrectly used the `need_cancel_request` flag instead of the `show_reset_to_draft_button` one. Italian EDI doesn't allow any sort of cancellation (in case of error you have to a full refund credit note).
This fix prevents two extra columns from appearing twice in the journal report. It keeps the report layout clearer and avoids confusion when reviewing accounting entries.
Original PR description
The function '_get_move_line_additional_col' adds the additional_col_1 and additional_col_2. In '_get_first_move_line' and '_get_aml_line' when we loop through the columns in the options, we have to break the loop when we arrive to the additional columns otherwise they are added twice.
The planning magnifier view no longer shows the resource color field column. This removes an unnecessary internal detail from the view, making the planning interface cleaner for users.
Original PR description
Description of the issue: resource color field column was visible in planning magnifier Desired behavior after PR is merged: resource color field column will be invisible in planning magnifier task-3484290