Odoo Changelog — 2023-09-29

Friday, September 29, 2023

53 changes · master

Improvements(8)

Enhancements to existing features

[IMP] sale_project: add icon on company dependent fields

Coremastersale_project

Product-related project settings now show a building icon next to fields that depend on the selected company. This makes it easier for users working across multiple companies to recognize when a value may vary by company.

Original PR description

This commit improves the visual indication of company dependent fields. add icon of 'fa fa-building' on side of fields label.

task-3186717

#usability#multi-company#product-settings

[IMP] web_editor: add preserveCursor callback return value

PR #126340

Coremasterweb_editor

The web editor now reports whether it successfully restored the user's cursor position after an editing action. This gives Odoo better control over editing behavior and helps reduce cursor-related inconsistencies for users.

Original PR description

By returning the `setSelection` value in the callback returned by the
`preserveCursor`, we allow better control for the caller over the fact that the
selection was effectively restored or if it failed.

task-3383561

#editor#cursor#usability

[IMP] fleet: improve length of model field

PR #133431

Coremasterfleet

The vehicle form now gives more space to the model field, making it easier for users to view and enter longer vehicle model names. This is a small usability improvement for fleet management users.

Original PR description

Improvement:
Following this commit the length of model field inside form view of vehicle is expanded.

taskID: 3477830

#fleet#vehicle#usability

[IMP] *: use private _read_group for efficiency/consistency.

PR #136381

Coremasteraccountim_livechatrepairsalestock

This update switches several backend data summary operations to a more efficient internal method. It should make related screens and calculations more consistent and slightly faster without changing what users see or do.

Original PR description

Since https://github.com/odoo/odoo/pull/110737, it is better to use
`_read_group` instead of `read_group` in the backend. In fact, the
public method is less efficient (it computes display_name of relational
groupby, extra order, ...) and more verbose.

This commit replaces these new uses of `read_group` with `_read_group`.

https://github.com/odoo/enterprise/pull/47826

#performance#consistency#backend

[draft] [IMP] l10n_ch_hr_payroll: Hide field for non-swiss companies

PR #46747

Enterprisemasterl10n_ch_hr_payroll

This update keeps a Swiss payroll-specific field hidden when users are working with non-Swiss companies. It reduces confusion by only showing country-specific payroll options where they are relevant.

Original PR description

task-3489435

#payroll#switzerland#usability

[IMP] *: use private _read_group for efficiency/consistency.

PR #47826

Enterprisemasteraccount_accountantappointmentwhatsapp

Backend reporting and grouping logic now uses a more efficient internal method across several Odoo Enterprise modules. This should improve consistency and reduce unnecessary processing without changing the user-facing workflow.

Original PR description

Since https://github.com/odoo/odoo/pull/110737, it is better to use `_read_group` instead of `read_group` in the backend. In fact, the public method is less efficient (it computes display_name of relational groupby, extra order, ...) and more verbose.

This commit replaces these new uses of `read_group` with `_read_group`.

https://github.com/odoo/odoo/pull/136381

#performance#backend#consistency

[IMP] helpdesk: make helpdesk admin template admin

PR #42993

Enterprisemasterhelpdesk

Helpdesk administrators now have permission to edit the templates used by their teams. This makes it easier for them to manage standard responses or workflows without needing extra technical support.

Original PR description

Add template editor permissions to helpdesk administrator so they can manage their users' templates

Task-2504439

#helpdesk#templates#permissions

[IMP] helpdesk_sale_timesheet: add icon on company dependent fields

PR #44830

Enterprisemasterdocuments_project_salehelpdesk_sale_timesheetindustry_fsm_sale_report

Product and service configuration screens now show a building icon next to fields that depend on the selected company. This makes it easier for users working across multiple companies to recognize which settings may vary by company and avoid confusion.

Original PR description

This commit improves the visual indication of company dependent fields. add icon of 'fa fa-building' on side of fields label.

task-3186717

#company settings#user interface#configuration

Bug Fixes(3)

Resolved issues and error corrections

[FIX] web_studio: element creation for insertion

PR #48136

Enterprisemasterweb_studio

This fixes a problem in Odoo Studio where adding content in the report editor could fail when the editor is embedded in a separate frame. Users should now be able to insert elements more reliably while editing reports, avoiding interruptions in report customization.

Original PR description

When the OdooEditor is mounted in an iframe, creating an element using the top document's `createElement` method produces a different result than creating one with the Editor's document. While the former is an instance of the top document's global `Node`, the latter is not (it is an instance of the iframe's global `Node` instead).

This commit fixes an undesired failed comparison using the `instanceof` operator in the editor's "insert" command, due to not using the Editor's document when creating a new element for insertion.

task-3521152

CE fw-port PR: https://github.com/odoo/odoo/pull/136597

#report editor

Refactoring(1)

Code cleanup and technical improvements

[MERGE][REF] knowledge: reorganize and refactor behaviors and html field patches

PR #43087

Enterprisemasterknowledge

This update reorganizes and simplifies the internal handling of Knowledge editor blocks and embedded content. It improves reliability when inserting or refreshing content in collaborative editing, while making future maintenance easier for developers.

Original PR description

This is a refactoring PR which intends to:

- Reorganize and rename `Behavior` templates so that it is more clear what
  purpose a specific template has.
  There are 3 types of template per `Behavior`:
  - `command` template: it should include nodes that are required by the
    `Behaviors engine` to mount a `Behavior` when it is inserted for the first
    time (`blueprint`). It is most often rendered by the `wysiwyg` when the
    user types a `/command` in the editor and is not rendered by `Owl`.
  - `Component` template: used by `Owl` to populate the `anchor` of a `Behavior`
    (which is the `parent` node of the `command` template)
  - non-protected "content" templates: rendered manually during the lifecycle of
    the `Behavior` `Component`. Those are rendered manually without `Owl`,
    because they can be altered by the collaboration (since they are
    `data-protected="false"`) and `Owl` does not support that the nodes it
    rendered be altered by something else than itself (will crash).

- Reorganize the js code of `Behavior` components and the `HtmlField` patch, so
  that there is some consistency between them and a foreign reader can better
  understand their structure.

- Refactor and rename `updateBehaviors` into `mountBehaviors` because the
  function is becoming quite long and complex, and handles some side effects in
  a pretty ugly way. Notably:
  - add some utils for common/complex use cases
  - add a `validator` object to formalize cases where a `Behavior` mounting can
    become obsolete
  - display warning messages upon `Behavior` `mount` failure only in debug mode

Read more details in each commits.

task-3383561

Other(41)

Miscellaneous changes

[FW][FIX] l10n_id_efaktur: rounding improvement

PR #136996

Coremasterl10n_id_efaktur

Original PR description

The efaktur export has rounding issues due to the fact that we need to display both the amount_untaxed and amount_tax rounded to 0 decimals as well as the detail of each line.

As the rounding of the sum will most of the time be different to the sum of rounded lines, the government website refuse the resulting file.

This fix will try to improve things a bit by:

- Avoiding to round the values while we are still manipulating them.
- Round the values once when the initial computation is done for the lines.

Once all lines have been computed, we will:

- Find the difference, if any, between the rounded amount_untaxed and amount_tax and the line totals and round that too.
- Update the first line with enough value in the result with that value in order to correct the total
- Finally, round the values for representation to two decimals.

If we cannot correct it in a single line, the correction is split in multiple lines.

Hopefully, these steps will help ensure that the sum of the lines will be equal to the rounded values of the amount_untaxed and amount_tax and thus be correct.

Task id # 3420220

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#136231

By returning the `setSelection` value in the callback returned by the `preserveCursor`, we allow better control for the caller over the fact that the selection was effectively restored or if it failed. task-3383561

Since https://github.com/odoo/odoo/pull/110737, it is better to use `_read_group` instead of `read_group` in the backend. In fact, the public method is less efficient (it computes display_name of relational groupby, extra order, ...) and more verbose. This commit replaces these new uses of `read_group` with `_read_group`. https://github.com/odoo/enterprise/pull/47826

When the OdooEditor is mounted in an iframe, creating an element using the top document's `createElement` method produces a different result than creating one with the Editor's document. While the former is an instance of the top document's global `Node`, the latter is not (it is an instance of the iframe's global `Node` instead). This commit fixes an undesired failed comparison using the `instanceof` operator in the editor's "insert" command, due to not using the Editor's document when creating a new element for insertion. task-3521152 CE fw-port PR: https://github.com/odoo/odoo/pull/136597

This is a refactoring PR which intends to: - Reorganize and rename `Behavior` templates so that it is more clear what purpose a specific template has. There are 3 types of template per `Behavior`: - `command` template: it should include nodes that are required by the `Behaviors engine` to mount a `Behavior` when it is inserted for the first time (`blueprint`). It is most often rendered by the `wysiwyg` when the user types a `/command` in the editor and is not rendered by `Owl`. - `Component` template: used by `Owl` to populate the `anchor` of a `Behavior` (which is the `parent` node of the `command` template) - non-protected "content" templates: rendered manually during the lifecycle of the `Behavior` `Component`. Those are rendered manually without `Owl`, because they can be altered by the collaboration (since they are `data-protected="false"`) and `Owl` does not support that the nodes it rendered be altered by something else than itself (will crash). - Reorganize the js code of `Behavior` components and the `HtmlField` patch, so that there is some consistency between them and a foreign reader can better understand their structure. - Refactor and rename `updateBehaviors` into `mountBehaviors` because the function is becoming quite long and complex, and handles some side effects in a pretty ugly way. Notably: - add some utils for common/complex use cases - add a `validator` object to formalize cases where a `Behavior` mounting can become obsolete - display warning messages upon `Behavior` `mount` failure only in debug mode Read more details in each commits. task-3383561

The efaktur export has rounding issues due to the fact that we need to display both the amount_untaxed and amount_tax rounded to 0 decimals as well as the detail of each line. As the rounding of the sum will most of the time be different to the sum of rounded lines, the government website refuse the resulting file. This fix will try to improve things a bit by: - Avoiding to round the values while we are still manipulating them. - Round the values once when the initial computation is done for the lines. Once all lines have been computed, we will: - Find the difference, if any, between the rounded amount_untaxed and amount_tax and the line totals and round that too. - Update the first line with enough value in the result with that value in order to correct the total - Finally, round the values for representation to two decimals. If we cannot correct it in a single line, the correction is split in multiple lines. Hopefully, these steps will help ensure that the sum of the lines will be equal to the rounded values of the amount_untaxed and amount_tax and thus be correct. Task id # 3420220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#136231

When user import records of project and if it contains tags in the file, a traceback will appear. Steps to reproduce the error: - Go to project > Favorites > Import records > Upload File - Note: Make sure that file contains tags Traceback: ``` TypeError: unsupported operand type(s) for +=: 'NoneType' and 'list' File "odoo/http.py", line 2134, in __call__ response = request._serve_db() File "odoo/http.py", line 1710, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1737, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1938, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 717, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 30, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 461, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 448, in _call_kw_multi result = method(recs, *args, **kwargs) File "addons/base_import/models/base_import.py", line 1332, in execute_import import_result = model.load(import_fields, merged_data) File "odoo/models.py", line 1279, in load for id, xid, record, info in converted: File "odoo/models.py", line 1441, in _convert_records converted = convert(record, functools.partial(_log, extras, stream.index)) File "odoo/addons/base/models/ir_fields.py", line 118, in fn converted[field], ws = converters[field](value) File "odoo/addons/base/models/ir_fields.py", line 637, in _str_to_one2many writable = convert(exclude_ref_fields(record), log) File "odoo/addons/base/models/ir_fields.py", line 118, in fn converted[field], ws = converters[field](value) File "odoo/addons/base/models/ir_fields.py", line 581, in _str_to_many2many id, _, ws = self.db_id_for(model, field, subfield, reference) File "odoo/addons/base/models/ir_fields.py", line 462, in db_id_for ids = RelatedModel.name_search(name=value, operator='=') File "odoo/models.py", line 1730, in name_search ids = self._name_search(name, args, operator, limit=limit, order=self._order) File "addons/project/models/project_tags.py", line 66, in _name_search domain += [('name', operator, name)] ``` https://github.com/odoo/odoo/blob/0480005e4498d76fe7a3446693f41500122e41d7/addons/project/models/project.py#L2763 When user import records that contains tags, here args will be None. So it will lead to above traceback. sentry-4494554048 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#136907 Forward-Port-Of: odoo/odoo#136374

This commit fix 3 issues with the reservation with use_expiration_date set on the product: 1) -- Discrepancy of available_quantity -- StockMove._update_reserved_quantity() works along StockMove._get_available_quantity() If the with_expiration context is added to one and not the other, the available_quantity sent to the 'update' method will not be correct. 2) -- Can't reserve on imperishable quants -- On the Quant, if expiration_date is False, the reservation will not be possible. Changed the domain from `expiration_date >= date` to `expiration is False or expiration_date >= date` 3) -- Expiration Date on untracked products -- On the Product Template form, you can: - set tracking to 'lot' - activate 'Use Expiration Date' - set tracking to 'none' Resulting in the configuration `tracking: 'none', use_expiration_date: True` which is not supported. --- # How to Reproduce - Create a product P, tracked by lot, with use_expiration_date = True - Set quantity on hand to 10 (without lot) - Create a Sale Order for 1 unit of P: Confirm - On the Delivery, 'Check Availability' (if not done automatically) => The Transfer is marked as Ready (aka: at least 1 unit reserved), but nothing is reserved. => If you Unreserve, the product availability is shown as Available, and if your Reserve again, it is shown as 'Not Available' OPW-3434996 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#132703

Currently, milestones planned at the end of a period (week/month/..) are not displayed correctly in the Gantt view. This commit address this problem. Steps ===== (in a browser not in UTC) - install module project_enterprise - Create a task in the Gantt view and a milestone for this task - Set the deadline of the milestone to the last day of the current month Issue ===== The milestone set to the last day of the month is not display in the good period in the Gantt view. It is displayed in the first day of the next month. Cause ===== There are two issues here: - The milestone is not display in its actual month: a problem in the loop exploring each column causes the last slot of the period to not be checked for milestones. - The milestone is displayed in the next period: When searching for milestones for the current period, a datetime, converted to UTC is sent to the server. This makes no sense are the milestones deadlines are date and not datetime. When comparing a date to a datetime, the server will just get rid of the time assosiated to the datetime. But this will cause problem when the end of the period in the Gantt is converted to UTC (e.g. July 1st 00:00 can become June 30th 22:00, so a milestone planned on the 30th of June will in that case appears in the July period). Fix === - For the first point, an interation is simply added to the loop. - For the second point, start/end of current Gantt period are first converted to dates before being used to search milestones. task-3412721 Forward-Port-Of: odoo/enterprise#48116 Forward-Port-Of: odoo/enterprise#43674

Improvements(8)

[IMP] sale_project: add icon on company dependent fields

[IMP] web_editor: add preserveCursor callback return value

[IMP] fleet: improve length of model field

[IMP] *: use private _read_group for efficiency/consistency.

[draft] [IMP] l10n_ch_hr_payroll: Hide field for non-swiss companies

[IMP] *: use private _read_group for efficiency/consistency.

[IMP] helpdesk: make helpdesk admin template admin

[IMP] helpdesk_sale_timesheet: add icon on company dependent fields

Bug Fixes(3)

[FIX] web_studio: element creation for insertion

Refactoring(1)

[MERGE][REF] knowledge: reorganize and refactor behaviors and html field patches

Other(41)

[FW][FIX] l10n_id_efaktur: rounding improvement

Improvements(8)

[IMP] sale_project: add icon on company dependent fields

[IMP] web_editor: add preserveCursor callback return value

[IMP] fleet: improve length of model field

[IMP] *: use private _read_group for efficiency/consistency.

[draft] [IMP] l10n_ch_hr_payroll: Hide field for non-swiss companies

[IMP] *: use private _read_group for efficiency/consistency.

[IMP] helpdesk: make helpdesk admin template admin

[IMP] helpdesk_sale_timesheet: add icon on company dependent fields

Bug Fixes(3)

[FIX] web_studio: element creation for insertion

Refactoring(1)

[MERGE][REF] knowledge: reorganize and refactor behaviors and html field patches

Other(41)

[FW][FIX] l10n_id_efaktur: rounding improvement

[FIX] *: remove invalid groups on field

[FIX] whatsapp_pos: receipt template field is not showing in setting

[FW][FIX] account_payment: Fee calculation fix

[FW][FIX] payment: payment status amount text color

[FW][FIX] base, test_read_group : process duplicated groupbys without lazy

[FW][FIX] sms: use partners on record to send sms

[FW][FIX] point_of_sale: use customer language for invoice product

[FW][FIX] sale_project: filter on tasks linked to the sale

[FW][FIX] web_editor: make `loadImageInfo` robust to absolute URLs

[FW][FIX] web_editor: replace extension of webp converted images

[FW][FIX] website_blog, website_event: incompat. of options

[FW][FIX] fleet: manage recurring yearly costs in report

[FW][FIX] stock: back order base on initial demand

[FW][FIX] project: import records of project

[FW][FIX] point_of_sale: correctly set lot_id on refund orders

[FW][REM] website_event_questions: remove useless directory

[FW][FIX] web_editor: apply font size on selected cells

[FW][FIX] website: make navbar content invisible when block invisible

[FW][FIX] mail: ignore obsolete chat window state received from bus

[FW][FIX] l10n_it_edi: register proxy user per company fix

[FW][FIX] web_editor: save image as attachment in forms

[FW][FIX] tools: Avoid to delete translation for Structured Model fields

[FW][FIX] website_sale: fix test with snippets to add to cart

[FW][FIX] stock,product_expiry: Add 'with_expiration' context to _get_available_quantity

[FW][FIX] safe_eval: 3.11 compatibility

[FW][FIX] web_editor: use Node from editable's document

[FW][FIX] point_of_sale: ticket cashier does not change after order finished

[FW][FIX] hr_timesheet: fix project kanban remaining hour field visibility

[FW][FIX] web_editor: only pre-convert webp images when within image fields

[FW][FIX] project_todo: remove filter on project when converting a to-do

[FW][FIX] website_slides: prevent content title overflow

[FW][FIX] point_of_sale: Prevent adding archived products by barcode

[FW][FIX] project: fix issue in project app

[FW][FIX] delivery: long trackingRef form view

[FW][FIX] project_enterprise: display milestones in the correct period

[FW][FIX] website_sale_renting: fix test with combination_info

[FW][FIX] sale_subscription: copy partner_invoice_id and partner_shipping_id

[FW][FIX] industry_fsm: planned dates don't fit user working schedule

[FW][FIX] hr_appraisal: fix appraisals employee rule expression warning

[FW][FIX] industry_fsm_stock: backorder adapation

[FW][FIX] hr_appraisal_survey: reorder 360 feedback view priority

[FW][FIX] mrp_workorder : access shop floor with company without employees