Monday, October 2, 2023
20 changes · master
Enhancements to existing features
When an employee contract is set to running, the system now automatically names the related Dimona to-do activity. This makes the task easier for payroll teams to recognize and act on without opening it for details.
Original PR description
When setting a contract to "running" status, a to-do activity for "Dimona" is created. However, the activity's summary was left blank. This improvement ensures that the summary is automatically filled with the term "Dimona". Task-3499212
Internal tests for Studio and spreadsheet features were updated to match recent wording and interface changes around record matching and filter conditions. This helps keep automated quality checks reliable without changing business workflows.
Original PR description
This commit updates studio and spreadsheet tests to fit with changes introduced in https://github.com/odoo/odoo/pull/135861 (removal of the Add condition button and new wording for records matching) task-3482381
Sales teams can now include rentable products as optional add-ons on rental quotations and templates, not just standard sale products. This makes rental offers more flexible and helps customers see relevant rental extras during the sales process.
Original PR description
Before this commit, only sale_ok products can be added as optional products. After this commit, rent_ok products can be added as optional products. Follow-up of https://github.com/odoo/enterprise/pull/47557 See also: https://github.com/odoo/odoo/pull/137053
The Knowledge app’s automated tests were adjusted to work with an updated internal HTML parsing helper. This keeps test coverage aligned with platform changes and helps prevent disruption as the underlying code evolves.
Original PR description
The parseHTML util now takes a `Document` object as first parameter. task-3526134 Community PR: https://github.com/odoo/odoo/pull/136984
Resolved issues and error corrections
This change removes leftover onboarding setup code from the WinBooks import flow that could cause imports to fail after an earlier onboarding redesign. It completes the cleanup of a step that was no longer visible to users, improving reliability without changing the user experience.
Original PR description
A field was left after step removal from the panel in d09cf75, onboarding refactoring in Task-3025136, and partial clean of this step in saas-16.4 This is the end of this. Task-3524102
Code cleanup and technical improvements
This update reorganizes how messaging-related data is stored internally, allowing related information to be set in one step instead of through extra preparation calls. The change should make future development and maintenance of Discuss, chatter, documents, WhatsApp, and related features more reliable without changing day-to-day user workflows.
Original PR description
Miscellaneous changes
We unintentionally omitted the XML declaration tag in the demo data for the article templates. This PR will rectify the issue by adding the necessary declaration tag, ensuring that the file is correctly identified as an XML file, complete with the specified version and encoding. task-3514934 Forward-Port-Of: odoo/enterprise#47670
Original PR description
We unintentionally omitted the XML declaration tag in the demo data for the article templates. This PR will rectify the issue by adding the necessary declaration tag, ensuring that the file is correctly identified as an XML file, complete with the specified version and encoding. task-3514934 Forward-Port-Of: odoo/enterprise#47670
The timer field was updated so it keeps working correctly after changes in how records refresh. This prevents timer display or start behavior from getting out of sync and also ensures background timer updates are properly stopped when no longer needed.
Original PR description
Since the new model (PR: odoo/odoo#114024), updating a record no longer triggers a deep render and therefore no longer triggers the onWillUpdateProps for Field components. The goal of this commit is to adapt the usage of onWillUpdateProps in Field composents in order to fix the bugs introduced by the RelationalModel
With this commit, instead of `Record.insert()` before setting
relation with records, we can immediately pass record data.
For example:
```js
message.author = { id: 3, type: "partner", name: "Admin" };
thread.messages.add({ id: 10, body: "some-text-content" })
```
This is supported on all relational fields that define a target
model.
To make this work while drastically avoiding cyclic dependencies
in code, whenever data have to be inserted in relation, they are
pre-inserted with essential data, and then they are fully inserted
after being registered in the relation.
https://github.com/odoo/odoo/pull/136539The link_to_record wizard was updated to fix the domain getter in [1]. However the upgrade of the module will now often fail because the view is checked when some models are not loaded in the model registry of the environment. We fix this by simply checking that it is actually in the env as that's a sensible behavior. [1]: f6b0eddc10fd65d65dc68b2d3333dd1850f48515 task-3487592 Forward-Port-Of: odoo/enterprise#48204
Original PR description
The link_to_record wizard was updated to fix the domain getter in [1]. However the upgrade of the module will now often fail because the view is checked when some models are not loaded in the model registry of the environment. We fix this by simply checking that it is actually in the env as that's a sensible behavior. [1]: f6b0eddc10fd65d65dc68b2d3333dd1850f48515 task-3487592 Forward-Port-Of: odoo/enterprise#48204
`SpreadsheetControlPanel` is spawning a `ControlPanel` in order to set some of its `slots`. It then calls a template `spreadsheet_edition.Breadcrumbs` which itself depends on `Dropdown`. With the current architecture, the template is called in the context of `SpreadsheetControlPanel`, which does not have `Dropdown`defined in its static components. The issue was partially solved by fixing the components of `DocumentsSpreadsheetControlPanel` but the issue could arise for actions that use `Spre
Original PR description
`SpreadsheetControlPanel` is spawning a `ControlPanel` in order to set some of its `slots`. It then calls a template `spreadsheet_edition.Breadcrumbs` which itself depends on `Dropdown`. With the current architecture, the template is called in the context of `SpreadsheetControlPanel`, which does not have `Dropdown`defined in its static components. The issue was partially solved by fixing the components of `DocumentsSpreadsheetControlPanel` but the issue could arise for actions that use `SpreadsheetControlPanel` directly. Task: / Forward-Port-Of: odoo/enterprise#48080 Forward-Port-Of: odoo/enterprise#48055
+ Clears the contact suggestion list when the transfer popover is blank + Ensures that a value is always provided as a phone number + Refactoring opw-3480011 Forward-Port-Of: odoo/enterprise#48110 Forward-Port-Of: odoo/enterprise#47586
Original PR description
+ Clears the contact suggestion list when the transfer popover is blank + Ensures that a value is always provided as a phone number + Refactoring opw-3480011 Forward-Port-Of: odoo/enterprise#48110 Forward-Port-Of: odoo/enterprise#47586
runbot-17534 https://github.com/odoo/odoo/pull/136776 Forward-Port-Of: odoo/enterprise#48158 Forward-Port-Of: odoo/enterprise#48020
Original PR description
runbot-17534 https://github.com/odoo/odoo/pull/136776 Forward-Port-Of: odoo/enterprise#48158 Forward-Port-Of: odoo/enterprise#48020
Steps to reproduce: - in accounting > Dashboard > Miscellaneous > upload - upload an xml that an `entNum` without "BE" prefix Issue: You will get an error opw-3422120 Forward-Port-Of: odoo/enterprise#47828 Forward-Port-Of: odoo/enterprise#46932
Original PR description
Steps to reproduce: - in accounting > Dashboard > Miscellaneous > upload - upload an xml that an `entNum` without "BE" prefix Issue: You will get an error opw-3422120 Forward-Port-Of: odoo/enterprise#47828 Forward-Port-Of: odoo/enterprise#46932
We change domain for: - not including when no GST tax is found - we need to show reverse charge GST amount in GSTR-1 - adding receipts everywhere as Invoice. l10n_in_reports_pos: - GSTR-1 report section B2CS must include credit note it's bug fix - also bug fix for match pos lines task - 3360018 Forward-Port-Of: odoo/enterprise#43155
Original PR description
We change domain for: - not including when no GST tax is found - we need to show reverse charge GST amount in GSTR-1 - adding receipts everywhere as Invoice. l10n_in_reports_pos: - GSTR-1 report section B2CS must include credit note it's bug fix - also bug fix for match pos lines task - 3360018 Forward-Port-Of: odoo/enterprise#43155
The type of the prop `no_format` on the AccountReportEllipsis component is set to Object although it can be a number or even null. We remove the type of the props to avoid the OwlError on the props validation. opw-3516743 Forward-Port-Of: odoo/enterprise#47830
Original PR description
The type of the prop `no_format` on the AccountReportEllipsis component is set to Object although it can be a number or even null. We remove the type of the props to avoid the OwlError on the props validation. opw-3516743 Forward-Port-Of: odoo/enterprise#47830
Current behavior: When we enable the timesheet reminder in the settings and somehow the the next date value (`timesheet_mail_employee_nextdate`) is not set, the date value is not re-calculated and therefore the CRON never send the reminders. Expected behavior: When enabling the reminder, recalculates the next date value. opw-3432435 Forward-Port-Of: odoo/enterprise#48130 Forward-Port-Of: odoo/enterprise#48096
Original PR description
Current behavior: When we enable the timesheet reminder in the settings and somehow the the next date value (`timesheet_mail_employee_nextdate`) is not set, the date value is not re-calculated and therefore the CRON never send the reminders. Expected behavior: When enabling the reminder, recalculates the next date value. opw-3432435 Forward-Port-Of: odoo/enterprise#48130 Forward-Port-Of: odoo/enterprise#48096
Steps: - Open Appraisals - Go to Configuration - Go to Settings - In the Settings , in My future , there was a typing mistake in carreer Issue: - carreer spelling is wrong it should be career not carreer. Cause: - Spelling mistake. Fix: - correct the career spelling in code and translation. Task: 3477824 Forward-Port-Of: odoo/enterprise#46394
Original PR description
Steps: - Open Appraisals - Go to Configuration - Go to Settings - In the Settings , in My future , there was a typing mistake in carreer Issue: - carreer spelling is wrong it should be career not carreer. Cause: - Spelling mistake. Fix: - correct the career spelling in code and translation. Task: 3477824 Forward-Port-Of: odoo/enterprise#46394
The goal of this task is to improve the overall UI design of the pdf report by changing some alignment, putting the total in bold. task: 3433943 Forward-Port-Of: odoo/enterprise#47403
Original PR description
The goal of this task is to improve the overall UI design of the pdf report by changing some alignment, putting the total in bold. task: 3433943 Forward-Port-Of: odoo/enterprise#47403
In salary configurator, when employee signs the contract, we are looking for existing bank account. If bank account exists, we set it for the employee. Here, to find the existing bank account, the search domain uses only 'acc_number'. This can be an issue, in case two employees, A and B have the same bank account. Because for employee B, search might return the bank account belonging to Employee A (as they have the same acc_number). While setting this bank account for employee B, we check
Original PR description
In salary configurator, when employee signs the contract, we are looking for existing bank account. If bank account exists, we set it for the employee. Here, to find the existing bank account, the search domain uses only 'acc_number'. This can be an issue, in case two employees, A and B have the same bank account. Because for employee B, search might return the bank account belonging to Employee A (as they have the same acc_number). While setting this bank account for employee B, we check whether address_home_id of the current employee is the same as bank_account.partner_id. And if it is not the case, we untrust the account. To solve this issue, we need to search for existing bank account not only by acc_number, but also by partner_id. Forward-Port-Of: odoo/enterprise#48011
This commit fixes various issues with the app switcher when using Studio. Requires : #https://github.com/odoo/odoo/pull/133712 task-3418936 part of task-3326263 --- ### Edit icon button is not aligned When trying to edit an app icon, the pencil icon is not correctly placed. It should be displayed in the top right corner of the tile and not in the center. <img width="110" alt="image" src="https://github.com/odoo/enterprise/assets/128030743/fde6c1bc-fec2-4f19-9188-2e922ae1c19c">
Original PR description
This commit fixes various issues with the app switcher when using Studio. Requires : #https://github.com/odoo/odoo/pull/133712 task-3418936 part of task-3326263 --- ### Edit icon button is not…
This commit fixes various issues with the app switcher when using Studio. Requires : #https://github.com/odoo/odoo/pull/133712 task-3418936 part of task-3326263 --- ### Edit icon button is not aligned When trying to edit an app icon, the pencil icon is not correctly placed. It should be displayed in the top right corner of the tile and not in the center. <img width="110" alt="image" src="https://github.com/odoo/enterprise/assets/128030743/fde6c1bc-fec2-4f19-9188-2e922ae1c19c"> ### Custom icon preview modal UI If you open Studio and click on the pencil icon to edit an icon, there are some issues with the modal displayed. - The `background-color` is dark -> It should be light like the modal ; <img width="848" alt="Screenshot 2023-07-26 at 10 27 16" src="https://github.com/odoo/enterprise/assets/128030743/a89d187f-56fb-4c0b-85a4-b09404cc330f"> - The preview image is not centered inside the modal. <img width="848" alt="Screenshot 2023-07-26 at 10 27 16" src="https://github.com/odoo/enterprise/assets/128030743/e7460250-b435-421c-b93a-43c9703c2231"> - The `Confirm` primary button use the same color for the `background` and the text in active state, causing readability issues. <img width="841" alt="image" src="https://github.com/odoo/enterprise/assets/128030743/5a41abde-bb3c-497d-9814-3297e5853e20"> ### Studio navbar contrast Still on the App Switcher while Studio is activated, the `Customizations` button at the top left of the screen in black on a dark background, which is not readable at all. There is also an issue with the pencil icon being placed weirdly to the icon container, it should be aligned to the top right corner. <img width="1480" alt="image" src="https://github.com/odoo/enterprise/assets/128030743/8168b602-1f6a-417f-8c3d-df905404c66f"> ### Custom uploaded icon `aspect-ratio` When an icon is not squared, its container would fit the image size while it should normally force the icon to be squared. This would lead to a rectangle icon in the middle of squared icon. <img width="377" alt="image" src="https://github.com/odoo/enterprise/assets/128030743/216e76fb-3835-420d-ae4b-7ac58f11bde2"> ### Custom uploaded icon `aspect-ratio` While fixing the issues above, I found out that the `aspect-ratio` also affects the icon rendered inside a module navbar. If you upload an icon with rectangle dimensions and open a module, the icon in the navbar would often overflows the name of the module and hide it. This is also not the expected render since we made the icon squared on the app switcher. <img width="775" alt="image" src="https://github.com/odoo/enterprise/assets/128030743/a7c8f84b-e972-4e12-918f-471c9d5a144d"> Forward-Port-Of: odoo/enterprise#47914 Forward-Port-Of: odoo/enterprise#43857