Wednesday, October 4, 2023
2 changes · master
Resolved issues and error corrections
This fixes an issue where Discuss call invitations and ringing conversations could fail to appear after recent internal data handling changes. Users should now reliably see incoming call cards and ringing thread status again.
Original PR description
Discuss model data that had commands have been simplified by [1]. Notably some `unlink` were replaced by `False` and or `DELETE`. Some code in Discuss calls was still expecting receiving command data in of `DELETE` while data received has become `false`. As a result, the state of ringing threads and showing call invitation card was not working. This commit fixes the issue by relying on recent improvements that commands can be passed immediately as data to relational fields [2]. Code in Discuss call still have some coupling between fields whenever some records are either added to or removed from a field. Hooks `onAdd` and `onDelete` on relational fields are added to support these cases. [1]: https://github.com/odoo/odoo/pull/136308 [2]: https://github.com/odoo/odoo/pull/137341
This fixes a livechat issue where visitors could remain tied to an outdated chat session if leaving the session failed. The chat state is now cleaned up reliably, and session restoration avoids sending duplicate initialization requests.
Original PR description
Before this PR, if an error occurred when leaving the session, the state of the livechat was not properly reset. This is an issue since this could lead to a visitor being stuck with an outdated session. This commit ensures the session state is reset even if an error occurs during the session leave rpc.